vertical tabcontrol has "vertical: true" property
for now just handle it as normal tab control,
it doesn't use tabpages but regular grids for
tab contents
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ie374f8c68cbbf1e3076ca884ab54568ee204f04c
LO is offering this using `CTRL`+`PageUp` or 'PageDown`.
- but there are some browser restriction related to security purpose some of the event we can not prevent.
- for an example CTRL + PageUp will not be prevented using JS in browser ( as per browser security rules )
- so i have tried to add this shortcut using Ctrl + Alt
- we can cycle through all sheets.
Adding this small enhancement as part of this `HackWeek` :)
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I4e76a0cc382fbe97f16037c8f9d78174e8663491
- Previously giving --with-lo-path as a relative path caused collabora
online to crash with "component context fails to supply singleton"
errors
- This patch uses readlink on the with-lo-path option, expanding it into
its full canonical path
- I could probably have gotten away with realpath, but for consistency
with --with-lokit-path I decided to use readlink -f
Change-Id: I16aacddbda9749451578fb7aded6c3c4e145ee26
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Otherwise eg. non-ASCII shortcuts appearing in files can cause
failures like this.
Traceback (most recent call last):
File ".../rpmbuild/BUILD/coolwsd-23.05.2.2snapshot/scripts/unocommands.py", line 454, in <module>
toolbarCommands = extractToolbarCommands(onlineDir)
File ".../rpmbuild/BUILD/coolwsd-23.05.2.2snapshot/scripts/unocommands.py", line 163, in extractToolbarCommands
for line in f:
File "/usr/lib64/python3.6/encodings/ascii.py", line 26, in decode
return codecs.ascii_decode(input, self.errors)[0]
Encountered after 1a2500c8d3.
This is not ASCII in browser/src/control/Control.NotebookbarWriter.js:
`'accessibility': { focusBack: true, combination: 'AI', de: 'ÖI' }
Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: I72aac2809530c14b9440f73e5072db17770f438a
On entering full screen the normal browser window goes "idle" on losing
focus. When the full screen presentation exits no "focus" events gets
sent to the normal window so clicking "presentation" again doesn't do
anything as idle inhibits anything getting actually sent to the server.
in:
commit 5f655a7555
Date: Tue Oct 13 19:26:16 2015 +0300
loleaflet: print handler tdf#94607
a similar _map.focus() is done after a similar L.DomUtil.remove()
and doing there same here gets this case to work.
https://github.com/CollaboraOnline/online/issues/7102
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Iae44ba949af2a64bf669b9d5f1113c647a354af1
Without it in calc -> insert -> chart treeview
for chart type selection was invisible / 0px width
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iaf28c4860adcd00591a638fa10838fe8719bee23
- It exits LOActivity when lokit thread finishes using lokit_main_mutex.
But if we edit document and exit without saving lokit thread gets
finished but COOLWSD is still running to clean up the docBrokers.
It takes some time to clean up this docBrokers.
We need to exit the LOActivity only after COOLWSD is finished
- for that I have added coolwsdRunningMutex again
- it was removed in ad32888d7c
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ic9785f5aa55deafbac98efc4013bd3376d0ba62d
- to show previews we use slide-sorter element
and presentation-controls-wrapper as container
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Iaed0892779d5016a565d556955305317129edea4
Block only close requests from the user clicking on
'X' button. We need to always process close messages
from the server.
Eg. Format -> Theme, click Add:
then close parent dialog using 'x' -> should not work
then close parent using 'cancel' button -> should exit dialog
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I2164f01acf47a67dc1e35b85b37142bc88dfedc4
Full screen feature is not available on iPhone,
only on iPad with iOS 12+ (https://caniuse.com/fullscreen).
Instead open svg directly in the browser as a fallback.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I047051e420a0d786ec084817b8fe19c34e086cf6
When button is inserted using postmessage API
it can have no command property. Prevent us from
TypeError here.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I84f1f94befb57d0e18699052c881b90de55a1239
newRequest is always called with a const Request& already so might as
well make this copy inside the function rather than passing a copy
by value and moving it.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ib572637d29590b8b470a42da3293065ed86d7dd0
When renaming file in writer use the original extension
to save the file if the user doesn't provide one
Signed-off-by: NickWingate <nick.wingate@collabora.com>
Change-Id: I6b6293bb7bf8ede38a8fa63995ad553d1e45ee1e
iss ctor takes a const std::string& and constructs with a copy of str as content
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I2805c869cb034a9b87e6e95cc58419b54a078b63
Document that authentication changes need double amount of care,
compared to other normal functional changes.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Ib1820581f7175957f08f5e080d542c7441a3ffa2
With the use of a single flag for both, the
logic is now less ambiguous, as we cannot have
termination flagged without also implying
shutting down.
The assertions are no longer needed.
Now that setting the termination flag
explicitly implies having the shut down flag
as well, the checks are simpler. We only
need to check that the shutdown is not set
to continue running as normal, since having
the termination flag must perfoce mean shut
down is also set, there is no need to check
both.
Change-Id: I99e22f5668385182b0594040a8e3354b55e74642
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
