Commit graph

3132 commits

Author SHA1 Message Date
Szymon Kłos
da75488a46 jsdialog: handle vertical tabcontrol
vertical tabcontrol has "vertical: true" property

for now just handle it as normal tab control,
it doesn't use tabpages but regular grids for
tab contents

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ie374f8c68cbbf1e3076ca884ab54568ee204f04c
2023-08-21 15:19:23 +02:00
Darshan-upadhyay1110
7ef605badd Switch tab using keyboard shortcut
LO is offering this using `CTRL`+`PageUp` or 'PageDown`.
- but there are some browser restriction related to security purpose some of the event we can not prevent.
- for an example CTRL + PageUp will not be prevented using JS in browser ( as per browser security rules )
- so i have tried to add this shortcut using Ctrl + Alt
- we can cycle through all sheets.

Adding this small enhancement  as part of this `HackWeek` :)
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I4e76a0cc382fbe97f16037c8f9d78174e8663491
2023-08-21 14:44:37 +02:00
Maks Wolkowinski
31ae779d82 feat: Add tooltip to hide menu button (compact view)
Signed-off-by: Maks Wolkowinski <m.wolkowinski@beebuzziness.com>
Change-Id: I05011bf9ffec99af8558c7af06dce5e350511f7c
2023-08-21 10:45:13 +02:00
Rash419
8310af30f0 fix: empty mobile wizard when opened for the first time
- it was only affecting wizard with tabs

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I6172a3a1a498982927e63676c4743be8f2ff9d80
2023-08-19 10:14:40 +02:00
Pedro Silva
9ac61152e1 Fix Rename document button works only on tabbed view #7109
We forgot to dispatch it

Signed-off-by: Pedro Silva <pedro.silva@collabora.com>
Change-Id: If1ae87ee8029d469d092680437023d389efcdec7
2023-08-19 07:55:10 +02:00
Rash419
c9e7591add clusteroverview: send routeToken with auth message
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I6412d68ef0c86d7a618eaf0ad252c16dee565d77
2023-08-18 23:27:04 +05:30
Gökay Şatır
6137636083 Add other missing classes.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I5fb6148e872776a3d6c3adc9f5c1421cf57ea2e8
2023-08-18 15:08:53 +03:00
Pedro Silva
d45b307e3f Notebookbar definitions: add missing class for dark mode toggle
Signed-off-by: Pedro Silva <pedro.silva@collabora.com>
Change-Id: Ie720f4dc762623bff0682162385fda7d591ebe0c
2023-08-18 15:08:53 +03:00
Pedro Silva
1404686fde Notebookbar definitions: add missing class for show resolved comments
Signed-off-by: Pedro Silva <pedro.silva@collabora.com>
Change-Id: I1de88564a4bd588544801f66518b964afa253a18
2023-08-18 15:08:53 +03:00
Pedro Silva
a1e916812f Notebookbar definitions: add missing class for collapse tabs
Signed-off-by: Pedro Silva <pedro.silva@collabora.com>
Change-Id: Ib9ca5fb61908cd2e5d621158478ab29aaff4b1c0
2023-08-18 15:08:53 +03:00
Gökay Şatır
edafed2413 Add missing class names to notebookbar definitions.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I15fb9fdba0d019a865c1edf42f1ab7b2197b4136
2023-08-18 15:08:53 +03:00
Gökay Şatır
1fd4c05111 Add "class" property to JSDialogs items.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I130b28ff40f9adf6bf05e2aed433e8ecc92acb1d
2023-08-18 15:08:53 +03:00
Darshan-upadhyay1110
c3aaae077f Add missing dark mode toggle in mobile view
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I89100d703444e8bfe2a8960d00c62a1e1ea88a84
2023-08-17 19:08:22 +05:30
Pedro Pinto Silva
3103ab5c66 Add missing rename document icon
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I219161ffc505c5093f3f8226960f7a7d35455d7e
2023-08-17 15:13:41 +02:00
Caolán McNamara
89f283c676 cool#7102 fix 2nd presentation under chrome not appearing
On entering full screen the normal browser window goes "idle" on losing
focus. When the full screen presentation exits no "focus" events gets
sent to the normal window so clicking "presentation" again doesn't do
anything as idle inhibits anything getting actually sent to the server.

in:
commit 5f655a7555
Date:   Tue Oct 13 19:26:16 2015 +0300

    loleaflet: print handler tdf#94607

a similar _map.focus() is done after a similar L.DomUtil.remove()

and doing there same here gets this case to work.

https://github.com/CollaboraOnline/online/issues/7102

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Iae44ba949af2a64bf669b9d5f1113c647a354af1
2023-08-17 09:47:11 +01:00
Gökay Şatır
a45b4e875f Add accessibility keys for insert and format tabs.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I575520db1c10abd46957912dd21e3a1362dc7ebb
2023-08-16 14:58:31 +03:00
Gökay Şatır
10b58a0a4f Add accessibility definitions to draw UI.
Also simplify definitions.

Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Ieccb431ba66a25a4e35ea4c2cb59c4490b84986d
2023-08-16 14:58:31 +03:00
Gökay Şatır
b304644be4 Calc - Add remaining tabs' accessibility definitions.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I5dfad5ec68277ec5e45df2885afdea853318eb39
2023-08-16 14:30:14 +03:00
Gökay Şatır
9436512afb Calc File and Home tabs' accessibility definitions.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I3eef334e14b710ab306cea8b7a3e3f11b986e245
2023-08-16 14:30:14 +03:00
Gökay Şatır
33abd9c437 Initialize contentlist with empty array.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I58abed98dffecb5d819e8a75f68dbe9d38a0149d
2023-08-16 14:30:14 +03:00
Gökay Şatır
49354607e0 Re-enable multi-language support on accessibility definitions.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I5d376260d05f72ebd56a8d4313dcbb1845b5041c
2023-08-16 14:30:14 +03:00
Gökay Şatır
34635de5d4 Calc: Add ids to notebookbar definitons & simplify definitons.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I0b4e7b17f6d5e361e2cf493b39459493c0441df1
2023-08-16 14:30:14 +03:00
Szymon Kłos
ac8440fea7 jsdialog: add minimal size for treeview
Without it in calc -> insert -> chart treeview
for chart type selection was invisible / 0px width

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iaf28c4860adcd00591a638fa10838fe8719bee23
2023-08-16 09:16:51 +02:00
Rash419
6a7b98af8a fix: cell border preview in mobile wizard
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I6b6049751d95af7c42d931666beed424fd4a208e
2023-08-16 08:58:39 +02:00
Rash419
639068e3fe impress: remove unused mobile-slide-sorter
- to show previews we use slide-sorter element
  and presentation-controls-wrapper as container

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Iaed0892779d5016a565d556955305317129edea4
2023-08-16 11:29:54 +05:30
Szymon Kłos
03fa9d9c86 jsdialog: always execute close message from server
Block only close requests from the user clicking on
'X' button. We need to always process close messages
from the server.

Eg. Format -> Theme, click Add:
then close parent dialog using 'x' -> should not work
then close parent using 'cancel' button -> should exit dialog

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I2164f01acf47a67dc1e35b85b37142bc88dfedc4
2023-08-16 07:56:36 +02:00
Szymon Kłos
2eda4740ca Don't show presentation on iOS in small frame
Full screen feature is not available on iPhone,
only on iPad with iOS 12+ (https://caniuse.com/fullscreen).

Instead open svg directly in the browser as a fallback.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I047051e420a0d786ec084817b8fe19c34e086cf6
2023-08-16 07:54:38 +02:00
Szymon Kłos
9a0b34f8fb jsdialog: fix error on insert_button
When button is inserted using postmessage API
it can have no command property. Prevent us from
TypeError here.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I84f1f94befb57d0e18699052c881b90de55a1239
2023-08-16 07:54:02 +02:00
NickWingate
68135a4682 Rename with file default when given unspecified extension
When renaming file in writer use the original extension
to save the file if the user doesn't provide one

Signed-off-by: NickWingate <nick.wingate@collabora.com>
Change-Id: I6b6293bb7bf8ede38a8fa63995ad553d1e45ee1e
2023-08-15 11:23:04 +02:00
NickWingate
24ac74db4f Add rename document to notebookbar and menubar
Signed-off-by: NickWingate <nick.wingate@collabora.com>
Change-Id: Iec25de88aa3e7089af102dd9f4bda6507308c215
2023-08-15 11:23:04 +02:00
Rash419
41bdf1ece8 admin: remove fixed width and height attr from svg
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I39df378a0bcba2199d625dd5bf7a202b15354b0f
2023-08-15 11:11:01 +05:30
Rash419
65f6f46093 admin: use humanizeMem in adminClusterOverview.js
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I323735c989e3a4448f57d896ea635dcdeb6bbe8b
2023-08-15 11:11:01 +05:30
Pedro Pinto Silva
555a07db70 AdminCluster: Use proper card headers for title instead
and round cards

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I632ca5a3053247ce4d12c4e028e0322ee1545124
2023-08-14 21:38:32 +05:30
Gökay Şatır
e660bb8e66 When document layer is not ready and socket message is not delayed, message is lost.
Wait for doclayer to be ready in this case.

Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Ib3e9427a89e8be7d97f7baf92bdcb6295c695ca2
2023-08-14 16:17:19 +03:00
Gökay Şatır
8570a03555 Correct menubutton control id calculation.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Ief7692cbdc479a651d350d7beab2e558e6d27b4b
2023-08-14 14:24:46 +03:00
Gökay Şatır
3d1725ea44 Cypress updates.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Ieefdcae70be0fce920e2e2b3d3b6ba1b179a6857
2023-08-14 14:24:46 +03:00
Gökay Şatır
7d084e40cb Update cypress tests.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I1c60f89d6ab68e4a61861d77383010dd7f22480a
2023-08-14 14:24:46 +03:00
Gökay Şatır
a3d9abcc20 Move all accessibility definitions from notebookbaraccessibilitydefinitions into control.notebookbarwriter.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I8db815859e91a65dc5452a0c3c0307701088514c
2023-08-14 14:24:46 +03:00
Gökay Şatır
7d0f7d7378 writer insert tab keys are added.
Replaced id based checks with uno command ones.
Removed unnecessary function from notebookbaraccessibility. We don't use automatic id assignments any more.

Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I3ad69916dea72d0e7e37430e629d74763c79005c
2023-08-14 14:24:46 +03:00
Gökay Şatır
1a2500c8d3 Merge accessibility definitions with notebookbar definitions.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I752eb0a2f44a892ed2cb7b2fd770c4d3ab997830
2023-08-14 14:24:46 +03:00
Gökay Şatır
939a7a0301 Simplify notebookbarwriter and tab page containers.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: If923c06ffd6b7bca77d25008497c390b8f3dcac8
2023-08-14 14:24:46 +03:00
Gökay Şatır
2cc714705a Remove access key assignments from jsdialogs.
Tabs' access keys are defined by notebookbar accessibility definitions class.

Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Ie04782aa5b747ea9f3b7bd3f84a33bf0554648dd
2023-08-14 14:24:46 +03:00
Gökay Şatır
f8e53bd851 Assign tab ids while defining tabs.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I51dbadb5d168f7b7f762a20a445773c6d53a511e
2023-08-14 14:24:46 +03:00
Szymon Kłos
4b9cbab33d jsdialog: fix spinfield precision detection
Use string based approach to avoid errors.
Eg. 36.37 was a problematic value when multiplied by 100.
This fixed indent spinfield in sidebar.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iae25acbf59cedfd20cbcb0677fd87e08d06c3f6d
2023-08-14 12:30:02 +02:00
Shehr Bano
e6a06eae1c FIX #7037: JSDialog: label vs textarea vs input field inconsistent paddings
Signed-off-by: Shehr Bano <shehr.bano@collabora.com>
Change-Id: I53494733c47b35d59133979c456665b4174e393c
2023-08-11 12:15:19 +02:00
Rash419
47f4305050 fix: cursor jump when hyperlink popup clicked in mobileview
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I4c5f1f2923f894156f5f05382b0f54476dea8a56
2023-08-10 17:38:22 +05:30
Caolán McNamara
912dfcd08e autofill onMouseDown doesn't generate working event position for hidpi
so the autofill handle in hidpi didn't work

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I718d9a8d3954a441705849eba174fe6b5b2983c4
2023-08-10 11:41:24 +01:00
Pedro Pinto Silva
c89cccfc7a Welcome: allow scroll bar
Otherwise content is not reachable.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibef06bd7ee18702674e41e8f942449ef49ffdd62
2023-08-10 11:48:36 +02:00
Marco Cecchetti
96a7cfb25e a11y: provide info about current table and cell to screen reader
When we get in one or more tables screen reader reports row and column
count.
When we get out one or more table screen report reports "out of table"
for each table.
When the fosused cell changes screen reader reports new row/col index.
Screen reader reports cell paragraph content, too.
Added also cypress tests for checking that the table/cell description
string is correct.

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I078b29a2f76f91df479f75db76113c80405f7169
2023-08-10 09:29:09 +02:00
Darshan-upadhyay1110
7825f82ce1 Remove open_local_editor button in tablet view
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I18908150ee537bfe7dd36b0b94f8baa11d2739ea
2023-08-10 12:51:40 +05:30