Commit graph

9480 commits

Author SHA1 Message Date
Szymon Kłos
dacfda2b1a jsdialogs: set current value for color picker
It works for font color and highlight now.

Change-Id: I253483eabe567b32f48bf47fbb8489e07d0f3a52
2019-11-05 16:41:46 +01:00
Tor Lillqvist
8c5b61b41e tdf#126973: Don't do anything in the tooltip show and hide functions on iOS
I have no understanding of what this code does and how it works but
this seems to fix the problem described in the bug.

Change-Id: I7188745b5c77d9e065828336b7dd6524aedc1dce
Reviewed-on: https://gerrit.libreoffice.org/81079
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit b95a22a740bccbd50d6cf49ad0b5fdbd1d489a90)
2019-11-05 17:00:51 +02:00
Muhammet Kara
ba3bfe4cab Add Makecache to gitignore
Auto-generated by GNOME Builder

Change-Id: I4112f751ee45df3000dbab0aa00151eaaf803cb7
Reviewed-on: https://gerrit.libreoffice.org/82070
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-05 14:25:56 +01:00
Pedro Pinto Silva
ee6700463a Spreadsheet: spreadsheet-toolbar: add proper press states on mobile and disable desktop over states when on mobile
Change-Id: Id768d33e7267a17b25664a880333195fe28ce0ba
Reviewed-on: https://gerrit.libreoffice.org/82033
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-05 14:19:57 +01:00
Pedro Pinto Silva
e2206e12ac Fix white screen after user's inactivity:
- add different class to vex overlay
- add different css rules

Change-Id: I89c971bd160a05a1c1fae20bbdecbf171c47f8ca
Reviewed-on: https://gerrit.libreoffice.org/82061
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-05 14:19:24 +01:00
Pedro Pinto Silva
ca7f7e5289 mobilewizard: impress: Hide top slide sorter when hamburger menu is open
Change-Id: I283282928ac73c32bbb62a017b0c4eeec52b47c3
Reviewed-on: https://gerrit.libreoffice.org/82009
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-05 14:18:49 +01:00
Pedro Pinto Silva
a023cc184c mobilewizard: impress: improve scrollbar and fix inconsistencies on the newly added slide sorter
Change-Id: Id889caf21de00b8bf6620a37066c4e40793226c6
Reviewed-on: https://gerrit.libreoffice.org/81994
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-05 14:18:23 +01:00
Pedro Pinto Silva
2cb592b560 mobilewizard: image: disable rotation label since it does not apply here
Change-Id: I83e5fbfd3377335b87a8d06b8570012e6c337ff2
Reviewed-on: https://gerrit.libreoffice.org/81986
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-05 14:17:36 +01:00
Pedro Pinto Silva
97c25ade86 mobileWizard: Center contents from impress: Layout tab without affecting other tabs
Change-Id: Ib0c989e5467b1f6fa9b0ed1d21281e14f75015ae
Reviewed-on: https://gerrit.libreoffice.org/81984
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-05 14:05:08 +01:00
Pedro Pinto Silva
a19f2faf2f mobile: toolbar-search:
- replace free text "Search:" with a proper label element
- give class to input group parent
- style search toolbar
- change font size to 16px so to avoid auto zooms from iOS devices

Change-Id: Iccbae8f7a932786acfde936e2002bd36b1fc564b
Reviewed-on: https://gerrit.libreoffice.org/81883
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-05 13:57:34 +01:00
Henry Castro
06b0bfe3e0 loleaflet: fix "Uncaught TypeError: Cannot set property 'invalid' of
undefined".

ImpressTileLayer.js:686 Uncaught TypeError: Cannot set property
'invalid' of undefined
    at NewClass._onInvalidateTilesMsg (ImpressTileLayer.js:686)
    at NewClass._onMessage (TileLayer.js:553)
    at NewClass._onMessage (ImpressTileLayer.js:604)
    at NewClass._onMessage (Socket.js:806)

Change-Id: Iea1272d8239a56731685597d022f63eb663bd6ea
Reviewed-on: https://gerrit.libreoffice.org/82044
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-04 22:27:54 +01:00
Henry Castro
7dbb6e4f38 loleaflet: mobile: recreate the scrollbar on 'orientationchange' event
The "mCustomScrollbar" was created the scrollbar dynamically, so when
the user change the orientation, it is necessary to destroy the scrollbar and
create again with the new respective axis.

Change-Id: Ic4d90de6e9989478f5d60254692b287c76368385
Reviewed-on: https://gerrit.libreoffice.org/82016
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-04 22:27:36 +01:00
Henry Castro
4db924d470 loleaflet: mobile: detect if device is in portrait orientation and
change axis of the scrollbar.

The "mCustomScrollbar" create the scrollbar dynamically, so it is
necessary to pass the axis property to show horizontal or vertical
scrollbar. If the device is in portrait orientation change the axis to
'x'.

Change-Id: Iefca4ca66efaf4f6cd1bfa12ebb70b90329aef73
Reviewed-on: https://gerrit.libreoffice.org/82015
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-04 22:27:01 +01:00
Henry Castro
35f2e56d82 loleaflet: mobile: apply CSS @media rule for portrait and landscape in
Impress document

When mobile device change orientation the client browser will apply the
corresponding @media rule.

Change-Id: I96b9d8fe7152833287de1be3a81d7423d22fc4c9
Reviewed-on: https://gerrit.libreoffice.org/82014
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-04 22:26:31 +01:00
Henry Castro
d8833d39d3 loleaflet: mobile: avoid hardcoding CSS bottom property
Use the CSS class selector to modify the bottom properties for
each tile layer document, so adjusting values for portrait or landscape
orientation not be so complicated.

Change-Id: I900ef5c4ec3f770fd802a23238fdd9e6eb838772
Reviewed-on: https://gerrit.libreoffice.org/81928
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-04 22:25:50 +01:00
Henry Castro
70d2a7b940 loleaflet: mobile: when the document tile layer was added also update
the sizes

When 'doclayerinit' is fired, a new document layer was added then it is
necessary to update the sizes and the default auto zoom.

Change-Id: Iece07bd5510789479f58e080b300525169539c6f
Reviewed-on: https://gerrit.libreoffice.org/81925
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-04 22:25:00 +01:00
Henry Castro
507dd08459 loleaflet: fire 'orientationchange' event
In order to detect if the orientation of the device has changed, it is
required to capture the window resize event. However, there is another
event attached from iframe element called resize-detector. I am not sure
how is used, but I do not want to cause any regression from desktop
version just let's add another event listener and it will be fired on
mobile case.

Change-Id: I54b5ba9239a71216faae4757a0cc7d9826c443ff
Reviewed-on: https://gerrit.libreoffice.org/81923
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-04 22:24:31 +01:00
Henry Castro
93265844c6 loleaflet: add DOM util functions: "isPortrait" and "isLandscape"
It is necessary to detect the mobile browser orientation.

Change-Id: I3281e4abac453c4f6de27e8d5e54bb0506fecf66
Reviewed-on: https://gerrit.libreoffice.org/81922
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-04 22:24:07 +01:00
Henry Castro
ad15c61e9b mobileWizard: avoid showing toolbar if it is not allowed
In view mode the function hideWizard it is forced to show the toolbar

Change-Id: Ib49501730fde1da65925db68b0b98baac2f15473
Reviewed-on: https://gerrit.libreoffice.org/81921
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-04 22:23:43 +01:00
Henry Castro
d4e364255d loleaflet: initialize mobile toolbars before adding the layer
Occurs that the 'permission' event, it is fired before the mobile
toolbar are created.

Change-Id: Ib96082b249a3d4e509d996f7382fd00c870de6f0
Reviewed-on: https://gerrit.libreoffice.org/81920
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-04 22:23:08 +01:00
Andras Timar
b6372c4be6 Online Help: translate TOC
Change-Id: I5049f5dca534a6c1a3cf2a6947dd13f2d0958ab3
2019-11-04 21:53:40 +01:00
Andras Timar
04ff4c8f82 Online Help: Spanish translation
Change-Id: Ia2c795732eafb9c23ff662e46a6a4187e033e1d4
2019-11-04 21:53:40 +01:00
Andras Timar
d8992b8056 Online Help: more formatting and grammar fixes
Change-Id: Iff9dd62ef907d89392134558c864ed5e51f9010b
2019-11-04 21:53:40 +01:00
Muhammet Kara
5c641b93d5 mobilewizard: Remove remnants of pseudo chart type panel
Change-Id: Iae8746459a6e846222ae73695cc68346504932b5
Reviewed-on: https://gerrit.libreoffice.org/82041
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-04 19:49:06 +01:00
Pedro Pinto Silva
49bb017e5a mobileWizard: toolbar-down: overlay
- improve w2ui-tb-down interaction and change its appearance depending on its status
- Fix w2ui-overlay-editbar -> menu where two triangles were being drawn instead of just one
- Fix w2ui-overlay-editbar -> Apply the same border and shadow etc properties used in the color picker overlay

Change-Id: Ic90844613eae126b5efdb7da8930d4007639850f
Reviewed-on: https://gerrit.libreoffice.org/81855
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-04 18:07:01 +01:00
Iván Sánchez Ortega
e1f4825dea loleaflet: Simplify data structs for Calc column/row headers
This replaces the (undocumented) L.Control.Header.DataImp data structure
with the (documented) L.Control.Header.GapTickMap data struct.

This is done in preparation for further work that needs to handle row/col sizes.

As a side effect, all column/row indices for the headers are now absolute to
the sheet, as opposed to relative to the visible ones in the screen.

The impact of these changes on performance should be negligible.

Change-Id: I1688b84db7445e97ac4d75dd073e32cc20e29d9d
2019-11-04 15:05:37 +00:00
Tor Lillqvist
9d6c174462 tdf#128577: Close an already open document when asked to open a new one
Add a "singleton" class method to DocumentViewController to return the
(as for now) singleton DocumentViewController.

Change-Id: I0b8a8def558cfe7f9469b6062a86311dfa63f549
Reviewed-on: https://gerrit.libreoffice.org/82007
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 2807f907d947549a17c5bae586b85d412d552a09)
Reviewed-on: https://gerrit.libreoffice.org/82021
2019-11-04 15:25:54 +01:00
Tor Lillqvist
2c8350b8a1 Don't require the Python modules unless on Linux
When building the iOS app my way, I do the J bits on a Linux box and
not on the Mac, thus I don't need any Python stuff on the Mac.

Change-Id: Ib8092870598fb3a8f304aefa8fab21fe7e3acc73
Reviewed-on: https://gerrit.libreoffice.org/82018
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2019-11-04 15:25:38 +01:00
Tor Lillqvist
36b126c745 Fix build for MOBILEAPP
Change-Id: I410359a8f2e6cda6e0857d370a3b18db68b619e2
Reviewed-on: https://gerrit.libreoffice.org/82013
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2019-11-04 15:25:01 +01:00
Tor Lillqvist
ed4558001f Set CFBundleShortVersionString to 4.2
Change-Id: I9115a9dc571c1b27e6b80181ec38732cb91ec799
Reviewed-on: https://gerrit.libreoffice.org/82019
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2019-11-04 15:24:41 +01:00
Tor Lillqvist
0c9bc2159b Add LSSupportsOpeningDocumentsInPlace
Probably a good idea, although doesn't seem to have much effect? At
least not on tdf#128577.

Change-Id: I7b66a2e9ba44bd4cef583c0861883edfae11eb1d
Reviewed-on: https://gerrit.libreoffice.org/82006
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 2990203dff05f977dfdc77b493deca051b54ca79)
Reviewed-on: https://gerrit.libreoffice.org/82020
2019-11-04 15:24:22 +01:00
Szymon Kłos
de0e75d2fb jsdialogs: avoid uing selectedEntries when no selection
Change-Id: I9cf44c6a51c46fe6a7f897d092f6fc2986217080
2019-11-04 14:39:53 +01:00
Andras Timar
e1413be3b3 Online Help: clarification
Change-Id: I883c87ba5bacb79b67dcf07c419dcc3cc7ddf1f7
2019-11-04 13:18:17 +01:00
Andras Timar
cd2a4cdc99 Add some more formatting to Online Help
Change-Id: I59f4840d2bd274c42c9c0ddd5a1a59def5adcb28
2019-11-04 12:37:24 +01:00
Andras Timar
80762b0310 Help says: Ctrl + Shift + ? – Displays the Keyboard shortcuts help
Change-Id: I0704b1f0aa9747d751fd2e18d458f166ad595b46
2019-11-04 12:36:26 +01:00
Andras Timar
1049b769ff loleaflet: Help -> Online Help
Change-Id: I673faae329013f0292afb9f517608a4eb90860d8
Reviewed-on: https://gerrit.libreoffice.org/81954
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2019-11-04 10:42:59 +01:00
Ashod Nakashian
f18cd4c458 wsd: improved shutdown cleanup
(cherry picked from commit 5eb58d4e13ed43156115d25482dffa96d7768bfe)

Change-Id: Ibdb822575c376af6065080070bf6b89c240ce67b
Reviewed-on: https://gerrit.libreoffice.org/81977
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2019-11-04 09:36:24 +01:00
Ashod Nakashian
688943906a service: improve stop and reload
SIGINT is the clean way of stopping
the service, while SIGTERM is be
the faster and rude way. So first
we want to use SIGINT and only when
we timeout do we want SIGTERM to
be used.

Here we ask systemd to stop WSD
by sending SIGINT and wait for 120
seconds. After that timeout, it will
assume the service is hung and needs
to be aborted. We expect that by then
we would have saved all documents and
cleanly exited. 120 seconds should be
sufficient time to save, close, and
upload the open documents.

Change-Id: I08321814db942d89a44cfce42885840f4afa279c
Reviewed-on: https://gerrit.libreoffice.org/81976
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2019-11-04 09:35:50 +01:00
Miklos Vajna
cd75e2c5f4 Convert render shape tests to a new-style one
So that they are in-process, which means it's easier to debug when they
fail.

Change-Id: I4acbfaa32f6c771d860c0ff2782024b176690ee5
2019-11-04 08:34:44 +01:00
Szymon Kłos
2017b7284b Show comments after scrolling down
Added view scroll after user clicks "V" button
to scroll comments down in impress.

Change-Id: Icb41a14fa5c7154e2f09bfc71473f623f2518464
2019-11-03 18:27:59 +01:00
Szymon Kłos
777c8b0324 Show code in language indicator
Fixes detection of a current code

Change-Id: I30f0caa6b33c78ef6ab6766d07c1ec34090b12ac
2019-11-03 18:11:46 +01:00
Szymon Kłos
985e68aa86 Show iso codes in dialog
Solves missing translations for languages.

Change-Id: If4c7d994b1927c80a374e4f85f1797b9c8cb472f
2019-11-03 18:11:37 +01:00
Szymon Kłos
786709794d Move language icon to the end of toolbar
Change-Id: Ic10e9540d13b6be45acbb87e5ed4a447a617b922
2019-11-03 18:10:40 +01:00
Szymon Kłos
d3b92abd8e Mobile language indicator and dialog
Change-Id: I2358ac60a3ba1a0f177e9fa3f965b7043ab99559
2019-11-03 18:00:22 +01:00
Szymon Kłos
fd787b7a51 Add HideNote item to the Calc context menu
Change-Id: I0dade45c8bc3e5b22d092429f14482f07d00920c
2019-11-03 17:50:02 +01:00
Szymon Kłos
8e466032ee Add Show/Delete Comment to the context menu in Calc
Change-Id: I14afbd5c6947279c68e3c778d019a5a2cea82541
2019-11-03 17:49:50 +01:00
Michael Meeks
1a28798850 Fix vex dialog close issues.
Amazingly - due to a bug in vex, without an animation closing
a dialog silently fails. cf. broken vex code determining hasAnimation
which needs to handle empty states in missing css properties eg.
-moz-animation-name.

Change-Id: I9834b438d33c908f4f9e96274ce1c2603a22c1fa
2019-11-02 18:53:31 +00:00
Michael Meeks
9390b07d71 Enable spreadsheet zoom.
Change-Id: I019fab6b91b170562e2a5be0729de9f52a0af1e0
2019-11-01 15:29:20 +00:00
Michael Meeks
823e2b2a92 Revert "Disable intermediate zoom levels on calc"
This reverts commit 12fa2aafa0.

Change-Id: Ib558243eb0583e0f96833caa5195022ebcc81c7d
2019-11-01 15:29:20 +00:00
Michael Meeks
ce6afa85be Revert "calc: forbid keyboard zoom to anything but 100% and 200%"
This reverts commit 03f5aab033.
2019-11-01 15:29:20 +00:00