Commit graph

21505 commits

Author SHA1 Message Date
Michael Meeks
03d83ab6b8 paste: cleanup excessive debugging.
We don't want to dump the whole paste buffer as hex, or indeed any
large mis-encoded string - instead crop to the problematic section
for easier debugging, and no performance hit.

Change-Id: I30518beea436895a42b3429c3cb6e16e2093cca9
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-07-28 21:38:02 +01:00
Pedro Pinto Silva
ec67c92264 Tablet: Non-functional sidebar button shown in read-only mode
Do not wrongly switch part of the UI to edit mode when on read-only
mode. Best to be only remove readonly css class when it's not needed as
opposed to removed it whenever refreshNotebookbar() is called.

Before this commit:
- We were showing tabs in wrong mode (readonly mode) -> every-time
refreshNotebookbar() was called. Thus, initial tablet mode was
appearing with icons and actions from edit mode.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6ad9c8c14e60d4c3513f63b75717db0a124b73ea
2023-07-27 16:44:09 +02:00
Szymon Kłos
a56f034dc6 Share code for findTailsGroup
Introduce getTailsGroupRect method which will be
different in every implementation but share findTailsGroup logic
using above function.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I321abaa2579bfdff08c8cd4df2e781cd9a28c3d3
2023-07-27 16:01:40 +02:00
codewithvk
8b5df0c4b3 Fix : Menubutton should have disabled state styling different
Signed-off-by: codewithvk <vivekpatel7202@gmail.com>
Change-Id: I1cd97503e0d3ca4333b11552ca3571093cf10bfe
2023-07-27 12:25:26 +02:00
Tex2002ans
06f8ee610f Update feature_request.md to use Headings
I added Headings + updated some wording/examples in:

- Feature Request

so when users submit a "New Issue" to Github, it will look nicer.

Signed-off-by: Tex2002ans <Tex2002ans@users.noreply.github.com>
Change-Id: Ic7c5b0a841d39b2cd2b20c5d4a31846eba0c3f4e
2023-07-27 12:21:25 +02:00
Tex2002ans
6b79e52831 Update bug_report_smoke-test.md to use Headings
I added Headings + updated some wording/examples in:

- Bug Report (Smoke Test)

so when users submit a "New Issue" to Github, it will look nicer.

Signed-off-by: Tex2002ans <Tex2002ans@users.noreply.github.com>
Change-Id: Id72ed9ac10a6ae935fb5fa4b1001c11683f46672
2023-07-27 12:21:25 +02:00
Tex2002ans
dcbc0208bb Update bug_report.md
I added Headings + updated some wording/examples in:

- Bug Report

so when users submit a "New Issue" to Github, it will look nicer.

Signed-off-by: Tex2002ans <Tex2002ans@users.noreply.github.com>
Change-Id: Ie32f2c9a4c6ed47aaf198286a0d39831fa397992
2023-07-27 12:21:25 +02:00
genofire
850089377f fix(helm): update appVersion
Change-Id: I497d36c76f74791b8535e6e89bc9acca536c58e3
Signed-off-by: genofire <geno+dev@fireorbit.de>
2023-07-27 12:47:29 +05:30
Darshan-upadhyay1110
16bb328456 Added visual feedback after copy information into clipboard
* Added visual feedback to inform the user that information is already copied
 * Change the image to a check-mark temporarily
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I41debc2421841e4f2235f2d31c49d3687a096339
2023-07-26 18:59:45 +02:00
Darshan-upadhyay1110
2ac7183e44 Add Left or right arrow on a tab label should switch tabs
- accessibility key features
    - focus on tab when press `Alt`.
    - move back and forth tab focus by ArrowLeft and ArrowRight
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Id8c8e2a8bcb57c90e0762dd3916b851fff8e0a6f
2023-07-26 10:24:13 +02:00
Aron Budea
80a390f740 Revert "Fix wrong device detection logic."
On actual iPad (2048x1536 native, 1024x768 browser), in
landscape view in Safari, mobile phone view is shown in
online instead of tablet.

This reverts commit f1e9ee72fe.

Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: I2cd4ba6cdcd616760c06c7db479e6d13be3d83b4
2023-07-26 10:08:58 +02:00
Aron Budea
91c166d26a Bump version to 23.05.2.2
Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: Ib03fddb00af05eaec4711c0b623713a993a5d56b
2023-07-24 17:08:40 +02:00
Pedro Pinto Silva
5aa5703885 Fixes #6946 and all unstyled kbd elements
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I09583d7c27cffc0f5b9722de1925977089bf832b
2023-07-24 16:30:02 +02:00
Szymon Kłos
fb2932067d Remove view selection on user disconnection
Fixes type error on switching sheets in Calc:

Steps to reproduce:
1. Open Calc spreadsheet with 2 sheets and 2 user sessions
2. Switch user A to sheet 1
3. Switch with user B to sheet 2 and select few cells
4. close user B browser / tab
5. switch user A to sheet 2

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I942becceaabae3a6e1bbbd230e12166348b341b3
2023-07-24 13:56:51 +02:00
Pranam Lashkari
fb5909bc40 theme: use integration theme value from the interation message
problem:
till now we used values from DOM elements which were unreliable,
sometimes they are not discoverable due to nested iframs.
That threw some 404 due to incorrect theming path.

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ibc291ce9f64db799095e1edcb14c598bdd085de7
2023-07-24 10:06:35 +02:00
Aron Budea
f84835b0c6 config: Fix 'warn_unused_result' during build
tools/Config.cpp: In member function 'virtual int Config::main(const std::vector<std::basic_string<char> >&)':
tools/Config.cpp:480:18: error: ignoring return value of 'int chown(const char*, __uid_t, __gid_t)' declared with attribute 'warn_unused_result' [-Werror=unused-result]
  480 |             chown(proofKeyPath.c_str(), pwd->pw_uid, -1);
      |             ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

From fc946198d3

Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: Iaa4db6fb4dc6f742779754d4e05708aa8f41ebd6
2023-07-23 13:18:42 +02:00
Andras Timar
fc946198d3 Rewrite coolwsd-generate-proof-key in C++
* simplified the tooling a bit: use coolconfig for creating
  RSA key pairs for WOPI Proof headers.
* got rid of a dependency: ssh-keygen, towards leaner docker images

Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Iaf468b5c8585d45027f512bb0a287ab77afb1ea9
2023-07-22 00:14:48 +02:00
Michael Meeks
7256b59bba deltas: don't drop delta cache on 10 seconds idleness.
This would have only a small impact on memory use, and a large
impact on interactivity, performance and bandwidth use. So lets
not do that.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I07b2538cd4f5cd2c91926cfabeaa159dd992b068
2023-07-20 18:32:59 -04:00
Aron Budea
bfdac84db2 Bump version to 23.05.2.1
Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: I5716d9d6556f45185b7b78fa05277403855d0353
2023-07-20 13:32:00 +02:00
Pranam Lashkari
d87b7c15d1 formulabar: fixed scrollIntoView caused problems
in some browser scrollIntoView causes problem without parameters
in this particular case problem was entire view being pushed upwords out of view
reproducing steps:
Open a spreadsheet in two views,
With 1st view, navigate to bottom right corner via Ctrl+⬇ and Ctrl+➡,
With 1st view, type something in that cell, and then the cell above (stay editing the cell, don't press Enter),
With 2nd view, start typing in A1.

2nd view's editing view is pushed upwards

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I4bc551de321483608eb210718c1d81a622de5a6d
2023-07-20 11:16:40 +02:00
Szymon Kłos
7aeb2f7015 Increase timer for pre-fetching adjacent tiles
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I76cf16e12968e26a73dbddd39fc919b400cecff2
2023-07-20 11:16:23 +02:00
genofire
115a79fdf9 fix(helm): chart release
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I6d2f038390da081ef98b5aaac7bedc10c77a964e
2023-07-20 12:05:37 +05:30
genofire
b372ea7e04 fix(helm): update nginx for dynamic Config server
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I83cb6aa999e75338d70c8d11e13266269c460903
2023-07-20 12:05:37 +05:30
genofire
0a9b6bb06c feat(helm): dynconfig upload
Signed-off-by: Klaus Erber <k.erber@erber-freelance.de>
Signed-off-by: Martin Müller <martin.mueller@dataport.de>
Signed-off-by: genofire <geno+dev@fireorbit.de>

Change-Id: I4dc4a456e3f61555468b98f1d0dfd54c1dd28770
2023-07-20 12:05:37 +05:30
Szymon Kłos
f04d37af44 Mark slide preview as fetched when it arrives
This fixes the problem when we requested a preview but
core didn't answer. This can happen when we have
nviewid mismatch and error is generated in logs:
ERR  Session is not found. Maybe exited after rendering request.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I951a05432c899a8e7d210dec7d57177d6c7aae7c
2023-07-20 07:51:03 +02:00
Szymon Kłos
eaeaee4134 LOK_CALLBACK_DOCUMENT_SIZE_CHANGED is different per view
In calc and impress we send different data depending on the view
in status: message which is triggered by LOK_CALLBACK_DOCUMENT_SIZE_CHANGED.
Every view can be on a different part / sheet / slide where document
size can be also independent.

This helps to reduce status: messages sent to other view when
switching sheets in other view.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I5b287f377a551affcfb4d12b6114dffa0fd51992
2023-07-19 19:50:19 +05:30
Pedro Pinto Silva
0e22c2a744 refactor: Toolbar down icons: remove unnecessary !important rule
If we set the initial backgrounds without `!important` then there is
no need to use `!important` for dark-mode (since we are already using
a more specific targe via data-them attribute)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I600629dfc0485edac6ff725f6278de1501e1c9a7
2023-07-19 16:02:12 +02:00
Rash419
c91655a08f fix: failed to play media when using indirection
regresssion from 3c55baf4e2e36c6df43707a7e469dae3fec2c3b0

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I21831ba076140d49a54a56e9c52f7edfca923ef5
2023-07-19 16:45:49 +05:30
Szymon Kłos
96f4120e4f Adjacent tiles prefetching with delay
While scrolling using scrollbar we tried to prefetch
lots of tiles adjacent to the view.

Introduce timer which will protect us from prefetching
tiles we will not need when scrolling is fast.
We will avoid doing it synchronously on every little step.

_update is called a lot in onMouseMove handler:

_update (CanvasTileLayer.js:6220)
...
panBy (Map.PanAnimation.js:51)
scroll (Scroll.js:11)
ScrollSection.scrollVerticalWithOffset (ScrollSection.ts:657)
ScrollSection.onMouseMove (ScrollSection.ts:776)
CanvasSectionContainer.propagateOnMouseMove (CanvasSectionContainer.ts:1097)
CanvasSectionContainer.onMouseMove (CanvasSectionContainer.ts:1403)

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If785fd0c0cc9076043e348b86a09577ad9fa667d
2023-07-19 16:08:48 +05:30
Ashod Nakashian
a82acb6c6e wsd: trim memory on idling
When all users idle their activities
for at least 10 seconds, we take the
opportunity to trim the memory footprint.

We are careful not to issue a subsequent
trimming too soon. A minimum of 30 seconds
needs to pass to trim again. This should
give a decent balance between performance
and reduced memory footprint.

Change-Id: I1c8b2c4a265c9aa0ac5033762695706ad970f11e
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-07-19 11:40:54 +02:00
Szymon Kłos
52627ab635 Prevent view from jumping on pressing alt key
this.accessibilityInputElement.focus();

line in onDocumentKeyUp in browser/src/dom/NotebookbarAccessibility.js
caused view to jump, in result half of the screen was white when
document was very long and had comment inside

To fix this insert accessibility input at the beginning of the DOM
so browser will not try to scroll anything when it is focused.

this is regression introduced in:
commit 3e40f3fbe4
Add functionality for notebookbar accessibility keys.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I68a1371928a5a3c02be32a3a9eab2ba909bb8ba0
2023-07-18 17:34:08 +02:00
Pedro Pinto Silva
cfece73517 Don't add outline to ShowInfoModal that have no buttons
Large Clipboard  and document idle modals were being set with tabindex
0 allowing for manual user focus plus were being focused dynamically
for each instance:
    - Transfer all that (just once) to showinfomodal instead for the
    cases where we have buttons
        - This in turn sets the things to the parent (dialog itself)
	and not the subcontianer
        - Set tabIndex with negative value so, it only allows focus via
    code
    - This fixes the weird outline (focus) that sometimes would appear
    on sub containers of that dialog instances

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If40192e05c4b0e25e2ce71bc612ab64fc54a29ec
2023-07-18 17:32:10 +02:00
genofire
182d4c2734 fix(helm): chart release
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: Ia51b23e9636ffa381aa1041f13487f4d9b632655
2023-07-18 19:47:44 +05:30
genofire
3cd9758564 fix(helm): update to newer code image
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: Ia6810cebfe99c120f8dfff956b67edc1add35178
2023-07-18 19:47:44 +05:30
genofire
87fa136899 fix(helm): allow no additional labels on servicemonitor
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I4dd6434cb6a1a9d121bccce7f4d80b040cf747c0
2023-07-18 19:47:44 +05:30
genofire
a3f784b531 fix(helm): move README to chart for publish on artifacts
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: Ic7308336c7ea635236514d0eeda89e876b1503ab
2023-07-18 19:47:44 +05:30
genofire
39db1377c4 fix(helm): artifactory image annotations
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: Id98830212e16e3ffc1a07b902d7d371f592623f3
2023-07-18 19:47:44 +05:30
genofire
d44630aaa9 chore(helm): yaml lint
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I8b6401624d23660f3b7fc6f244ce633bd0529c6a
2023-07-18 19:47:44 +05:30
genofire
6a64fdbf0b fix(helm): dynamicConfig broken configmap name in yaml
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I07127c2032cc5c684f037dbc058a9581be762488
2023-07-18 19:47:44 +05:30
genofire
2dda61615a fix(helm): statefulset with servicename from helmrelease (multiple install)
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I6f9a098fbbb11522029709c73bf912b884ee3f26
2023-07-18 19:47:44 +05:30
genofire
b86099ddc1 fix(helm): grafana add tags also on overview.json dashboard (like in ha-allocation)
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I6af734feb5cfc3dd8688a45a94e2fca012fcd312
2023-07-18 19:47:44 +05:30
genofire
bcc8ce7ba5 fix(helm): grafana only upload json files (not maybe screenshots)
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I9771caf619e7fd59c98a8029e08cb3a5c88db4b5
2023-07-18 19:47:44 +05:30
genofire
9c822cac18 chore(helm): use with in hpa (instatt of if and path again)
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I1895aff3a622d126e69b3a16ebfa130e1ce96996
2023-07-18 19:47:44 +05:30
genofire
b04cefa57a chore(helm): move dynamicConfig in extra folder
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I99c9c8b3aecc006b399defce5a605221358e04aa
2023-07-18 19:47:44 +05:30
genofire
33b64c0836 fix(grafana): add options to set annotations to dashboards ConfigMap
Change-Id: d9569af164b649863ec05d7b61a362c1ee876f4d
Signed-off-by: genofire <geno+dev@fireorbit.de>
2023-07-18 19:47:44 +05:30
Szymon Kłos
d696fe57f9 jsdialog: don't block uno commands when snackbar is shown
when any dialog is shown we block executing uno commands
don't count snackbar as a dialog and allow full interaction
of the user when snackbar is shown

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Idb1ec1aff9532ba2f1789157982cb25843df0c31
2023-07-18 16:00:52 +02:00
Darshan-upadhyay1110
fd630d427f Fix Spell checker js Dialog
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Idc0800eaa4ab751601bd34bba6c2e9cfef38de4d
2023-07-18 15:42:35 +02:00
Pedro Pinto Silva
7f2e5df037 Calc: fix document background. It should be white.
With c04c065edc we start to dynamically
set the canvas background. The problem is that for Calc cells do not
have intrinsically a background and thus what we end up to see as the
document background color is actually the canvas color.
	 - Make sure that when we are in presence of calc we set the
	 canvas color (clearColor) with the value coming from
	 documentBackgroundColor
	 - To make it clear: create a new CSS variable to be used as
	 background-document

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4c456e4aeea233609ee58684d967984dd8afd63a
2023-07-18 15:01:25 +02:00
Michael Meeks
b700ea08a8 deltas: further increase Kit delta cache to 96 tiles.
Should help for single user with large screens.
Also dump delta cache sizes on USR1.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Id16a287be6b05cee5681abe1d9d2dc0ec61cda2a
2023-07-18 09:43:34 +02:00
Michael Meeks
226dfe83fb deltas: don't clear useful debugging counters when restoring tiles.
Otherwise when we get under pressure re: canvas' we loose useful
statistics around the number of deltas applied.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I44a089e4af2819007b8f400b506292f8d469ff82
2023-07-18 09:43:34 +02:00