Commit graph

21505 commits

Author SHA1 Message Date
Szymon Kłos
d475083f05 jsdialog: close snackbar when action button clicked
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ibbdb247a052d8d4c2cca5f26d5bb9f31ced42187
2023-07-11 16:29:48 +02:00
codewithvk
df03cf1ce8 Fix : Wrong context menu in Slides Pane in master view for Impress
Signed-off-by: codewithvk <vivekpatel7202@gmail.com>
Change-Id: Icf19c9db12e0430fca98b0d639be62e2bbf29d37
2023-07-11 18:42:51 +07:00
Szymon Kłos
168f7cde07 jsdialog: field with time format should be simple edit
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Id745fc6651b3cab6f080e41abb97d13e444d0c73
2023-07-11 12:48:28 +02:00
Szymon Kłos
83c0f61f82 jsdialog: add disabled state for menubutton
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0b5c8db6015348c9ad7803c08d5ac00b6fff7016
2023-07-11 12:48:28 +02:00
Szymon Kłos
9720311bcd jsdialog: don't ignore menubutton with empty text
build also empty menubuttons, example:
- writer -> review -> manage -> filter
- select 'Date' checkbox
result: end date disappears
expected: menubutton should be recreated with empty string

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I96ba161d209a4f65bd40b4a1efac896e3e172d0c
2023-07-11 12:48:28 +02:00
Szymon Kłos
ee3935a997 jsdialog: calendar control
can be tested in Writer -> Review -> Manage -> Filter (date dropdown)

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I63b052ae29ac45b9ded66d1ca75195c58f3d7e13
2023-07-11 12:48:28 +02:00
Szymon Kłos
9187ae99d7 Center IFrameDialog using CSS
instead of using hardcoded pixel distance...

affects eg. feedback dialog which was impossible to
access in very small windows due to position outside window

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I2a85defcd2aabf1bdb8ec88d70b6e6a873dec75f
2023-07-11 10:19:40 +02:00
Szymon Kłos
8fb734b52d Make snackbar non-modal
Snackbar shoudn't block user interactions with other
UI components. This fixes regression introduced with
vex rework to JSDialogs where snackbar become modal.

This fixes problem with "send feedback" and "Zotero"
snackbars which block users for ~10s from editing.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I71a2d1654b58a89162679346208409124f24b14e
2023-07-11 10:19:40 +02:00
Pranam Lashkari
8120449cb4 scroll: override any pending scroll for cursor following
problem:
unselecting shape would make document jump to position where
cursor was before selecting the shape

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I4aa75932631de51e84e3aca9b439f1a9a945e2d3
2023-07-11 14:49:04 +07:00
Pranam Lashkari
5d049a2fd3 jsdialog: avoid closing parent dialog if child dialog is open
this patch assumes that dialog ids are incremental,
and no two dialogs are open at the same time unless
one dialog(parent dialog) has triggered another dialog

i.e: calc advance filter dialog triggers warning dialogs,
if entered an invalid range and closing the advance filter dialog
before the warning dialog causes a crash of LOK

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ic4ba3b4553fb0ee089b1ab9b50b1c023801b674a
2023-07-11 14:47:21 +07:00
Rash419
12dbc98395 fix: info level log for exceptions
- hard to find exception if browser logs error at info level

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I9f354480e1ee1d2da8a85973acd7b6563df83291
2023-07-11 12:37:34 +05:30
Caolán McNamara
aba5583ca9 drop empty CanvasTileLayer::_viewReset
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I77ac5e2069f86bcb9d2062cdabd9e886fbd34623
2023-07-10 17:50:13 +01:00
Caolán McNamara
42c9f54a98 osCanvasExtraSize is unused
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I96d74a5a9f6ae86ab4c33f58b60988f62afda417
2023-07-10 17:50:13 +01:00
Caolán McNamara
d5c7306a16 halfExtraSize and extendedOffset are newly unused
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ia2a51478ad674d0b10eeebdfb7e4bc4eb4614984
2023-07-10 17:50:13 +01:00
Caolán McNamara
d842d39cb2 extendedPaneBounds is now unused
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I0f1f37ee096f9e0e765effea23139d6a7a6bf456
2023-07-10 17:50:13 +01:00
Caolán McNamara
04acabbe87 oscCtxs and offscreenCanvases are write only
as far as I can see they are only written to, they are
not read from anywhere.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I0faf8f2b087c4b4228ac40e6804694be0f83eb54
2023-07-10 17:50:13 +01:00
Pranam Lashkari
f56694ef96 scroll: avoid selecting elements while dragging scroll bar
problem:
In safari and gnome web when you scroll using scroll bar,
DOM elements on the slidebar and documents would get selected

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I222d246148d5d84a5c0b3cfdb1890350f428e696
2023-07-10 23:48:00 +07:00
Henry Castro
8773e0e050 cypress: cypress logs for cool.html iframe
Also logs unhandled exceptions from iframe cool.html

Change-Id: I6f7b7d1340c8818d3f81916d42d6d9ed2920e35c
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
3c0731bf2c cypress: add emacs mode lines
Change-Id: I2cb19d34639ea6af55c693fad7bef8855a0ccba3
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
aa6be258fa cypress: upgrade version 12.17.0
Change-Id: I1464063e5149143f9a0aa4a1f5a433f5171b1d8e
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
fc791bbf37 cypress: fix missing package 'semver'
Change-Id: Ica5bd8d562127b9369b7b1fdf19a0dad3a861ef0
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
6ea782103f cypress: logging 'npm install'
Change-Id: I6b188bae89f2389124946c0fda497c9f9744e6b4
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
95436dcb3f cypress: fix missing dependencies
Change-Id: I5439d769dce043b8fc33416d0aa618a371314c26
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
a396c91886 cypress: check if NODE_PATH env exits
Change-Id: I69b64f1ad29e2ddd09663444922e8c1dc16411f2
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
9bcc79b266 cypress: add option baseURL
Setting a baseURL cypress verify if the server is
running and prevents to refresh when command cy.visit()

Change-Id: I1cffc0932d6a1ec4ee9793eb3935f60e02ca2545
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
f3787c85e8 cypress: install package 'cypress-terminal-report'
https://github.com/archfz/cypress-terminal-report

Change-Id: I242e421aeb02ee3861b16af78af87c6a9db22ad5
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
e69969a07b cypress: install package "@cypress/webpack-preprocessor"
"https://github.com/cypress-io/cypress-webpack-preprocessor"

Change-Id: Id261c7d1675c6f6c30d5f1661b4988511528b0d7
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
1ac16a13f1 cypress: remove plugin package 'cypress-failed-log'
It has a bug, it executes twice beforeEach function
if fails or unhandled exception.

Change-Id: I005815d440af0309cf797e52fbfb3693896418a9
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
2ec6bd70a2 cypress: disable screenshot
not useful for C.I. for now.

Change-Id: I1940d617b6b7c5f0a7dcae7e38c58dc5bd57f2e4
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
51ae4a836e cypress: logging stack traces of the unit test failing
Change-Id: Ic06c62b1cbd467abe17a5ff859848ca10673b4a4
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
a32cbb311d cypress: logging unhandled exceptions
Change-Id: I82bd3552fbf0b844492340762899b5c492148eca
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
a2048ce70d cypress: fix "loadTestDoc" remote server
If it is a remote 'coolwsd' server,
there is no way to rename or copy files.

Change-Id: Ic38302de5ecf3fa08fedd485d6060ede320867bc
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
119eee8036 cypress: fix work folder if remote server
If it is already running remote "coolwsd"" server,
there is no way to create a remote work folder.

Change-Id: I17932fcca321e2f7e0cdfcab2ad678dbcffc56ed
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
54e79ce289 cypress: add option "verbose=1"
To debug and trace command executions

Change-Id: I5e458c2db4cedef32b24e5925b38c1ee2aaaa4cd
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
ffb0bb8f7e cypress: add option "coolwsd=server:port"
It is useful inspect logs and run unit test
with an already running coolwsd instance.

Change-Id: I6b01316d552e3d12bf63db9cc7e813adb33a20c0
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
dec0fe5a83 cypress: fix missing config file, builddir != srcdir
"Could not find a Cypress configuration file in this folder""

Change-Id: I7d5b2094d6cd10ca3da2a099650f830bee31dfb1
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Henry Castro
a2920949d0 cypress: fix eslint error, buildir != srcdir
11:26  error  'process' is not defined  no-undef

Change-Id: I637bda97d3ba360a095c04a1987c9c64eef1349c
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-07-10 10:49:04 -04:00
Marco Cecchetti
ff34b16947 cypress tests for accessibility toggle ui
Helper functions:
checkAccessibilityEnabledToBe
  check accessibility state independently from current desktop ui
setAccessibilityState
  set accessibility state independently from current desktop ui

Both helper functions check that ui state and a11y support in text
input element are in sync.

Enable/Disable Accessibility Support
  test state toggling and state preservation when switching ui

Typing after switching accessibility state
  check editable area content after toggling accessibility support

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Icce5ae148024a8abf9b65a90229915f28f720554
2023-07-10 16:02:18 +02:00
Marco Cecchetti
d69de71094 remove dup code: A11yTextInput inherits from TextInput
Now A11yTextInput inherits from TextInput.
Added hasAccessibilitySupport to both TI and ATI

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Ic296afb840824e7901202c9c089c4025c6bb8ab2
2023-07-10 16:02:18 +02:00
Marco Cecchetti
d5cd0c67e3 TextInput: gecko: fixed not working delete key
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I01ebbfb6c0d64fba044ae211d81b58a2f3ef06f9
2023-07-10 16:02:18 +02:00
Marco Cecchetti
6be9a99c0d remove dup code: A11yTI: _sendKeyEvent uniformed to TI version
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I09dd4d1667c8075cc859a6b96a1da025d5b196ea
2023-07-10 16:02:18 +02:00
Marco Cecchetti
b750d6e93b remove dup code: A11yTI: _onInput mentions part uniformed to TI version
Pulled in changes performed by commit:
24c83b9e Rash419 refactor: consolidate mentions-related code in
TextInput.js

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I37577163ec2a8abf0131e276df83d6710dec4f73
2023-07-10 16:02:18 +02:00
Marco Cecchetti
32298f08f6 remove dup code: A11yTI: _onKeyDown uniformed to TI version
Pulled in changes performed by commits:
847ade24 Szymon Kłos Mention popup focus fix
a006c917 Gökay Şatır Focus on the selected comment with keyboard.
02616ed3 Gökay Şatır Don't auto show the comment on Calc.

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Icdc510f6d90af1b6f2379b6cbd4317940f0ac0ad
2023-07-10 16:02:18 +02:00
Marco Cecchetti
24727deee3 remove dup code: TextInput: uniformed code fragments to A11yTextInput
Uniformed code:
  getValueAsCodePoints
  _setupStyles
  _setPos
  _onInput: this._deleteHint
  getValue
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>

Change-Id: I6b5424e0afe3202d65abaf2d5b785b95cc9346c9
2023-07-10 16:02:18 +02:00
Marco Cecchetti
bc782c6b71 remove dup code: TI: _onCommandResult: clear content in desktop case too
TextInput:
undoing something does not trigger any input method
this causes the editable area content not to be a substring
of the document text

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I803c32d243c6331dc21685a6d2ee03919e21a8cf
2023-07-10 16:02:18 +02:00
Marco Cecchetti
b2c8cb32e5 remove dup code: TI: keep _hasWorkingSelectionStart for logging only
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Id8de738846a796be37184ecbc083fbd796620739
2023-07-10 16:02:18 +02:00
Marco Cecchetti
73c10a1d08 remove dup code: A11yTextInput: removed unused code
A11yTextInput:
_tabHint: removed unused property
_isTextContentEmpty: removed unused method
_onComposingContent: removed unused properties
_onCommandResult is no more used since on undoing editable area
content is updated by core through some accessibility message
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Ifc31a994661827d4f53891f85c6f7229bea758a5
2023-07-10 16:02:18 +02:00
Marco Cecchetti
abca8e5dd3 Adding support for enabling/disabling a11y support from the ui
Added toggle button/menu entry for enable/disable accessibility support.
This ui feature is available for Online Writer only.
The button/menu entry is added only when accessibility is enabled at
server level.
That allows to enable/disable accessibility per view.
By default, the accessibility support is disabled.
Anyway the accessibility support state is saved to local storage
if available.

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: If5968a47f17922038b9da3d320cbed84ebb7688b
2023-07-10 16:02:18 +02:00
Alexander Gabilondo
2ec2f7bcce Translated using Weblate (Basque)
Currently translated at 99.5% (461 of 463 strings)

Translated using Weblate (Basque)

Currently translated at 99.3% (460 of 463 strings)

Co-authored-by: Alexander Gabilondo <alexgabi@openmailbox.org>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/eu/
Translation: Collabora Online/Help
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ic84fed0a093017e8eb3d9b8669ea4c772d3d10bb
2023-07-09 15:07:12 +02:00
Sebastiaan Veld
3dfa51a234 Translated using Weblate (Dutch)
Currently translated at 100.0% (507 of 507 strings)

Co-authored-by: Sebastiaan Veld <sebastiaan.veld@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/nl/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I2aa565735b80609e557e2c6e3cdbb081a7f83968
2023-07-09 15:07:12 +02:00