Marco Cecchetti
def6ba9c21
A11yTextInput: empty selection at the beginning of a list entry
...
When there is an empty selection at the beginning of a list entry and
a <backspace> is typed, the <backspace> doesn't delete only the empty
selection as it occurs in a normal paragraph.
So we need to avoid to send 2 backspaces.
Since both a <backspace> and a <delete> removes the empty selection we
always send a <delete> followed by a <backspace> when a <backspace> is
typed and we need to remove an empty selection.
This solution works both for normal paragraph and for list entries.
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Idae144b65ed04ac28c602ee2155d337369c534fe
2023-06-15 15:00:18 -04:00
Marco Cecchetti
809234805e
refactored cypress tests for editable area
...
Helper functions has been moved to external file:
contenteditable_helper.js
Tests have been subdiveded in groups.
Spec file renamed from editing_spec to editable_area_spec
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Ifdb18b0de4851a2fc927b3a8fb3b1472165f2b7f
2023-06-15 15:00:18 -04:00
Patrick Luby
e381b9194e
Implement minor changes suggested during review
...
Signed-off-by: Patrick Luby <plubius@neooffice.org>
Change-Id: Id25c8a9deec35b9ae74ed1cc8a9dcf88dc5486cc
2023-06-15 19:01:42 +01:00
Patrick Luby
57a9db5664
Replace preprocessor directives with C++ conditional check
...
UnitBase::isUnitTesting() and UnitWSD::isUnitTesting() to avoid
calling methods that crash on mobile.
Signed-off-by: Patrick Luby <plubius@neooffice.org>
Change-Id: Ie6bc2d238ac9e475b02ceef5809c55acc129dd52
2023-06-15 19:01:42 +01:00
Patrick Luby
12213d7ec5
Fix iOS build breakages by adding http::Request to iOS build
...
Still needed to add a bunch of #if !MOBILAPP to disable all of the
Online server's unit testing classes so that the iOS app won't crash
when opening a document.
TODO: the iOS app will not accept text input at all. Is some code
unexpectedly consuming message data sent over the mobile fake socket?
Signed-off-by: Patrick Luby <plubius@neooffice.org>
Change-Id: Ie874ee8e452188a7b4cdf6d5f87708e5ed9b0235
2023-06-15 19:01:42 +01:00
Caolán McNamara
00705d4a32
use more string_view
...
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Iad56a97f9bef1f6f905f08002b1958072a209551
2023-06-15 13:29:04 +02:00
Marco Cecchetti
39be94e852
Force notebookbar ui when a11y is enabled
...
When accessibility is enabled in coolwsd.xml, overrides setting in
<user-interface> section by force to use the notebookbar UI.
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I98f4b288439b21110214ca2a67df639b397184c9
2023-06-15 08:54:51 +01:00
Marco Cecchetti
ac6ca0c59f
When Calc starts with the notebook ui, sheet tabs are missing
...
This patch fix a regression started from
17b50868ea
"impress: introduce slide hiding/showing in presentation"
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I55263b07088d16fe07171e004b5d505eb3b70500
2023-06-14 23:28:54 +02:00
Ashod Nakashian
874e4f4b29
wsd: signal handlers must preserve errno
...
Change-Id: I13ee808f73d739c9a30724799532d04b0b8b577a
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-06-14 07:04:26 -04:00
Ashod Nakashian
c9542a44cd
wsd: thread-safe kit pid
...
Change-Id: Id8dc3b894d18606e80806950f8bad65cf657a565
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-06-14 07:04:26 -04:00
Ashod Nakashian
40a915ab4d
wsd: thread-safe socket shutdown flag
...
Change-Id: I1f0b5be698b0e4a1cb55edf65eb706f181cd8516
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-06-14 07:04:26 -04:00
Ashod Nakashian
e5f274c65c
wsd: test: better test timeout thread management
...
Change-Id: I156d3563c13bd303e628d5a76fc2a48e6141bcf2
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-06-14 07:04:26 -04:00
Ashod Nakashian
a729d37af2
wsd: signal handler cannot log
...
Logging allocates and calls signal-unsafe
functions.
Also, we flush cerr now.
Change-Id: I80f371c1d32b0c650f0d5e132d30af9991b1e24e
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-06-14 07:04:26 -04:00
Andreas-Kainz
9383f46994
Dark Icons add missing ones
...
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: Iccd593de8fa4a420bf70beb59c59ea64285e32db
2023-06-14 11:41:09 +02:00
Caolán McNamara
24d55168ac
cid#318916 Uninitialized scalar field
...
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I5272fa72fb9edc32a1e1f93f17dafff907278672
2023-06-14 10:10:46 +02:00
Caolán McNamara
2f9c9396d3
cid#318856 Uninitialized scalar field
...
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I2a6c3e9d021884b898f9efdc51c528428321d6f0
2023-06-14 10:10:46 +02:00
Caolán McNamara
2e38ab907c
cid#318943 Uninitialized scalar variable
...
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I4b5afe9f26f90c11aec6009c55a9438263cff4e4
2023-06-14 10:10:46 +02:00
Caolán McNamara
1063fdbcba
cid#318963 Uninitialized scalar field
...
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I459f70a41e5c1bab2e575c8d9ee699e213f2456e
2023-06-14 10:10:46 +02:00
Caolán McNamara
fb9fe79d3d
cid#318951 Uninitialized scalar field
...
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I20dc0f87f000a68e1c6a6304292e792953959099
2023-06-14 10:10:46 +02:00
Caolán McNamara
88df33d467
cid#318915 Uninitialized scalar field
...
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ia93efc031d6072e97f90136f93dcaff03af934cc
2023-06-14 10:10:46 +02:00
Caolán McNamara
c8c49c5b53
cid#318908 Uninitialized scalar field
...
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I24f1ec683651439761fda48d2db68fee19afcc62
2023-06-14 10:10:46 +02:00
Caolán McNamara
572135c076
cid#318822 Uninitialized scalar field
...
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I9f3e7d440b0fadf2f73ca3f955ab34b0d1cc11dc
2023-06-14 10:10:46 +02:00
Caolán McNamara
0c027a73a3
cid#318882 AUTO_CAUSES_COPY
...
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I18f8af8bc3c3b0ea903a1b7d0786d3ce60da21e4
2023-06-14 10:10:46 +02:00
Caolán McNamara
a5c000fa35
cid#318941 AUTO_CAUSES_COPY
...
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I256c1f61ed997615e3277817ba60db4971783dab
2023-06-14 10:10:46 +02:00
Caolán McNamara
2d6b190805
cid#318977 AUTO_CAUSES_COPY
...
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Idea2efdb46d1b819b8210a380bd026789d666e2b
2023-06-14 10:10:46 +02:00
Caolán McNamara
bd34e1f7ee
cid#318952 Resource leak
...
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I1535456a76c403c4fb8d0eb5d3a88a923528f6aa
2023-06-14 10:10:46 +02:00
Caolán McNamara
13ed88a547
cid#318930 Resource leak
...
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I12cdbe749b2f46422f329e9da39427ede7feb436
2023-06-14 10:10:46 +02:00
Caolán McNamara
532688c6ab
cid#318877 Resource leak
...
commit fde57adbbf
Date: Fri Jul 7 17:12:19 2017 +0530
Introduce hard mode when we are OOM
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I507fcd07f07d15f613bcf1ce4c0141d23d518f88
2023-06-14 10:10:46 +02:00
Caolán McNamara
b68634db9a
cid#318867 Using a moved object
...
probably went astray with:
commit 52f2600cf9
Date: Wed Feb 16 17:22:18 2022 -0500
wsd: test: embue all tests with a name and unify logs
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Idf4f9bfce7ef188ac15a7cf62baadc3dd5b59dcd
2023-06-14 10:10:46 +02:00
Caolán McNamara
53e4209377
Resolves : #6514 disable noop 'canceltiles'
...
Given that all messages that can have "ver=" in them will also have
"nviewid=", "oldwid=" and "wid=" then the "id=" search is always
successful and this loop doesn't achieve anything. Disable this for now
and later either drop canceltiles or repair it to do something
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I085bd18f05561df3a542eb14ceb4744b228f4621
2023-06-13 20:04:57 +01:00
Henry Castro
05ad5c7b4b
browser: fix first character IME input
...
The FireFox browser corrupts the first IME input character
while it is IME composing and changing cursor position.
Change-Id: I96a6ddd9f5c74b83566051b447b46e45745fa2be
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-06-13 09:03:26 -04:00
Pranam Lashkari
71c3a431cd
impress: only one of hide/show slide button should be visible
...
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: If1823e7b40c8c4fdde5e954e9d89f854add8763b
2023-06-13 18:29:28 +07:00
Pedro Pinto Silva
fa39b29402
Add missing hideslide and showslide icons
...
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I60e4162d083bb1bb49b8bb5d13c7ebde719bb02f
2023-06-13 18:29:28 +07:00
Pranam Lashkari
17b50868ea
impress: introduce slide hiding/showing in presentation
...
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: If91726a1a66e1679b58603e496a5b90cde5f0b5b
2023-06-13 18:29:28 +07:00
Andras Timar
43965a0c6c
docker: force mv
...
I saw unexpectedly a prompt in non-interactive mode:
mv: replace '/etc/coolwsd/key.pem', overriding mode 0600 (rw-------)?
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I9acdc52bd612a1de52b5989e854b45898eda4b01
2023-06-13 11:36:01 +02:00
Henry Castro
f46f69eb1f
browser: fix encode hyperlink parameter
...
Encode the "JumpToMark" bookmark parameter to jump
sheet name with white spaces.
Change-Id: I3943751379bd00bbd4036e137256df1338d26f0d
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-06-13 10:21:18 +01:00
Caolán McNamara
81b2cbe63a
perf: avoid creating strings by using string_view
...
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ibffa35d40ee9839635cbd37be8cdc9c69b834504
2023-06-13 09:59:59 +02:00
Andras Timar
ab6dc9e044
docker: numeric user id of cool user is 100
...
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I7a3679289245f837d21525eb64eb234b7c796755
2023-06-13 08:54:43 +02:00
Andras Timar
e28e3643c5
docker: one more chmod commit was missing
...
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I18495a706326d0b6af98895501f5b830af7e08c3
2023-06-13 08:19:55 +02:00
Gökay Şatır
b6cb9796be
Fix JS error.
...
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: If0eeb49ec35793ab8a7d312f317d046d665dea99
2023-06-12 18:34:20 +02:00
Andras Timar
f23a49cd88
Bump version to 23.05.0.5
...
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Icd47475c24b1820e8fe42491c5260d81adc8805d
2023-06-12 14:55:39 +02:00
Sebastiaan Veld
064e7c66f0
Translated using Weblate (Dutch)
...
Currently translated at 100.0% (463 of 463 strings)
Translated using Weblate (Dutch)
Currently translated at 100.0% (503 of 503 strings)
Translated using Weblate (Dutch)
Currently translated at 100.0% (110 of 110 strings)
Co-authored-by: Sebastiaan Veld <sebastiaan.veld@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/nl/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/nl/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/nl/
Translation: Collabora Online/Android app
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I3e663b659de186cec2b0bd62b995fcef3b95b3ad
2023-06-12 13:54:21 +02:00
Sabri Ünal
889250dd2d
Translated using Weblate (Turkish)
...
Currently translated at 100.0% (503 of 503 strings)
Co-authored-by: Sabri Ünal <libreajans@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/tr/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I0fcb775cbbd4fa583599e7d1af959a7d92a8f119
2023-06-12 13:54:21 +02:00
Martin Srebotnjak
ce19410ce9
Translated using Weblate (Slovenian)
...
Currently translated at 100.0% (503 of 503 strings)
Co-authored-by: Martin Srebotnjak <miles@filmsi.net>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/sl/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ib35f3ff71af19b47c96165885575720b8dca616b
2023-06-12 13:54:21 +02:00
Sveinn í Felli
ba63c1ce31
Translated using Weblate (Icelandic)
...
Currently translated at 71.7% (332 of 463 strings)
Translated using Weblate (Icelandic)
Currently translated at 100.0% (503 of 503 strings)
Co-authored-by: Sveinn í Felli <sv1@fellsnet.is>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/is/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/is/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I69e9ae9a4b0fe9d5d5d1187d296017e5ae6824dd
2023-06-12 13:54:21 +02:00
gallegonovato
2221f67f28
Translated using Weblate (Spanish)
...
Currently translated at 100.0% (503 of 503 strings)
Co-authored-by: gallegonovato <fran-carro@hotmail.es>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/es/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ide2542491af424aa434129ccf4cfb4047d161b4c
2023-06-12 13:54:21 +02:00
Andi Chandler
c1424f73a1
Translated using Weblate (English (United Kingdom))
...
Currently translated at 100.0% (503 of 503 strings)
Co-authored-by: Andi Chandler <andi@gowling.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_GB/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ib839358a9e4e19f432ba33b711afe47fd8c67137
2023-06-12 13:54:21 +02:00
Rob Pearson
f66fdcbe5d
Translated using Weblate (English (South Africa))
...
Currently translated at 100.0% (503 of 503 strings)
Translated using Weblate (English (New Zealand))
Currently translated at 100.0% (503 of 503 strings)
Translated using Weblate (English (Australia))
Currently translated at 100.0% (503 of 503 strings)
Co-authored-by: Rob Pearson <rob.dunedin@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_AU/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_NZ/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_ZA/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Iea7d2fff1be3e26769094e0cce84f407463cf8dd
2023-06-12 13:54:21 +02:00
Andras Timar
fc50bd98c6
Translated using Weblate (German)
...
Currently translated at 100.0% (503 of 503 strings)
Co-authored-by: Andras Timar <andras.timar@collabora.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/de/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I27df0c0954089941bfeb7d9a2f2ecacc26bad648
2023-06-12 13:54:21 +02:00
Gökay Şatır
ffd626a62b
Fix paste_special_dialog id in clipboard.js.
...
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I14fbce5e96a0d456b7caf42892e0e9e89082a4d1
2023-06-12 14:49:31 +03:00