URIs may or may not have authorization data specified
via access_header or access_token query parameters.
In the event that the host doesn't have such needs
(for example authrorization could be performed by
some other means), we should accept the request
and still go ahead and make the WOPI request
all the same.
This patch effectively reverts the changes from
a019c93d90 which threw
an exception when the authorization method was
undefined. Since there was an assertion to warn
programmers that something is amis, now we simply
log the fact in trace mode and move on.
A new unit-test is added and another one that
expected the now-removed exception has been modified.
Change-Id: I26cc2514d7465b344037a6e32b777c0fe0ba9a2c
* provide a title to indicate that it's on purpose left blank and to pass automated tests
* be sure to hide the content altogether from screen reader users using aria-hidden="true"
Change-Id: Ia86eded442777d695ef399fe4bee95ac89000549
is it a POCO bug?
The implicit decode URI is not working
if a file is "test___á.pdf" <=> "test___%C3%A1.pdf"
getPath() returns "test___%C3%A1.pdf"
Change-Id: I79e2ec13cd5500d188a1657e47af03d29b151824
Some code was not actually hit because
$.inArray('.uno:SpellCheckIgnore', menuItem)
does nothing, since menuItem is not an array.
Broke since:
6fdad3ba94
It seems delaying spelling context menu is
not needed anymore, so we can remove that part.
Change-Id: I6cc96ee0f5b39d2090052fec29eae463285b3dfc
We don't have shape / table insertion items on bottom
toolbar for mobile. It must be the desktop related code
that was copy&pasted here.
Change-Id: I6af47392b4784d5ac61553e57430f493471c835c
The unit test is extended to check the response status
when the API convert-to is used.
use case file name: "test___á.txt"
Change-Id: I7b18dde01f7d44251e7c584a5348dd1228d6e420
if a file is "test__á.pdf" and if it is encoded "test___%C3%A1.pdf"
then stat("test___%C3%A1.pdf") is false
Change-Id: I28a5ed90c599b7244f0c3a3d2259d83b25be762f
If it is encoded again, the result file does
not exist.
If a file is "test___á.pdf" and encode again
"test___%C3%A1.pdf"
fileExists("test___%C3%A1.pdf") false
Change-Id: I9fa1b8b52ebf0993158eb6ebe383da53921f640a
It's enough to notify when they hit master.
Also don't write about non-master commits, which are sources for PRs to
be opened, in many cases.
Change-Id: I4bb7628cce4bb767016cd30aace72e88074970d4
When read-only shared file can be save-as to
users own storage, then it must be start with
edit permission after save-as. Otherwise,
user must close the doc and reopen again in order
to be able to edit.
Change-Id: I9eacc9373f3333d1ed3fff142d8023667e31342a
Signed-off-by: mert <mert.tumer@collabora.com>
Jenkins sometimes does not work properly and core
installation is not accessible for online build.
In this case the test build was passing without
actually run the tests. Fail on this instead to
avoid getting untested patches in the code repo.
Change-Id: I35c49562dfeaeda5f6c8aa4bd3a746b1f04de3ea
