Commit graph

21440 commits

Author SHA1 Message Date
Shehr Bano
e6a06eae1c FIX #7037: JSDialog: label vs textarea vs input field inconsistent paddings
Signed-off-by: Shehr Bano <shehr.bano@collabora.com>
Change-Id: I53494733c47b35d59133979c456665b4174e393c
2023-08-11 12:15:19 +02:00
Pedro Pinto Silva
16b8bead39 Revert "Add action for detecting code duplicates"
This reverts commit 8ce751a3ca.

- Any PR coming from fork fails
  - User needs to manually go to:
  settings > Actions: General > "Workflow permissions" and allow write permissions
- Right now we have too big of a threshold (26 lines) to be as useful as we would hope

Probably best to remove this action for now and instead use directly
the npm package (https://www.npmjs.com/package/jscpd#usage). Advantages:
  - More control over what is analyzed
  - It can be add as a step in make check
  - User can run it locally using make check; CI can also use that.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I3c112218a83fd6e56e7fb2f47b24315347a74cdd
2023-08-11 11:45:21 +02:00
Rash419
47f4305050 fix: cursor jump when hyperlink popup clicked in mobileview
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I4c5f1f2923f894156f5f05382b0f54476dea8a56
2023-08-10 17:38:22 +05:30
Caolán McNamara
912dfcd08e autofill onMouseDown doesn't generate working event position for hidpi
so the autofill handle in hidpi didn't work

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I718d9a8d3954a441705849eba174fe6b5b2983c4
2023-08-10 11:41:24 +01:00
Ashod Nakashian
a42adac98f wsd: add the web-server URL to the media-src list
We need to allow loading media sources from
the web-server URL. This seems to be necessary
at least on iOS.

Change-Id: Ic7b23c4f80b975460de9311a67f3c5cb51758d14
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-08-10 12:24:08 +02:00
Andras Timar
85ee03f98f CollaboraOnline#6546 enable automatic color in default paragraph style
use the xml token "use-window-font-color" to toggle auto color on.

https: //github.com/CollaboraOnline/online/issues/6546
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ib14b144ce6f593114a8130f5816f479d5cd4fe85
2023-08-10 12:22:26 +02:00
Pedro Pinto Silva
c89cccfc7a Welcome: allow scroll bar
Otherwise content is not reachable.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibef06bd7ee18702674e41e8f942449ef49ffdd62
2023-08-10 11:48:36 +02:00
Marco Cecchetti
96a7cfb25e a11y: provide info about current table and cell to screen reader
When we get in one or more tables screen reader reports row and column
count.
When we get out one or more table screen report reports "out of table"
for each table.
When the fosused cell changes screen reader reports new row/col index.
Screen reader reports cell paragraph content, too.
Added also cypress tests for checking that the table/cell description
string is correct.

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I078b29a2f76f91df479f75db76113c80405f7169
2023-08-10 09:29:09 +02:00
Darshan-upadhyay1110
7825f82ce1 Remove open_local_editor button in tablet view
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I18908150ee537bfe7dd36b0b94f8baa11d2739ea
2023-08-10 12:51:40 +05:30
Caolán McNamara
5185b7bedf cid#318934 silence Untrusted loop bound
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Icd7a7d3394dda93045f97481b109498fca3c01c8
2023-08-10 08:47:25 +02:00
Caolán McNamara
d79d86ed91 cid#318844 Dereference before null check
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ie3b4da580b86f4f313825dabb6d73af1508432d9
2023-08-10 08:47:25 +02:00
Caolán McNamara
2a8910a941 addPollFor default arg is now always explicitly passed
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ic9a822835ace44a1dee0c3dc4c8eb64d8e929b4d
2023-08-10 08:47:25 +02:00
Caolán McNamara
c593a0bde5 replaySync is unused
since:

commit 96adaa15d1
Date:   Thu Apr 14 19:05:26 2022 -0400

    wsd: kill coolwsd_fuzzer

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Id4b2275fbb0680a82ae29848a182de06a2de0d04
2023-08-10 08:47:25 +02:00
Caolán McNamara
b6f87b06e3 cid#322475 COPY_INSTEAD_OF_MOVE
configure currently requires a min of c++17

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I613dac6e66c3e77183d46623346969179bccc489
2023-08-10 08:47:25 +02:00
Caolán McNamara
1cd88f217e cid#321976 AUTO_CAUSES_COPY
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I2207cc530e1773f29cf540ea2ff9c6f44c4c237b
2023-08-10 08:47:25 +02:00
Rash419
5dcce1965e android: enable dark mode in documents
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I108601f78f4d7bbf704b5f5f89b20c8f8a597355
2023-08-09 17:37:16 +02:00
Pedro Pinto Silva
c2192b4a67 Screen reader doesn't properly report tab names in Tab View UI
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0ebe938080fa0e6865d4bf18e5dd33b0eb6a1567
2023-08-09 17:21:58 +02:00
Caolán McNamara
0c611649e5 cid#318854 Unchecked return value
check this one like we check all the others

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Id8379c6873fe7dd6466dc265cea6847d120aa0ce
2023-08-09 13:39:23 +02:00
Caolán McNamara
6d873d6837 cid#318919 Dereference after null check
map is never null so make it a reference

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I9f6ad863d0a1102dd7e26a5668b1c6ba71249580
2023-08-09 13:39:23 +02:00
Caolán McNamara
b1f88c4cb2 cid#318875 Dereference after null check
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I40c824e26183f0c0c17e1503dc1c438ba1d2ce5c
2023-08-09 13:39:23 +02:00
Caolán McNamara
2119a19881 cid#321981 AUTO_CAUSES_COPY
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I6c2d30c8db254beb6b20aae7891b089a986a4df8
2023-08-09 13:39:23 +02:00
Henry Castro
a2b924033d admin: rename ACCESS_TOKEN -> JWT_TOKEN
To avoid confusion with the WOPI access token.
.

Change-Id: Ie38e0f11d0655e89eb1c7f1e20b73a9b8756ba21
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-08-08 08:27:30 -04:00
Gökay Şatır
441d064b7a Make insert shapes menu accessible.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I7421cbf8e745b0dd973c7f99b985e8bf98b4859f
2023-08-08 10:07:09 +03:00
Rash419
340bbb0328 admin: increase font-size of y-axis
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I0439d79d487329bea8162762854430bac0b51448
2023-08-08 10:10:53 +05:30
Pedro Pinto Silva
3f0c9d5c55 admin: imprv ui sizes of adminClusterOverview.html
- Graph axis text is too small (10px) better to set it to 1em based on
parent div (16px). Good to also set any group within svg to 1em to
avoid any surprises
- Currently tablets from one card is spilling over to the next card
when there is not enough space. Better to allow scrolling.
- The left pane should be hidden even before reaching the mobile
size. This will fix the lack of space for cards and avoid everything
being so small

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I58c88385875469b56542703663e570ab4d63fbdc
2023-08-08 10:10:53 +05:30
Gökay Şatır
c12885c6ec Make insert table popup accessible.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I8dfa71208e22bd26257f2133a85a407afb2fd364
2023-08-07 15:19:00 +03:00
Gökay Şatır
345c8c7d48 Fix js error - notebookbar accessibility.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Ic17054cf6e195d8d1d6acb8b5c2a92112084e0de
2023-08-07 15:19:00 +03:00
Paris Oplopoios
a003126a65 Give new sockets a canonical view id in tests
Signed-off-by: Paris Oplopoios <paris.oplopoios@collabora.com>
Change-Id: I0c8a534fccb8088ab303852304802b4926369058
2023-08-05 12:00:08 +03:00
Paris Oplopoios
d0c5321aaf Fix getting canonical view id of 1000
Also tilecombine request now uses the canonicalviewid

Signed-off-by: Paris Oplopoios <paris.oplopoios@collabora.com>
Change-Id: Ib386edcf78de17cb4fc3d8c3c6ce65f6b52c8b5f
2023-08-05 12:00:08 +03:00
Rash419
0ed983d7a3 admin: refactor adminClusterOverview.js
- refactored special case for templating
  adminClusterOverview.html
- removed useless variable
- format the code, fix indent

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ib22cb481db7c7ef94b11f3044d0cd856e6d0eed5
2023-08-05 14:28:29 +05:30
Rash419
87bc8b10c4 admin: imprv ui of adminClusterOverview.html
- increased the sidebar length
- fixed html not covering fullscreen
- increase the number of card from 2->3
- remove unused property

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I86f6cf0225d4675bbd69dd0ebd7f77dbba6f9858
2023-08-05 14:28:29 +05:30
Rash419
8a879404ba admin: added podname to card
- if podname doesnot exist use serverId as title of card

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I7c09b7a8943b8a6a19bc6937ff180a06d82d12a6
2023-08-05 14:28:29 +05:30
Rash419
944f269926 admin: added new cluster overview page
- added DlgLoading class to show loading modal dialog
- upgraded the d3

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I8bd99bbadaa59a7de1e83bebde8db0dce920705d
2023-08-05 14:28:29 +05:30
Rash419
fc77e1a1ff admin: fix auth issue when switching between
multiple cool servers
- also good to check response first as client
  might use persisted cookies

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Idcd85266a4cc5020aeaca7d7fb8428bc0a3d7d32
2023-08-04 21:25:37 +05:30
Caolán McNamara
718992e30a cool#6911 don't show notes in hidden cells
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: If29b9603b990479b538dcc62c1e0e924679a7275
2023-08-04 15:43:33 +02:00
Caolán McNamara
15422721b7 cool#6911 don't show off-screen notes from col/row 0
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ib8281304568f8376ba01e14e360d6f174859851b
2023-08-04 15:43:33 +02:00
Caolán McNamara
7b51f8c22e cool#6911 draw the note indicator browser-side
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I175a5dc8f553c7e0eafef3a5e4aedff4796352e9
2023-08-04 15:43:33 +02:00
Caolán McNamara
4d7f7d67d0 cool#6911 calc comment positions are now cell addresses
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I0a70f1801f519df066ff5bc9dd57a5d485967b61
2023-08-04 14:15:06 +02:00
Caolán McNamara
aaa61e44e5 allow tileprocessed to accept multiple comma-seperated tileids
and bundle them together when emitted from the browser-side

// i.e. FIXME: new multi-tile-processed message.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I69916cbe30c26686fb44a2d8d229704c459b6601
2023-08-04 13:07:29 +01:00
Caolán McNamara
509c29421e split this hunk into reusable ClientSession::onTileProcessed
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I383542b6c9c3a888937e2f7e330ec7e77efaaa82
2023-08-04 13:07:29 +01:00
Caolán McNamara
040ee51ec9 occasionally testTileSubscription fails
sometimes the deltas arrive in a different order, later in the same test
we have "ordering is undefined tiles arrive in so swap if needed" for
a pair of later deltas, so do the same reordering for this
intermittently failing earlier test

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: If51edb9a4e22d469d9e029c38da7348c34b17832
2023-08-04 11:18:02 +01:00
Gökay Şatır
5485bea24e Add arrow key handlers for better accessibility support.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I3f6e81797c63dbe3cc5742ff39382a4052225541
2023-08-04 12:29:19 +03:00
Gökay Şatır
14c84ac453 Improve accessibility of w2ui drop down menus.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I9ff58eec19ccc7229c81b9d1f258bc8c4825634d
2023-08-04 12:29:19 +03:00
Caolán McNamara
8bb41ee775 cid#318947 Unchecked return value from library
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ia8b96035d5038d82a55f68a751fdbda5806ec1d6
2023-08-04 10:17:58 +02:00
Caolán McNamara
9e0b0a0c85 cid#318909 Argument cannot be negative
and

cid#318961 Argument cannot be negative

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I4bae768a3c72361309b84b624c019a315b574d97
2023-08-04 10:17:58 +02:00
Caolán McNamara
1d179cdf76 cid#321981 AUTO_CAUSES_COPY
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I92d66a3d497d574d819f18960bff5b60e180b715
2023-08-04 10:17:58 +02:00
Caolán McNamara
7cb1dfd4eb cid#321977 AUTO_CAUSES_COPY
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I50f94b290e40b11d555c51448630835d71a62019
2023-08-04 10:17:58 +02:00
Henry Castro
c56ebcc06d browser: remove hyperlink pop-up
Unfortunately, we cannot show the hyperlink pop-up,
in client side based on cell formula, because the formula
had not been evaluated.

=HYPERLINK(A1,A1);

The server should fire event "hyperlinkclicked".

Change-Id: Ie2b743812493e1790b9e54f0050974c585e61e00
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-08-04 08:52:59 +01:00
Pranam Lashkari
cbeee7727e accessibilty: added accessibilty fields to the mobile edit button
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ifdb59ff3463a0354549316994f8e80b341e28133
2023-08-04 09:17:58 +02:00
Szymon Kłos
e8b2ea5ca1 Deduplicate onInitialize method in Column/Row Groups
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I404b9de7159b410f922dd1a66991aadc5dae1c91
2023-08-04 08:12:03 +02:00