The unit test checks the aspect ratio of the preview thumbnails,
this happens when the document size changes (i.e changing paper format)
Change-Id: I0267e797327b73d714947258e004fe64cce9d1dd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97775
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
When copy is disabled don't put stub message about
download button in the clipboard.
Allow internal copy & paste when copy is disabled
- so disable only external interaction.
Change-Id: Ie7864abc8a239aa068880545cf09a48155ebbaea
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98237
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
In some browsers with strange settings localStorage is
not available.
Change-Id: If9e5ebeb9701cc0a2b19c5946bcbc23f76a8c577
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98238
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
the cell-area selection. Improbable, but can happen in a cypress test.
Change-Id: I112ef88d11818c6e0abc91a8de37c329666dcdbc
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98216
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
See commit: "Replay print-twips messages for a couple of reasons..."
for context on replay.
Change-Id: I8a834fef08685d0ee713f64abed1696e56987241
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98158
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
All graphic-selection messages from core are in print-twips if
sc_print_twips_msgs is set in SAL_LOK_OPTIONS. So do all the necessary
conversions on intercepting the message.
In addition, in this mode the core expects the parameters of the command
'.uno:TransformDialog' to be in print-twips. This is also done in this
patch.
Change-Id: Ief8a0d4677f83f26b135ce47b68c27bff5aaf5c9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98157
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
own: invalidatecursor, textselectionstart, textselectionend
view: invalidateviewcursor
See commit: "Replay print-twips messages for a couple of reasons..."
for context on replay.
Change-Id: I7d7cfd62202ac46b3410ad3e08bc04f0e2cdab00
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98156
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
and reuse this to parse all rectangles in text-selection (own/view) message.
Change-Id: Ic6946b2f10d9f642232d540b5974d53edbb774d7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98153
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
Print twips coordinates for chart/draw edit-cursor is not there yet in
core (needs more work).
Change-Id: If8cd9431fa43351340c74e989ee837f4b1b859dd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98152
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
until we have a better solution. It messes up the positioning of headers
w.r.t the map at certain zooms.
Change-Id: I32422a5f5076f83631f28a90db6a543e830ccf0e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98150
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
and reuse them where we need to parse points/rectangles strings from
core and avoid writing the same parsing code everywhere.
Change-Id: I029ba97eaa1062eef404eeb8f35d1c6897315d80
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98149
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
like we have for L.Point.
Change-Id: Ic7d1bf7d41f8d3e2cec2dab05ba0742342840775
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98147
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
when zooming close to bottom/right of a sheet. The bug is due to the
view centering logic on zoom without the knowledge of sheet area
hard-limits and is present in online master without the calc-coordinates
cleanup work.
Change-Id: Ic3b9f2873c4a22365a87a08a2ff89d8584a16581
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98145
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
The new utility is safer and more readable.
Change-Id: I3a86675378d458cb004e5534dbf2b401936d0e57
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98183
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Since this file is only created manually,
it shouldn't be removed automatically.
Change-Id: I8d26b7bfc7f7cd899318b2edd3e5ef9bd462cc99
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98184
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Instead, set brandProductName from the MOBILEAPPNAME. Now the mobile
app name shows up in the progress bar.
This reverts commit 24a0c7c3dc.
Change-Id: I91c7ea3d21f5362fc6a4d777b041089413e921ee
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98205
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Newly jails folder is cleaned up after a run.
Change-Id: Ia4f3eb26f61c5f14304e9ae6a3d5b5f60a0ee592
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98204
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
If L.CalcTileLayer.options.printTwipsMsgsEnabled is set, we will not get
some messages (with coordinates) from core when zoom changes because
print-twips coordinates are zoom-invariant. So we need to remember the
last version of each of them and replay, when zoom is changed. We also
need to replay the messages, when sheet-geometry changes. This is
because it is possible for the updated print-twips messages to arrive
before the sheet-geometry update message arrives.
Change-Id: Icd77ad77c7642aae24e68fb0b7f229c7ec62484a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98114
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
This is conditioned on the flag printTwipsMsgsEnabled.
Change-Id: I61a9165a9f81ce7473c3fa6579947f34552dbdaf
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98106
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
with the height(width) of the parent container, because if it does, the
header-canvas scales its contents to adjust to the new height(width) and
of course goes out of sync with the tiles.
This bug is visible when we do synchronous update of headers and if one
or both of the headers change size due to increase/decrease of
table-outline levels.
Change-Id: Ib65fd27f3598c7d58323d37c80ce2a147e594911
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98104
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
at document load till we get a response, by using flag.
Change-Id: I6296d6e18a122ee3cb714f26c019f9080c7febc7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98101
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
and use it to fetch the changed sheet geometry data and update the view.
Change-Id: I5a72012ce08f23e456cd64388e22385872f665a5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98099
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
sheet-geometry data source is enabled, because these messages are not
just for sheet geometry changes.
Change-Id: I8b2cca968a189607e46a4f9512c60e4b29f124bc
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98098
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
