Commit graph

20149 commits

Author SHA1 Message Date
Rash419
e93a193ae0 Revert "Remove unnecessary .waits from image tests"
- image test consistently fails without waits in CI

This reverts commit b529c96a48.

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I66bd85c8fe1ce28ccab8d644a98265145d3de64b
2023-03-14 17:31:57 +05:30
Andras Timar
ec7e460739 GitPod: use core assets of version 23.05
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ie9c945211404d11e9fa9c368e113d4e30f53cc4b
2023-03-14 12:04:51 +01:00
Andras Timar
86797465e3 CodeQL C++: use core assets of version 23.05
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I309a36812f931cd51a0b755cee21b8b9d9d87765
2023-03-14 12:04:32 +01:00
Andras Timar
1baf6565d7 Cirrus CI: use core assets of version 23.05
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I0b1fa6bab026c6329d263f28b50259313f86db37
2023-03-14 12:01:38 +01:00
FedericoHeichou
985f284c89 Fix isLocal failing check with IPv4
Signed-off-by: FedericoHeichou <34757141+FedericoHeichou@users.noreply.github.com>
Change-Id: If6fa382102252908dac1fb80199bb332ce400aeb
2023-03-14 10:48:20 +01:00
Gökay Şatır
33fc77c412 Remove vex from password dialog.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ibd7364e44d14eaca025037c37d85cb621a2ebec5
2023-03-14 10:35:10 +01:00
Gökay Şatır
c17671b541 Remove vex dialog from saved-as warning.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Id41c98806bc4763797c9986a60ef39301581da06
2023-03-14 10:32:45 +01:00
Szymon Kłos
824afb669c jsdialog: mobile tab handler in separate file
and don't hide tabs

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ic78c8c17e1543ff4dc1a0874d13e05f5a7a7426b
2023-03-14 10:31:26 +01:00
Szymon Kłos
243bb8f3f0 cypress: adjust file description to new typing
we send value on every key press now, but core still
sends updates back, after we update core to not notify
us with the same value it can be reverted

this prevents us from having incorrect text when typing long
sentences and receiving updates with delay

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If87c3f1c83018920dfaa8f3c31f567b25df27c61
2023-03-14 10:31:26 +01:00
Szymon Kłos
3bb07cdd52 jsdialog: set text for textview after every key press
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0a00b453d903a1b13ae69c7efc37e0e7d2e81913
2023-03-14 10:31:26 +01:00
Szymon Kłos
58e686deb9 jsdialog: send selection for text view
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I3d87a676a1c47ea8fc99ba523ccf960a6cbde90f
2023-03-14 10:31:26 +01:00
Szymon Kłos
1665d6e7bc Move formulabar edit field to separate file
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia4d5f1c8547cf329c5f624ad09ac9049bdda62f7
2023-03-14 10:31:26 +01:00
Szymon Kłos
d06f539943 jsdialog: don't warn when unselect all is called
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I1671203ba490fb83aa65baeba86f109325750cdf
2023-03-14 10:31:26 +01:00
Gökay Şatır
1ba537d8bf Remove vex from _switchToEditMode function in permission.js.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I444ea61eb6cf6c92858833a30be92ee9a6a36509
2023-03-14 10:30:37 +01:00
Andras Timar
489a323742 Translated using Weblate (Portuguese (Brazil))
Currently translated at 100.0% (525 of 525 strings)

Translated using Weblate (Italian)

Currently translated at 100.0% (525 of 525 strings)

Translated using Weblate (French)

Currently translated at 100.0% (525 of 525 strings)

Translated using Weblate (Italian)

Currently translated at 96.9% (509 of 525 strings)

Co-authored-by: Andras Timar <andras.timar@collabora.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/fr/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/it/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pt_BR/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ic8131fcba722e09e8b2a73df39de25b54b88ae59
2023-03-14 09:04:33 +01:00
Ayhan Yalçınsoy
b43a7fdfc6 Translated using Weblate (Turkish)
Currently translated at 100.0% (525 of 525 strings)

Co-authored-by: PhD. Ayhan YALÇINSOY <ayhanyalcinsoy@pisilinux.org>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/tr/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I2a229ba7e216752858c6f2b25cfa9b16bc11b31a
2023-03-14 08:28:00 +01:00
Sebastiaan Veld
d4556acde4 Translated using Weblate (Dutch)
Currently translated at 100.0% (525 of 525 strings)

Co-authored-by: Sebastiaan Veld <sebastiaan.veld@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/nl/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I6b68d8f60bfb84f8215fbf40969a52e7cb0ac35e
2023-03-14 08:28:00 +01:00
Alex Gabilondo
b6e2891044 Translated using Weblate (Basque)
Currently translated at 99.6% (523 of 525 strings)

Co-authored-by: Alex Gabilondo <alexgabi@disroot.org>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/eu/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I713bf5df8e70011e02010a268c0d0532900fc7f2
2023-03-14 08:28:00 +01:00
Rob Pearson
d625a1fec4 Translated using Weblate (English (South Africa))
Currently translated at 100.0% (525 of 525 strings)

Translated using Weblate (English (New Zealand))

Currently translated at 100.0% (525 of 525 strings)

Translated using Weblate (English (Australia))

Currently translated at 100.0% (525 of 525 strings)

Co-authored-by: Rob Pearson <rob.dunedin@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_AU/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_NZ/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_ZA/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ic7ba5fe496b85f3c8b167f90c0e53fc2b27a0420
2023-03-14 08:28:00 +01:00
NickWingate
b6652a3f29 Force viewport to be correct size for image tests
Signed-off-by: NickWingate <nick.wingate@collabora.com>
Change-Id: I01d3b7ddaa0a48b59b43466ffdd2e5bb54ccc7c8
2023-03-14 11:25:43 +05:30
NickWingate
b529c96a48 Remove unnecessary .waits from image tests
Change-Id: I6ad9b0f256d7613a784684569966dbcf36ec6e2a
Signed-off-by: NickWingate <nick.wingate@collabora.com>
2023-03-14 11:25:43 +05:30
Jaume Pujantell
002cf9e436 Stop erasing the whole tmp directory after a download
Signed-off-by: Jaume Pujantell <jaume.pujantell@collabora.com>
Change-Id: I805e27df25d3134eb12926f28b6f9ff09b4ed230
2023-03-13 16:18:08 +01:00
Tor Lillqvist
43a8ed3f1c Rename variables to match meaning and add a few comments
It is misleading to use the word "pixel" in a variable name when the
variable specifies a size in twips.

Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: Idc59c3dafd63a9ae73601f9c367b37c495e1593a
2023-03-13 12:33:49 +01:00
Tor Lillqvist
12c22706f9 We aparently want thumbnails to be of size 1200x630 pixels
Tweak the "zoom" variabe to be 1 so that with this thumbnail size, for
a typical document we get more of it into the thumbnail.

Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I419afccbf57eae23062ab4c849dd41293f068f00
2023-03-13 12:33:49 +01:00
Ashod Nakashian
98a0f5d97a wsd: do not disconnect the last session if saving
Previously we only waited if a new auto-save has
been issued at the point of disconnecting the
last session. However, we could have a save in
progress, particularly when it's a slow one,
and we should equally wait for it before
disconnecting the last session.

Failing to do so will exit the kit right after
finishing the save and will rob us of the
ability to upload the just-saved version.

Change-Id: I678689a95211fa8b80bcd3e8d4537de7de5d6632
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-03-13 08:19:33 +00:00
Rash419
f335d08e09 fix: renaming doesnot work when indirection_endpoint is enabled
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ic79a0436f87d4ab4697597d15fd60fa148050270
2023-03-13 08:07:16 +01:00
Rash419
58d66fca59 admin: notify routing_rmdoc to subscribers when all views expires
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I360b90d2b93ce9e8508f16822a2654e111ba2407
2023-03-13 08:07:16 +01:00
Michael Meeks
d5e95c80ec quarantine: cleanup.
Also handle OOB values of config setting.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ia0d4e2e0475bfd6d487006847ea0622b573569b7
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-03-11 17:42:30 -05:00
Michael Meeks
eb43a27396 locking: avoid spamming warnings in some circumstances.
If we have no write-able sessions, we can't lock the document -
fair enough to complain, but not every ~300ms - so defer another
lock period in this case.

Change-Id: I7beb974b3c17fd6ac01a32d8fe50261a54340665
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-03-11 17:42:30 -05:00
Gökay Şatır
7ad8a38a48 Remove vex from confirmation dialogues.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I240e6771ab1f57118cfa263fda1566349a38f8ac
2023-03-11 10:03:07 +03:00
Gökay Şatır
7b205f8821 Rename version check to versionbar.
There was a naming conflict with infobar event.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I0b2a80bcb6f6e636980f8acff21f39fec5414174
2023-03-11 10:00:17 +03:00
Gökay Şatır
045df53848 Remove vex dialog from infobar.
Remove the control.infobar file.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I57a0be34b318413256d691e636510e0a32403751
2023-03-11 10:00:17 +03:00
Tor Lillqvist
3294030b37 Handle get-thumbnail also for graphic objects
I am a bit surprised that this seems to work. Thanks to Szymon Kłos
for pointing me in the right direction.

Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: Ie9740a7a281a2b82ac7ca9fdf5f6374a29feec5d
2023-03-10 19:41:16 +00:00
Tor Lillqvist
59051dc5f7 No need for any saveAs when doing a get-thumbnail
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I4a7887455ebb5e0c4e9c5fbaf534e5e8a57c963d
2023-03-10 19:41:16 +00:00
Tor Lillqvist
b72edec3b5 There is no separate paintThumbnail() API in LibreOfficeKit any longer
It was just a thin wrapper around paintTile() anyway.

Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I7cca1b05b1ded754ae1f50a0e9d434b505247e70
2023-03-10 19:41:16 +00:00
Szymon Kłos
7cb8005df9 Send thumbnail in binary format
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iad5aec0cfa699f7e38a28c3c6812426ea345bafb
2023-03-10 19:41:16 +00:00
Szymon Kłos
a8f0263d75 Use http::Response for extract-link-targets and get-thumbnail
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ife0d24f9cac487ad08ff18fd9e180222371c70fa
2023-03-10 19:41:16 +00:00
Szymon Kłos
ffb15a2dea Send BadRequest if parameters missing
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I2acc4cb22d064994f3fca16b92b7d4528b403044
2023-03-10 19:41:16 +00:00
Szymon Kłos
50b5c06ad7 Scroll to target
using URL parameter we setup documents position on load.
example: ...&target=image6.png|graphic

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I855bdb148819966e0d51dde217a94474003a6437
2023-03-10 19:41:16 +00:00
Szymon Kłos
dd4b1239e0 Introduce scrollToPos function
This shares code in few places.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I9abfb1c3e7859260f568072b6c6f7d1ebcb51ef8
2023-03-10 19:41:16 +00:00
Szymon Kłos
e82aa05293 Handle target in get-thumbnail
Using target parameter we move cursor to the desired position.
Thumbnail then is created and sent to the client.
Example target: "image7.png|graphic"

Original author was Mert Tümer.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I170f6af6fd29c420565feca69b8bef034fd91a66
2023-03-10 19:41:16 +00:00
Szymon Kłos
3bec642b02 Add get-thumbnail endpoint
Which generates PNG of selected link target in the document

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Icfdca2f0b58ea370ca0125c188759e942aacc2e0
2023-03-10 19:41:16 +00:00
Szymon Kłos
f116a8e619 Merge extract-link-targets and convert-to request handling
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0d3787dd33c103f128f4b16bb9b4c1d1195658c0
2023-03-10 19:41:16 +00:00
Szymon Kłos
18e304e87c Add extract-link-targets endpoint
Original author was Mert Tümer.

Example output for: POST http://localhost:9980/cool/extract-link-targets/

{
    "Targets": {
        "Tables": {
            "Table1": "Table1|table"
        },
        "Frames": {},
        "Images": {
            "image7.png": "image7.png|graphic"
        },
        "OLE objects": {},
        "Sections": {
            "Table of Contents1": "Table of Contents1|region"
        },
        "Headings": {},
        "Bookmarks": {
            "_lh2zfxamp5al": "_lh2zfxamp5al"
        },
        "Drawing objects": {}
    }
}

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iab55ec631d78dbe25b2800ed9296bc0cb8997e97
2023-03-10 19:41:16 +00:00
Michael Meeks
7987af35c4 coolmap: accelerate handling large ascii strings without \0 termination.
Change-Id: I6831f455da038a20eb611fbbb0902dc495dc31d7
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-03-10 17:08:59 +00:00
Gökay Şatır
9d5155f463 Remove vex dialog from command.js.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I76370dfab1c6c793a76ba14324878c0b656613ba
2023-03-10 16:26:22 +03:00
Szymon Kłos
2ab0304c2b jsdialog: post process also elements in buttonbox
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ice3d0dbdf9c089925219c9b094c55a36136b7cc7
2023-03-10 18:39:11 +05:30
Ashod Nakashian
acdce2e72f wsd: check if SysTemplate is writable once per update
Change-Id: I3bc77eaf42cc84e7e5b6365f7fc446ea38df5dc0
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-03-10 07:45:12 -05:00
Ashod Nakashian
d0ed6cd3d2 wsd: test: do not start the next test if test is not finished
Change-Id: Ibdcf66f9a037f6b4e2e575cb61fe1459c912e44f
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-03-10 07:45:12 -05:00
Ashod Nakashian
5f0248ef7f wsd: not an error to not support storage locking
Change-Id: I0314a37bbda40808bd7d225540e69b93a1ab18d2
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-03-10 07:45:12 -05:00