- image test consistently fails without waits in CI
This reverts commit b529c96a48.
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I66bd85c8fe1ce28ccab8d644a98265145d3de64b
we send value on every key press now, but core still
sends updates back, after we update core to not notify
us with the same value it can be reverted
this prevents us from having incorrect text when typing long
sentences and receiving updates with delay
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If87c3f1c83018920dfaa8f3c31f567b25df27c61
Three elements have the `.cool-annotation-collapsed` tag
Specify the correct one
Signed-off-by: NickWingate <nick.wingate@collabora.com>
Change-Id: I1c8f16c9ef7cfedecf02fe0c46afbf5cbde90a7c
Merge downloadas-pdf and exportpdf actions to have same functionality
on desktop and mobile view. Now we can see setup dialog on mobile view.
On mobide view Download as -> PDF should show PDF download
settings dialog before downloading the document same like
desktop view.
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Ib0dd3877973dae025e7a6d4f15f2fa26351ea369
Merge downloadas-epub and exportepub actions to have same functionality
on desktop and mobile view. Now we can see setup dialog on mobile view.
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Iebe05e65f331de6737be88288fac34244cfcde18
This feature didn't have any visual indicator
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ice0a9f953cbd2028d21f514882b7997d775b7d7a
impress/table_operation_spec.js was failing due to split dialog converting to jsdialog
writer/top_toolbar_spec.js failing due to change in name of clear formatting button
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ia70b80540ebfee66b1499b931c1fc32ab6f9df95
showModal is going to be replacement for vex
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ic339dcb0338a6a15b85b7653e09f5a721e49640b
rollbackPastChange function already opens the menu
so don't do it twice
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I930f669589da1f9e18840dae4013d81a49707639
prefer picker id, not palette id with number which is generated
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I52d30c3991b516378e82455fdc104b5d94e94f91
- The repair document dialog is a leaflet dialog
- As this dialog is online-side only, I'll use the JSDialog builder
directly rather than writing a UI file
- Most of the code to build the dialogs is already very adaptable from
looking at the protocol of existing JSDialogs that come from the
server & where the code goes, however a small change had to be made to
dialog modifications to allow us a callback function, as otherwise we
would send off to the server whenever we pressed on a list item
- Finally, if there's no list to show, we'll show a bit of text saying
that there's nothing, as otherwise it looks like an empty/broken dialog
- If we're on mobile, we'll need to use the alternative helper (the one
that handles mobile wizard building)
- Fix a cypress test for writer (although impress and calc seem to have
tests for this too that aren't implemented: this should be handled in
a follow-up PR)
- Fix mobile tests
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: Iab9e943a428e66b05e28819c2ee1001a2deffd2c
Form tests seems to be a bit unreliable due to toolbar down items
- Not be visible sometimes
- And when the zoom check up is too fast
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4319db1a833335300780d052555f33afc976f33a
Before scrollbar-right would get in the way making it impossible
to click in the desired element
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6a00dfe8cddf503d39d8e7207b46bba1588f9b96
By Renaming .vex-dialog-button-primary -> .button-primary and
.vex-dialog-button-secondary -> .button-secondary
- So we can remove duplicity on CSS buttons
- Easier to set vex primary and secondary button to use our css classes
- This way there is no need to hunt those specific cases down.
- Update cypress tests
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I82f4b33560367805eeeeb5aec9af8d1abd313788
Adding attribute by jQuery and testing in cypress was
not working: visible value was correct after change but
in DOM we had original value which was tested by cypress.
Use val() to setup value and have.value for cypress to test.
Unify inputs so we don't use attributes but always props.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I1b3acccbd6d4ba493f867044b9b3c1f17b16873e
problem: when we click on checkbox to filter the data in autofilter dialog the checkbox itself disappear
if that is expected behaviour then cypress test needs to modified if not bug needs to be fixed first before
enabling this test
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I4dbfcf8abebe1c65e27c8c090bfce3ed0c59d086
- The test contains coordinate ranges for where the scrollbar must be
- As PR #5131 moves the scrollbars, we need to adjust these coordinates
so the test passes
Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Change-Id: I6d037a304cc86553c47e81acbc63643742db2f66
Now it is merged on core side.
This reverts commit 4e3b34d6dd.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ie8f7e8f3e8d269af186e0a3d82aed73f63577789
There is no reason for custom handler.
Thanks to that we don't need special css.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I9b576d4a6ef5668ec281c4e1348335d3b93bbac0
