Commit graph

24611 commits

Author SHA1 Message Date
Szymon Kłos
eb671baef6 SlideShow: use presentation info
- first turn on fullscreen (has to be on user interaction)
- then start presentation when presentationinfo and content arrives
- share some code, remove unused code

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I7a3f7daad31c590e653e62cfd12bef112064abe2
2024-07-17 20:13:38 +02:00
Javiya Vivekkumar Dineshbhai
4e008cae9e Replace first two slide preview with hard code image path
Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com>
Change-Id: Iafb297f6699b5c3e3f9b3b76d21c3619dcf16f6a
2024-07-17 20:13:38 +02:00
Szymon Kłos
a2e83037bb Unify SlideShow namespace usage
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia20c3fee0159238badabcbb8948825077abfb20c
2024-07-17 20:13:38 +02:00
Javiya Vivekkumar Dineshbhai
a8cdf1985a Prepare Presentation mode canvas for transition
Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com>
Change-Id: I1335c5191ae3c3d2df8e5b956a5268f7289b86b3
2024-07-17 20:13:38 +02:00
Tomaž Vajngerl
14683f93db Introduce SlideshowPresenter to show the slide shows
SlideshowPresenter is a class for presenting individual slide
bitmaps and transitioning between the slide bitmaps.

Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Change-Id: Ie4a23574deeb1207ce63ccd152fe7be1d9ca84a1
2024-07-17 20:13:38 +02:00
Javiya Vivekkumar Dineshbhai
e474454b78 Add 2d Fade transition
Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com>
Change-Id: I4745b6e8d747e68cc8e0264a534ba9bf87d90df8
2024-07-17 20:13:38 +02:00
Szymon Kłos
cf7f0b4dd4 Convert SlideShowPresenter to TS
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ic54a92e499b6171bed79a2d6cdab7cbe0e4aff3c
2024-07-17 20:13:38 +02:00
Tomaž Vajngerl
10e73c48c0 Introduce SlideshowPresenter to show the slide shows
SlideshowPresenter is a class for presenting individual slide
bitmaps and transitioning between the slide bitmaps.

Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Change-Id: Ie4a23574deeb1207ce63ccd152fe7be1d9ca84a1
2024-07-17 20:13:38 +02:00
Caolán McNamara
be940ae030 run cypress tests with mount namespace defaults
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I72749f46090f90f73835eabfc02dab9e1771b229
2024-07-17 16:49:30 +02:00
Caolán McNamara
5fbc4bbbdd use a smaller subset of flags for remounting readonly
a) In the linux namespace mount case an additional MS_NOATIME, etc. will result in
EPERM on remounting something hosted in a toplevel [rel]atime mount. man 2 mount
has 'An attempt was made to modify (MS_REMOUNT) the MS_RDONLY, MS_NOSUID, or
MS_NOEXEC flag, or one of the "atime" flags (MS_NOATIME, MS_NODIRATIME, MS_RELATIME)
of an existing mount, but the mount is locked'.

b) lxc has default apparmor rules of
https://github.com/lxc/lxc/blob/main/config/apparmor/abstractions/container-base
where the closest match is:  "mount options=(ro,remount,bind,nodev,nosuid)"
so additional 'MS_SILENT' or 'MS_REC' flags similarly also cause the remount to
be denied

So if we use a more recognized set of options we work out of the box in
the default lxc configuration.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I5f8de2de998ae1a85fefc1c9537b79b2b3bdefec
2024-07-17 15:40:30 +02:00
Josh
9719250e73 fix(COOLWSD): Fix a typo remove_font_config->remote
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Change-Id: Ib2c5bc13ded052aa3e76b0dcb280b32d7febedb5
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
2024-07-17 15:07:34 +02:00
Caolán McNamara
e5bfc8529e this._marker.closePopup not a function
this can be reproduced by inserting a table in writer, and then clicking
and dragging one of the "marker" indicators above the columns

wsd-308187-308314 2024-07-17 06:59:38.909586 +0000 [ websrv_poll ] ERR  jserror {
  "userAgent": "mozilla/5.0 (x11; linux x86_64; rv:109.0) gecko/20100101 firefox/115.0",
  "vendor": "",
  "message": "TypeError: this._marker.closePopup is not a function",
  "source": "https://.../browser/.../bundle.js",
  "line": 21863,
  "column": 88
}
this._marker.closePopup is not a function
_onDragStart@https://.../browser/.../bundle.js:21863:88

possibly since:

commit 9932ad7516
AuthorDate: Tue Jul 9 18:41:52 2024 +0300

    Remove unused files, variables and functions.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I34b21713b980beba0e1123a9738c870334c10354
2024-07-17 12:47:15 +02:00
Caolán McNamara
72de0e666c undefined docLayer seen on _onWheelScroll
wsd-308160-312471 2024-07-17 08:14:44.302140 +0000 [ docbroker_031 ] ERR  ToClient-7e2: jserror {
  "userAgent": "mozilla/5.0 (x11; linux x86_64; rv:127.0) gecko/20100101 firefox/127.0",
  "vendor": "",
  "message": "TypeError: docLayer is undefined",
  "source": ".../browser/.../bundle.js",
  "line": 20766,
  "column": 37
}
docLayer is undefined
L.Map.Scroll<._onWheelScroll<@.../browser/.../bundle.js:20766:37

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ibaa7aef4051977e708b7dad5396ac0564b06a5af
2024-07-17 10:43:14 +01:00
Caolán McNamara
b65ded3f6b Allow Namespace use even if BindMounting failed
For Namespaces the parent uses e.g.

jails/195178-46f603be/tmp/cool-82ChWNp1XiISVSpV/

to pass files to what is normally the child's (hidden) bind mount of that as

jails/195178-46f603be/82ChWNp1XiISVSpV/tmp

If BindMounting fails and we fallback to linking, then symlink
jails/195178-46f603be/tmp/cool-82ChWNp1XiISVSpV/ to the fallback
jails/195178-46f603be/82ChWNp1XiISVSpV/tmp so the parent can still
use the path expected for Namespaces.

So we can still get the goodness of namespaces wrt capabilities even
if we have the ills of bind-mounting fail.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I9a6f9e8db8f6edced18fe20367afc4d599a29ed2
2024-07-17 11:19:11 +02:00
Gökay Şatır
0fd5802ed7 Introduce docevents.ts for firing / listening to events.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I856bd4666f0a00fbc822b67a18e3aca52095b252
2024-07-17 11:09:29 +02:00
Gökay Şatır
e5392d861a Move the resizeDetector and use document-container for the event handling.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I6990480da8ba3a058e4e5d32407bf38d341e8ee4
2024-07-17 11:09:29 +02:00
Miklos Vajna
d04d6bd392 wsd: avoid nested startActivity()
Avoids this assertion failure:

    #7 0x7f9fbef8fcf1 in __assert_fail (/lib64/libc.so.6+0x42cf1) (BuildId: cfb059a57e69ac95d5dadab831626b3bd48a4309)
    #8 0x55d44ed78891 in DocumentBroker::startActivity(DocumentBroker::DocumentState::Activity) /home/vmiklos/git/collaboraonline/online-fuzz/./wsd/DocumentBroker.hpp:1550:13
    #9 0x55d44ee0884f in DocumentBroker::startSwitchingToOnline() /home/vmiklos/git/collaboraonline/online-fuzz/wsd/DocumentBroker.cpp:4654:10
    #10 0x55d44f05760a in ClientSession::_handleInput(char const*, int) /home/vmiklos/git/collaboraonline/online-fuzz/wsd/ClientSession.cpp:1168:20

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Iedc515b90c0e4f43dc14f0d998ba5c756fddd10d
2024-07-17 09:46:50 +02:00
Szymon Kłos
321c41cd51 ServerAudit: add post message status checker
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ic455e3fe3cd731d73056693f8523342bed70027d
2024-07-17 09:35:37 +02:00
Szymon Kłos
595fb45132 ServerAudit: add browser side checks
can be used for quick check if post message api is
correctly initialized in the current session

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I3b64ce738362cd1be936fe3e26a9ad381e01fdb2
2024-07-17 09:35:37 +02:00
Caolán McNamara
20d48e7dbb fix UnitSaveTorture with linux namespaces
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I035dbf79daf379642b8b6d329adced3cd974d0fe
2024-07-16 21:13:53 +01:00
Caolán McNamara
28d6f681bc unit-crash doesn't wait long enough when BindMount fails
in a failed BindMount the wait period to restart a failed coolforkit
is the default CHILD_TIMEOUT_MS * 4 which is 20s, while the test
default timeout is 10s

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I527aaadd802d7f8cd752ae1c4a6ed6597608f09e
2024-07-16 21:13:53 +01:00
Gökay Şatır
ab8ec53abd Fix cellcursor visibility issue.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ic26d6b26f967e3de9a9bb6217dbe9e0fb0accc28
2024-07-16 16:25:37 +02:00
Bayram Çiçek
4cc4dfe065 tooltip: don't show tooltip if mouse moves very fast
- cancel "_showTimeout" before it triggers show() - if beginHide() is called

Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: I70e87ab573cf347759aa565bf24ab962efbd483f
2024-07-16 16:00:03 +02:00
Bayram Çiçek
aedb198003 tooltip: fix overflowed/cropped tooltips
- add 8 different position for tooltips
  - bottom-right, bottom-left, top-right, top-left and their left/right aligned versions
  - pick one of them which is visible and is not overflow from the window
  - tooltips at the bottom and left/right aligned ones take precedence

Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: I0bdcb0980d228050962f6c77f12b64c89466257a
2024-07-16 16:00:03 +02:00
Bayram Çiçek
8e51ab5acf tooltip: change color and bg color
- add box-shadow
- change padding

Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: I7dee98f11c72fe5a44cd64e543640870132a17a2
2024-07-16 16:00:03 +02:00
Henry Castro
23bea39196 browser: tooltip: add image alt attribute
Change-Id: Ifb25a269bb1695cfe70c4706a0417b2003142e98
Signed-off-by: Henry Castro <hcastro@collabora.com>
2024-07-16 16:00:03 +02:00
Henry Castro
545b6a3024 browser: tooltip: attach listener to buttons
Change-Id: Iae636213d0921879cdab48e65f1add4d334d7cb0
Signed-off-by: Henry Castro <hcastro@collabora.com>
2024-07-16 16:00:03 +02:00
Henry Castro
eaa1a793ac browser: tooltip: add Control.Tooltip.js file
Change-Id: I97c4820eca7d4e82e5934fac130431bd705a892b
Signed-off-by: Henry Castro <hcastro@collabora.com>
2024-07-16 16:00:03 +02:00
Henry Castro
0dd902d1ba browser: tooltip: add util function
DOMRect intersection

Change-Id: If1d204520161131f81345961157ab31cf76e01ab
Signed-off-by: Henry Castro <hcastro@collabora.com>
2024-07-16 16:00:03 +02:00
Attila Szűcs
c4543d4e16 fix EOL issue in transform Document Structure
Send encoded JSON string instead of decoded.
This way it will not have special characters, and it will
reach the core side even with a \n or \r inside ot it.

This way we can set multi-line text to a contentControl.

Signed-off-by: Attila Szűcs <attila.szucs@collabora.com>
Change-Id: I8b32aeef522faf7f4597405bec9bbb37b99d53cf
2024-07-16 10:28:44 +02:00
Parth Raiyani
d3be8fbb30 fix: animate zoomreset to remove traces of previous document zoom level
- sync zoom options

Signed-off-by: Parth Raiyani <pmr642001@gmail.com>
Change-Id: I1dc7847e21ab3cb56b9ec01a1a8f577bb26366d1
2024-07-16 10:28:03 +02:00
Andras Timar
ea69f42fd3 Bump version to 24.05.5.2
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I7e8ea1ef0427f4f992f4860326add64c237f8d10
2024-07-16 07:13:41 +02:00
Rhoslyn Prys
e11cdbcb5b Translated using Weblate (Welsh)
Currently translated at 100.0% (610 of 610 strings)

Co-authored-by: Rhoslyn Prys <rprys@posteo.net>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/cy/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: If60ab4e3feef700e2cd23ff7f61456aae9d0743e
2024-07-16 07:12:09 +02:00
Caolán McNamara
58fe85ba12 Disable MountNamespaces if Bind mount failed
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Id387fdf346f83274d054a8c9f4665f4699b5c14b
2024-07-16 07:09:42 +02:00
Caolán McNamara
4f3c2961d3 Make sure that we can mount, remount and unmount before enabling bind-mounting
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I25d4f64982e12d17c454a301ef559b04ef073c2b
2024-07-16 07:09:42 +02:00
Caolán McNamara
9dd558ed56 fix UnitWOPISaveOnExit test with mount namespaces enabled
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I8f6ac58b064ecff8a74a694736fd85c627be0a27
2024-07-16 07:09:42 +02:00
Caolán McNamara
22d8e1f651 do coolwsd setupRoot in a fork
so we don't have multiple threads, which is problematic for
linux namespace creation.

The make check unittests use multiple threads even if the
normal coolwsd usage doesn't.

Given that, then restore the Poco log archive thread seeing as disabling
it in coolwsd isn't needed anymore.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ife8f579076a7d76a6ec7a18ca6629c8988c700cc
2024-07-16 07:09:42 +02:00
Caolán McNamara
6e73f37a7c disable mount_namespaces for tests for now
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I535ddda2a8c68f57a5f9372e6d452c8a0de63ef2
2024-07-16 07:09:42 +02:00
Caolán McNamara
f361fb1375 default to using mount namespaces if experimental enabled
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I5ce91a2aaefd8c84eecb6aa5d66f492cb8a3becd
2024-07-16 07:09:42 +02:00
Gökay Şatır
9dc4e94154 Fix visibility issue when split-panes is active.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Id3c0ac56310049c426c9f394f9c1fe68749694c2
2024-07-15 21:03:33 +03:00
Gökay Şatır
44d992b86c CellCursorSection: Fix RTL case.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I83231572f4d9c1afa8737c7c05cc96b8a5d1b691
2024-07-15 21:03:33 +03:00
Szymon Kłos
9013f47fad jsdialog: add tooltip to menubutton
Fox example font color item on the notebookbar didn't have
tooltip with the name of a button.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If3bac724f040d24fe69e97b47596a3c9f00b2241
2024-07-15 17:26:40 +02:00
Lily Logua
6f9dd43315 Translated using Weblate (German)
Currently translated at 100.0% (610 of 610 strings)

Co-authored-by: Lily Logua <lily.logua@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/de/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ic5ae5f714fc118d6738c472ede8a387e64359195
2024-07-15 17:19:14 +02:00
Ayhan Yalçınsoy
689cd30e6a Translated using Weblate (Turkish)
Currently translated at 100.0% (478 of 478 strings)

Co-authored-by: Ayhan Yalçınsoy <ayhanyalcinsoy@pisilinux.org>
Co-authored-by: PhD. Ayhan YALÇINSOY <ayhanyalcinsoy@pisilinux.org>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/tr/
Translation: Collabora Online/Help
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I34cd91488b0e6801067dcadf40cf2b5a443d719c
2024-07-15 17:19:14 +02:00
Miloš Šrámek
c99bc35e6b Translated using Weblate (Slovak)
Currently translated at 69.8% (426 of 610 strings)

Co-authored-by: Miloš Šrámek <msramek22@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/sk/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I29adc2bdc4d02e7c277e0be1af05b89e7161ef05
2024-07-15 17:19:14 +02:00
Ali
20a46bce35 Translated using Weblate (Arabic)
Currently translated at 100.0% (610 of 610 strings)

Co-authored-by: Ali <alimahwer@yahoo.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ar/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I693ac54c632e148647285f104dc5cf1627c97ba5
2024-07-15 17:19:14 +02:00
Gökay Şatır
450348b3a4 Translated using Weblate (Turkish)
Currently translated at 100.0% (610 of 610 strings)

Co-authored-by: Gokay Satir <gokaysatir@gmail.com>
Co-authored-by: Gökay Şatır <gokaysatir@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/tr/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ife42cba42e89a3cf7f07918f8f0a40068127179d
2024-07-15 17:19:14 +02:00
Leif-Jöran Olsson
c55954eb80 Translated using Weblate (Swedish)
Currently translated at 100.0% (610 of 610 strings)

Co-authored-by: Leif-Jöran Olsson <info@friprogramvarusyndikatet.se>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/sv/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ide84ec2874ca30dba7ba3fd2d4944fee0578c524
2024-07-15 17:19:14 +02:00
Martin Srebotnjak
bf060562d2 Translated using Weblate (Slovenian)
Currently translated at 100.0% (610 of 610 strings)

Co-authored-by: Martin Srebotnjak <miles@filmsi.net>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/sl/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I699d03af4143c3bad75aeee0ebc837a293df7dfd
2024-07-15 17:19:14 +02:00
SC
f7472fe561 Translated using Weblate (Portuguese)
Currently translated at 100.0% (610 of 610 strings)

Co-authored-by: SC <larcansal@users.noreply.hosted.weblate.org>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pt/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ifd64b9dfcf23dce43e584c7848707cdb60e1e685
2024-07-15 17:19:14 +02:00