When toggling tile debugging in the Help>About, toggle Trace Event
recordning, too. Add a comment with an example of how to turn on
SAL_LOG overriding at the same place.
The following new messages from client to server are introduced:
traceeventrecording <start/stop>
Starts or stops comphelper::TraceEvent recording.
sallogoverride <string>
Overrides the SAL_LOG value, or stops overriding if no parameter
or parameter is "default".
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I8b56c28cd99d39115cd796c44e5051d934d21a1f
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Perhaps we should use the exact same code in both core and online? But
that would be a bit tedious as core needs to be cross-platform (and
thus we use things like osl_getSystemTime and osl_getProcessInfo in
its version) while online is Linux-only.
Also imporve the test for it.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I0bc9dca71dc4489bd1671e0dae1e582990a8f8b4
Compiled but not yet used.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I3b85696ca6076e42d16e710b49bfd37bac342ec8
Signed-off-by: Tor Lillqvist <tml@collabora.com>
It is (for now) produced (by the ProfileZone things in core) whenever
logging level is "trace". The Event Trace file pathname can be given
in the loolesd.xml file or on the loolwsd command line.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I6d5829121e71460a4600ee94d2ebf51043c8893f
with #2235 and the fix of the home tab height it's now possible to reduce the notebookbar height to 72px in height instead of 84px.
Sure there would be 68 px theoretical possible, but the additional 4px in height are good for the home tab.
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Id28bcc63db142d235986cb5449d750808b684c4f
- Use something more specific to documentation, instead of product icon
- Fixes#2172
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idace492f776a635398c704c8ab78e13a6ceefede
When a document is opened inside the app's document list
intent.getType becomes null. In this case we can retrive the
correct mimeType from contentResolver. This is needed especially
for csv files, because ".csv" is needed to be added to the temp file name
for lok to recognize it correctly. Otherwise it will be treated as
text file.
Signed-off-by: merttumer <mert.tumer@collabora.com>
Change-Id: I61b853cf7ba9b648bf4ae8c54fd8b10d5754cf4c
Don't crash if marker object is not defined for a view.
Conflicts:
loleaflet/src/layer/tile/TileLayer.js
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: If8f13da684ebf4028bff888c9edf4bac3ab359bf
(cherry picked from commit 99985b91b2cb45a3d013be0a2d2d40f33829dca9)
Make sure the we have the latest cursor before we attempt view
centering. Core sends 'cursorvisible' before any new 'invalidatecursor'
so the handler of 'cursorvisible' should not attempt view centering with
the previous cursor position and it should only after the new
coordinates with 'invalidatecursor' has arrived.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Ib8db1166b1a928ddf20f849572360fdef30c13d4
Text import dialog is displayed on initial document load
so we need to hide progressbar after that in order to
interact with the ui
Signed-off-by: merttumer <mert.tumer@collabora.com>
Change-Id: I840bfea9d078260751622cbb09d256153821ff0e
When we display JS Dialog before the document is loaded
We should hide the progressbar. Spinning should be until the
1st user interaction.
Signed-off-by: merttumer <mert.tumer@collabora.com>
Change-Id: Iad8bf56d9bcc57e106e76a961ba72490a74b26c0
Seems like this was a bug in clang-format
that is fixed in clang-12.
Change-Id: I8144179d2b290f5d875af41dbd44dedcf4152639
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
While Poco::Exception inherits from std::exception,
it's what() member returns simply the name of the
exception, which is hardly useful without the message.
Therefore, we are forced to log it's displayText()
member for the full error message.
Change-Id: I650614a9b4b3bb1b2e31841c37250a2a069e6b77
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This is optional, but when provided it's what the caller will
get, so that a given test can simulate different responses
from the WOPI-like host.
Change-Id: Iba5513174dc94757be09640d3fdb08b46af4a960
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Instead of supporting char appending,
we now support appending literal strings
with size capturing. This covers both
single- and multi-character appending
without the need for an explicit size.
Change-Id: Iee2c20b7aa2cdb6863c88e91cd770205719c2ba6
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
(cherry picked from commit 96e3e88a014960a5249fc83a5b2f3b785ac8737d)
The browsers - unfortunately appear to round-robin the asynchronous
unload of an individual tile - which causes a _tileReady callback
with updating the canvas.
This means that we re-render the canvas (at whatever speed) for each
tile we load - guarenteeing a nice animated effect of loading tiles
one by one, and refreshing the view: not so cool.
So - instead, as per WebSocket messages, slurp them - and then
refresh the view in one shot after 1ms; since it is fairly bogus
to convert a base64 encoded URL image to a real image asynchronously
anyway, this gives some nice results eg.
TileLayer.js:2464 Slurp tiles 34
TileLayer.js:2464 Slurp tiles 25
TileLayer.js:2464 Slurp tiles 53
TileLayer.js:2464 Slurp tiles 5
TileLayer.js:2464 Slurp tiles 3
It also significantly improves pageing down in calc, and presumably
a number of other operations.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ib2a7daf8aa35835edd78dc5da187b0cb76b76ac3
1:
Move to line 100 (line 1 shouldn't be visible)
Select it
Press CTRL+SHIFT+Home
Row headers aren't painted correctly.
2:
Select row 5
Select row 15
Rows between 5 and 15 shouldn't be painted, but they are.
3:
Select some cells.
Press F2.
Edit the cell content.
While you edit, row and column headers should be painted as selected,
they are not.
Press Enter.
Previous selection should exist.
This commit solves above issues.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I90e3abee88fc3112fd92b4058063f199a0c30ec0
When user saves the document with a different name, new document will be
loaded.
While this happens, if there are more than one servers, client may be
directed to another server for the new file.
In this case, socket code will think that current server has restarted
and will reload the page. Socket code can't see if the server is
different than the previos one.
So, after a save-as operation, if we check the file adress with the
previous one, we can detect that the file we are viewving has changed.
In that case, we will not reload the page.
Change-Id: Idbf50678a453feccb34eb67a5b9286904a96bffa
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
dropdown reduce 4px in height so that the dropdown's fit into notebookbar row.
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Id3ca9d7d4d11490720cbe18f001c7afaa93cf6db
- Normal: has-dropdown
- Part of color control: has-dropdown--color
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I71f6083e727eef223e55e89df94e37c394359443
