Commit graph

13587 commits

Author SHA1 Message Date
Yaron Shahrabani
7955b481b1 Translated using Weblate (Hebrew)
Currently translated at 100.0% (364 of 364 strings)

Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/he/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I1d51d1bef6994540c51f3ec3e93e353763652384
2021-01-04 08:37:11 +01:00
Milo Ivir
152eda55a0 Translated using Weblate (Croatian)
Currently translated at 100.0% (364 of 364 strings)

Co-authored-by: Milo Ivir <mail@milotype.de>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/hr/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I651691408e0b159c8445a867ee7b13060ca940e2
2021-01-04 08:37:11 +01:00
Andras Timar
8fb8af419f Translated using Weblate (Dutch)
Currently translated at 100.0% (364 of 364 strings)

Translated using Weblate (French)

Currently translated at 100.0% (364 of 364 strings)

Translated using Weblate (German)

Currently translated at 100.0% (364 of 364 strings)

Co-authored-by: Andras Timar <andras.timar@collabora.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/de/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/fr/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/nl/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ieacae070522d77e4e43a7ee0f8cd8c8db9ad098e
2021-01-04 08:37:11 +01:00
Matthaiks
efa33a5201 Translated using Weblate (Polish)
Currently translated at 100.0% (364 of 364 strings)

Co-authored-by: Matthaiks <kitynska@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pl/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ia749956e5457ab87f23269896e45669d16a9ce4f
2021-01-04 08:37:11 +01:00
Martin Srebotnjak
8de7cbaf45 Translated using Weblate (Slovenian)
Currently translated at 100.0% (5 of 5 strings)

Co-authored-by: Martin Srebotnjak <miles@filmsi.net>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/code-welcome-text/sl/
Translation: Collabora Online/CODE welcome text
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ib1483e725bcd3af23367dee5c6bebc9a760c1740
2021-01-04 08:37:11 +01:00
日陰のコスモス
5c19461847 Translated using Weblate (Japanese)
Currently translated at 43.9% (47 of 107 strings)

Translated using Weblate (Japanese)

Currently translated at 52.7% (220 of 417 strings)

Translated using Weblate (Japanese)

Currently translated at 63.1% (230 of 364 strings)

Translated using Weblate (Japanese)

Currently translated at 60.9% (222 of 364 strings)

Translated using Weblate (Japanese)

Currently translated at 28.0% (30 of 107 strings)

Co-authored-by: 日陰のコスモス <baffclan@yahoo.co.jp>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/ja/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/ja/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ja/
Translation: Collabora Online/Android app
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I573cace9c336d81204614c1789b08ef1688c42c1
2021-01-04 08:37:11 +01:00
Pranam Lashkari
2a56af7958 leaflet: use new view comments icon in topbar
this icon was added to writer but was missing in impress and calc

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I032f5430cd96cc66501aa813df2dd06f6aa4d7a6
2021-01-03 22:12:26 +05:30
Pranam Lashkari
4bf0302a78 cypress: fixed test and enabled missing test for annotation
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I8c1b4e6a679f31b9ebfa814b67f18b25eab3d2be
2021-01-01 16:10:59 +01:00
Pranam Lashkari
9e2b9f8972 cypress: modified annotation tests to work with comment wizard
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I25ff9c590aa12d1787d8966cc4f68151ed8d505f
2021-01-01 13:18:10 +01:00
Pranam Lashkari
1859e66543 leaflet: avoid creating child comment when possible in wizard
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ibd9b04c1f275adb8e2fd0429e1bef3adb1916e0b
2021-01-01 08:35:43 +05:30
Tamás Zolnai
c29ed235ba cypress: improve moveCursor() helper method.
View also jumps with cursor movement, so we can't be
sure that the vertical/horizontal pozition actually
increase / decrease. Better to test only that the position
was changed.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I2358348c3f6d4f2278eff4e2db4a8409bc86b25a
2020-12-31 18:53:26 +01:00
Tamás Zolnai
dd22bde4d9 cypress: php-proxy: this workaround is not needed anymore.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I2d74a30aa177051a0faf4c8f946779c2389a8d34
2020-12-31 18:53:26 +01:00
Pranam Lashkari
65ceaa0a55 leaflet: moved undo handler for text in TextInput.js
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ifa368ac45e32183c1c0e242be44131afd995d0ce
2020-12-31 16:58:01 +05:30
Pranam Lashkari
47a548a8a5 leaflet: add mousewheel handler only in desktop
this caused problem in mobile while adding comments

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I8923fdec4b09a6d7c8c8bc6f248d1ca671fd252c
2020-12-31 12:47:45 +05:30
Tamás Zolnai
ae7e93144f update cypress: 5.6.0 -> 6.1.0.
Test code needs an update because .should('not.be.visible')
does not pass on non existing elements anymore.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: If8a89d2996d154d287672dacb3668ec5399d99f2
2020-12-30 19:49:42 +01:00
Tamás Zolnai
63ee524010 cypress: disable welcome dialog via loolwsd config.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I15c060e5eac1993116828dfaefe8916030fe2b63
2020-12-30 19:49:42 +01:00
Pranam Lashkari
dd6ee044e7 leaflet: don't create container for frame in mobile wizard
problem:
creating an additional container for frames causes problem in wizard
while trying to go level up because changing level depends upon
finding the sibling of the current not and making them visible or invisible
having extra container breaks this relation

in addition not creating an additional container does not affect anything visually

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I5f6342febcf444c71eef964da5585e5f73ae367e
2020-12-30 15:07:26 +01:00
Andreas-Kainz
81a5d029e0 NB shortcuts-bar vertical alignment update
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: Ia93ff33742d16417a2a325ffcf649b2ca3499e23
2020-12-29 17:39:54 +01:00
Ashod Nakashian
01138d7ae0 wsd: save errno before invoking any other functions
Most C and Posix API clobber errno. By failing to save
it immediately after invoking an API we risk simply
reporting the result of an arbitrary subsequent API call.

This adds LOG_SYS_ERRNO to take errno explicitly.
This is necessary because sometimes logging is not done
immediately after calling the function for which we
want to report errno. Similarly, log macros that log
errno need to save errno before calling any functions.
This is necessary as the argements might contain calls
that clobber errno.

This also converts some LOG_SYS entries to LOG_ERR
because there can be no relevant errno in that context
(f.e. in a catch clause).

A couple of LOG_ macros have been folded into others,
reducing redundancy.

Finally, both of these log macros append errno to the
log message, so there is little point in ending the
messages with a period.

Change-Id: Iecc656f67115fec78b65cad4e7c17a17623ecf43
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-12-29 11:40:17 +00:00
Szymon Kłos
d4c8378782 Revert "NB update: calc file tab: bottom align labels"
This reverts commit 6cceee7e43.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I641487f7325f1e8ce439db479bccc072682ae3de
2020-12-29 11:33:33 +01:00
Szymon Kłos
1aa90ad787 Revert "NB: Update writer and impress file tab according to calc #1080"
This reverts commit d9cadd1259.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I91e1420e28030e6e30177c290de8afdcaee9355e
2020-12-29 11:33:33 +01:00
Pranam Lashkari
e7718ebc7b leaflet: prevent entering non numeric value in spin field
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I78403b489f8057b3131e1ccc1cbeef74377bedc4
2020-12-29 11:15:22 +01:00
Pranam Lashkari
ea3d78c9bf leaflet: avoid keyboard suggestions after undo/redo
problem:
undoing something on mobile does not trigger any input method
this causes problem in mobile working with suggestions
i.e: type "than" and then select "thank" from suggestion
now undo and then again select "thanks" from suggestions
final output is "thans"
this happens because undo doesn't change the textArea value
and no other way to maintain the history
So better to clean the textarea so no suggestions appear

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Idfdfd8acfa6d738bf695a473610d399b123e7019
2020-12-29 10:50:54 +01:00
Tamás Zolnai
09fbbf43b0 cypress: extract clean-up code into a function.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I572b164f89023cd66fca2d392b830417eb6a9d74
2020-12-29 10:42:51 +01:00
Tamás Zolnai
5ebbe451e0 cypress: simplify run_iteratively.sh script.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ibdecf2a70d83a4ef4b021657b3238951d7bbd3b2
2020-12-29 10:42:51 +01:00
Szymon Kłos
26ea341b7d notebookbar: hide non-async dialogs in graphic tab
Change-Id: Idb3dda5152c2baf7e967dccbbd442675c7d6a5e9
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-29 10:09:31 +01:00
Henry Castro
8a768e6554 test: makefile: fix build builddir!=srcdir
fatal error: test/lokassert.hpp: No such file or dire
ctory
   17 | #include <test/lokassert.hpp>

Change-Id: I935cc4e0afd6862469d27b3d2620dfa83e38ef69
Signed-off-by: Henry Castro <hcastro@collabora.com>
2020-12-28 15:07:35 -04:00
Ashod Nakashian
0072a4080e wsd: test: log timeout better
Change-Id: I3643a2bad8611d1f6402615435295717eb2e93c1
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-12-28 12:04:53 -04:00
Ashod Nakashian
2edbf1c5e1 wsd: test: check if a WS Close Frame message exists
The text message in the WS Close Frame is optional.
Here we actually copy the remaining data after parsing
the status code, not assuming it exists or that the
status code was exactly 2 bytes (although in a well-
behaving WS implementation it always will be 2 bytes).

Also, no good reason to wait a full second between
socket reads in getErrorCode. However a small sleep
seems sensible to avoid logging "got 0 bytes" or so.

Change-Id: I162dfb0dd3ebf615a3e8e237006883388b9ff494
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-12-28 12:04:53 -04:00
Ashod Nakashian
d2e29d592a wsd: test: httpcrashtest drain using the getErrorCode helper
Reading the messages using a different helper means
we may miss (=consume without checking) the close frame.

Change-Id: I93a529723ba8d2b516319d54496c56c7e6d7da27
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-12-28 12:04:53 -04:00
Ashod Nakashian
96c9e03b88 wsd: test: catch and fail WSD tests when exceptions are thrown
Change-Id: Ifaabb6387d86c5a80e00cd5de34093520a1e9d66
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-12-28 12:04:53 -04:00
Ashod Nakashian
39e69e8168 wsd: test: improved UnitWOPIDocumentConflict
This adds proper phases instead of arbitrary
sleeping and similar workarounds. Also,
each phase documents what it expects, so
debugging failures are now self-explanatory.

Change-Id: Id51f4c285c5cf98aceba3415f0ffe14bd7605acc
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-12-28 12:04:53 -04:00
Ashod Nakashian
b3366cfef0 wsd: test: better logging in WopiTestServer
Change-Id: I8e33172d5c474c1d56e0af214f7a6281510d0836
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-12-28 12:04:53 -04:00
Ashod Nakashian
7972ded44f wsd: test: log test assertions
Change-Id: Ibf9274b1812f70f54ccd4e7be991b08a11f36c86
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-12-28 12:04:53 -04:00
Ashod Nakashian
64251966d5 wsd: test: use LOG_TST in new-style tests
Change-Id: I0d4558d44bc6cb92ba820ae8471d7ed2528277fc
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-12-28 12:04:53 -04:00
Ashod Nakashian
3b4add03ef wsd: test: store the current test name in UnitBase
Change-Id: Iaf521f6a99dcd6e6465769aed7f3757332e04f7d
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-12-28 12:04:53 -04:00
Ashod Nakashian
b4d9e1f413 wsd: test: use chrono types
Change-Id: Iec7f64a122126ae82af3bf16719081ea4ee645f3
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-12-28 12:04:53 -04:00
Ashod Nakashian
9bbd273e91 wsd: test: leverage the log system in TST_LOG
This moves the test log macros into a new home,
test/testlog.hpp, to avoid cycling dependencies.

Change-Id: Iacb80e813a64ff830fa18f63ec4de2535ee702b7
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-12-28 12:04:53 -04:00
Ashod Nakashian
f6082661d6 gitignore: .clangd and .cache
Change-Id: Iecb5e83bdb6dc5a54600b8bcc91254a33487a07e
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-12-28 12:04:53 -04:00
Pranam Lashkari
a3e59d1d21 leaflet: allow document scrolling when mouse is over annotations
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I9bb092a053b61f9cdd13c020b1349ae753d2289a
2020-12-28 11:57:35 -04:00
Tamás Zolnai
e8961e5123 Revert "downgrad wait-on: 5.2.0 -> 3.3.0"
This reverts commit a409b221f8.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I5662bfbf7b1209c0919eca2b8debefae9c82450d
2020-12-28 15:11:06 +01:00
Tamás Zolnai
8db4b19469 cypress: move includes of 3rd-party packages to support file.
Now we handle support file better for parallel test run too:
a13b1a93bc

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I4a88f815ddb1c4d79042134cc07e0c418d4ea10f
2020-12-28 15:11:06 +01:00
mert
6fec533398 Fix browsing parts visibility with PageDown/PageUp
Now the scrolling works as expected with the
parts that are invisible

Change-Id: I8fd41624befaea49978d43cf4e88249c47dc7534
Signed-off-by: mert <mert.tumer@collabora.com>
2020-12-28 16:13:22 +03:00
mert
067381f0b2 Pre-fetching next or previous slide tiles
Fetch the tiles of the part that is in the direction
of travel. This way we will avoid the tear effect
while browsing the tiles sequentially.

Change-Id: Ie47d1174f986253e4b43aa0c3276f05e7ddd0c81
Signed-off-by: mert <mert.tumer@collabora.com>
2020-12-28 16:13:11 +03:00
Henry Castro
5985ed252f jsdialog: only update the incoming control changes
It will update the control that has changed the model,
in the current visible dialog instead to recreate the
dialog again.

Change-Id: Ibad681df32952f380d63ccd82b01d83c488d95b4
Signed-off-by: Henry Castro <hcastro@collabora.com>
2020-12-28 08:36:17 -04:00
mert
c9cc7e840f Save Watermark bitmaps per user for re-use
Although we already save it for 256x256 regular
tiles, we use smaller tiles for preview requests
everytime there is a preview request the pixmap has to
recreated. Used unordered_map instead to keep different
resolutions saved for re-use

Change-Id: I3ced6b08b6e5f8096195b253abba8bb5afdffa3c
Signed-off-by: mert <mert.tumer@collabora.com>
2020-12-28 14:51:02 +03:00
mert
20476e147b Fix different size thumbnail rendering problem
We dont send broadcasts anymore for thumbnails
therefore no need to use higher dpi in case
we have highdpi views. This causes glitching on the thumbnail
especially when a watermark is applied. It gets smaller and bigger
back and forth and also this mean x2 more rendering for single preview.

Change-Id: I80ba8c70bcd9d5d3c00c2ddffadae11a6b0b2e61
Signed-off-by: mert <mert.tumer@collabora.com>
2020-12-28 14:50:54 +03:00
mert
92741efba3 More clean-ups wrt slide sorter
Fix preview placeholder does not load
Slowed down slide sorter scroll speed
Fix undefined function error

Change-Id: Ie19ec84bc43fbbdc2eb70fec183b895ef1409a96
Signed-off-by: mert <mert.tumer@collabora.com>
2020-12-28 14:50:37 +03:00
mert
9ef68cf19b Cancel preview requests that are not visible
Change-Id: I43db0d9d3068d38b98d449c3bba31050a1e288cd
Signed-off-by: mert <mert.tumer@collabora.com>
2020-12-28 14:50:37 +03:00
mert
fa7c5f572a Throttle preview requests on Impress
We should limit the on-fly preview requests to stop trashing
the server with countless preview requests
depending on the slide size and ask for more when we have them
rendered.

This patch adds the preview tile requests to a queue to be sent to server
as 3 requests at a time until they are rendered and received by the client
Also adding them to the queue allows us to check whether we already have
the same tile in the queue waiting to be sent which we can avoid sending
twice.

Change-Id: I03684dc807a7aef6c996a91efba100a9dca9686d
Signed-off-by: mert <mert.tumer@collabora.com>
2020-12-28 14:50:37 +03:00