This makes the code self-documenting and avoids accidental
comparison or assignment of Result variables/values.
Change-Id: I84b8e36aa999191c8704938552b73ddc1c3dc3fc
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This replaces Util::getFileTimestamp with
FileUtil::Stat::modifiedTimepoint() and fixes a potential bug:
getFileTimestamp had only 1 second precision (it simply dropped
sub-second data). This could mean that any modifications to a file
within a second could not be detected.
Minor simplifications done where possible and overly long lines
have been reformatted.
This is a non-functional change (except that file modified-time
now supports microsecond precision).
Change-Id: I3606638a86fc3e00c0ad5cb602bdbb2b4651867b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Often loleaflet.html is loaded via POST requests. This
new sample demonstrates and exercises this approach and
is a handy way to load documents.
Change-Id: I065a946413ab08d399ac5704c67f6f1ba37bdd9e
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This should make this sample much more useful by documenting
the proper usage and helping the user avoid common pitfalls.
Change-Id: I965bed0e4ab685dd2a68f7b246dd9a409d296337
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Confusion arose due to separate creation of session, and watermark
property fetch from CheckFileInfo which happens in DocumentBroker::load
which doesn't do a load. This happens in a subsequent 'load url='
message cf. global.js which can then race vs. the session creation.
This causes mis-ordering of another unhelpfully shared Session,
letting the view canonicalization list to get out of sync between
the two processes.
So instead - tell the view it's canonical id. An example of the
problems of trying to share some unclear subset of the Session
class between kit and wsd perhaps.
Change-Id: I63dc30f9a047e3f889fd339b6aaf392b9fef37b9
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
The issue was fixed triggered by this test case.
Change-Id: I00522835c25ca18aa374958c5b33b13f35e79563
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It's duplicated now. It was one of the first
prototype tests.
Change-Id: I6a63644713189c8f56a77cc21df0c2a42d724547
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
After a test failure, it's common, that the afterAll
method also fails which covers the right error
message and also makes the following tests to be ignored.
Change-Id: I5c1bbc5dd8b1b48dd2a8f1fc20a8ca3b8ecd8462
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
1033 means en-US locale. It can be different in an
NC environment for example.
Change-Id: I929a7308b9f0d4a102f836d1ec66c5c98a6eb9c6
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
In NC environment it does not work properly.
Change-Id: I9adbb01b450103a6ac2aa211eb933a5ab3f5fcd2
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
For some reason if we use proxy.php continuously, then
it will eventually fail on the test. With visiting the
localhost in the afterEach method we can avoid that.
Change-Id: If56c8e40e9e2b9002c1c5b0b91851e4a19a2c9bd
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
to match its height (that is comming from vex theme)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibffc3040d07afd2ea98af65a3aeaa041b0dc73fe
existent classes while overruling line-height and padding
for that particular btn (has np chevron since it's a btn and not a combobox)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I393c972b44402c4030a6d7838750cfbd8156530e
fix logo (document-header) overlap on some devices, namely iPads.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib2ca48d805f6decd941ae3f817f987791a074ed4
We might hit a race conidtion here. I'll need to
investigate this later. It seems sometimes the
selectio is what is undo-ed and not the text
modification.
Change-Id: Ib9c6214cefd0b8625116681c3cbca17899beaece
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Let's hope this doesn't have any unintended side effect.
Change-Id: I38d5c6f3a8526ce510fe07f58fba17e98eb09e2e
Signed-off-by: Tor Lillqvist <tml@collabora.com>
problem:
once text inside the cell is selected,
taping on other cell does not remove the selection
Change-Id: I2c4bd4e46a42854bdcc5a09f6af170d33dc4e8c0
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
In CI environment this does not work. I'll need to find out
how to make this tests work there too.
Change-Id: If9780796b52aa27fd18d72cc3bf786ab46865e4a
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
New-line breaks can now be inserted in the watermark
text using
. This helps break long watermark texts
at desired points and therefore make watermarks more
readable.
Change-Id: Ifee6faa06c9fb1fac38e5a4036c2e225829d796d
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
The watermark handler member has been fully encapsulated
inside ChildSession, so there is no need to have public
members or circular dependencies (ChildSession owns Watermark
instance, and Watermark takes ChildSession instance to
construct and initialize).
Minor refactoring and const-correctness improvements.
This is a non-functional patch.
Change-Id: I32525c47e35e96fc5314e107639be93ebc49a60e
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Let see whether waiting some time after context switch
makes things better. Cypress does not support iframes
very well.
Change-Id: If6011f16c54e3473bef20546f39bb45941c40dc9
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It's a known issue that formula bar is very laggy,
which makes test to fail.
Change-Id: Ia2cbee763c596065e36d178913a8df400adb4668
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Its status is not reported on GitHub, so at least make this easy to
find.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I8a4f5bffbdb6692afa7f55e0f55ce41c04facd39
