Will add bullets after pressing enter
Example: press * then some sentence and enter
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I63676eb3f725dba0d9fdb0a12cb31847fef8e663
apparently since:
commit b0a7532b08
Date: Sat Nov 14 19:43:02 2020 +0300
Turn off broadcast on presentation preview tiles
so drop this field from TileDesc and protocol.txt
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ib4b1eca0d30911e13c245551cb3e3261afc99dd2
getTokenString(const StringVector& tokens...) loops over each
token and calls
getTokenString(const std::string&...) with token.getParam() on each
token. We already have a loop over each token, so we can merge those
loops here.
perf reports TileDesc::parse taking 3.68% of the time in a hour
of an interactive writer session with multiple participants
Though looking further, broadcast seems unused by anything now.
To be followed up on that topic.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I244637043c58d90562001ec58fac494da54e55a8
calc -> insert -> hyperlink dialog has combobox which is
useless, let's replace it with edit field
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ifc5c10028fa55459a8433ae0b932c857aa883de8
we expected number in the id, but it has been changed in
commit f8e53bd851
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I5c8793facca03a586918f411d7e88066ac30dc16
introduce it in Calc only as it has better knowledge about
cell content and what should be edited
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Idc66e3380e83975b44ca88d47586de3bd0e7dee9
it seems we generate previews later now
it might be related to commit 04ac02b033
Do not request tiles until we are sure a canonical id is set
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I250c37049ba62c4cdc06b16413767edafc362dc0
this is only desktop test that fails, let's skip
it until we fix the regression and not block others
from testing their patches
regression was introduces in:
commit 04ac02b033
Do not request tiles until we are sure a canonical id is set
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I1de44a94121648b381df67d926bbc33dd1044b76
Add new property to commentSection (children).
Update commentListSection for Writer comments.
Now the comments at the same position are separated.
The parent / child relations are set by "parent" attribute.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I0a8ab060c133a51f4d09e71777cc6233b78a6efa
and not just some of them discarding the others, so we
always apply all messages received in order the arrived
without omissions.
TODO: apply them when the conditions application requires become
true rather than depending on a timer poll.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I265b6ccb45e211c15c5f4daf9d6572fa051b68eb
to parent from parentId while importing the comments.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I2f8fa3eae995d894b33558a2fb67639c7af5f1a1
how it is expected to work:
before this patch, whenever comment is saved,
editing comment box(DOM elements) is deleted and
a new comment(DOM elements) is created when we recieve the data from server about saved comment
This commit prevents the deletion of the original comment box which is being edited,
if comment loses focus it is saved. If user explicitly saves the comment then it
follows the routine which were used previously.
Many checks were added to prevent comments from getting unselected(select means it is highliting the text in doc)
or getting collapsed
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: If24ccbcd7a0287b659f790db486ada5d17608a32
It seems the CSS class was only added to impress in
c582d75f57
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4e8884004bbd1a4f6e4e62a841eb940e23065f50
Added support for keyboard shortcut to add
- Numbered list Ctrl + Shift + 7
- Bulleted list Ctrl + Shift + 8
Still type * (asterisk) then Spacebar to add list view not implemented
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I097691edd81fdc95718d778fcac57c0b0d3e9fb5
Read only sessions cannot modify the document, so
we shouldn't consider input from such a session
as potentially modifying the document. This
becomes important during an abrupt disconnection
where we look at isPossiblyModified() as an
indicator for data-loss.
New unit-test that reproduces the corner-case
with disconnection. With graceful unloading
a previous unit-test verified that it worked
as expected.
Change-Id: Id84cda4f4599c559018247c32ea1205e154e4984
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
https://github.com/CollaboraOnline/online/issues/7164
might be best to add everything to this queue, and not drop any
incoming message, and then process the queue when both
this._map._docLayer and _isReady become available/true.
But perhaps this serves as a reasonable safe checkpoint to return to
if it becomes necessary.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ib77a4126437689709e2ca0915667b5b9b2f2f207
RecentFilesAdapter.java:76: Error: Value must be ≥ 0 [Range]
filename = cursor.getString(cursor.getColumnIndex(OpenableColumns.DISPLAY_NAME));
RecentFilesAdapter.java:97: Error: Value must be ≥ 0 [Range]
length = cursor.getLong(cursor.getColumnIndex(OpenableColumns.SIZE));
file_explorer_grid_item.xml:42: Error: Inconsistent alignment specification between textAlignment and gravity attributes: was center_vertical, expected center_horizontal [RtlCompat]
android:textAlignment="center"
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I663a89b0ecce03b067e1fa216a030a19fa578da5
