If we have all default values of imgSize, wid, old-wid then we
should simply not serialize these out to save space and improve
readability.
Unfortunately, this means that we need to catch the mutation of
the TileCombined's content in two places; now just one. Building
the queue of rendered tiles to send back is now moved and
wrapped into a TileCombinedBuilder class - this also lets us
stop serialize taking a random vectors of TileDescs. However
the DocumentBroker::handleTileCombinedRequest method needs to
set the force-keyframe oldWid=0 flag on individual tiles and
then update the TileCombined.
Ideally we would have a nice visitor API and drop the non-const
getTiles() method that returns a reference to our internal vector.
Update tests, to not have redundant attributes, and add more tests
to ensure redundant attributes are removed.
Change-Id: Id76d3ae14d459d73bbae8112d840dea27f66588b
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
- Replacing the height value with the CSS variable will help maintain better consistency.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I0627778919885c8ee0a989f0b47b976304892585
Reduce size of UIManager and also it will make it possible
to add queue of snackbars to show.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I221049f48f471d85795ede7922a668eef4c7f0df
So it behaves similar to other hello/hello-world documents.
Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: I529b5bec81c1bf5085300f8c52311db023c6b09a
- we have now some uno item present only in dark mode.
- so there is no resone to check image exist or not for light mode.
- we will set dummy url for those image elements.
- this patch will consider those items and will not throw error if icons are not present light mode
- Example: please see `invertbackground` item in view tab after change to dark mode
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I6aa2fc9d7bdd356617a808f17d14f77bc8453496
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
- `zoom` menubutton is not a image to represent so we will make `image: false`
- this pathc will fix image not found error for `lc_zoom.svg`
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I39c2d68f4b0afc7b3831c2082be2ae1a315b2d8e
Before this commit the search field wouldn't fill the available space.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If079942b1e594a0461835e52ad65827a639c6173
Make those transparent since color would just look odd within tab
background and more importantly because they offer no interactivity.
----
Currently the treeview accepts clicks (not just the expanding and
collapsing) but also children accept clicks but do nothing. Probably
we should fix this.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ifc53d0099a19103b15895dc8b76127034b05f3c1
- Use all the available space on both tabs' content
- Fix Structure tab's content
- make the tree view extent the available space (1fr)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib1c9e852a3a292f795675365040318c1d5602f35
Before this commit the tabs in this dialog were being rendered as top
level dialog navigational tabs. However, this is not the case. Add
background and border to clear separate one and the other.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I158ee1e1d4d163417f5055459adfeac47b6ab437
- remove use of Leaflet's
- change working js code to ts
- please check above commit messages for understanding of implementation.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Iee222bbdb343730014260c1785a90e68c6dedfd1
- we are string previous response values of top/bottom margin
- resone is because we need that values to pass after dragEnd.
- but if we change section foucs from Header to Footer or Text area to Shape then we need to reset that old values with the incoming response
- this patch will do that.
- for `table` we will hide the marker as we do not need that. table already have there marker to resize.
- added some edge cases like if start marker goes beyond end marker
- start and end marker should not cross limit beyond page top/bottom
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Iffd3cbf08806666b858d9c3da7ca6362085223dd
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
- Send Upeer and Lower space value for header and footer according to drag
- we need to send both values in core.
- even if we drag either upper or lower we will send values accordingly but both values should be updated
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I4ef3287c5afe6e1eef5aac225d3c06ca9d1fd9e5
- As we do for horizontal ruler we need marker that will change margin of Header and Footer of the document
- current patch will have design where user can see markers in vertical ruler
- you can drag and change potition of marker.
Improvments that still need to do:
- user can drag but it will not change size/margin of header/Footer
- next we will pass info to CORE according to corrdinates we got from drag
- it will update text potition on document
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I9663a75d5c84eace784266c76be12abd762434bb
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
- Before this commit vertical ruler stays only in first page
- if we jum to page 2,3 so and so ruler won't change it's possition
- but i have added some calculation based data we recevice from CORE
- calculation:
- we need to consider pageoffset for vertical ruler
- check if cursor moves to other page
- then add total Height of previous pages.
- for Ex: if we are at page 3 then ruler.marginInlineStart should additionally have total height ( page1Height + page2Height)
- this will place ruler to exact possition where we want
- next : add Top and Bottom margin drag
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Ie2a2d4e5f0cfd627bcafd81230ad33b7aec280a2
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
- add new LOK callback for vertical & horizontal ruler update
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I3c0e26f22072de4612e128d58ac41b629be82807
Add vertical ruler and implement margin calculation
- Added new vertical ruler file to separate it from horizontal ruler calculation
- For vertical ruler we do not need tab stops so removed it.
- next stpe will be to implement add top and bottom margin by drag
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I8186c874ff59571db7a75ec4c31f81fc655ef301
This stops a huge amount of parsing, re-parsing and conversion
from strings and back, making our few N^2 loops over the tiles
much more efficient.
Retain queue tests with the same strings via using a helper
to convert back to something expected.
Replace TileDesc::getId() with isPreview().
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: If40fc45f1fb474d37371e4b949da5fdfc594fdc8
Leave them as strings for now; this should be a pure re-factor.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ibad2bc343afe3fe32ea729623f6b03575c7b0121
- improved color contrast between text area and edge.
- changed --color-canvas for contrast between text and edge area.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I8dd8296901da6ee5ce59704f7e27d8c37d29e8b1
Parsing a string to a TileDesc and then comparing is inefficient
enough, without doing that in an N^2 loop for the SenderQueue.
Still N^2 - and of dubious value in the world of deltas; but in
almost all cases a simple string + integer compare.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ibe8230679e27b98cfa95567fea700e2f7d5ac09c
* On Calc, when user starts editing a cell and uses zoom, core side sends "cursorvisible: false" message.
* This hides the cursor.
* We also hide the cursor while user is zooming in / out.
* But the core side zoom doesn't set the opacity back.
This commit fixes the input handler's visibility issue.
But the core side will continue sending the cursorvisibility message.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ibf679c132f96dc3504de17d00958133bd45244fb
since:
commit 6f49f9398e
Date: Thu May 9 09:19:44 2024 +0100
Split outbound callback processing from incoming message queueing.
an out by one adjustment
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ie5c2133dd7239aa62c017306c962c26ea6e526bb
Currently translated at 100.0% (588 of 588 strings)
Translated using Weblate (Portuguese (Brazil))
Currently translated at 100.0% (588 of 588 strings)
Co-authored-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Co-authored-by: Pedro Silva <pedro.silva@collabora.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pt/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pt_BR/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I9c45a233e479ea10c9de092265afee238a793b75
Currently translated at 100.0% (110 of 110 strings)
Translated using Weblate (Arabic)
Currently translated at 100.0% (588 of 588 strings)
Co-authored-by: Ali <alimahwer@yahoo.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/ar/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ar/
Translation: Collabora Online/Android app
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I8f8cc2a8f27e50d3a60b6a8ba3f8adc9e8dbd6d9
Replace svgs introduced in 3efbfaeccd
- Animation and smiley svg: Use gray
- Don't use a smiley face, use instead something more semantic such as
a checkmark
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I38e341ae393c59e785adff9207f8111d68c341ef
