No description
Find a file
Miklos Vajna 08ecc20a90 CanvasTileLayer: allow empty string as payload of the state changed callback in json, too
Once core emits JSON format for the LOK_CALLBACK_STATE_CHANGED callback
for the .uno:RowColSelCount uno command, select 2 cells in Calc ->
status bar is updated correctly, now select a single cell again in Calc
-> status bar is not updated. We want to emit JSON format for more uno
commands in the future, for example that is meant to allow testing the
fix for the statusbar part of
<https://github.com/CollaboraOnline/online/issues/7492>.

CanvasTileLayer's _onStateChangedMsg handles a mix of plain text and
json payloads, and the plain text case already allows an empty payload,
while the JSON one does not.

Fix the problem by assuming the intention in commit
403fe10c9d (jsdialog: handle graphic items
updates, 2019-11-28) was to make sure the json key is not missing, not
to block empty string values for the 'state' key.

Once this is in, core.git can emit JSON for .uno:RowColSelCount, can say
which locale was used to generate the payload and we can assert the
correct language in a test.

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I145a552e88fdc869a151a0bd07e8b42474ffd6b8
2024-01-08 10:11:17 +00:00
.git-hooks
.github helm: push chart to github container registry with 2023-12-20 17:00:38 +05:30
.gitpod-files Gitpod: update defaults in coolwsd-gitpod.xml 2023-11-15 15:28:48 +01:00
android Translated using Weblate (Croatian) 2024-01-05 13:05:11 +01:00
browser CanvasTileLayer: allow empty string as payload of the state changed callback in json, too 2024-01-08 10:11:17 +00:00
common wsd: clean up unused header includes 2024-01-08 08:38:48 +01:00
cypress_test Rename getFrame() to cframe() 2024-01-05 07:12:17 -05:00
debian Bump version to 23.05.6.4 2023-12-20 09:19:07 +01:00
docker docker: added a few labels 2023-11-16 11:13:57 +01:00
etc
fuzzer wsd: check for nullptr channel in AdminSocketHandler 2023-12-01 15:35:39 +00:00
gtk extract some functions to extra files for in process mode 2023-12-18 10:34:10 +00:00
indexing
ios Bump version to 23.05.7 for iOS app 2024-01-04 20:32:06 +01:00
kit Use /proc/self/smaps_rollup for improved perf #7927 2024-01-03 20:20:02 +00:00
kubernetes/helm fix(helm): improve alerts many viewer on document with metadata 2024-01-04 13:15:10 +05:30
man Add cli option to use settings from env variables 2023-09-23 12:44:50 +02:00
net wsd: clean up unused header includes 2024-01-08 08:38:48 +01:00
scripts wsd: test: better run_unit.sh 2023-10-24 09:20:32 +02:00
test wsd: clean up unused header includes 2024-01-08 08:38:48 +01:00
tools wsd: clean up unused header includes 2024-01-08 08:38:48 +01:00
wasm extract some functions to extra files for in process mode 2023-12-18 10:34:10 +00:00
wsd wsd: clean up unused header includes 2024-01-08 08:38:48 +01:00
.cirrus.yml
.clang-format
.clang-tidy
.gitignore extract some functions to extra files for in process mode 2023-12-18 10:34:10 +00:00
.gitpod.dockerfile
.gitpod.yml
.mailmap
AUTHORS
autogen.sh autogen: conditionally invoke configure at the end 2023-12-19 15:00:34 +01:00
browsersync-config.js
ChangeLog
CODE_OF_CONDUCT.md
config.h.in configure: WASMAPP is now defined for WASM targets 2023-12-09 19:22:24 +00:00
config_version.h.in
configure.ac Bump version to 23.05.6.4 2023-12-20 09:19:07 +01:00
CONTRIBUTING.md
coolkitconfig-mobile.xcu sc: set hyperlink MS interoperability true in online 2023-08-27 18:32:08 +02:00
coolkitconfig.xcu.in Enable autocorrect option to add bulltes 2023-09-11 11:48:47 +02:00
coolwsd-systemplate-setup copy CA certificates to jail 2023-11-14 17:01:49 +00:00
coolwsd-welcome.xml
coolwsd.init.rhel6
coolwsd.service
coolwsd.spec.in rpm: BuildRequires - those python packages have different names on differenct OS versions 2023-11-06 12:07:33 +01:00
coolwsd.xml.in wsd: quarantine: absolute-path and better logging 2024-01-02 10:57:20 +01:00
COPYING
discovery.xml
favicon.ico
g
jsstress.in
Makefile.am Make eslint in make check fail on eslint warnings 2023-12-19 20:25:43 +00:00
NEWS
PROBLEMS
README.CONTRIBUTING.md Contriburing instructions: add a section on commit messages 2023-09-12 08:45:14 +02:00
README.FILENOTICES.md spdx: improve machine and human readability of headers. 2023-11-14 19:36:31 +00:00
README.md Readme: remove temporally the IRC in favor of matrix 2023-11-16 17:42:19 +01:00
SECURITY.md
trace-event.sample2.json

Open in Gitpod

Collabora Online

Master: Pull request policy

irc Telegram Forum Website L10n Gitpod Ready-to-Code

Your own private Office in the Cloud

Get in touch 💬

Key features

  • View and edit text documents, spreadsheets, presentations & more
  • Collaborative editing features
  • Works in any modern browser no plugin needed
  • Open Source primarily under the MPLv2 license. Some parts are under other open source licences, see e.g. browser/LICENSE.

Website

For many more details, build instructions, downloads and more please visit https://collaboraonline.github.io/

Developer assistance

Please ask your questions on any of the bridged Matrix/Telegram rooms

Join the conversation on our Discourse server at https://forum.collaboraonline.com/

Watch the tinderbox status (if it's green) at https://cpci.cbg.collabora.co.uk:8080/job/Tinderbox%20for%20online%20master%20against%20co-22.05/

Development bits

This project has several components:

  • wsd/
    • The Web Services Daemon - which accepts external connections
  • kit/
    • The client which lives in its own chroot and renders documents
  • common/
    • Shared code between these processes
  • browser/
    • The client side JavaScript component
  • test/
    • C++ based unit tests
  • cypress_test/
    • JavaScript based integration tests

Please consult the README files in the component's directory for more details:

iOS and Android apps

See the corresponding READMEs:

GitPod

Head over to https://collaboraonline.github.io/post/build-code/#build-code-on-gitpod and follow the steps.

Enjoy!