Once core emits JSON format for the LOK_CALLBACK_STATE_CHANGED callback
for the .uno:RowColSelCount uno command, select 2 cells in Calc ->
status bar is updated correctly, now select a single cell again in Calc
-> status bar is not updated. We want to emit JSON format for more uno
commands in the future, for example that is meant to allow testing the
fix for the statusbar part of
<https://github.com/CollaboraOnline/online/issues/7492>.
CanvasTileLayer's _onStateChangedMsg handles a mix of plain text and
json payloads, and the plain text case already allows an empty payload,
while the JSON one does not.
Fix the problem by assuming the intention in commit
403fe10c9d (jsdialog: handle graphic items
updates, 2019-11-28) was to make sure the json key is not missing, not
to block empty string values for the 'state' key.
Once this is in, core.git can emit JSON for .uno:RowColSelCount, can say
which locale was used to generate the payload and we can assert the
correct language in a test.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I145a552e88fdc869a151a0bd07e8b42474ffd6b8
Also better explain that we dump sessions twice.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Iec3ad5b9f78f0572d43cfba1191bcec3584c0092
These tend to be sent at small increments of time, so have some
hysteresis to aggregate drops. Stalled JS such as in a debugger
or a client not responding can cause this for quite some tiles.
Change-Id: Ia807d4ba0ac26a95cad435cba9ed191f22706041
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Download does not mean much in mobile app context.
It's an offline tool. We can save (or export) the
document in a different file format.
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I7b5cd8cd49258803c21bd21ff087008fe715c613
Currently translated at 100.0% (467 of 467 strings)
Translated using Weblate (Czech)
Currently translated at 100.0% (554 of 554 strings)
Co-authored-by: Stanislav Horáček <stanislav.horacek@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/cs/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/cs/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I19dd29ea5c45d9658d9bd9775b1b64706d94f1f4
Currently translated at 100.0% (467 of 467 strings)
Translated using Weblate (Slovenian)
Currently translated at 100.0% (554 of 554 strings)
Co-authored-by: Martin Srebotnjak <miles@filmsi.net>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/sl/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/sl/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I0d687f46e979aa49ebf7fc0ccf8b50f97305e5c4
Currently translated at 99.1% (463 of 467 strings)
Translated using Weblate (German)
Currently translated at 99.2% (550 of 554 strings)
Translated using Weblate (German)
Currently translated at 98.5% (460 of 467 strings)
Translated using Weblate (German)
Currently translated at 98.0% (458 of 467 strings)
Translated using Weblate (German)
Currently translated at 97.8% (457 of 467 strings)
Translated using Weblate (German)
Currently translated at 93.3% (436 of 467 strings)
Co-authored-by: Ettore Atalan <atalanttore@googlemail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/de/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/de/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I828e5ef8e9ac572c696970c42eec333c16a87092
Currently translated at 100.0% (467 of 467 strings)
Translated using Weblate (Croatian)
Currently translated at 100.0% (467 of 467 strings)
Translated using Weblate (Croatian)
Currently translated at 100.0% (554 of 554 strings)
Translated using Weblate (Croatian)
Currently translated at 100.0% (110 of 110 strings)
Co-authored-by: Milo Ivir <mail@milotype.de>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/hr/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/hr/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/hr/
Translation: Collabora Online/Android app
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I4caa22b84638934e6f8474cbdad5ecd9e5ffc51e
Currently translated at 100.0% (467 of 467 strings)
Translated using Weblate (Polish)
Currently translated at 81.1% (379 of 467 strings)
Translated using Weblate (Polish)
Currently translated at 100.0% (554 of 554 strings)
Co-authored-by: Matthaiks <kitynska@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/pl/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pl/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ic5af4a7980c51e36c6b5b5af9e1eaf173f23d09d
- when migrating document from one server to another using indirection
server tiles were not getting updated
- _resetClientVisArea should be called even if there are no changes to
the client because the server needs new data even if the client is
unmodified.
- changing wireId and invalidFrom values to 0, 0 to force a keyframe
b1f0834ac4/browser/src/layer/tile/CanvasTileLayer.js (L7266)
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I9aa0b34c3b1f157f3e4494568802588e00376d7e
If user opened any dialog and we got blur event on
map - it was doing the view inactive by sending
userinactive message to the server and ignoring any
meesages we tried to send. Because of that it was
impossible to test in cypress dropdown dismiss by
click outside popup (due to losing focus from map).
This is regression from rework:
commit 86e8491707
For .eslintrc change, see: https://github.com/typescript-eslint/typescript-eslint/issues/1824
where we changed:
- if (!this._active || isAnyVexDialogActive()) {
+ if (!this._active || isAnyVexDialogActive() || this.map.jsdialog.hasDialogOpened()) {
Make more precise condition so we check if the dialog is a dim one.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ic200bd3f0327e4c43d80fb8cf7c2fbd176485b82
problem:
if comment is already selected and has replies,
then if we try to modify it may not rearrange replies to make comment editing fully visible
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I1c563e5a728dcaa3fdd93cd3612f59a3518e887e
It is a bug from Firefox, according to records
https://bugzilla.mozilla.org/show_bug.cgi?id=292284
The vertical scroll bar requires minimum height to render.
Change-Id: I93b06c625bc98c307dde0c1d6331d457ff99baa5
Signed-off-by: Henry Castro <hcastro@collabora.com>
The 'addMultiClickListener' fires 2 times
'triple click', because it also registers
for 'quadruple click' too.
Change-Id: Iee7565163e64373c87016743c06fe1cc084b80f4
Signed-off-by: Henry Castro <hcastro@collabora.com>
When always_save_on_exit=true we should
still not upload the document when it
isn't modified.
In this case, because we now always
save the document (forced) when
always_save_on_exit=true, and because
saving always generates a new file on
disk, with a new timestamp, we couldn't
detect that there are no modifications.
We now still force save, but ask Core
to skip it if the document is unmodified.
This is safe since we now always issue
the save, but rely on Core to do the
right thing. When the document is saved,
we do the normal upload as in that case
we know we have a new version of the
document, which must be uploaded.
Worth noting that the closedocument
command doesn't trigger the same path.
To reproduce the issue, we need a new
test that disconnects, instead of the
graceful closedocument command.
Change-Id: Iaa4e0363ed2eca124f2d1943393e65c0c187aa18
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
The new WKWebView.inspectable property must be set to YES in order
for Safari to connect to a debug version of the iOS app whether the
app is running on an iOS device or on macOS.
Signed-off-by: Patrick Luby <guibomacdev@gmail.com>
Change-Id: I873a25a149e3ec967ab0775ba8105ecce26f07ac
Similarly to the iOS case seen in #7908 the %SAVED_STATE_UI%
does not get replaced. In mobile apps there is no fileserver
that can replace these variables.
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Icb7f9d7550b0990cc0ad1d65253773b49ff97795
This is partial revert of "jsdialog: use open/close instead of toggle for dropdowns"
commit 0833ec6489.
Which introduced "state" variable which was desynchronised with core in
some cases. Now directly call desired close command in closePopover.
This fixes bug:
1. Click on the sidebar's Paragraph's "Ordered list" dropdown arrow;
2. Click on any kind of the list (so that the current paragraph gets the chosen list style);
3. Click on the drop-down arrow again, expecting the drop-down to open.
Result: you need to click two times to open menu again
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ief49d4aff45bc58a6c02fcdcd8cb2b3f1ec6e691
Using the aggregated file saves a hundred+ system-calls per
pid we're getting data for, and presumably also lots of time.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I41c40982ebbec44aba72a1d15dabf24a8986f59e
It internally handles the mouseup. So we don't send it again.
Without this change, context menus can't behave normal. Because mouse pointer is set to somewhere else with the mouse up event.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I719565b1ce192045250f9217e971725d8cc1003b
Don't show error to the user as it is not critical
but put in the logs more meaningful message so we can debbug
later.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I7b27a19ac7af845de74d7a4fb65682dfe03c042d
