d0db456dc3
As far as I understand, it is not necessary to link symbols of the wsd process into unit-copy-paste.so, since we link it with the -module libtool flag and then load it using dlopen, see <https://www.gnu.org/software/libtool/manual/html_node/Building-modules.html#Building-modules>. It seems this is the only test that links ${test_base_source}. This fixes the following ODR violation: ==18174==ERROR: AddressSanitizer: odr-violation (0x000002090b20): [1] size=40 'SigHandlerTrap' ../common/SigUtil.cpp:76:12 [2] size=40 'SigHandlerTrap' common/SigUtil.cpp:76:12 These globals were registered at these points: [1]: #0 0x5f9a68 in __asan_register_globals.part.13 /home/vmiklos/git/libreoffice/lode/packages/llvm-472c6ef8b0f53061b049039f9775ab127beafbe4.src/compiler-rt/lib/asan/asan_globals.cc:365 #1 0x7f60335f1e4b in asan.module_ctor (/home/vmiklos/git/libreoffice/online-san/test/../test/.libs/unit-copy-paste.so+0x60ae4b) [2]: #0 0x5f9a68 in __asan_register_globals.part.13 /home/vmiklos/git/libreoffice/lode/packages/llvm-472c6ef8b0f53061b049039f9775ab127beafbe4.src/compiler-rt/lib/asan/asan_globals.cc:365 #1 0xe2bd5e in asan.module_ctor (/home/vmiklos/git/libreoffice/online-san/loolwsd+0xe2bd5e) Change-Id: Ic990a1885777e198e59cbc85156c7e5231bac524 |
||
---|---|---|
.. | ||
data | ||
.gitignore | ||
countloolkits.hpp | ||
DeltaTests.cpp | ||
fakesockettest.cpp | ||
helpers.hpp | ||
httpcrashtest.cpp | ||
httpwserror.cpp | ||
httpwstest.cpp | ||
integration-http-server.cpp | ||
Makefile.am | ||
run_unit.sh.in | ||
test.cpp | ||
test.hpp | ||
TileCacheTests.cpp | ||
TileQueueTests.cpp | ||
UnitAdmin.cpp | ||
UnitClient.cpp | ||
UnitConvert.cpp | ||
UnitCopyPaste.cpp | ||
UnitFuzz.cpp | ||
UnitHTTP.cpp | ||
UnitOAuth.cpp | ||
UnitOOB.cpp | ||
UnitPrefork.cpp | ||
UnitStorage.cpp | ||
UnitTileCache.cpp | ||
UnitTimeout.cpp | ||
UnitTyping.cpp | ||
UnitWOPI.cpp | ||
UnitWOPIDocumentConflict.cpp | ||
UnitWOPILoadEncoded.cpp | ||
UnitWopiOwnertermination.cpp | ||
UnitWOPIRenameFile.cpp | ||
UnitWOPISaveAs.cpp | ||
UnitWOPITemplate.cpp | ||
UnitWOPIVersionRestore.cpp | ||
WhiteBoxTests.cpp | ||
WopiTestServer.hpp |