f7a70ba9d3
Now with the "Unipoll" concept all this locking is unnecessary as the kit process is single-threaded, and actually it is harmful as the bug shows. Michael explains in chat: But in fact - we should be a single threaded kit process there now. We are protected by the solar-mutex (which is recursive) while our locking is not. This was the whole point of the Unipoll refactor: to remove the extra threads, complex queues, etc. etc. I just left the mutexes. Even a recursive mutex won't work there; since it needs to be drop-able and transferable to another (LOK internal thread) in Yield, so - we should remove them. Change-Id: I7d1e1dfb0e20f14134be5f81da057539b0f86ab9 Reviewed-on: https://gerrit.libreoffice.org/75849 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> |
||
---|---|---|
.. | ||
data | ||
.gitignore | ||
countloolkits.hpp | ||
DeltaTests.cpp | ||
fakesockettest.cpp | ||
helpers.hpp | ||
httpcrashtest.cpp | ||
httpwserror.cpp | ||
httpwstest.cpp | ||
integration-http-server.cpp | ||
Makefile.am | ||
run_unit.sh.in | ||
test.cpp | ||
test.hpp | ||
TileCacheTests.cpp | ||
TileQueueTests.cpp | ||
UnitAdmin.cpp | ||
UnitClient.cpp | ||
UnitConvert.cpp | ||
UnitFuzz.cpp | ||
UnitHTTP.cpp | ||
UnitOAuth.cpp | ||
UnitOOB.cpp | ||
UnitPrefork.cpp | ||
UnitStorage.cpp | ||
UnitTileCache.cpp | ||
UnitTimeout.cpp | ||
UnitTyping.cpp | ||
UnitWOPI.cpp | ||
UnitWOPIDocumentConflict.cpp | ||
UnitWOPILoadEncoded.cpp | ||
UnitWopiOwnertermination.cpp | ||
UnitWOPIRenameFile.cpp | ||
UnitWOPISaveAs.cpp | ||
UnitWOPIVersionRestore.cpp | ||
WhiteBoxTests.cpp | ||
WopiTestServer.hpp |