strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tdf#145161: Change pdf and image compression dialog string

Browse source 
Since image/pdf compression does not always reduce image
or pdf resolution, change the misleading label from
"reduce" to "change" wherever possible.

Keep identifiers having "reduce" in their name as is
as of now, only change the string values containing
"reduce" to  "change".

Change-Id: I6c4263250faff906d0a16bd1290dc57960161be0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175929
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
This commit is contained in:
Aditya Sahu 2024-11-01 11:32:53 -04:00 committed by Ilmari Lauhakangas
parent b53242ec23
commit 412a775d0a
7 changed files with 13 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
filter/source/pdf/impdialog.cxx
View file

@ -550,7 +550,7 @@ ImpPDFTabGeneralPage::ImpPDFTabGeneralPage(weld::Container* pPage, weld::DialogC
, mxRbJPEGCompression(m_xBuilder->weld_radio_button(u"jpegcompress"_ustr))
, mxQualityFrame(m_xBuilder->weld_widget(u"qualityframe"_ustr))
, mxNfQuality(m_xBuilder->weld_metric_spin_button(u"quality"_ustr, FieldUnit::PERCENT))
, mxCbReduceImageResolution(m_xBuilder->weld_check_button(u"reduceresolution"_ustr))
, mxCbReduceImageResolution(m_xBuilder->weld_check_button(u"changeresolution"_ustr))
, mxCoReduceImageResolution(m_xBuilder->weld_combo_box(u"resolution"_ustr))
, mxCbPDFA(m_xBuilder->weld_check_button(u"pdfa"_ustr))
, mxCbPDFUA(m_xBuilder->weld_check_button(u"pdfua"_ustr))

12
filter/uiconfig/ui/pdfgeneralpage.ui
View file

@ -275,8 +275,8 @@
</packing>
</child>
<child>
<object class="GtkCheckButton" id="reduceresolution">
<property name="label" translatable="yes" context="pdfgeneralpage|reduceresolution">Reduce ima_ge resolution to:</property>
<object class="GtkCheckButton" id="changeresolution">
<property name="label" translatable="yes" context="pdfgeneralpage|changeresolution">Change ima_ge resolution to:</property>
<property name="visible">True</property>
<property name="can-focus">True</property>
<property name="receives-default">False</property>
@ -287,8 +287,8 @@
<relation type="label-for" target="resolution"/>
</accessibility>
<child internal-child="accessible">
<object class="AtkObject" id="reduceresolution-atkobject">
<property name="AtkObject::accessible-description" translatable="yes" context="pdfgeneralpage|extended_tip|reduceresolution">Select to resample or down-size the images to a lower number of pixels per inch.</property>
<object class="AtkObject" id="changeresolution-atkobject">
<property name="AtkObject::accessible-description" translatable="yes" context="pdfgeneralpage|extended_tip|changeresolution">Select to resample or down-size the images to a lower number of pixels per inch.</property>
</object>
</child>
</object>
@ -318,7 +318,7 @@
</object>
</child>
<accessibility>
<relation type="labelled-by" target="reduceresolution"/>
<relation type="labelled-by" target="changeresolution"/>
</accessibility>
<child internal-child="accessible">
<object class="AtkObject" id="resolution-atkobject">
@ -1091,7 +1091,7 @@
<widget name="selection"/>
<widget name="losslesscompress"/>
<widget name="box3"/>
<widget name="reduceresolution"/>
<widget name="changeresolution"/>
<widget name="watermark"/>
</widgets>
</object>

2
sc/qa/uitest/calc_tests4/exportToPDF.py
View file

@ -35,7 +35,7 @@ class exportToPDF(UITestCase):
with self.ui_test.execute_dialog_through_command('.uno:ExportToPDF', close_button="") as xDialog:
selectedChildren = ['bookmarks', 'display', 'effects', 'enablea11y',
'enablecopy', 'exporturl', 'reduceresolution', 'tagged']
'enablecopy', 'exporturl', 'changeresolution', 'tagged']
for child in selectedChildren:
self.assertEqual("true", get_state_as_dict(xDialog.getChild(child))['Selected'])

2
sd/qa/uitest/impress_tests/exportToPDF.py
View file

@ -37,7 +37,7 @@ class exportToPDF(UITestCase):
with self.ui_test.execute_dialog_through_command('.uno:ExportToPDF', close_button="") as xDialog:
selectedChildren = ['bookmarks', 'display', 'effects', 'enablea11y',
'enablecopy', 'exporturl', 'reduceresolution', 'tagged']
'enablecopy', 'exporturl', 'changeresolution', 'tagged']
for child in selectedChildren:
self.assertEqual("true", get_state_as_dict(xDialog.getChild(child))['Selected'])

2
svx/source/dialog/compressgraphicdialog.cxx
View file

@ -125,7 +125,7 @@ void CompressGraphicsDialog::Initialize()
m_xLosslessRB = m_xBuilder->weld_radio_button(u"radio-lossless"_ustr);
m_xQualityMF = m_xBuilder->weld_spin_button(u"spin-quality"_ustr);
m_xQualitySlider = m_xBuilder->weld_scale(u"scale-quality"_ustr);
m_xReduceResolutionCB = m_xBuilder->weld_check_button(u"checkbox-reduce-resolution"_ustr);
m_xReduceResolutionCB = m_xBuilder->weld_check_button(u"checkbox-change-resolution"_ustr);
m_xMFNewWidth = m_xBuilder->weld_spin_button(u"spin-new-width"_ustr);
m_xMFNewHeight = m_xBuilder->weld_spin_button(u"spin-new-height"_ustr);
m_xResolutionLB = m_xBuilder->weld_combo_box(u"combo-resolution"_ustr);

4
svx/uiconfig/ui/compressgraphicdialog.ui
View file

@ -313,8 +313,8 @@
<property name="margin-start">12</property>
<property name="margin-top">6</property>
<child>
<object class="GtkCheckButton" id="checkbox-reduce-resolution">
<property name="label" translatable="yes" context="compressgraphicdialog|checkbox-reduce-resolution">Change image resolution to:</property>
<object class="GtkCheckButton" id="checkbox-change-resolution">
<property name="label" translatable="yes" context="compressgraphicdialog|checkbox-change-resolution">Change image resolution to:</property>
<property name="visible">True</property>
<property name="can_focus">True</property>
<property name="receives_default">False</property>

2
sw/qa/uitest/writer_tests4/exportToPDF.py
View file

@ -33,7 +33,7 @@ class exportToPDF(UITestCase):
with self.ui_test.execute_dialog_through_command('.uno:ExportToPDF', close_button="") as xDialog:
selectedChildren = ['bookmarks', 'display', 'effects', 'enablea11y',
'enablecopy', 'exporturl', 'reduceresolution', 'tagged']
'enablecopy', 'exporturl', 'changeresolution', 'tagged']
for child in selectedChildren:
self.assertEqual("true", get_state_as_dict(xDialog.getChild(child))['Selected'])