cppcheck: pass by reference

This commit is contained in:
Caolán McNamara 2011-01-18 10:55:43 +00:00
parent dfb0fac47b
commit 8a20f85dfa
2 changed files with 4 additions and 4 deletions

View file

@ -817,12 +817,12 @@ void GenericOptions::LoadData()
LINK( this, GenericOptions, LoadGroup ).Call( NULL );
}
void GenericOptions::ShowSelectPath( const String aType )
void GenericOptions::ShowSelectPath( const String &rType )
{
Point aNPos = aPbNewValue.GetPosPixel();
Point aDPos = aPbDelValue.GetPosPixel();
long nDelta = aDPos.Y() - aNPos.Y();
if ( aType.EqualsIgnoreCaseAscii( "PATH" ) && !bShowSelectPath )
if ( rType.EqualsIgnoreCaseAscii( "PATH" ) && !bShowSelectPath )
{ // Show Path button
nMoveButtons += nDelta;
aMoveTimer.Start();
@ -830,7 +830,7 @@ void GenericOptions::ShowSelectPath( const String aType )
aPbSelectPath.Show( TRUE );
aPbSelectPath.Enable( TRUE );
}
else if ( !aType.EqualsIgnoreCaseAscii( "PATH" ) && bShowSelectPath )
else if ( !rType.EqualsIgnoreCaseAscii( "PATH" ) && bShowSelectPath )
{ // Hide Path button
nMoveButtons -= nDelta;
aMoveTimer.Start();

View file

@ -273,7 +273,7 @@ class GenericOptions : public TabPage
StringList* GetAllGroups();
void LoadData();
void ShowSelectPath( const String aType );
void ShowSelectPath( const String& rType );
DECL_LINK( LoadGroup, ComboBox* );
DECL_LINK( DelGroup, Button* );