tdf#163486: PVS: variable is used after being declared

V614 	The 'pReturn' smart pointer is utilized immediately after being declared or reset. It is suspicious that no value was assigned to it.
V614 	The 'pReturn' smart pointer is utilized immediately after being declared or reset. It is suspicious that no value was assigned to it.

Change-Id: Ic84af8c395c4b3f86017eb83be17a6fbd628e5d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176553
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
This commit is contained in:
Xisco Fauli 2024-11-13 16:34:05 +01:00
parent 6570d56009
commit aa60d9a5af

View file

@ -228,8 +228,7 @@ namespace {
}
}
std::shared_ptr<SfxItemSet> pReturn;
return pReturn;
return std::shared_ptr<SfxItemSet>();
}
class Iterator
@ -285,7 +284,6 @@ namespace {
std::shared_ptr<SfxItemSet> Iterator::getNext()
{
std::shared_ptr<SfxItemSet> pReturn;
while( mpNode || mpCurrParent != maParents.end() )
{
if( !mpNode )
@ -315,7 +313,7 @@ namespace {
return mpNode->getItemSetOfIgnorableChild( mbSkipUnusedItemSets );
}
}
return pReturn;
return std::shared_ptr<SfxItemSet>();
}
}