clang-tidy:readability-redundant-member-init

Change-Id: I39b9ac81d65f4a269293824642c1b2ec593c0584
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121490
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin 2021-09-02 09:16:09 +02:00
parent a8638dc415
commit b1af7083b4
30 changed files with 19 additions and 113 deletions

View file

@ -45,14 +45,14 @@
// Problem of implementation: No hierarchical commits. Therefore only
// overall transaction-oriented or direct.
StgDirEntry::StgDirEntry( const void* pBuffer, sal_uInt32 nBufferLen, sal_uInt64 nUnderlyingStreamSize, bool * pbOk ) : StgAvlNode()
StgDirEntry::StgDirEntry( const void* pBuffer, sal_uInt32 nBufferLen, sal_uInt64 nUnderlyingStreamSize, bool * pbOk )
{
*pbOk = m_aEntry.Load( pBuffer, nBufferLen, nUnderlyingStreamSize );
InitMembers();
}
StgDirEntry::StgDirEntry( const StgEntry& r ) : StgAvlNode(), m_aEntry( r )
StgDirEntry::StgDirEntry( const StgEntry& r ) : m_aEntry( r )
{
InitMembers();
}

View file

@ -33,7 +33,7 @@
// This class holds the storage header and all internal streams.
StgIo::StgIo() : StgCache()
StgIo::StgIo()
{
m_pTOC = nullptr;
m_pDataFAT = nullptr;

View file

@ -1440,7 +1440,6 @@ UCBStorage_Impl::UCBStorage_Impl( const ::ucbhelper::Content& rContent, const OU
, m_bIsLinked( true )
, m_bListCreated( false )
, m_nFormat( SotClipboardFormatId::NONE )
, m_aClassId( SvGlobalName() )
, m_bRepairPackage( bIsRepair )
, m_xProgressHandler( xProgressHandler )
{
@ -1469,7 +1468,6 @@ UCBStorage_Impl::UCBStorage_Impl( const OUString& rName, StreamMode nMode, UCBSt
, m_bIsLinked( false )
, m_bListCreated( false )
, m_nFormat( SotClipboardFormatId::NONE )
, m_aClassId( SvGlobalName() )
, m_bRepairPackage( bIsRepair )
, m_xProgressHandler( xProgressHandler )
{
@ -1515,7 +1513,6 @@ UCBStorage_Impl::UCBStorage_Impl( SvStream& rStream, UCBStorage* pStorage, bool
, m_bIsLinked( false )
, m_bListCreated( false )
, m_nFormat( SotClipboardFormatId::NONE )
, m_aClassId( SvGlobalName() )
, m_bRepairPackage( false )
{
// opening in direct mode is too fuzzy because the data is transferred to the stream in the Commit() call,

View file

@ -340,10 +340,6 @@ OUString SmFontFormatList::GetNewFontFormatId() const
SmMathConfig::SmMathConfig() :
ConfigItem("Office.Math")
, pFormat()
, pOther()
, pFontFormatList()
, pSymbolMgr()
, bIsOtherModified(false)
, bIsFormatModified(false)
{

View file

@ -1716,7 +1716,6 @@ void SmFontNode::Arrange(OutputDevice &rDev, const SmFormat &rFormat)
SmPolyLineNode::SmPolyLineNode(const SmToken &rNodeToken)
: SmGraphicNode(SmNodeType::PolyLine, rNodeToken)
, maPoly(2)
, maToSize()
, mnWidth(0)
{
}

View file

@ -2686,8 +2686,7 @@ std::unique_ptr<SmExpressionNode> SmParser5::DoError(SmParseError eError)
// end grammar
SmParser5::SmParser5()
: AbstractSmParser()
, m_nCurError(0)
: m_nCurError(0)
, m_nBufferIndex(0)
, m_nTokenIndex(0)
, m_nRow(0)

View file

@ -46,7 +46,6 @@ namespace stoc_corefl
IdlReflectionServiceImpl::IdlReflectionServiceImpl(
const Reference< XComponentContext > & xContext )
: OComponentHelper( _aComponentMutex )
, _aElements()
{
xContext->getValueByName(
"/singletons/com.sun.star.reflection.theTypeDescriptionManager" ) >>= _xTDMgr;

View file

@ -322,7 +322,7 @@ protected:
} // namespace store
FileLockBytes::FileLockBytes (FileHandle const & rFile)
: m_hFile (rFile.m_handle), m_nSize (SAL_MAX_UINT32), m_xAllocator()
: m_hFile (rFile.m_handle), m_nSize (SAL_MAX_UINT32)
{
}
@ -695,7 +695,7 @@ protected:
} // namespace store
MemoryLockBytes::MemoryLockBytes()
: m_pData (nullptr), m_nSize (0), m_xAllocator()
: m_pData (nullptr), m_nSize (0)
{}
MemoryLockBytes::~MemoryLockBytes()

View file

@ -69,8 +69,7 @@ const sal_uInt32 OStoreDirectory_Impl::m_nTypeId(0x89191107);
* OStoreDirectory_Impl.
*/
OStoreDirectory_Impl::OStoreDirectory_Impl()
: m_xManager (),
m_aDescr (0, 0, 0),
: m_aDescr (0, 0, 0),
m_nPath (0),
m_hTextCvt (nullptr)
{}

View file

@ -43,9 +43,7 @@ const sal_uInt32 OStoreLockBytes::m_nTypeId(0x94190310);
* OStoreLockBytes.
*/
OStoreLockBytes::OStoreLockBytes()
: m_xManager (),
m_xNode (),
m_bWriteable (false)
: m_bWriteable (false)
{
}

View file

@ -28,13 +28,7 @@
namespace svgio::svgreader
{
SvgTextPositions::SvgTextPositions()
: maX(),
maY(),
maDx(),
maDy(),
maRotate(),
maTextLength(),
mbLengthAdjust(true)
: mbLengthAdjust(true)
{
}
@ -563,11 +557,8 @@ namespace svgio::svgreader
const InfoProvider& rInfoProvider,
const SvgTextPositions& rSvgTextPositions)
: mpParent(pParent),
maX(), // computed below
maY(), // computed below
maRotate(solveSvgNumberVector(rSvgTextPositions.getRotate(), rInfoProvider)),
mfTextLength(0.0),
maPosition(), // computed below
mnRotationIndex(0),
mbLengthAdjust(rSvgTextPositions.getLengthAdjust()),
mbAbsoluteX(false)

View file

@ -22,10 +22,7 @@
namespace svgio::svgreader
{
SvgDocument::SvgDocument(const OUString& rAbsolutePath)
: maNodes(),
maAbsolutePath(rAbsolutePath),
maIdTokenMapperList(),
maIdStyleTokenMapperList()
: maAbsolutePath(rAbsolutePath)
{
}

View file

@ -136,7 +136,6 @@ namespace
SvgDocHdl::SvgDocHdl(const OUString& aAbsolutePath)
: maDocument(aAbsolutePath),
mpTarget(nullptr),
maCssContents(),
bSkip(false)
{
}

View file

@ -37,19 +37,9 @@ namespace svgio::svgreader
SvgNode* pParent)
: SvgNode(aType, rDocument, pParent),
maSvgStyleAttributes(*this),
maX1(),
maY1(),
maX2(),
maY2(),
maCx(),
maCy(),
maR(),
maFx(),
maFy(),
maGradientUnits(SvgUnits::objectBoundingBox),
maSpreadMethod(drawinglayer::primitive2d::SpreadMethod::Pad),
mbResolvingLink(false),
maXLink(),
mpXLink(nullptr)
{
OSL_ENSURE(aType == SVGToken::LinearGradient || aType == SVGToken::RadialGradient, "SvgGradientNode should only be used for Linear and Radial gradient (!)");

View file

@ -25,8 +25,7 @@ namespace svgio::svgreader
SvgDocument& rDocument,
SvgNode* pParent)
: SvgNode(SVGToken::Stop, rDocument, pParent),
maSvgStyleAttributes(*this),
maOffset()
maSvgStyleAttributes(*this)
{
}

View file

@ -41,15 +41,10 @@ namespace svgio::svgreader
SvgNode* pParent)
: SvgNode(SVGToken::Rect, rDocument, pParent),
maSvgStyleAttributes(*this),
maSvgAspectRatio(),
maX(0),
maY(0),
maWidth(0),
maHeight(0),
maXLink(),
maUrl(),
maMimeType(),
maData()
maHeight(0)
{
}

View file

@ -25,9 +25,7 @@ namespace svgio::svgreader
SvgDocument& rDocument,
SvgNode* pParent)
: SvgNode(SVGToken::Marker, rDocument, pParent),
aPrimitives(),
maSvgStyleAttributes(*this),
maSvgAspectRatio(),
maRefX(0),
maRefY(0),
maMarkerUnits(MarkerUnits::strokeWidth),

View file

@ -267,10 +267,8 @@ namespace svgio::svgreader
mrDocument(rDocument),
mpParent(pParent),
mpAlternativeParent(nullptr),
maChildren(),
maXmlSpace(XmlSpace::NotSet),
maDisplay(Display::Inline),
maCssStyleVector(),
mbDecomposing(false),
mbCssStyleVectorBuilt(false)
{

View file

@ -26,8 +26,7 @@ namespace svgio::svgreader
SvgDocument& rDocument,
SvgNode* pParent)
: SvgNode(SVGToken::Path, rDocument, pParent),
maSvgStyleAttributes(*this),
maPathLength()
maSvgStyleAttributes(*this)
{
}

View file

@ -34,15 +34,8 @@ namespace svgio::svgreader
SvgDocument& rDocument,
SvgNode* pParent)
: SvgNode(SVGToken::Pattern, rDocument, pParent),
aPrimitives(),
maSvgStyleAttributes(*this),
maSvgAspectRatio(),
maX(),
maY(),
maWidth(),
maHeight(),
mbResolvingLink(false),
maXLink(),
mpXLink(nullptr)
{
}

View file

@ -1249,41 +1249,21 @@ namespace svgio::svgreader
SvgStyleAttributes::SvgStyleAttributes(SvgNode& rOwner)
: mrOwner(rOwner),
mpCssStyleParent(nullptr),
maFill(),
maStroke(),
maStopColor(basegfx::BColor(0.0, 0.0, 0.0), true),
maStrokeWidth(),
maStopOpacity(),
maFillOpacity(),
maStrokeDasharray(),
maStrokeDashOffset(),
maStrokeLinecap(StrokeLinecap::notset),
maStrokeLinejoin(StrokeLinejoin::notset),
maStrokeMiterLimit(),
maStrokeOpacity(),
maFontFamily(),
maFontSize(),
maFontSizeNumber(),
maFontStretch(FontStretch::notset),
maFontStyle(FontStyle::notset),
maFontWeight(FontWeight::notset),
maTextAlign(TextAlign::notset),
maTextDecoration(TextDecoration::notset),
maTextAnchor(TextAnchor::notset),
maColor(),
maOpacity(),
maVisibility(Visibility::notset),
maTitle(),
maDesc(),
maClipPathXLink(),
mpClipPathXLink(nullptr),
maMaskXLink(),
mpMaskXLink(nullptr),
maMarkerStartXLink(),
mpMarkerStartXLink(nullptr),
maMarkerMidXLink(),
mpMarkerMidXLink(nullptr),
maMarkerEndXLink(),
mpMarkerEndXLink(nullptr),
maFillRule(FillRule::notset),
maClipRule(FillRule::nonzero),

View file

@ -27,7 +27,6 @@ namespace svgio::svgreader
SvgDocument& rDocument,
SvgNode* pParent)
: SvgNode(SVGToken::Style, rDocument, pParent),
maSvgStyleAttributes(),
mbTextCss(false)
{
}

View file

@ -35,12 +35,6 @@ namespace svgio::svgreader
SvgNode* pParent)
: SvgNode(SVGToken::Svg, rDocument, pParent),
maSvgStyleAttributes(*this),
maSvgAspectRatio(),
maX(),
maY(),
maWidth(),
maHeight(),
maVersion(),
mbStyleAttributesInitialized(false) // #i125258#
{
}

View file

@ -25,8 +25,7 @@ namespace svgio::svgreader
SvgDocument& rDocument,
SvgNode* pParent)
: SvgNode(SVGToken::Svg, rDocument, pParent),
maSvgStyleAttributes(*this),
maSvgAspectRatio()
maSvgStyleAttributes(*this)
{
}

View file

@ -31,8 +31,7 @@ namespace svgio::svgreader
SvgDocument& rDocument,
SvgNode* pParent)
: SvgNode(SVGToken::Text, rDocument, pParent),
maSvgStyleAttributes(*this),
maSvgTextPositions()
maSvgStyleAttributes(*this)
{
}

View file

@ -120,7 +120,6 @@ namespace svgio::svgreader
mrTextStart(rTextStart),
mnMaxIndex(rPolygon.isClosed() ? rPolygon.count() : rPolygon.count() - 1),
mnIndex(0),
maCurrentSegment(),
mfCurrentSegmentLength(0.0),
mfSegmentStartPosition(0.0)
{
@ -242,9 +241,7 @@ namespace svgio::svgreader
SvgDocument& rDocument,
SvgNode* pParent)
: SvgNode(SVGToken::TextPath, rDocument, pParent),
maSvgStyleAttributes(*this),
maXLink(),
maStartOffset()
maSvgStyleAttributes(*this)
{
}

View file

@ -27,8 +27,7 @@ namespace svgio::svgreader
SVGToken aType,
SvgDocument& rDocument,
SvgNode* pParent)
: SvgNode(aType, rDocument, pParent),
maText()
: SvgNode(aType, rDocument, pParent)
{
OSL_ENSURE(aType == SVGToken::Title || aType == SVGToken::Desc, "SvgTitleDescNode should only be used for Title and Desc (!)");
}

View file

@ -26,8 +26,7 @@ namespace svgio::svgreader
SvgDocument& rDocument,
SvgNode* pParent)
: SvgNode(SVGToken::Tref, rDocument, pParent),
maSvgStyleAttributes(*this),
maXLink()
maSvgStyleAttributes(*this)
{
}

View file

@ -25,8 +25,7 @@ namespace svgio::svgreader
SvgDocument& rDocument,
SvgNode* pParent)
: SvgNode(SVGToken::Tspan, rDocument, pParent),
maSvgStyleAttributes(*this),
maSvgTextPositions()
maSvgStyleAttributes(*this)
{
}

View file

@ -28,11 +28,6 @@ namespace svgio::svgreader
SvgNode* pParent)
: SvgNode(SVGToken::Use, rDocument, pParent),
maSvgStyleAttributes(*this),
maX(),
maY(),
maWidth(),
maHeight(),
maXLink(),
mbDecomposingSvgNode(false)
{
}