strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

apple_remote: autorelease --> release in dealloc (destructor)

Browse source 
using autorelease here leads to “just leaking” because there's no autorelease pool for thread
besides, make sure that released fields do not contain used•to•be•a•valid•pointer value

Change-Id: Id6cb37643230f64dbe9f6128f52236f04d0c88e4
Reviewed-on: https://gerrit.libreoffice.org/22981
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Douglas Mencken 2016-03-07 06:23:31 -05:00 committed by Stephan Bergmann
parent 487ba71c9e
commit d676bd620a
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
apple_remote/source/RemoteMainController.m
View file

@ -155,9 +155,9 @@
}
- (void) dealloc {
[remoteControl autorelease];
[remoteControlBehavior autorelease];
[super dealloc];
[ remoteControl release ]; remoteControl = nil;
[ remoteControlBehavior release ]; remoteControlBehavior = nil;
[super dealloc];
}
// for bindings access