This fixes a five year old (non-)easyhack with 3 duplicates.
Note the nice-to-have dependencies in the bug report(s).
When the document has a unique background (area) image,
it is now added to the list of available images
IF/WHEN the user looks in the area tab.
This allows the user to switch back after changing,
or re-use it in other places in the document.
Most of this patch ended up being plumbing to ensure that
this added image is ONLY available to the current document,
because it MUST NOT be saved to the user profile.
This change affects all apps and all types of areas: NICE
-tested Writer pages, paragraphs, headers, textbox, sidebar(page)
-tested Calc page style
-tested Draw page, sidebar(page), textbox
Caveats:
-the bitmap list is NOT updated at the time of document import,
only when area property inspected.
(The bug requesting inclusion at the time of import is tdf#100832).
make -srj1 UITest_writer_tests8 \
UITEST_TEST_NAME=tdf125969.tdf125969.test_tdf125969 \
SAL_USE_VCLPLUGIN=gen
Change-Id: Ic9fea9b199602c4df1376e781d5df019526473d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176253
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
This fixes a 7.6 regression
from commit e66ddcd4b6.
At import, the base filter was treating too many documents
as if they were limited to Word 2007 format,
and thus reducing their compatibilityMode to 12 on export.
This import case is matched in a LOT of unit tests.
However, it doesn't manifest itself in
saveAndReload(mpFilter) (or DECLARE_OOXMLEXPORT_TEST)
because the mpFilter string set in the Test class with
SwModelTestBase(..."ooxmlexport/data/", "Office Open XML Text"),
forces saving in ISOIEC_29500_2008 mode
and thus unit tests basically NEVER round-trip as "MS Word 2007 XML".
However, the general user was almost always round-tripping
these as MS Word 2007 XML / compat12 since LO 7.6.
make CppunitTest_sw_ooxmlexport20 CPPUNIT_TEST_NAME=testTdf158855
Change-Id: If635866cc816e7b4734443f87b30410ac3bba951
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178048
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Update helpcontent2 from branch 'master'
to 635f1dc3de1c1af8b6a99205d2237c0650084bea
- tdf#155193 No indexing when indexer="excluded" in <topic>
Use omindex property of HTML indexing. See
https://xapian.org/docs/omega/overview.html
Change-Id: I9737d0111860da875e09f27814adf7b14104919b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178156
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update helpcontent2 from branch 'master'
to f723cce6039b88b82380fbc8ebe9a2e18eaf3fd4
- tdf#162504 Create help page for Alignment Sidebar panel
Create new file source/text/scalc/01/sidebar_alignment.xhp to explain
the features of the Alignment panel of the Properties sidebar.
In AllLangHelp_scalc.mk
- Add new file source/text/scalc/01/sidebar_alignment.xhp to the make
file
- Change the file path for
source/text/scalc/01/sidebar_number_format.xhp to show amended file
location.
In source/text/shared/01/05020700.xhp
- Add variable tag so that the file can easily be linked from other help
pages.
In source/text/shared/01/05100100.xhp
- Add section tags so that content can be easily embedded in other
pages.
In source/text/shared/01/05340300.xhp
- Add section and variable tags so that content can be easily embedded
in other pages.
- Reformat the "reference_edge" section so that each option has its own
heading. This improves readability and consistency and allows the same
content to be re-used in the help page for the Alignment Sidebar panel.
In source/text/shared/01/LeftToRight.xhp
- Add section tags so that content can be easily embedded in other
pages.
In source/text/shared/01/RightToLeft.xhp
- Add section tags so that content can be easily embedded in other
pages.
In source/text/scalc/sidebar_number_format.xhp
- Moved file to source/text/scalc/01/sidebar_number_format.xhp
In source/text/shared/01/sidebar_properties.xhp
- Embed description of Alignment sidebar panel
- Update file path for source/text/scalc/01/sidebar_number_format.xhp
- Add loc_false tags for embedded variables
Change-Id: Id9c232c18bab1cfab99eec83e796f8db25681898
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177707
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
... was matched at all, even for a-b-c with MDY a<=12 or DMY a<=31.
Change-Id: Ie2d62c73c91794a96114b787d6ad2357c7affb2a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178171
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
Quoting WCAG 2.2 "Success Criterion 1.4.3 Contrast (Minimum)" [1]:
> The visual presentation of text and images of text has a contrast
> ratio of at least 4.5:1, except for the following:
>
> Large Text
>
> Large-scale text and images of large-scale text have a contrast
> ratio of at least 3:1;
Regarding large text, the corresponding "Understanding SC 1.4.3" [2]
clarifies:
> Text that is larger and has wider character strokes is easier to read at
> lower contrast. The contrast requirement for larger text is therefore
> lower. This allows authors to use a wider range of color choices for
> large text, which is helpful for design of pages, particularly titles.
> 18 point text or 14 point bold text is judged to be large enough to
> require a lower contrast ratio.
Therefore, lower the text contrast requirement in
Writer's accessibility check from 4.5 to 3.0 for
text that is considered large according to that
specification.
Add a unit test with 2 test documents:
* one that adheres to the requirements and would have triggered false
positives without this change in place
(sw/qa/core/accessibilitycheck/data/ContrastTestOK.odt)
* one that doesn't adhere to the requirements and still fails the
check, as it should
(sw/qa/core/accessibilitycheck/data/ContrastTestFail.odt)
[1] https://www.w3.org/TR/WCAG22/#contrast-minimum
[2] https://www.w3.org/WAI/WCAG22/Understanding/contrast-minimum.html
Change-Id: I398f72aa5bdcd77c42834632575d6465a5ecd586
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178127
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
ucrts are no longer added to the installation sets and the corresponding
configure switch has been removed as well.
Change-Id: I484c65c6109572ddd31738e91fcc798575508a7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178076
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins
Now that support for Windows versions earlier than Windows 10
was dropped in
commit b664c08a6d
Date: Sat Dec 7 14:46:24 2024 +0500
Drop support for Windows versions prior to Windows 10
, also drop handling for earlier versions from
`getOSVersionString`.
All still supported Windows versions (10, 11,
corresponding server versions) report a major/minor
version of 10.0 (see [1]), so rely on the build
version only and drop previous logic to retrieve
the major and minor version.
[1] https://learn.microsoft.com/en-us/windows/win32/sysinfo/operating-system-version
Change-Id: I91e0e8238350f680594a516b5e0c042244a49683
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178135
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Added a tooltip that says "Click here to select all cells" to calc
select all rows corner. The report shows a tooltip
will suffice instead of an added icon
Change-Id: I33f9bcb48f9185267be760219f58b196e4d5874d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178092
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
* Update dictionaries from branch 'master'
to 31bc2a1104a1cd175f900902f994c76dea35c763
- Add new word "Ratenvereinbarung"
And put "Rattenvereinbarung" on the blacklist
Change-Id: Ie4d7b8fd93c5758316b5a60539c2a42152725537
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/178143
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
The notes text content was not resized when we changed the paper size
in the print dialog.
Change-Id: I2f610579e2ac84c298c4105a5c1235fbe62ad627
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178146
Tested-by: Jenkins
Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
paragraph spacing, add this values to the notes text size.
Change-Id: I277ecad30244a418d5038e2a8668cf28302f10ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177856
Tested-by: Jenkins
Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
Even if current fill is not "use background" we should reset useBgFill
explicitly, since this value could be set from master slide and was
nested in current shape.
It is somewhat confusing to have fillStyle as none and using slide
background at the same time. So better to clean it explicitly.
Change-Id: I0d817dc295785be7a6cb8f884d5023d316cd2ebf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165994
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Jenkins
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
...so it can be used with std::sort in impSolve() (further down in
basegfx/source/polygon/b2dpolypolygoncutter.cxx). At least on macOS with a
LLVM 20 trunk libc++ in hardened mode, JunitTest_sfx2_complex failed with
> ~/llvm/inst/bin/../include/c++/v1/__debug_utils/strict_weak_ordering_check.h:59: assertion __comp(*(__first + __a), *(__first + __b)) failed: Your comparator is not a valid strict-weak ordering
To simplify the new implementation of struct SN operator <, add a B2DPoint
operator <=> (but whose implementation would cause
> In file included from /home/tdf/lode/jenkins/workspace/android_arm/basegfx/source/curve/b2dbeziertools.cxx:21:
> In file included from /home/tdf/lode/jenkins/workspace/android_arm/include/basegfx/curve/b2dcubicbezier.hxx:22:
> /home/tdf/lode/jenkins/workspace/android_arm/include/basegfx/point/b2dpoint.hxx:129:41: error: invalid operands to binary expression ('tuple<const double &, const double &>' and 'tuple<const double &, const double &>')
> { return std::tie(a.mnX, a.mnY) <=> std::tie(b.mnX, b.mnY); }
> ~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~
etc. on Android with NDK 23.2, see
<https://ci.libreoffice.org/job/gerrit_android_arm/43174/>, so work around that
in the implementation for now).
Change-Id: I9f46d39dc9e9024fe9ac59413c44e49642282c8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175622
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
For a style that isn't inserted yet, the m_sParentStyleName is converted
to UIName by setParentStyle() but isn't converted back to ProgName in
getParentStyle().
This caused all of the writerfilter test failures in commit
c166d112381f195a171425d1f9c1d38ce579319a.
Change-Id: Ib5495785996807a8f3d9339ed2740f286b04d716
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177998
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
we probably shouldn't do that anyway, but the assumption at this
import check appears to be for >= 0
Change-Id: Ibf98b1b0802a15bc283b3d1e3db7e4e8163837dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178132
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
to match the underlying field and avoid confusion.
The "IsOn" prefix normally means "is the current thread running on",
which is not what this method means
Change-Id: I3399a707582c9b0c681cd4aa03bc9f94860fc7fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177960
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
which are more likely to hide an underlying bug than they are to help
Change-Id: I118b592677df05246912d7fa3d7ab8ca2fe99377
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177999
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
which are more likely to hide an underlying bug than they are to help
Change-Id: I5087827665bd6213142ee90450bf58d8d819c93f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178005
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
which are more likely to hide an underlying bug than they are to help
Change-Id: Ifba3c38e9dc6c3d47c9c62bebf5b5e68f11d9ee7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178004
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
which are more likely to hide an underlying bug than they are to help
Change-Id: I3bcac401d62f9baf27e72bacb6bb0a2315d1c081
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178000
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
I added some asserts here, and discovered that sometimes
m_aPages and the pages in the underlying TabControl get out
of sync. So rather than relying on indexing into a vector,
just store a map indexed on the page identifier, which
means everything uses the same scheme now.
Change-Id: I1b8228e9b124521bda0e79c98e4961bedc71d641
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178003
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to f45820f45e2cf351d3f08238952d25de0f68337d
- tdf#161502 Update label Structure to Content in Function Wizard help
Change-Id: I62322b720b0ec54c54268d9cb6a0f2d36b7c8d94
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178125
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
Add clear method to clear the variables that we usually want to
be cleared. Also rename Encrypt to canEncrypt - which is more
clear what it means. Cleanup initializers.
Change-Id: I96735eb6f73a699fb0759496fc8781bcff3854de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176455
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177874
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
This is needed because we have to separate the init. for both
encryption methods and we have to init both when the password is
entered. Currently we only prepared this, to make this possible
when we introduce the other encryption method.
Change-Id: Id6556ddc6a6218164a93bb689f03d6ec6dbad8b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176454
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177873
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
so a new window of the same type will open with the same settings
Change-Id: I7ee4b476d207d1dbd538ce6c054d83f7281f0309
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178119
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
