Rename weld::TreeView member + methods to clarify
that these are about selection changes:
* m_aChangeHdl to m_aSelectionChangedHdl,
* signal_changed to signal_selection_changed
* connect_changed to connect_selection_changed
In GtkInstanceTreeview, also rename the
related methods calling signal_selection_changed
accordingly for consistency.
Change-Id: I299d7930484677395a0bdd0ff105df18688f2e04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178023
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This method from the unpublished XAccessibleExtendedComponent
interface is not used by any of the a11y platform bridges, and
I don't know of any platform a11y API that would need it.
In order to report character/font attributes, there is the
XAccessibleText interface and its
XAccessiText::getCharacterAttributes method instead, which
actually gets used by the platform a11y bridges.
Therefore, drop this method to simplify code, and also decouple
the accessibility module a bit further from the toolkit
module without having to reorganize code further.
(VCLXFont from the toolkit module currently gets used in
various implementations.)
Change-Id: I06ea3cc5998a13927b3f869877b28f03ac07c89b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177809
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
(make from 5 existing only one)
Much of what makes up this patch is adapted from existing code that is
used to organize and select macros and to assign macros to shortcut
keys. Comments in the patch say where code is borrowed from.
Known issues:
+ Scripting framework library rename for BeanShell, Java, and JavaScript
always returns fail when there are no macro entries in the library even
though it actually succeeds. The same thing happens using
SvxScriptOrgDialog::renameEntry.
+ Deleting Basic macros from the Macro Manager dialog is not implemented
yet.
Change-Id: If4da04549f8b39675910cbbd1f94dd9a6b73c31a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176254
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
This variable is passed by a reference to the 'readArguments' function in which its value will be utilized. Inspect the fifth argument.
Change-Id: I39d71ac5e76d3d9a808fa08a430af9aa0686684d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177494
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Add support for input and output of 'split position' parameter (number of entries
in second plot) for of-pie charts. In OOXML this uses the supported split-pos
tag. For ODF I added an extension in loext namespace for this parameter.
This commit also includes simple tests for the I/O functionality in OOXML and
ODF.
Change-Id: I00ff59db721867fa836eb99b6677350040d005dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170666
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
And drop EPosition, which duplicates EPaM, except for its default
ctor (used in a single place).
Change-Id: I48bb6dafcba84465d61579df0ec71b815945532a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177075
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
I think I managed to disable this when I converted it to
use the shared plugin infrastructure.
So fix that, and then make it much smarter to avoid various
false positives.
Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
V1037 Two or more case-branches perform the same actions. Check lines: 146, 158. This will still be the case, the code being just at the moment similar.
Change-Id: Iceca3c717ccc6ee3ea865d3a469418ff6e8accd7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175146
Reviewed-by: David Gilbert <freedesktop@treblig.org>
Tested-by: Jenkins
An existing optimization avoids rendering a bubble chart bubble if
it is nearly the same size and position as the preceding bubble. This
results in incorrect rendering in the case of transparent fill. Skip
the optimization in this case.
Change-Id: Ie21235a66c4d22ac2ce793264ef5bb7b6434117e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172115
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Change-Id: I71c6cd9b5dbcb3126da1919108be009f6512b0d0
V1037: Two or more case-branches perform the same actions. Check lines: 100, 122
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175054
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Change-Id: Icb29cacf3888421843c958a4f157d1079343cc9e
V1037: Two or more case-branches perform the same actions. Check lines: 1173, 1176
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175053
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
we can just take a "const &".
(found by running clang-tidy with the
performance-unnecessary-copy-initialization warning)
Change-Id: I20fd208c65303da78170b1ac06c638fdf3aa094b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176267
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Change-Id: Ief90706c81423116efa2507e1e2bf2b4eee1a2fc
V1037: Two or more case-branches perform the same actions. Check lines: 256, 287
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175145
Reviewed-by: David Gilbert <freedesktop@treblig.org>
Tested-by: Jenkins
Change-Id: I2f34381ccf0e9649874652b382e43fbd1737577a
V1037: Two or more case-branches perform the same actions. Check lines: 121, 127
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175147
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
which allows us to eliminate a bunch of rounding at various layers, and
consequently maintain a lot more precision
Change-Id: I911dedd7c041c1d67396c082e5695346ea689acb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175814
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
V1037: Two or more case-branches perform the same actions. Check lines: 106, 141, 288
Change-Id: I160bc72851f24503f23a96048feb071f164cbdef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175090
Reviewed-by: David Gilbert <freedesktop@treblig.org>
Tested-by: Jenkins
Partial fix.
(*) fixed bugs where the use of continue in loops meant that a tracking
variable was not being updated
(*) improved exception message in TableModel::getCellByPosition
(*) rather than exiting the view generation process with an exception,
log a warning and skip that part of the view process
The root of the problem here is that we don't seem to be importing
data-tables from PPTX properly. I suspect that we need more import
code, in particular, we probably need to read some flag that
indicates if we have header rows and columns.
Change-Id: Iaa9a1593bc185a5bb4f36a434117bbd5bf323e18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175551
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Since
commit 44569a657c
Author: Release Engineers <releng@openoffice.org>
Date: Thu Jul 2 19:17:43 2009 +0000
CWS-TOOLING: integrate CWS bubblechart
V778 Two similar code fragments were found. Perhaps, this is a typo and 'xValuesX' variable should be used instead of 'xValuesY'.
Change-Id: I8a3515e2c3de97f82547786a8428f47c503335ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175321
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Since
commit 4c2701d4cc
Author: Vladimir Glazounov <vg@openoffice.org>
Date: Tue May 22 17:53:11 2007 +0000
INTEGRATION: CWS chart2mst3 (1.1.4); FILE ADDED
V778 Two similar code fragments were found. Perhaps, this is a typo and 'xValuesX' variable should be used instead of 'xValuesY'.
Change-Id: I24a904ee2e0fa81eb50756545d4b1127b93579fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175322
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Change-Id: Ibe65f4eca6009e8be4355974cdf33b5cabbe03e5
V1037: Two or more case-branches perform the same actions. Check lines: 54, 60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175144
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Implemented chart data extraction, and transformation
added insert/delete/modify row/column, and the ability to set
resize data table
setcolumndesc / setrowdesc .. for 1 descriptor,
or with multiple descriptor to set
set 1 cell value, or set the whole table cells values.
it will resize the table, but you can still use partial arrays
like
"data": [ [ 1,2,3,4 ],
[ 2,3,4,5 ],
[ 3 ],
[ 4,5,6,7 ],
[ 2,2,1 ],
[ 5,6,7,8 ] ],
that means the 3. row 2,3,4th cell will not be overwritten.
for insert column, it call codes from DataBrowserModel.
(used by dialog code)
added tests, fixed a contentcontrol date problem
2. commit (made by Caolan) squashed into 1. commit:
WIP hack this to link
move stuff from chartcontroller to chartcore and adjust visibility
until it links at least
Change-Id: I5529f4da33f046eef7e947d755e29486fa966274
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172849
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175121
Tested-by: Jenkins
Change-Id: I4afca4f9d7eb8968dc7a2465222f7c2060f10bd4
V1037: Two or more case-branches perform the same actions. Check lines: 178, 194
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175055
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
