strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
502520 commits 9 branches 795 tags 2.1 GiB
Commit graph

4006 commits

Author SHA1 Message Date
Stephan Bergmann
8075798b22 Fix check for further exotic protocols 
...that were added in 59891cd398 "look at
'embedded' protocols for protocols that support them"

Change-Id: I42836d6fd27cd99e39ab07e626053f002a2651f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178047
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
 2024-12-07 22:22:23 +01:00
Caolán McNamara
59891cd398 look at 'embedded' protocols for protocols that support them 
Change-Id: Ie99f5f5a390639bdc69397c831e0a32594a5030c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177981
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-12-06 17:09:51 +01:00
Rosh
71ec40df42 tdf#147021 - Use std::size() instead of SAL_N_ELEMENTS() macro 
Change-Id: I2495fa1ad081ad75bd8e79a22bdeaa97217aa398
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177581
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
 2024-11-30 09:27:12 +01:00
Caolán McNamara
12cad7e619 cid#1607163 silence Overflowed return value 
and

cid#1608078 Overflowed return value
cid#1608461 Overflowed return value

Change-Id: Ic5fa20994c5be5d6c09a21c0bd1e3530ae9a6941
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177164
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-11-24 15:14:59 +01:00
Caolán McNamara
836d73a651 consider VndSunStarExpand an exotic protocol 
and generally don't bother with it when fetching data
from urls

Change-Id: I51a2601c6fb7d6c32f9e2d1286ee0d3b05b370b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176645
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
 2024-11-19 20:20:03 +01:00
Stephan Bergmann
39f701d540 Avoid UBSan when negating the most negative sal_Int64 value 
...as exhibited by recently added 08e566f0c9 "add
a couple of tests for tools::BigInt"

Change-Id: Icd1080f86ccd985868fce34d6f86e2706acd58df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176677
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
 2024-11-16 23:27:39 +01:00
Noel Grandin
c6fa60bdff consistently return -1 in SvFileStream::PutData 
for the error case

Just for consistency with the other error cases in PutData/GetData

Change-Id: Ib7fd27f9347021b3063e6eac88fd8038d5f218e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176621
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-11-15 12:12:54 +01:00
Noel Grandin
08e566f0c9 add a couple of tests for tools::BigInt 
because I might touch this area and I want to be sure I don't mess it up

Change-Id: I62c177031f690f4455a58f3280ed26186df94158
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176620
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-11-15 11:38:18 +01:00
Caolán McNamara
54f5e44f58 cid#1606697 silence Overflowed constant 
Change-Id: I81d0b10f8e0c34f9d276e59b5eed2c3d879f05cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176195
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
 2024-11-07 11:57:42 +01:00
Noel Grandin
54a91f287f loplugin:passstuffbyref in tools 
Change-Id: Id902f711d14eb21dc14366e8fe8fc5a96c0afec4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176055
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-11-06 09:25:37 +01:00
Caolán McNamara
051365a71f cid#1606943 Overflowed constant 
Change-Id: I056e45e19bb3794acbdf7b5c2b4ecb787e52de0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175975
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-11-04 09:38:46 +01:00
Noel Grandin
5de73f04f3 new loplugin:staticconstexpr 
Change-Id: Ida1996dfffa106bf95fd064e8191b8033b4002f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175336
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-11-04 08:51:00 +01:00
Caolán McNamara
15eb26d0f2 ofz: Undefined-shift 
Change-Id: Ibb42de616566aabdf6596b7c45d0afab90118bc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175877
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-10-31 18:18:48 +01:00
Noel Grandin
cb24239ef0 cid#1606943 Overflowed constant 
Change-Id: If097a933e8d856e4528313cd351959ceb9041b27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175718
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2024-10-28 18:42:47 +01:00
Noel Grandin
79b28add29 cid#1606697 Overflowed constant 
Change-Id: Icc71db8d231737d8a401da05e836a552e31a4875
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175716
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2024-10-28 12:14:44 +01:00
Julien Nabet
ed425db15b tdf#163486: PVS: Array overrun is possible 
In both cases, we know nSubSelPos < aSels.size() since it's been tested some lines before

Change-Id: I1e1e7c63f30bf0ea830f050284b5d2af18a597f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175673
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2024-10-27 09:13:52 +01:00
Stephan Bergmann
b0195d40f3 Avoid signed integer overflow 
...as seen at

> /tools/source/misc/fix16.cxx:79:53: runtime error: signed integer overflow: -2147483648 - 1 cannot be represented in type 'int'
>     #0 0x7fc2f9f50a60 in mask(int) /tools/source/misc/fix16.cxx:79:53
>     #1 0x7fc2f9f505fd in fix16_div(int, int) /tools/source/misc/fix16.cxx:122:34
>     #2 0x7fc2f00d12e0 in vcl::fixedDiv(int, int) /vcl/source/fontsubset/sft.cxx:127:12
>     #3 0x7fc2f00d11c1 in vcl::fixedMulDiv(int, int, int) /vcl/source/fontsubset/sft.cxx:135:12
>     #4 0x7fc2f00d0851 in vcl::GetCompoundTTOutline(vcl::AbstractTrueTypeFont*, unsigned int, std::__debug::vector<vcl::ControlPoint, std::allocator<vcl::ControlPoint> >&, vcl::(anonymous namespace)::TTGlyphMetrics*, std::__debug::vector<unsigned int, std::allocator<unsigned int> >&) /vcl/source/fontsubset/sft.cxx:544:91
>     #5 0x7fc2f00af5f1 in vcl::GetTTGlyphOutline(vcl::AbstractTrueTypeFont*, unsigned int, std::__debug::vector<vcl::ControlPoint, std::allocator<vcl::ControlPoint> >&, vcl::(anonymous namespace)::TTGlyphMetrics*, std::__debug::vector<unsigned int, std::allocator<unsigned int> >*) /vcl/source/fontsubset/sft.cxx:621:15
>     #6 0x7fc2f00aea34 in vcl::GetTTGlyphPoints(vcl::AbstractTrueTypeFont*, unsigned int, std::__debug::vector<vcl::ControlPoint, std::allocator<vcl::ControlPoint> >&) /vcl/source/fontsubset/sft.cxx:1239:12
>     #7 0x7fc2f00b92de in vcl::GetTTRawGlyphData(vcl::AbstractTrueTypeFont*, unsigned int) /vcl/source/fontsubset/sft.cxx:1667:9
>     #8 0x7fc2f00b23ed in vcl::CreateTTFromTTGlyphs(vcl::AbstractTrueTypeFont*, std::__debug::vector<unsigned char, std::allocator<unsigned char> >&, unsigned short const*, unsigned char const*, int) /vcl/source/fontsubset/sft.cxx:1374:32
>     #9 0x7fc2f00bc71a in vcl::CreateTTFfontSubset(vcl::AbstractTrueTypeFont&, std::__debug::vector<unsigned char, std::allocator<unsigned char> >&, unsigned int const*, unsigned char const*, int, FontSubsetInfo&) /vcl/source/fontsubset/sft.cxx:1549:13
>     #10 0x7fc2eff57836 in vcl::font::PhysicalFontFace::CreateFontSubset(std::__debug::vector<unsigned char, std::allocator<unsigned char> >&, unsigned int const*, unsigned char const*, int, FontSubsetInfo&) const /vcl/source/font/PhysicalFontFace.cxx:367:12
>     #11 0x7fc2ee4e0472 in vcl::PDFWriterImpl::emitFonts() /vcl/source/gdi/pdfwriter_impl.cxx:3152:24
>     #12 0x7fc2ee4e9cb9 in vcl::PDFWriterImpl::emitResources() /vcl/source/gdi/pdfwriter_impl.cxx:3363:10
>     #13 0x7fc2ee53f91d in vcl::PDFWriterImpl::emitCatalog() /vcl/source/gdi/pdfwriter_impl.cxx:5288:10
>     #14 0x7fc2ee567ae3 in vcl::PDFWriterImpl::emit() /vcl/source/gdi/pdfwriter_impl.cxx:6341:10
>     #15 0x7fc2ee3d3f2a in vcl::PDFWriter::Emit() /vcl/source/gdi/pdfwriter.cxx:53:29
>     #16 0x7fc249b4b82a in PDFExport::Export(rtl::OUString const&, com::sun:⭐:uno::Sequence<com::sun:⭐🫘:PropertyValue> const&) /filter/source/pdf/pdfexport.cxx:1127:39
>     #17 0x7fc249bb2782 in PDFFilter::implExport(com::sun:⭐:uno::Sequence<com::sun:⭐🫘:PropertyValue> const&) /filter/source/pdf/pdffilter.cxx:182:24
>     #18 0x7fc249bb342b in PDFFilter::filter(com::sun:⭐:uno::Sequence<com::sun:⭐🫘:PropertyValue> const&) /filter/source/pdf/pdffilter.cxx:247:23
>     #19 0x7fc2a51ebec6 in SfxObjectShell::ExportTo(SfxMedium&) /sfx2/source/doc/objstor.cxx:2945:25
>     #20 0x7fc2a51d7bec in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) /sfx2/source/doc/objstor.cxx:1943:19
>     #21 0x7fc2a5213f83 in SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet const&, com::sun:⭐:uno::Sequence<com::sun:⭐🫘:PropertyValue> const&) /sfx2/source/doc/objstor.cxx:3459:39
>     #22 0x7fc2a520b709 in SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&, com::sun:⭐:uno::Sequence<com::sun:⭐🫘:PropertyValue> const&) /sfx2/source/doc/objstor.cxx:3249:9
>     #23 0x7fc2a5147a8b in SfxObjectShell::APISaveAs_Impl(std::basic_string_view<char16_t, std::char_traits<char16_t> >, SfxItemSet&, com::sun:⭐:uno::Sequence<com::sun:⭐🫘:PropertyValue> const&) /sfx2/source/doc/objserv.cxx:320:19
>     #24 0x7fc2a543024c in SfxBaseModel::impl_store(rtl::OUString const&, com::sun:⭐:uno::Sequence<com::sun:⭐🫘:PropertyValue> const&, bool) /sfx2/source/doc/sfxbasemodel.cxx:3231:42
>     #25 0x7fc2a54374f4 in SfxBaseModel::storeToURL(rtl::OUString const&, com::sun:⭐:uno::Sequence<com::sun:⭐🫘:PropertyValue> const&) /sfx2/source/doc/sfxbasemodel.cxx:1813:13
>     #26 0x7fc2c74053ae in ScPDFExportTest::exportToPDF(com::sun:⭐:uno::Reference<com::sun:⭐:frame::XModel> const&, ScRange const&) /sc/qa/extras/scpdfexport.cxx:179:16
>     #27 0x7fc2c7437e0f in ScPDFExportTest::testForcepoint97() /sc/qa/extras/scpdfexport.cxx:915:5

during CppunitTest_sc_pdf_export
(<https://ci.libreoffice.org/job/lo_ubsan/3346/>)

Change-Id: I3074479ea3267417a73ecafa81b4a9898f19d1a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175469
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
 2024-10-23 12:10:21 +02:00
Caolán McNamara
746f66f4b1 cid#1607748 Overflowed constant 
Change-Id: Id077fdc914f461a3631c42c37b2d5be37632e0e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175374
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-10-22 20:37:17 +02:00
Noel Grandin
19bc8856c4 move vcl::DeleteOnDeinit to tools 
so we can fix a shutdown use-after-free in sot.

Change-Id: I32f83bd94627d72d7bee7ea2ebd6ab77a7f78435
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175335
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-10-22 08:01:19 +02:00
Mike Kaganski
7e5f69aa33 Make tools::Time ctor taking sal_Int64 private 
This ctor is meant to set the value of nTime directly; and that value
is not nanoseconds, but an encoded value, using SEC_/MIN_/HOUR_MASK.
But in some places, this ctor was misused for setting of nanoseconds,
which would only accidentally work for values less than one second.
All places that initialized tools::Time with 0, now use EMPTY.

This makes the ctor private; and for the very few cases where really
the encoded value of nTime is stored / restored, fromEncodedTime is
introduced.

Change-Id: I1f1994bd9aab1b51a41b1de637619049fe820da4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175283
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2024-10-21 10:30:58 +02:00
Mike Kaganski
794cb79c0e Optimize a bit 
Change-Id: Ief89a827c05ae1197142de46a2d9365f87455158
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175282
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
 2024-10-21 06:26:42 +02:00
Noel Grandin
5c4fac1e9f loplugin:unusedmethods 
Change-Id: I6ba4b4046190b701d4a15c6fa90b6009ecf4ab1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175014
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-10-16 15:52:02 +02:00
Noel Grandin
6402a656cd cid#1607163 Overflowed return value 
Change-Id: I403a2c5bb55e3a80d3bf99302b262aa507812d68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174895
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2024-10-14 16:58:51 +02:00
Mike Kaganski
53f889780f Reimplement GetSystemDateTime using std::chrono 
Change-Id: I15bce244f96a8940df73f4b5933bcb95a547673e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174691
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2024-10-08 17:10:32 +02:00
Mike Kaganski
bbcd4765ee Simplify tools::Time code 
Change-Id: I44a61a0ae2f6e2b81cce96ff96418484a611821d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174689
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2024-10-08 14:05:14 +02:00
Stephan Bergmann
c3b3b27e57 loplugin:noexceptmove (macOS, LLVM 20 trunk libc++) 
Change-Id: I77a48bbdfcb3d80af69155b11b31ee8e8223bd64
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174261
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
 2024-09-30 11:21:34 +02:00
Caolán McNamara
c8b5ac2a54 cid#1607586 Overflowed return value 
and

cid#1608074 Overflowed return value
cid#1607598 Overflowed return value

Change-Id: Ib884c10083c01578a7a0926d5f2f3c2d1f7501c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173833
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-09-24 13:27:26 +02:00
Mohit Marathe
be16c6cf5c sw: add Comments Panel in sidebar 
This commit adds a sidebar deck for comments.
It has all the functionalities of the old comments
shown via annotation window.

Change-Id: Ibab0e21a54c097d0f42bddb1d07da74319970135
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167840
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
 2024-09-13 12:35:45 +02:00
Caolán McNamara
5f903bd3ad ofz#70815 optimize this a little 
#5 0x558251409124 in operator new[](unsigned long) /src/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:98:3
 #6 0x558255fb4937 in ImplPolygon::ImplPolygon(ImplPolygon const&) /src/libreoffice/tools/source/generic/poly.cxx:74:26
 #7 0x558255fbbfd3 in impl_t /src/libreoffice/include/o3tl/cow_wrapper.hxx:195:17
 #8 0x558255fbbfd3 in cow_wrapper /src/libreoffice/include/o3tl/cow_wrapper.hxx:236:26
 #9 0x558255fbbfd3 in tools::Polygon::Polygon(tools::Rectangle const&) /src/libreoffice/tools/source/generic/poly.cxx:887:53

shouldn't need to create a copy here

Change-Id: I44122aaca0b49f31dd85e95920c9911b96e4227f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172706
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
 2024-09-01 12:11:53 +02:00
Caolán McNamara
2a5c998d4c allow an exemption to be made for a specific host 
Change-Id: Ie423df7839e793a9c07561efb56d5649876947ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168826
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172328
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-08-23 21:52:26 +02:00
Caolán McNamara
dd689fb914 cid#1557699 COPY_INSTEAD_OF_MOVE 
and

cid#1557435 COPY_INSTEAD_OF_MOVE
cid#1557307 COPY_INSTEAD_OF_MOVE
cid#1557209 COPY_INSTEAD_OF_MOVE
cid#1557192 COPY_INSTEAD_OF_MOVE
cid#1557184 COPY_INSTEAD_OF_MOVE
cid#1557183 COPY_INSTEAD_OF_MOVE
cid#1557171 COPY_INSTEAD_OF_MOVE
cid#1557150 COPY_INSTEAD_OF_MOVE
cid#1557148 COPY_INSTEAD_OF_MOVE
cid#1557123 COPY_INSTEAD_OF_MOVE
cid#1557118 COPY_INSTEAD_OF_MOVE
cid#1557116 COPY_INSTEAD_OF_MOVE
cid#1557103 COPY_INSTEAD_OF_MOVE
cid#1557078 COPY_INSTEAD_OF_MOVE
cid#1557075 COPY_INSTEAD_OF_MOVE
cid#1557071 COPY_INSTEAD_OF_MOVE
cid#1557070 COPY_INSTEAD_OF_MOVE
cid#1557067 COPY_INSTEAD_OF_MOVE
cid#1557049 COPY_INSTEAD_OF_MOVE
cid#1557046 COPY_INSTEAD_OF_MOVE
cid#1557042 COPY_INSTEAD_OF_MOVE
cid#1557036 COPY_INSTEAD_OF_MOVE
cid#1557030 COPY_INSTEAD_OF_MOVE
cid#1557024 COPY_INSTEAD_OF_MOVE
cid#1557012 COPY_INSTEAD_OF_MOVE
cid#1557009 COPY_INSTEAD_OF_MOVE
cid#1557008 COPY_INSTEAD_OF_MOVE
cid#1557004 COPY_INSTEAD_OF_MOVE
cid#1556999 COPY_INSTEAD_OF_MOVE
cid#1556992 COPY_INSTEAD_OF_MOVE
cid#1556987 COPY_INSTEAD_OF_MOVE
cid#1556984 COPY_INSTEAD_OF_MOVE
cid#1556981 COPY_INSTEAD_OF_MOVE

Change-Id: Id2687aa282f4e2d4b8053b73c7aa1a74a9516b16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171974
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-08-18 11:04:45 +02:00
Heiko Tietze
74d910231c Resolves tdf#161766 - WCAG 2.1 compliant luminance for isDark() 
Alternative solution to I63b85694584cdc6213e7b904ed6402b6c2f2b422

Change-Id: Ifca47de30616295a9965b9313886456313921401
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171862
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
 2024-08-16 08:55:54 +02:00
Caolán McNamara
437412d79b cid#1557980 COPY_INSTEAD_OF_MOVE 
and

cid#1557869 COPY_INSTEAD_OF_MOVE
cid#1557807 COPY_INSTEAD_OF_MOVE
cid#1557804 COPY_INSTEAD_OF_MOVE
cid#1557799 COPY_INSTEAD_OF_MOVE
cid#1557781 COPY_INSTEAD_OF_MOVE
cid#1557781 COPY_INSTEAD_OF_MOVE
cid#1557766 COPY_INSTEAD_OF_MOVE
cid#1557746 COPY_INSTEAD_OF_MOVE
cid#1557737 COPY_INSTEAD_OF_MOVE

Change-Id: I1866c576f525ea697c62e9e0a96890e5fdaa780f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171795
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-08-14 09:27:19 +02:00
Caolán McNamara
d7056b1456 cid#1558088 COPY_INSTEAD_OF_MOVE 
and

cid#1558080 COPY_INSTEAD_OF_MOVE
cid#1558077 COPY_INSTEAD_OF_MOVE
cid#1558055 COPY_INSTEAD_OF_MOVE
cid#1558043 COPY_INSTEAD_OF_MOVE
cid#1558039 COPY_INSTEAD_OF_MOVE
cid#1558015 COPY_INSTEAD_OF_MOVE
cid#1558014 COPY_INSTEAD_OF_MOVE
cid#1558009 COPY_INSTEAD_OF_MOVE
cid#1558002 COPY_INSTEAD_OF_MOVE
cid#1557998 COPY_INSTEAD_OF_MOVE
cid#1557996 COPY_INSTEAD_OF_MOVE
cid#1557990 COPY_INSTEAD_OF_MOVE
cid#1557986 COPY_INSTEAD_OF_MOVE
cid#1557980 COPY_INSTEAD_OF_MOVE
cid#1557971 COPY_INSTEAD_OF_MOVE
cid#1557968 COPY_INSTEAD_OF_MOVE
cid#1557967 COPY_INSTEAD_OF_MOVE
cid#1557961 COPY_INSTEAD_OF_MOVE
cid#1557959 COPY_INSTEAD_OF_MOVE
cid#1557958 COPY_INSTEAD_OF_MOVE
cid#1557956 COPY_INSTEAD_OF_MOVE
cid#1557953 COPY_INSTEAD_OF_MOVE
cid#1557949 COPY_INSTEAD_OF_MOVE
cid#1557947 COPY_INSTEAD_OF_MOVE
cid#1557940 COPY_INSTEAD_OF_MOVE
cid#1557931 COPY_INSTEAD_OF_MOVE
cid#1557930 COPY_INSTEAD_OF_MOVE
cid#1557915 COPY_INSTEAD_OF_MOVE
cid#1557913 COPY_INSTEAD_OF_MOVE
cid#1557910 COPY_INSTEAD_OF_MOVE
cid#1557886 COPY_INSTEAD_OF_MOVE
cid#1557884 COPY_INSTEAD_OF_MOVE
cid#1557880 COPY_INSTEAD_OF_MOVE
cid#1557875 COPY_INSTEAD_OF_MOVE
cid#1557871 COPY_INSTEAD_OF_MOVE
cid#1557862 COPY_INSTEAD_OF_MOVE
cid#1557847 COPY_INSTEAD_OF_MOVE
cid#1557845 COPY_INSTEAD_OF_MOVE
cid#1557844 COPY_INSTEAD_OF_MOVE
cid#1557843 COPY_INSTEAD_OF_MOVE
cid#1557838 COPY_INSTEAD_OF_MOVE
cid#1557835 COPY_INSTEAD_OF_MOVE
cid#1557834 COPY_INSTEAD_OF_MOVE
cid#1557828 COPY_INSTEAD_OF_MOVE
cid#1557823 COPY_INSTEAD_OF_MOVE
cid#1557817 COPY_INSTEAD_OF_MOVE
cid#1557813 COPY_INSTEAD_OF_MOVE
cid#1557812 COPY_INSTEAD_OF_MOVE

Change-Id: I55d4a920daa2d148683419169eb828325fd3c757
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171732
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-08-11 20:14:54 +02:00
Caolán McNamara
ac0514fb3d cid#1555415 COPY_INSTEAD_OF_MOVE 
and

cid#1555430 COPY_INSTEAD_OF_MOVE
cid#1555497 COPY_INSTEAD_OF_MOVE
cid#1555542 COPY_INSTEAD_OF_MOVE
cid#1555543 COPY_INSTEAD_OF_MOVE
cid#1555564 COPY_INSTEAD_OF_MOVE
cid#1555593 COPY_INSTEAD_OF_MOVE
cid#1555602 COPY_INSTEAD_OF_MOVE
cid#1555610 COPY_INSTEAD_OF_MOVE
cid#1555667 COPY_INSTEAD_OF_MOVE
cid#1555693 COPY_INSTEAD_OF_MOVE
cid#1555719 COPY_INSTEAD_OF_MOVE
cid#1555757 COPY_INSTEAD_OF_MOVE
cid#1555795 COPY_INSTEAD_OF_MOVE
cid#1555826 COPY_INSTEAD_OF_MOVE
cid#1555847 COPY_INSTEAD_OF_MOVE
cid#1555851 COPY_INSTEAD_OF_MOVE
cid#1555863 COPY_INSTEAD_OF_MOVE
cid#1555865 COPY_INSTEAD_OF_MOVE
cid#1555867 COPY_INSTEAD_OF_MOVE
cid#1555869 COPY_INSTEAD_OF_MOVE
cid#1555879 COPY_INSTEAD_OF_MOVE
cid#1555890 COPY_INSTEAD_OF_MOVE
cid#1555893 COPY_INSTEAD_OF_MOVE
cid#1555900 COPY_INSTEAD_OF_MOVE
cid#1555922 COPY_INSTEAD_OF_MOVE
cid#1555925 COPY_INSTEAD_OF_MOVE

Change-Id: I5d362a09e80eecd282e63c745bfe26eac2631a0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171492
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
 2024-08-06 09:13:52 +02:00
Caolán McNamara
4177e553e0 cid#1555587 COPY_INSTEAD_OF_MOVE 
and

cid#1555589 COPY_INSTEAD_OF_MOVE
cid#1555593 COPY_INSTEAD_OF_MOVE
cid#1555596 COPY_INSTEAD_OF_MOVE
cid#1555602 COPY_INSTEAD_OF_MOVE
cid#1555608 COPY_INSTEAD_OF_MOVE
cid#1555610 COPY_INSTEAD_OF_MOVE
cid#1555620 COPY_INSTEAD_OF_MOVE
cid#1555623 COPY_INSTEAD_OF_MOVE
cid#1555625 COPY_INSTEAD_OF_MOVE
cid#1555626 COPY_INSTEAD_OF_MOVE
cid#1555634 COPY_INSTEAD_OF_MOVE
cid#1555638 COPY_INSTEAD_OF_MOVE
cid#1555667 COPY_INSTEAD_OF_MOVE
cid#1555682 COPY_INSTEAD_OF_MOVE
cid#1555686 COPY_INSTEAD_OF_MOVE
cid#1555702 COPY_INSTEAD_OF_MOVE
cid#1555710 COPY_INSTEAD_OF_MOVE
cid#1555750 COPY_INSTEAD_OF_MOVE
cid#1555752 COPY_INSTEAD_OF_MOVE
cid#1555761 COPY_INSTEAD_OF_MOVE
cid#1555762 COPY_INSTEAD_OF_MOVE
cid#1555771 COPY_INSTEAD_OF_MOVE
cid#1555772 COPY_INSTEAD_OF_MOVE
cid#1555784 COPY_INSTEAD_OF_MOVE
cid#1555785 COPY_INSTEAD_OF_MOVE

Change-Id: Ib9724230c05b2027b4edf64e6a0bb5e22a270a88
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171274
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-07-31 17:37:14 +02:00
Caolán McNamara
07d3577569 cid#1555417 COPY_INSTEAD_OF_MOVE 
and

cid#1555423 COPY_INSTEAD_OF_MOVE
cid#1555430 COPY_INSTEAD_OF_MOVE
cid#1555436 COPY_INSTEAD_OF_MOVE
cid#1555440 COPY_INSTEAD_OF_MOVE
cid#1555443 COPY_INSTEAD_OF_MOVE
cid#1555454 COPY_INSTEAD_OF_MOVE
cid#1555459 COPY_INSTEAD_OF_MOVE
cid#1555461 COPY_INSTEAD_OF_MOVE
cid#1555468 COPY_INSTEAD_OF_MOVE
cid#1555477 COPY_INSTEAD_OF_MOVE
cid#1555484 COPY_INSTEAD_OF_MOVE
cid#1555511 COPY_INSTEAD_OF_MOVE
cid#1555515 COPY_INSTEAD_OF_MOVE
cid#1555519 COPY_INSTEAD_OF_MOVE
cid#1555534 COPY_INSTEAD_OF_MOVE
cid#1555537 COPY_INSTEAD_OF_MOVE
cid#1555544 COPY_INSTEAD_OF_MOVE
cid#1555553 COPY_INSTEAD_OF_MOVE
cid#1555559 COPY_INSTEAD_OF_MOVE
cid#1555561 COPY_INSTEAD_OF_MOVE
cid#1555563 COPY_INSTEAD_OF_MOVE
cid#1555564 COPY_INSTEAD_OF_MOVE
cid#1555568 COPY_INSTEAD_OF_MOVE
cid#1555571 COPY_INSTEAD_OF_MOVE
cid#1555580 COPY_INSTEAD_OF_MOVE

Change-Id: Ia42a78bffddc80d0e82144f4db51dc6e4d2e9a1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171237
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-07-31 09:33:06 +02:00
Caolán McNamara
2a9ae69483 tools#1608074 silence Overflowed return value 
Change-Id: Id1db2d006a82e08e6e011be5c5fcfa515381ad44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171060
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-07-26 10:42:00 +02:00
Caolán McNamara
7f135227a9 cid#1556131 COPY_INSTEAD_OF_MOVE 
and

cid#1556135 COPY_INSTEAD_OF_MOVE
cid#1556146 COPY_INSTEAD_OF_MOVE
cid#1556164 COPY_INSTEAD_OF_MOVE
cid#1556171 COPY_INSTEAD_OF_MOVE
cid#1556177 COPY_INSTEAD_OF_MOVE
cid#1556181 COPY_INSTEAD_OF_MOVE
cid#1556182 COPY_INSTEAD_OF_MOVE
cid#1556183 COPY_INSTEAD_OF_MOVE
cid#1556192 COPY_INSTEAD_OF_MOVE
cid#1556201 COPY_INSTEAD_OF_MOVE
cid#1556208 COPY_INSTEAD_OF_MOVE
cid#1556215 COPY_INSTEAD_OF_MOVE
cid#1556224 COPY_INSTEAD_OF_MOVE
cid#1556227 COPY_INSTEAD_OF_MOVE
cid#1556228 COPY_INSTEAD_OF_MOVE
cid#1556238 COPY_INSTEAD_OF_MOVE
cid#1556246 COPY_INSTEAD_OF_MOVE
cid#1556247 COPY_INSTEAD_OF_MOVE
cid#1556288 COPY_INSTEAD_OF_MOVE
cid#1556293 COPY_INSTEAD_OF_MOVE
cid#1556305 COPY_INSTEAD_OF_MOVE
cid#1556310 COPY_INSTEAD_OF_MOVE
cid#1556317 COPY_INSTEAD_OF_MOVE
cid#1556321 COPY_INSTEAD_OF_MOVE
cid#1556322 COPY_INSTEAD_OF_MOVE
cid#1556331 COPY_INSTEAD_OF_MOVE
cid#1556339 COPY_INSTEAD_OF_MOVE
cid#1556342 COPY_INSTEAD_OF_MOVE
cid#1556351 COPY_INSTEAD_OF_MOVE
cid#1556358 COPY_INSTEAD_OF_MOVE
cid#1556370 COPY_INSTEAD_OF_MOVE
cid#1556379 COPY_INSTEAD_OF_MOVE
cid#1556390 COPY_INSTEAD_OF_MOVE
cid#1556423 COPY_INSTEAD_OF_MOVE
cid#1556532 COPY_INSTEAD_OF_MOVE
cid#1556561 COPY_INSTEAD_OF_MOVE
cid#1556662 COPY_INSTEAD_OF_MOVE
cid#1556704 COPY_INSTEAD_OF_MOVE
cid#1556730 COPY_INSTEAD_OF_MOVE
cid#1556988 COPY_INSTEAD_OF_MOVE
cid#1557071 COPY_INSTEAD_OF_MOVE
cid#1557081 COPY_INSTEAD_OF_MOVE
cid#1557177 COPY_INSTEAD_OF_MOVE

Change-Id: I2c723f0fe9a4eefa62a68f47049ed690d06eb0ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170932
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-07-24 22:12:32 +02:00
Caolán McNamara
309dc58aee cid#1555652 COPY_INSTEAD_OF_MOVE 
and

cid#1555655 COPY_INSTEAD_OF_MOVE
cid#1555658 COPY_INSTEAD_OF_MOVE
cid#1555665 COPY_INSTEAD_OF_MOVE
cid#1555667 COPY_INSTEAD_OF_MOVE
cid#1555670 COPY_INSTEAD_OF_MOVE
cid#1555675 COPY_INSTEAD_OF_MOVE
cid#1555684 COPY_INSTEAD_OF_MOVE
cid#1555687 COPY_INSTEAD_OF_MOVE
cid#1556539 COPY_INSTEAD_OF_MOVE
cid#1556542 COPY_INSTEAD_OF_MOVE
cid#1557448 COPY_INSTEAD_OF_MOVE
cid#1557449 COPY_INSTEAD_OF_MOVE

Change-Id: I3567528e559bca0031c4f5b46801e3130073633b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170448
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-07-14 15:16:40 +02:00
Yuki Joou
cfe6ce1656 tdf#145538 - related: Make tools::PolyPolygon iterable 
This patch allows tools::PolyPolygon to be iterated using c++11's
fancy range-based for-loops. It also upgrades a bunch of old-style
for-loops iterating over polypolygons to the new style to make code
more readable.

Note that not all for-loops iterating over polypolygons have been
upgraded, as I didn't find a way to automatically find those. I just
did a few I found manually.

Change-Id: Ifa8d0d44e6f0aa28fdcfd87d70058b12f48c1349
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168730
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2024-07-14 12:24:14 +02:00
Tomaž Vajngerl
02c91f82c2 move UniqueID to tools and rework to increase counter in constructor 
In the tools module it can be used in more other modules.

Changed the instantiation to increase the counter already in the
constructor, so no need to check if the ID is 0.

Also test for UniqueID

Change-Id: I77c80461875c69496a7e218534d16d6550c168c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170061
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2024-07-07 09:41:02 +02:00
Noel Grandin
039a18ff14 compute these using floating point 
which means we can avoid the checked_multiply complexity

Change-Id: I2badbde7bf9c6f18337913034b24672fddce3af8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168472
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-06-06 08:26:10 +02:00
Caolán McNamara
550e50c529 ofz#69290 Integer-overflow 
Change-Id: I20b49bf5e3a507979332cd854205f290a3b3971c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168118
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-05-28 13:10:34 +02:00
Noel Grandin
45f9627659 loplugin:ostr in tools 
Change-Id: I0e601100b034eaa99b08c7cbf09e5f817e69b507
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167736
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2024-05-16 14:49:58 +02:00
Noel Grandin
57dc0cbd8e do less OString->OUString conversion in tools datetime functions 
Change-Id: I93d012f32b8006019c431b8bf88ab9c7ffb4d3a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167574
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
 2024-05-13 14:44:19 +02:00
Noel Grandin
05d4420c5e createFromAscii -> OUString literals in INetURLObject 
Change-Id: I3c564f469635271d27fa0513d676241ce7ded51d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167573
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-05-13 13:05:57 +02:00
Noel Grandin
8b075d020c replace createFromAscii with OUString literals in INetURLObject 
Change-Id: Ibad8181624afd745e2fa501cdcc7a5d915dfe6ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167544
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-05-12 17:01:06 +02:00
Christian Lohmaier
0c4c84a14b makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo) 
…by a simple/static $(gb_CustomTarget_workdir)/foo

The build system has a lot of overly complicated leftovers from when it
was introduced and had not only deal with split repositories but also
had to coexist with another buildsystem. Along with lots of copy'n'paste
along the years the makefiles became hard to grasp for newcomers with
all our calls and evals.
As a first step to streamline that, the macros from TargetLocations that
simply prefix a static path to the argument (and similar of the same
kind) are a natural pick before simplifying the rules themselves/getting
rid of a bunch of eval statements.

Change-Id: Ia06dbbcd5d1994755a2ff05b84f72ccbc4e3cab5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167005
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
 2024-05-03 16:06:14 +02:00
Caolán McNamara
bea8576e82 cid#1596706 Dereference after null check 
Change-Id: If7156d9b0aaa392ff0c1e98dfdd4d05c6dcaabce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166982
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-05-02 00:13:32 +02:00