opening a DOCX with shadowing (w:shd) instead of highlight
(w:highlight), for example, a DOCX saved in LibreOffice.
This reverts also commit aa02ed306f
(tdf#106991: Highlighting remains after select no fill).
Change-Id: I0935694e3c309b5a450cd424fd398a88d13f8b22
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93082
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
This was added in commit bdfc6363d6
(n#793998 sw: add TabOverMargin compat mode, 2013-01-08), it's off by
default and on for MSO documents.
Change-Id: Ic97e711e4c8be507db71c49ffbdb63b40464c1bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93178
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
since librevenge's string class already has the length
Change-Id: I194ae49596dacc1205bdfb10d0a6a1833914f884
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93171
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Update helpcontent2 from branch 'master'
to 5999ae5b939b73fbb194547a7bd134859a3c8a43
- tdf#132534 Unmute l10nN in chemical formula
Change-Id: I8578cfe5b0752e997cd5d2c1c336e91315c2dedc
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/93185
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update translations from branch 'master'
to 2a61ce8496f6a5633af3ec710882358c3836abd0
- update translations for master
and force-fix errors using pocheck
Change-Id: I9bbea708cab941400c98f6a83b67215bb19469fa
The OOXML equivalent is <wp:positionV relativeFrom="bottomMargin">, and
the position is typically a negative number (i.e. the position is the
offset between the top of the shape and the top of the top or bottom
margin; not the distance and it's always the top of some margin).
Change-Id: Ia979bc8bfaa37d29b0947c4408335e0a80c05880
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93172
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
and reset preview idle when font list is cleared
Change-Id: Ice8c149754fbf64c9f81aa812465f0269de4c9d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93161
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
the default is very wide in the default gtk themes, try and minimize
that padding as the existing designs generally assume a very narrow
dropdown
Change-Id: Ibb3b0280067e981b7c782b6023fc3d36dbc0d364
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93167
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
using entry_width_chars to specify how much characters in the Entry to use to
show the font name makes the most logical sense.
Doing that would make the widget wider under gtk that is currently is, which is
arguably too narrow, but being wider would probably mean some toolbar contents
wouldn't fit on small screens generating complaint churn.
So, match the original width using LogicToPixel rather than
get_approximate_digit_width where the latter uses the width of the widest digit
in the font, and the former uses 1/8th the width of "aemnnxEM"
Change-Id: I1bb6970faa6fc34830681902640fe1f61e3cc55e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93151
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
The argv[0] passed to osl_setCommandArgs will then be the relative
path and osl::realpath() will fail. Instead, use
bootstrap_getExecutableFile() which calls _NSGetExecutablePath() to
get the executable's pathname for g_command_args.
Change-Id: I1345afe158d7b64871f6340733fb5490d5ca6bd8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93123
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Add the com.apple.security.get-task-allow entitlement when not
building for release.
Change-Id: I1b05d8c48f0f2d587325d7dfc800bb4880a7fcaf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93159
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
No warnings required for unknown tags, so better go with SAL_INFO
Change-Id: Ie9269161d485c457d81b8c2b94a952b5025a46c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93164
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
For zoom > 2.0 and zoom < 0.5 the scaled dropdown looks either
too oversized or tiny and makes the ui look unpolished, so the
zoom factor is trimmed between this range and then used to scale
the validation window.
Change-Id: Ic69383f273cb32670b6012f59715250dbfcf627c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92915
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit a87e78df63)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93067
Tested-by: Jenkins
The validation dropdown looks ugly for lists with small number of
items as its height is hardcoded to
SC_FILTERLISTBOX_LINES(=12) * TextHeight
Instead lets use the number of entries in the list to determine
the height if this count is less than SC_FILTERLISTBOX_LINES
Change-Id: If026140044e6665159cd616c13a2eb57356ae53f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92914
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit adf10bae8a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93066
Tested-by: Jenkins
Reverse the zoom scale on the position of the dropdown before
letting the vcl::FloatingWindow convert this to twips without
any scale information. Without this reverse scaling, the
dropdown will be incorrect due to double application of the same zoom
(one in core and one in client).
Change-Id: I73de12593b13e1bc9fb0514bec23c20d440d8923
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92913
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit a68bfe87f6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93008
Tested-by: Jenkins
Mulit-line label split, Build realized as link_button
Required changes also solve tdf#132066 partially as many
localized strings are not anymore copied to clipboard
Change-Id: I346fdc65cd1734f17854eccd587fe0b7e216e720
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93119
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Add a unit test
Apply autofilter to data if there are no changes from the user for
AutoFilterMode::Normal mode
The condition
eMode == AutoFilterMode::Normal
at that position is equivalent to
eMode != AutoFilterMode::Top10
&& eMode != AutoFilterMode::Empty
&& eMode != AutoFilterMode::NonEmpty
because
- Top10: Excluded in if()
- Custom: Already handled before
- Empty: Excluded in if()
- NonEmpty: Excluded in if()
- SortAscending: Already handled before
- SortDescending: Already handled before
- Normal: The remaining condition
Delete dead code:
The condition
if (mpAutoFilterPopup->isAllSelected())
will never be true since
eMode == AutoFilterMode::Normal && mpAutoFilterPopup->isAllSelected()
is excluded in the "outer if condition"
!(eMode == AutoFilterMode::Normal && mpAutoFilterPopup->isAllSelected())
Moreover aParam.RemoveAllEntriesByField(rPos.Col()); has already been called
before.
Change-Id: I1a5362f6edf6d28b3e049977d761cef83897e63e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91645
Tested-by: Jenkins
Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de>
Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de>
It was added in the hardened_runtime.xcent that is used for
LibreOffice distribution for macOS outside the App Store already last
year.
Note that it is plausible that the mention of the extension manager in
the comment in hardened_runtime.xcent is a red herring, and that it is
just a coincidence that some extension manager code that runs early when
LibreOffice is starting is the first code to make use of the dynamic
machine code generation in the C++/UNO bridge.
Change-Id: I90a48d585efee27a215d77e5db45d3cda5c8fedc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93122
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Formula alignment was not handled at all.
Now "oMathPara", "oMathParaPr" elements
and m:jc attribute are handled using paragraph
alignment, as a workaround.
Co-author: Tibor Nagy
Change-Id: I71546755492e0f9187c77f5324bada6f3c68f0dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91435
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
The import of underline color was unhandled.
Co-Author: Szabolcs Toth
Change-Id: I47dce90966c7130ca67941ee47b0e4b2ba7eb972
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93108
Tested-by: Jenkins
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
* Update helpcontent2 from branch 'master'
to 698b678fff3ce1c596196a3ca6cf8b16c5d108e4
- tdf#131382 scope of function (Calc or BASIC)
Change the heading to indicate BASIC function and not a
CALC function
Change-Id: I4dc14ed0d8bb585d99e30cf72f255a523affc9b0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/91005
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update helpcontent2 from branch 'master'
to 4d6b5e5f74c50cc440a46fada8fa89ad2f946749
- Apply module brand color to Help page
Change page header and headings to module colors
Module colors from branding wiki page
https://wiki.documentfoundation.org/Marketing/Branding#Colors
Based on ideas of Beatriz Fonseca (@beatorizu)
betrizaf@gmail.com
Change-Id: Ia855872185a9c5ff6bcf3c351cc78e57e5a7901c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/93100
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
This is useful for checking in uitests whether the infobar exists
Change-Id: I436c2659abd40756673634f7cd1f8e4846c03836
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92635
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
The problem was that the cell margin that overrides the
table defaults was only being applied to one cell,
while a range of cells might be defined.
a sprmTCellPadding is specified by a CSSA.
The CSSA starts with an ItcFirstLim, which consists of
a start and end cell. The end cell is NOT included.
Change-Id: Ia90bc28451d39d60ce343d24b02fd3661b05d950
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92628
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
...which had been introduced with 0f2f719ccd
"tdf#106324: Remove unnecessary test folder from LibreOfficePython framework",
but had apparently forgotten to touch the target file when done, so any make
target that would (indirectly) depend on it would keep rebuilding python3 et al.
Change-Id: I0ac3611383c82c4e91a1eaa02e4cf5db28d326fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93117
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
The changed code is used to initialize data before processing first
pixel of each row/column of the bitmap, since in order to blur it,
we need some information about assumed previous pixels. But previous
code assumed that information for the first pixel or each row and
each column is taken from first pixels of first column, not from
first pixels of respective row or respective column. This doesn't
make practical difference for the pre-extended bitmap with a solid
color of the border (see centerExtendBitmap; it's the only actual
case ATM). But in case of not pre-extended bitmap with non-solid
border color, that would result in wrong blur of first pixels.
Consider this bitmap (* is white, 0 is black):
*00000000
*00000000
*00000000
*00000000
*00000000
000000000
...
For this bitmap, existing code pre-initialized each row and each
column as if it were prepended with "******" from column 0, and so
each first pixel of each column and each row would be blurred with
white, even where it's all black (consider columns >=1, and rows
>=5).
Additionally, the existing initialization assumed that there's
always at least as many scanlines as min(radius, bmpWidth), which
might be false. See how aArrays was initialized using nLastIndexX
in stackBlurHorizontal, and then that value affected the index
passed to pReadAccess->GetScanline.
This changes the code to consistently consider first pixels of
respective rows/columns for pre-initialization data.
Change-Id: Ibe3be8750fe5347302eca782a00b36096d99820c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93118
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
like TextCharAttribList::FindAttrib does which spell checking
used before
commit 243b5b3929
Author: Caolán McNamara <caolanm@redhat.com>
Date: Fri Jun 14 21:56:44 2019 +0100
weld SpellDialog
converted to use an EditEngine instead of a TextEngine in order to
be able to host it in a native widget
Change-Id: I190429fdab6e32572f2d6df94ab8e375bb4c0c61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93085
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
And format code inside
Change-Id: Ied0d98935134bf6f7bc8c929645ad5faac9affa3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93116
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* make cache size configurable (defaults to 15)
* have one cache object per PDFWriter instance, thus avoiding
accidentally caching JPEGs with different compression settings
Change-Id: I6664fc09b382f471cbe7c3e7aaedb3ebb5883b47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93112
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Prevent a feedback-loop, where LibreOffice would request a shorter timeout on
each refresh.
WebDAV servers do not return the lock-timeout the lock was set up with; they
have to return the remaining time. There are WebDAV servers that return a lower
timeout. Two examples [2] [3]. Other servers probably reuse the same timestamp
for the whole request and are therefore not subject to that problem. (This might
even be incorrect if the request takes very long.)
Updating the lock-timeout with the value returned by the server decreases the
timeout until it reaches zero.
LibreOffice request SERVER response
LOCK(180) -> LOCK(60)
LOCK(60) -> LOCK(59)
LOCK(59) -> LOCK(58)
...
0: no LOCK header -> FAIL
If we do not update the timeout in NeonSession::LOCK() only the initial setup
updates the timeout.
LibreOffice request SERVER response
LOCK(180) -> LOCK(60)
LOCK(60) -> LOCK(59)
LOCK(60) -> LOCK(59)
...
It is essential that lastChanceToSendRefreshRequest uses the timeout returned by
the server; after it calculated the deadline, we reset the timeout.
The maintainer of neon confirmed that the timeout should stay the same after the
initial setup. [4].
[1] https://tools.ietf.org/html/rfc4918#section-6.6
[2] https://www.alfresco.com/
[3] https://github.com/mar10/wsgidav
[4] https://github.com/notroj/neon/issues/12
Change-Id: Ie76338f7a88f41f47569a62ea6efec8c6f646f50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92981
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
No docs found after a year or so.
Change-Id: I303ecc6fa24216c8f1c7ff9fa2bb70c1a84f2292
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93004
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
