Commit graph

449129 commits

Author SHA1 Message Date
Tomaž Vajngerl
029194643d drawinglayer: extract constant in renderWrongSpellPrimitive2D
Change-Id: I131e2d5620d027f32dc2929cd12fedb168e30e9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93390
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-04 08:43:35 +02:00
Tomaž Vajngerl
2f844056c3 drawinglayer: flatten renderWrongSpellPrimitive2D
Change-Id: I93ff19f9f54b6f14c660af554d697b9ba525f81c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93389
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-04 08:43:21 +02:00
Tomaž Vajngerl
e4f72f8466 remove helperwrongspellrenderer.{cxx,hxx} from clang-format blacklist
Change-Id: Ib0b1f389189012ab27dd061481737ac6a6a1a84e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93388
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-04 08:43:03 +02:00
Tomaž Vajngerl
a57a6d145f pragma once in helperwrongspellrenderer.hxx
Change-Id: I25aac069b9212824fee50240a1b6682bf7e6f0f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93387
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-04 08:42:46 +02:00
Tomaž Vajngerl
e360fb8a31 organize includes in vclpixelprocessor2d.cxx
Change-Id: I1590e437946aaa4bd3a8b6a2c47d2ee17d2060a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93386
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-04 08:42:10 +02:00
Tomaž Vajngerl
94d5587e01 organize includes in vclprocessor2d.cxx
Change-Id: I1117eb86823762882d463c6e4d3b295efaa3151c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93365
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-04 08:41:55 +02:00
Tomaž Vajngerl
8e63a3623a dl: replace OSL_ENSURE with SAL_WARN_IF in impBufferDevice
Change-Id: I457b9310109157da03b6c310783651f5232d2054
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93364
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-04 08:41:20 +02:00
Tomaž Vajngerl
f256d5d5cb drawinglayer: remove aBuffer typedef in VDevBuffer
Also use back() method on vector instead of end() - 1

Change-Id: I944691d097f82b1651cff87a7bb0d7c457ece27a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93363
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-04 08:41:05 +02:00
Tomaž Vajngerl
e5889bb63a remove vclhelperbufferdevice.{cxx,hxx} from clang-format blacklist
Change-Id: I0ab6572ab700756322f96b982f7faeb6d8dc9fb6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93362
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-04 08:40:50 +02:00
Tomaž Vajngerl
1a86c041cd pragma once in vclhelperbufferdevice.hxx
Change-Id: I12e53849fa23496799ba5e45fc0077cb9b54048c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93361
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-04 08:40:17 +02:00
Andrea Gelmini
b6caf887c6 Fix typo
Change-Id: Ic084ebbc04731b362bac0cf51e4b2bbdf5ef0526
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93208
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-04 07:18:39 +02:00
Andrea Gelmini
a162f0f036 Fix typos
Change-Id: I63ae6adec1967bcf888538437e5e88f0acdea66e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93392
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2020-05-04 07:01:22 +02:00
Olivier Hallot
b58b06fdc5 Update git submodules
* Update helpcontent2 from branch 'master'
  to 45490e779509af867ed9da186f834cc868d518db
  - tdf#132630 Hide Whitespace -> Show Whitespace
    
    Change-Id: I9a14cce825874338b87b5f82f55c52f661e7a877
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/93346
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-04 03:54:53 +02:00
Caolán McNamara
00db5933de use SfxStyleSearchBits::All for GenerateUnusedName
use in SfxManageStyleSheetPage is definitely with
SfxStyleSearchBits::All applied. It seems almost certain that
use in SwDocShell::ExecStyleSheet would prefer that

Change-Id: I245c3f02bcce87f124bf0e507b59738a6dff34d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93354
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-03 22:44:21 +02:00
Caolán McNamara
a9102a1c63 explicitly pass SfxStyleFamily to GenerateUnusedName
Change-Id: I7879578383d58cb65441c9049e91e33bb4827afb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93353
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-03 22:44:08 +02:00
Tomaž Vajngerl
28609e1017 vcl: simplify graphic type detection for EPS files
Change-Id: Ia48560274c33aaa8e81a5ee6eb00f6470e92e0fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93349
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-03 22:16:34 +02:00
Tomaž Vajngerl
fe98579520 vcl: add test case for EPS file detection
Change-Id: Ia6a4cedf5c570e5d9544887ae66da0ec1e491647
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93348
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-03 22:16:06 +02:00
Andras Timar
3cf06b8f32 setuprc has to be a .PHONY target in order to get the current git hash
Change-Id: I7962966b9e0075715e419a375c74283e2a771e01
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93367
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-03 21:57:32 +02:00
Caolán McNamara
e3517eefed Related: tdf#130108 expand single arg SfxStyleSheetBasePool::Find uses
remove it and expand its uses to explicitly show what it does

Change-Id: I2d4511c58b51003c327a2c70e3cc4f60751f520d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93352
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-03 21:28:50 +02:00
Caolán McNamara
454a3c945f Resolves: tdf#130108 ensure we don't reuse the last SetSearchMask setting
Change-Id: Iddc4438b8bd30576be4531d47b6be0ac70847a9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93350
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-03 20:07:48 +02:00
Andras Timar
18f9d47e83 Update git submodules
* Update translations from branch 'master'
  to 704f999109b58d58954585e970c8896b18803557
  - Updated Slovenian translation
    
    Change-Id: I8b7bf5de319cc6f31b6e01209378537f7f9286ec
2020-05-03 19:43:37 +02:00
Tomaž Vajngerl
bb459008de vcl: add DetectorTools + tests, refactor array string matching
Add DetectorTools with byte array searching and matching to a
input string (or another byte array). This refactors the existing
function in GraphicFormatDetector. It needs to go into its own
header so that the function(s) can be tested easily. Replace
the previous searchEntry implementation with refactored one in
the source code.

Change-Id: I59d30b694e13f28d6366f1a99fe2ef2ea3c1a07d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93339
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-03 19:37:13 +02:00
Tomaž Vajngerl
76803b3703 vcl: extend TypeSerializerTest for Graphic serialization
Add test case for Animation and GDIMetaFile serialization.

Change-Id: Ibe2fa9982c8faea36e1f26ca9c6b735ae0ebd8ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93337
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-03 19:36:48 +02:00
Caolán McNamara
9a87be3055 Resolves: tdf#131898 we only want the text from column 0
in the fallback file picker

Change-Id: I60527661f83fde135145249a14b4f3b35840fff8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93347
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-03 17:44:52 +02:00
Tomaž Vajngerl
c90f39f939 vcl: Simplify searchEntry in GraphicFormatDetector
Makes the code much more readable..

Change-Id: I99d89652bda4ac74c867d70ec565403510c58c61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93338
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-03 17:28:38 +02:00
andreas kainz
1411998edb Templates: add simple writer template
Change-Id: Idfd6e13ed5d5bfb76a8aed492abcdbb7d15e94aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93336
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-05-03 13:06:09 +02:00
andreas kainz
72d29798fa tdf#132623 custom property dialog expand update
Change-Id: Iab659269942853ed330ef65fbcb1e0155b3b24cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93335
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-05-03 13:05:40 +02:00
Tomaž Vajngerl
1114ebb374 vcl: add Graphic reading to TypeSerializer + tests
Change-Id: I73aafc4f9a6f964a31d116610df6cf15dc51770c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93334
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-03 13:04:51 +02:00
Tomaž Vajngerl
92b0a4d933 SdrPdfImport: rename ImportText to InsertTextObject
There are two ImportText methods, so rename one to something
else to avoid confusion.

Change-Id: I1ccc491fca47b2d72ba1f7bd5a75d325819ec041
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93333
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-03 11:10:23 +02:00
Tomaž Vajngerl
09e2800837 move unit conversions to UnitConversion, add convertPointToMm100
Change-Id: I3e5a4632e9809562885c1e0ec5c5262acec145d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93332
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-03 11:10:04 +02:00
Tomaž Vajngerl
d4190effb9 SdrPdfImport: fix garbled text at breaking the PDF graphic
The text size of OUString expects no. of characters, but we give
the number of bytes as that is what we get from PDFium. Best to
just not give the text size at all and let OUString determine
that as the text shouldbe terminated correctly.

Change-Id: Icc5cd6e851a9d2920faa9ca2eb6d827465483e72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93330
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-03 11:08:59 +02:00
Tomaž Vajngerl
9e3da9e3bc SdrPdfImport: rename some variables to non-abbreviated names
Change-Id: I1cb004a8e426f8ea26bb930d4897db3763433b31
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93329
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-03 11:08:39 +02:00
Noel Grandin
47cd34a60f use more compact namespace syntax in /include
excluding the UDK headers of course

Change-Id: Iac7ab83d60265f7d362c860776f1de9d5e444ec0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93268
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-03 09:21:51 +02:00
Tomaž Vajngerl
c79dd92480 vcl: add Graphic serialization (writing) to TypeSerializer + tests
Change-Id: I3c4845550e776c4c2c891d94db71bacea27c9a37
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93328
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-03 08:22:45 +02:00
Julien Nabet
18c97df0dc Related tdf#131125: Improperly used ampersand
Really search all occurences of Find & Replace

Change-Id: I1c1301451afa4d339902a275594ecb4cd46030db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93331
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-05-03 07:01:08 +02:00
Pranam Lashkari
cbe86ee370 Added separate color picker for slide background gradient
Change-Id: I27b60244f011cb482affa5f47cde170daf3fc309
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92889
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-02 23:22:06 +02:00
U-LAPTOP-LENOVO-H\marco
550f564d16 Update git submodules
* Update dictionaries from branch 'master'
  to c51a343b3c4c19e57ef3d9b7ceca94d3d4146dfb
  - Updated the English dictionaries: GB
    
    Change-Id: I7f5a6732dd4f8a8105fbf628e849ce7ec4c93955
    Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/92929
    Tested-by: Andras Timar <andras.timar@collabora.com>
    Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-02 23:21:01 +02:00
Tomaž Vajngerl
b8ab04486f vcl: test Graphic serialization to a stream - WriteGraphic funct.
Change-Id: Ic365d27e9ef1c676e47de22b8949b5679c0a2841
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93326
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-02 22:55:29 +02:00
Tomaž Vajngerl
151c026e43 cleanup namespaces in pdfdocument.hxx
Change-Id: I861a9ef81cda439a17d6d085cf59ace7860f79d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93325
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-02 22:55:12 +02:00
andreas kainz
df08f2d69e Template: Add Simple writer template style
Change-Id: I6fdf8241d740929a6548029f6926b32ead409d84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93327
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-05-02 22:50:16 +02:00
Xisco Fauli
3b30c934bb tdf#106724: sw: Add unittest
Change-Id: Icb65e69a92bd1bbad8db945bf91153eb5c730d23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93314
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-02 22:27:14 +02:00
Tomaž Vajngerl
4505bc1701 test import and export of multi-page PDF with PDFium filter
The test checks that the exported PDFs contain embedded PDF for
different pages.

Change-Id: I4e5cd108d8597851d86aa774efbde0d4f2b9d2ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93322
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-02 21:47:49 +02:00
Tomaž Vajngerl
e1c79efa64 remove vclpixelprocessor2d.cxx from clang-format blacklist
Change-Id: I03ad72d0754cb8c180f4eab0e8040c3dab533ef9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93321
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-02 21:41:50 +02:00
Tomaž Vajngerl
47ee147e28 remove vclprocessor2d.cxx from clang-format blacklist
Change-Id: I359dfb0fe6fdf88e9c8141186a770c4cde777161
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93320
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-02 21:41:36 +02:00
Tomaž Vajngerl
f1d90767ea vcl: PdfExportTest rename topdf method to saveAsPDF
Change-Id: Id26a79fa047f1f6d26cab1f08e1db57330d4168b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93319
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-02 20:50:15 +02:00
Jim Raykowski
9ba0df5d3c Resolves: tdf#132477 Fix Writer Navigator drag and drop crash
Dont allow drag and drop when tree root is selected

Change-Id: Ia5b8c07861c4ac9b0e4632ccc09e1cd9211e2a8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92962
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-02 20:25:30 +02:00
Caolán McNamara
ce019a60c0 Related: tdf#132477 use GDK_KEY_Escape to cancel dnd
simply calling gtk_drag_cancel on the treeview dnd under X doesn't seem to work
as hoped for (though under wayland all is well).  Under X the next (allowed)
drag effort doesn't work to drop anything, but a then repeated attempt does.

But sending an Escape keyevent to get gtk to cancel the drag for us does work
as hoped for.

Change-Id: I09d3187e66774f9d23c77e0d515af7ae2a8fe156
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93317
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-02 20:17:10 +02:00
Caolán McNamara
b2dfc44c5c use revenge instead of librevenge
Change-Id: I3ec4d8b5e508653668bee3567e32f0920f56e3b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93313
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-02 20:16:31 +02:00
Caolán McNamara
0db6e58fd4 Resolves: tdf#132604 GtkToolButtons that should be GtkToggleToolButtons
Change-Id: Ie481fd0599e0cbd22ea1be7e353016f951837a1a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93318
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-02 20:16:15 +02:00
Caolán McNamara
d8c77a54ce cid#1401342 silence Uncaught exception
Change-Id: I961d68bc02ed22ab446dabbc6073df8ddf6730f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93312
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-02 18:29:26 +02:00