Switch to '-z $LIB_FUZZING_ENGINE' to check if LIB_FUZZING_ENGINE is
set. The previous version evaluates to false when LIB_FUZZING_ENGINE is
not set, meaning you would not be warned at configure time when using
-enable_fuzzers without setting LIB_FUZZING_ENGINE.
Original broken version landed in:
44b36a0602
( https://gerrit.libreoffice.org/c/core/+/111691 )
Change-Id: Ic2174777ebf724e471cd605ba54b245e4e804705
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118372
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
so this is Logically dead code
Change-Id: Ieede7331bf2639610ad7a3a983a87263d291c75d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118352
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
See also commit a2e964afc5, doing the
same for DOC.
Change-Id: Ib0ddb36de8589f9264fe857b20a6ef2aa2607c52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118369
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Otherwise, the document's keywords will be duplicated since the first
keyword is written twice. Regression from I19eba57bc6058c317473d0746f06699a09ba2830.
Change-Id: I4c6f840b6e095ca9eaf5ffb53af07280b901e28d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118358
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Otherwise CppunitTest_sw_odfimport testDateFormFormats fails with
- Expected: Wednesday, March 4, 2020
- Actual : Wednesday, March 04, 2020
if DateFormatter uses number formatter.
This is also what
https://www.localeplanet.com/icu/en-US/index.html
lists for Date.0 and formatindex="30" has as well.
This makes adapting CppunitTest_svl_qa_cppunit testNumberFormat
necessary.
Change-Id: I1c8cfd954f34f742b0397b8f922d22eb11ae19f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118361
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
/** If a value is a valid argument for sin(), cos(), tan().
IEEE 754 specifies that absolute values up to 2^64 (=1.844e19) for the
radian must be supported by trigonometric functions. Unfortunately, at
least on x86 architectures, the FPU doesn't generate an error pattern for
values >2^64 but produces erroneous results instead and sets only the
"invalid operation" (IM) flag in the status word :-( Thus the application
has to handle it itself.
*/
chart2/source/tools/RelativePositionHelper.cxx
Function name: RelativePositionHelper::getCenterOfAnchoredObject
From here: suppose it's related to the orientation of the chart << 2^64
chart2/source/view/main/LabelPositionHelper.cxx
LabelPositionHelper::LabelPositionHelper
Suppose: setup label position.
There won't be angles grater than 360º.
chart2/source/view/main/PlottingPositionHelper.cxx
PolarPlottingPositionHelper::transformUnitCircleToScene
Suppose: maybe disc chart orientation?
Internal angle should be safe.
chart2/source/view/main/ShapeFactory.cxx
ShapeFactory::getSizeAfterRotation
Suppose: rotate shape
Internal angle should be safe.
drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
Constant 100% safe
sc/source/core/data/documen4.cxx
bool ScDocument::Solver
Suppose: the tangent is being used as numerical derivative (Regula falsi algorithm)
So no impossible angles
scaddins/source/analysis/bessel.cxx
Filtered it out as bad imput
Change-Id: Ib348cca6ce13263d087b6731f93f58d8a15cc725
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118193
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
and "Apply and Edit Changes".
Transliteration worked only during typing, because
AutoCorrect->Apply and "Apply and Edit Changes" remove
right-to-left text direction silently, which resulted
missing transliteration of text (with Default Paragraph
Style and right-to-left direction) to Old Hungarian.
Change-Id: I1481d958494828b6dce66f2eeecb44b327c70db4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118346
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
The SrcRect could be specified outside of source bitmap.
In such cases the Destination bitmap should be displayed as shifted
(eg. if position is negative), and scaled properly.
Change-Id: Ied6d339703999faaae061802ef6a28e190d5a176
Change-Id: Ia9772ced282684c2c94a261d97d30b53921d6171
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118345
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
If Options → LibreOffice → Security → Security Options
and Warnings → Options... → Security Options → Remove personal
information on saving" is enabled.
Use the same time (Unix epoch) for mandatory time stamps, and
replace authors with "Author1", "Author2", ... and creator-initials
with "1", "2", "3" etc., also to avoid of joining adjacent redline
ranges.
Note: to see the work of the unit test in Linux command line:
(cd sw && make UITest_writer_tests7 UITEST_TEST_NAME="tdf90401.tdf90401.test_tdf142902_remove_personal_info_in_DOCX" SAL_USE_VCLPLUGIN=gen)
Follow-up to commit 12da70f885
"tdf#90401 xmloff: remove personal info of comments and changes".
Change-Id: Ice996f171f5d82d13ce0ea2e4833696af0aab90c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117444
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Used programmatically with number formatter's NF_DATE_SYSTEM_LONG
but quite some locales were lacking the day of week; maybe legacy
because duplicated formats sometimes were avoided, which nowadays
are suppressed in the number format dialog. Made the format code a
copy of formatindex="30" explicit DATE_SYS_NNNNDMMMMYYYY.
Didn't know what to do about lt_LT so kept that as is.
This made it necessary to adapt a dreaded UITest_writer_tests5
test that checks for listbox content,
test_date_field_with_custom_format, which depends on actual locale
data. See comment there.
Change-Id: Ifc26a4a5be6bed3fb8d9cedc1afcba1225751635
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118335
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
It is better to do this more intensive check AFTER
the "continue" clause - since both those conditions
need to be true anyway in this section.
Change-Id: I6051832c207fbfd402c00cab4ed1a8ed662c1b12
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118341
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
related to work being done for tdf#104239.
This should practically be an NonFunctionalChange
that just avoids some unnecessary processing.
Unit tests prove that these semi-defined styles
are still necessary for inheritance etc.,
but they shouldn't need to be used for selecting
the outline numbering.
The "continue" that I am moving was first added with
commit d6078b0843
Author: Caolán McNamara on Wed Aug 27 09:19:30 2014 +0100
OutlineStyles can only be Paragraph Styles
which probably just failed some automated tests,
so that suggests there is plenty of room for improvement here.
Change-Id: I5d4d6ba374f0f271b5248fef3d2d8c0ce62082cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118342
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
It's just used for a singke assert and SalData is generally just
used as a static cast.
Change-Id: I8d74e82e511413d940a3f200f022a9204e588cd7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118288
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
This simplifies iteration over the test files, and avoids relying
on file URLs being the same (e.g., having no /./ segments).
Change-Id: I227785806e474a3a2dffeb46df21617eae43327e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118329
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
This reverts commit ff641dc9e4.
Reason for revert: This patch is wrong, when close_button is set, the exceptions will be caught here so the test won't fail
Change-Id: Id884abe70ab5602f914742e91bb2ed644c23b041
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118303
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* Update helpcontent2 from branch 'master'
to 86d4cff5887833253bcfe95ecdb1689ef810315c
- tdf#102523 Improve Advanced Filter help page
This patch embeds the page specialfilter.xhp and 12040201.xhp into the 12040300.xhp file, which is the landing page when the user clicks the Help button in the Advanced Filter dialog.
As a result, the landing page now covers all the features in the dialog and also presents a useful example.
This also updates the .tree file.
Change-Id: I25d31838fa2604851962fdf8200b887255489017
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118191
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
This addresses a comment of Jan-Marek Glogowski on commit
3262fc5ef3.
Change-Id: I0a94ad08d035fd23c0adb5bc53fccdcbc0173e1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118324
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
This also fix the problem of basic_coverage tests not showing
the results when they were failing, since doUnitTest
returned a Integer
Change-Id: I637cd4cfaa34047bc99bfe6e0930f2945f1a9315
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118234
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
a little but to have less arbitrary numbers in it
Change-Id: Id386616a31c69ebcdea7e97a62a3067bb2fbf60b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118315
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
DOCX body text can overlap with header/footer, if top/bottom
page margin is negative. To support this, convert header/footer
text content to textbox anchored to header/footer, if needed.
Note: possible improvements:
1) Skip this hack, if the header is small enough to not overlap with
the body, calculate only the height of the header at the import time.
2) This hack does not fix the case when the top of the header
is under the top of the body. (A problem in DOC import, too.)
This could be achieved by repositioning the dummy header to the top,
and lower the textbox by the same amount. (This would still not
resolve the extreme situation, when the body start from 0 mm
(in LibreOffice, header must be at least 1 mm).
3) Import of VertOrientation::BOTTOM property seems to be bad,
or at least the footer loses this property after a DOCX round-trip,
resulting bad footer position.
4) after a round-trip, the 1 mm height of the dummy header
increases to 1 line height. Also the "Autofit height" and
"Use dynamic spacing" settings are changed, likely related
to their missing DOCX export.
Co-authored-by: Tibor Nagy (NISZ)
Change-Id: I8319c93c6c5a980878ee9956c8ab2953da60409e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117842
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
In the bullets and numbering dialog, don't show the filename including
its extension in the tooltip of the image.
Change-Id: I2a37f79e8c57d3126e6607f01756771857440faa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118215
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
In the bullets and numbering dialog under customize, don't show the
filename including its extension in the context menu of the gallery.
Change-Id: Ia3d4277f5b074be78244f0599883f36385a40c8a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118218
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
