Commit graph

501767 commits

Author SHA1 Message Date
Aron Budea
10f3e7f602 tdf#163486: PVS V1028 Possible overflow. Consider casting operands,
...not the result.

Change-Id: I4ba8afa5989aea906000bb9c4059855015055002
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177042
Tested-by: Jenkins
Reviewed-by: Aron Budea <aron.budea@collabora.com>
2024-11-23 06:39:52 +01:00
Balazs Varga
869fff459c Related: tdf#160517 - chart odf: import/export formatted chart titles
No need to check chart title paragraph style name and ID, since its
never exists.

follow-up of:
d7214aba95
6fdad72372

Change-Id: Ieffe3026adc848cfbf3a847b4f876b5aa2e2a026
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177011
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
Tested-by: Jenkins
2024-11-22 21:58:13 +01:00
Christian Lohmaier
bbad335816 bump product version to 25.2.0.0.alpha1+
Change-Id: If5be3912a516f279ada6f6b5d82b927701a0ac16
2024-11-22 21:06:27 +01:00
Caolán McNamara
d7cfb08c1f cid#1634864 avoid Missing move assignment operator
and

cid#1634866 Missing move assignment operator

Change-Id: Iaf588bdd9185da6afeee26eea0607e72a9792bab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177045
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-22 20:34:31 +01:00
Caolán McNamara
36c2ce1344 cid#1608081 silence Overflowed array index write
Change-Id: I40d4207eafe46736a122e07c56f6db94cb517697
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177044
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-22 20:34:25 +01:00
Noel Grandin
437aaf54c6 loplugin:unusedmethods
Change-Id: I24666a7746f8920ddf84731f204f3e1a5b9b0c85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177024
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-22 20:03:48 +01:00
Noel Grandin
d1e8e430db loplugin:unusedfields
Change-Id: I9ee946ceabf59e4126db938d6abda446fcf9ce36
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176994
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-22 20:03:37 +01:00
Noel Grandin
0c7c2716db loplugin:methodcycles
found cycle
    FmEntryData::FmEntryData(const FmEntryData &)
    svx/source/inc/fmexpl.hxx:148

    FmFormData::FmFormData(const FmFormData &)
    svx/source/inc/fmexpl.hxx:230

    FmControlData::FmControlData(const FmControlData &)
    svx/source/inc/fmexpl.hxx:252

    std::unique_ptr<FmEntryData> FmEntryData::Clone()
    svx/source/inc/fmexpl.hxx:161

Change-Id: I2bef463f62b4513c473bb99eb999a97e99f5e602
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176993
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2024-11-22 20:03:28 +01:00
Christian Lohmaier
2fe487b20e add Santali (Ol-Chiki) languagepack (sat-Olck)
Change-Id: I6cdc09f1c44acf3c7e2d8b24ccb5a73f175acbc6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177043
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-11-22 19:08:52 +01:00
Christian Lohmaier
351e6e17e0 Update git submodules
* Update translations from branch 'master'
  to 096ea211364abd9f3a59671796e3aabb093faf54
  - add translation files for Santali (Ol-Chiki) (sat-Olck)
    
    Change-Id: Ic6efa6bfeee7fbd70c8fd629e3e7f87c8e840f8d
2024-11-22 17:48:14 +01:00
Christian Lohmaier
e49e878d82 Update git submodules
* Update translations from branch 'master'
  to 318e92fb60edf7a9889cac87bd0489123553ce1d
  - update translations for master/25.2.0 alpha1
    
    and force-fix errors using pocheck
    
    Change-Id: Ie52bd18e7f82e90d5095b195ffbf6bbc4f84e254
2024-11-22 17:42:36 +01:00
Xisco Fauli
90c25e5912 PVS: V547 Expression 'bComplete' is always true.
Since
commit 47527821f3
Author: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
Date:   Mon Nov 16 22:17:07 2020 +0100

    SwGrfNode: Remove graphic arrived hack

Change-Id: I7c0a3b0208d2da06781be6b69e04e9958b762870
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177036
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-22 17:07:11 +01:00
Michael Stahl
ea1d0a62d9 sw: do not paint hidden frames' borders
SwFrame::PaintSwFrameShadowAndBorder() is called by upper's
SwFrame::PaintSwFrameBackground() so it needs another check.

(regression from commit ff7f1b59e2)

Change-Id: Ic7ac28e4af8e0abf4970d87edb40a79ad4d25156
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177032
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-11-22 17:06:40 +01:00
Xisco Fauli
c80cbceeed PVS: V547 Expression '!aPropertyStates.empty()' is always true.
Identified by M. Kaganski

Change-Id: I02c3ab0ec29367ebc2e73586044d729eab24231d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177029
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-22 16:55:00 +01:00
Xisco Fauli
f3a302043b PVS: V1048 The 'bRet' variable was assigned the same value
Change-Id: Idbd94e0eb49819f737a90bcb161cd3dd88f24221
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177014
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-22 16:54:18 +01:00
Tomaž Vajngerl
180a99d9ff Render objects that are in an animation as a separate layer
Change-Id: I4220b8398e75589bd54b67942cf987244b1d0b0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177035
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2024-11-22 16:51:26 +01:00
Julien Nabet
a680e71b50 tdf#163486: PVS V1043 global object variable is declared in header (starmath)
Change-Id: Ieb038d21f27c7d31362be44b71fd13e2932fcf69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176995
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-22 16:35:42 +01:00
Patrick Luby
97c0797cf3 Revert "tdf#163945 present drawable immediately"
This reverts commit 32eb29377c.

Reason for revert: Original commit did not fix tdf#163945

Change-Id: Ie66edde40ed44f89bb28043db074fab7e6e06a49
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177025
Tested-by: Jenkins
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
2024-11-22 15:21:54 +01:00
Xisco Fauli
026e52441b sw: no need to pass a bool as a reference
Change-Id: I62aabd66d368856959be032d866888b82b018dd9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177018
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-22 15:19:42 +01:00
Xisco Fauli
a57d16d524 PVS: V1048 The 'bTestAllowed' variable was assigned the same value.
Change-Id: I8322b68ce93adedbcb5ae2462b5ed1868d3552db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177013
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-22 14:54:08 +01:00
Andrea Gelmini
e85d48c90e Fix typos
Change-Id: I49cf90c401243c9606372735ad160f5f2b63b603
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177026
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-22 14:28:50 +01:00
Julien Nabet
b86368d712 tdf#163486: PVS V1043 global object variable is declared in header (sw)
Change-Id: I7d8375e822dabcceeaf25eaf4ba1f29ce7494337
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176996
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-22 14:26:19 +01:00
Julien Nabet
de7e10f9dd tdf#163486: PVS V1043 global object variable is declared in header (sc)
Change-Id: Ie328b5120bc879702db351555c9db5d6b661be41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176990
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2024-11-22 14:26:09 +01:00
Julien Nabet
2fa2017322 tdf#163486: PVS V1043 global object variable is declared in header (include/)
Change-Id: If6a656f47cb88dd218af660def31ece572a3b8ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176989
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2024-11-22 14:25:57 +01:00
Xisco Fauli
816b51c7a9 PVS: V547 Expression 'bNoDictionaryAvailable' is always false
Since
commit a50a2bf8e8
Author: Szymon Kłos <szymon.klos@collabora.com>
Date:   Thu Jan 24 11:22:22 2019 +0100

    tdf#86731 Don't show 'start from beginning' when dictionary is missing

Change-Id: Ib71051ddbb3318c74fb5020ec27560f1c6f73893
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177017
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-22 14:24:44 +01:00
Xisco Fauli
2bcaafd4a2 PVS: V1048 The 'nConcurrency' variable was assigned the same value.
Change-Id: I5819652b2f5ab491b7412e6cb4d0159f640297bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177012
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-22 14:12:20 +01:00
Xisco Fauli
53872d4eee PVS: V547 Expression '!aHandlePropVec.empty()' is always true.
Change-Id: I1eaf7fbb481f061948d65e9b7e855d9a9261e3ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177001
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
2024-11-22 14:05:13 +01:00
Xisco Fauli
bf2c665316 CppunitTest_sd_tiledrendering: factor out common code
Change-Id: I8ba7871cd3ca7580230c31dedf468aaa8219241a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176915
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-22 14:02:04 +01:00
Xisco Fauli
568fcd66c5 PVS: V560 A part of conditional expression is always true:
!rPolyPolygon.empty().

Change-Id: I61b79d0995cc08b70c2a39bdeb043a22722313e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177000
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-22 13:45:45 +01:00
Xisco Fauli
9ab81e7c44 PVS: V547 Expression '!aPropertyStates.empty()' is always true.
Change-Id: Id71d10060c79d36095bbd952b89aa6af68a29a6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176999
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-22 13:44:47 +01:00
Caolán McNamara
f2cf4d9168 crashtesting: invalid iterator on load of forum-de-1233.odt docx export
although the actual order doesn't change there is a Delete/Insert of
the object in case the order should change.

::Insert will check if sorted and resort if not anyway, so presumably
if we just skip the middle-men and resort here if we need to then that
is equivalent, but without the invalidation for the already sorted case.

 #0  SwSortedObjs::Remove (this=0x510ed40, _rAnchoredObj=...) at core/sw/source/core/layout/sortedobjs.cxx:243
 #1  0x00007fffce0af130 in SwSortedObjs::Update (this=0x510ed40, _rAnchoredObj=...) at core/sw/source/core/layout/sortedobjs.cxx:282
 #2  0x00007fffcdf32c40 in SwAnchoredObject::UpdateObjInSortedList (this=0x51123c0) at core/sw/source/core/layout/anchoredobject.cxx:661
 #3  0x00007fffcdf8fc38 in SwFlyFrame::SwClientNotify (this=0x5112260, rMod=..., rHint=...) at core/sw/source/core/layout/fly.cxx:859
 #4  0x00007fffcdf9d1bf in SwFlyAtContentFrame::SwClientNotify (this=0x5112260, rMod=..., rHint=...) at core/sw/source/core/layout/flycnt.cxx:112
 #5  0x00007fffcd65bca8 in SwModify::CallSwClientNotify (this=0x4e68da0, rHint=...) at core/sw/source/core/attr/calbck.cxx:311
 #6  0x00007fffcd65bd71 in sw::BroadcastingModify::CallSwClientNotify (this=0x4e68da0, rHint=...) at core/sw/source/core/attr/calbck.cxx:316
 #7  0x00007fffcd65b42f in SwModify::SwClientNotify (this=0x4e68da0, rHint=...) at core/sw/source/core/attr/calbck.cxx:302
 #8  0x00007fffcd66771b in SwFormat::SwClientNotify (this=0x4e68da0, rHint=...) at core/sw/source/core/attr/format.cxx:300
 #9  0x00007fffcdf4448a in SwFrameFormat::SwClientNotify (this=0x4e68da0, rMod=..., rHint=...) at core/sw/source/core/layout/atrfrm.cxx:2843
 #10 0x00007fffcd65be1e in sw::ClientNotifyAttrChg (rModify=..., aSet=..., aOld=..., aNew=...) at core/sw/source/core/attr/calbck.cxx:325
 #11 0x00007fffcd66948e in SwFormat::SetFormatAttr (this=0x4e68da0, rSet=SfxItemSet of pool 0x1bcebe0 with parent 0x4e68e68 and Which ranges: [(88, 141), (159, 159), (1014, 1034)] = {...})
     at core/sw/source/core/attr/format.cxx:597
 #12 0x00007fffce649a2c in SwXFrame::setPropertyValue (this=0x5e47b90, rPropertyName="Size", _rValue=uno::Any("com.sun.star.awt.Size": ...))
     at core/sw/source/core/unocore/unoframe.cxx:1867
 #13 0x00007fffcdc4d7ea in SwTextBoxHelper::syncProperty (pShape=0x4dce770, nWID=89, nMemberID=0 '\000', rValue=uno::Any("com.sun.star.awt.Size": ...), pObj=0x0)
     at core/sw/source/core/doc/textboxhelper.cxx:995
 #14 0x00007fffcdf2e2d7 in SwAnchoredDrawObject::GetObjBoundRect (this=0x4e69dd0) at core/sw/source/core/layout/anchoreddrawobject.cxx:757
 #15 0x00007fffcdf320ca in SwAnchoredObject::GetObjRectWithSpaces (this=0x4e69dd0) at core/sw/source/core/layout/anchoredobject.cxx:575
 #16 0x00007fffcdf31eaa in SwAnchoredObject::InvalidateObjPosForConsiderWrapInfluence (this=0x4e69dd0) at core/sw/source/core/layout/anchoredobject.cxx:400
 #17 0x00007fffcdf32be5 in SwAnchoredObject::UpdateObjInSortedList (this=0x510e530) at core/sw/source/core/layout/anchoredobject.cxx:654
 #18 0x00007fffcdf8fc38 in SwFlyFrame::SwClientNotify (this=0x510e3d0, rMod=..., rHint=...) at core/sw/source/core/layout/fly.cxx:859
 #19 0x00007fffcdf9d1bf in SwFlyAtContentFrame::SwClientNotify (this=0x510e3d0, rMod=..., rHint=...) at core/sw/source/core/layout/flycnt.cxx:112
 #20 0x00007fffcd65bca8 in SwModify::CallSwClientNotify (this=0x4e364a0, rHint=...) at core/sw/source/core/attr/calbck.cxx:311
 #21 0x00007fffcd65bd71 in sw::BroadcastingModify::CallSwClientNotify (this=0x4e364a0, rHint=...) at core/sw/source/core/attr/calbck.cxx:316
 #22 0x00007fffcd65b42f in SwModify::SwClientNotify (this=0x4e364a0, rHint=...) at core/sw/source/core/attr/calbck.cxx:302
 #23 0x00007fffcd66771b in SwFormat::SwClientNotify (this=0x4e364a0, rHint=...) at core/sw/source/core/attr/format.cxx:300
 #24 0x00007fffcdf4448a in SwFrameFormat::SwClientNotify (this=0x4e364a0, rMod=..., rHint=...) at core/sw/source/core/layout/atrfrm.cxx:2843
 #25 0x00007fffcd65be1e in sw::ClientNotifyAttrChg (rModify=..., aSet=..., aOld=..., aNew=...) at core/sw/source/core/attr/calbck.cxx:325
 #26 0x00007fffcd66948e in SwFormat::SetFormatAttr (this=0x4e364a0, rSet=SfxItemSet of pool 0x1bcebe0 with parent 0x4e36568 and Which ranges: [(88, 141), (159, 159), (1014, 1034)] = {...})
     at core/sw/source/core/attr/format.cxx:597
 #27 0x00007fffce649a2c in SwXFrame::setPropertyValue (this=0x4a86e10, rPropertyName="Size", _rValue=uno::Any("com.sun.star.awt.Size": ...))
     at core/sw/source/core/unocore/unoframe.cxx:1867
 #28 0x00007fffcdc4d7ea in SwTextBoxHelper::syncProperty (pShape=0x4dc65f0, nWID=89, nMemberID=0 '\000', rValue=uno::Any("com.sun.star.awt.Size": ...), pObj=0x0)
     at core/sw/source/core/doc/textboxhelper.cxx:995
 #29 0x00007fffcdf2e2d7 in SwAnchoredDrawObject::GetObjBoundRect (this=0x4e3a0d0) at core/sw/source/core/layout/anchoreddrawobject.cxx:757
 #30 0x00007fffcdf320ca in SwAnchoredObject::GetObjRectWithSpaces (this=0x4e3a0d0) at core/sw/source/core/layout/anchoredobject.cxx:575
 #31 0x00007fffcdf815b3 in (anonymous namespace)::IsNextContentFullPage (rThis=...) at core/sw/source/core/layout/flowfrm.cxx:217
 #32 0x00007fffcdf81002 in SwFlowFrame::IsKeep (this=0x4e5a630, rKeep=..., rBreak=..., bCheckIfLastRowShouldKeep=false) at core/sw/source/core/layout/flowfrm.cxx:259

Change-Id: If2191e8b99d1b0347bab54a704013ce0a9a19410
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176992
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-22 13:43:41 +01:00
Xisco Fauli
1329b4fa54 PVS: V560 A part of conditional expression is always true
!aTempContentText.empty().

Change-Id: If61fc09e7e19786ee055b78442b69f0147c8da75
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176998
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-22 13:22:54 +01:00
Xisco Fauli
51ca3c42ad PVS: V547 Expression 'aUnoArgs.empty()' is always false
Change-Id: I9283b59499fe7739f06d926357218ef7eb916a41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176997
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-22 13:09:16 +01:00
Xisco Fauli
17e7743d5f sd: add CppunitTest_sd_lokit_search
Change-Id: If4844f3f9a40495f3ceaf2603de5211b9f1555cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176972
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-22 13:08:28 +01:00
Xisco Fauli
e0a5ad2f8d LOKitSearchTest.cxx: use CPPUNIT_TEST_FIXTURE()
Change-Id: I11af98e069be3a8b5ec88a55024bb767e6b2c543
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176991
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
2024-11-22 13:08:19 +01:00
Tomaž Vajngerl
2088e585b6 pdf: move stream/string encryption into PDFEncryptor
Change-Id: Ie710e51faa7d65686d72a03d1ef4ca40dff8c27e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176889
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-11-22 13:07:18 +01:00
Tomaž Vajngerl
b1ce30df8b pdf: add initial test for PDF 2.0 (check using PDFium)
Change-Id: I43e6048d34ee9c51e0602cd671a73b19145a9c17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176888
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-11-22 13:07:05 +01:00
Olivier Hallot
a3aa8acfed Update git submodules
* Update helpcontent2 from branch 'master'
  to 143fba581c7499e9e36971e52e18bada4a262be1
  - Revisit Writer Navigator Help page.
    
    Change-Id: I1bdc2fe094bcc3d75d5e1442af458f018ee60f81
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176973
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-22 12:50:37 +01:00
Olivier Hallot
05565fc057 Update git submodules
* Update helpcontent2 from branch 'master'
  to a6f1acf9c43c6d2de0de9d8d3e3fad2c849f1278
  - Mute L10n on <embedvar>
    
    Change-Id: I268936d73e67b2108f92f1fa2bb2dbcb28955277
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176975
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-22 12:39:59 +01:00
Mike Kaganski
eecd788250 ReqIF: avoid 'type' attribute in 'ul' elements
Change-Id: I028737cac0b89344be5df55f9b60046230603979
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176987
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
2024-11-22 11:24:30 +01:00
Julien Nabet
cbc5fd0df4 tdf#163486: PVS V1043 global object variable is declared in header (svddef.hxx)
Change-Id: If11d609ccf6bdaadfec6b3844e08589cb289aec3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176971
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-22 10:34:37 +01:00
Noel Grandin
c06de26c4b tsan: make oslPipe thread-safe
add a mutex around accesses of the internal data structures of
oslPipeImpl, to prevent data-races

Change-Id: Ia39961c0a3df0a5a5db31cc515d248d013998255
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176931
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-11-22 08:53:40 +01:00
Bogdan Buzea
35f07a5185 tdf#148161 - Remove redundant attributes from configuration schema XML files
Change-Id: I25b6dd6868ac8f24155d4c2d45333ef47557c9c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176950
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
2024-11-22 08:03:03 +01:00
Tomaž Vajngerl
626c184f77 crypto: add AES256 test, document Encrypt, Hash conv. function
This adds AES256 test of encryption and decryption - an example
on how the Encrypt and Decrypt classes are used.

Also add a convenience function for Hash, accepting vector of
bytes as this is used in a lot of places.

Change-Id: I9b395c7afb8fac45cae8d7d8bd983f5daaafd64b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176887
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-11-22 07:19:30 +01:00
Tomaž Vajngerl
68de311b3b pdf: wrap more encryption specific code into PDFEncryptor
To make the code contained, so it is easier to add the new
encryption method later.

Change-Id: Ie3e3194c2148f6c3cb8ac58709fcd5f74e84a93a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176886
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-11-22 07:19:12 +01:00
zdavis
b61ae38fe4 tdf#143148 Use pragma once instead of include guards
Change-Id: Ic6796c91318bc838804ec30790f52480734e9b7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176615
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
2024-11-22 07:01:52 +01:00
Justin Luth
0d3748e5fb tdf#163598 editeng: avoid using fake outline depth
Most implementations do not actually
do anything meaningful with Get/SetDepth,
so don't exception or accept their values.

To fix the bug, I could have just checked for
dynamic_cast<SvxEditEngineForwarder*>
(since it supports EE_PARA_OUTLLEVEL directly)
but this way seemed more encompassing.

The potential downside is that EE_PARA_OUTLLEVEL
will be requested as a real property
after GetPropertyValueHelper
with some of these dummy providers,
and who knows what UNO might do about that...

IF this patch causes problems,
then I need to implement Get/SetDepth
in SvxEditEngineForwarder
(or consider the dummy providers as SupportsOutlineDepth).

Change-Id: I74bf5e39a13bb1d588c39634347eb0982bda66b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176981
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
2024-11-22 04:52:46 +01:00
Michael Weghorn
d3613d15e5 notebookbar: Simplify logic to detect whether hidden children
The actual number of hidden children is not of interest here,
only whether there is at least one, so stop iterating once
the first hidden child is encountered.

Change-Id: Ice1a7461d2bfd9d576109771cf93deb6a17ef975
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176930
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-22 00:16:11 +01:00
Michael Weghorn
de426177dc notebookbar: Drop PriorityHBox::GetHiddenCount
The method is only used in the PriorityMergedHBox
subclass, which overrides the method anyway,
so drop the base class implementation.

Change-Id: If2c11377b1ca0ac0f3c6cd4fec9890cdcbbce0ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176929
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2024-11-22 00:16:01 +01:00
Michael Weghorn
d723ef6392 notebookbar: Drop unnecessary static_cast
Change-Id: If7aa91609409d3ad499a55348545d49d136d6606
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176928
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2024-11-22 00:15:53 +01:00