part of the process of hiding the internals of SwPosition
Change-Id: Idc0b3c68d8f2c560868eacf5679e8a1f133cf80b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140574
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
part of the process of hiding the internals of SwPosition
Change-Id: I026a5480ede5e640550b39e8b030de303870cfc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140573
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
part of the process of hiding the internals of SwPosition
Change-Id: I466640e5cf7aac57b0248e9a5069e75ccd7e779a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140572
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
part of the process of hiding the internals of SwPosition
Change-Id: I20052ec81800ce206877bc1781297e5c13fb400c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140571
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Revert "updatePathFromSdrPathObj can just call getRange"
This reverts commit 7c52337f95.
Not sure why this change did not work.
Change-Id: I2c42b9b7ff4b85f3018bea289efd3d934dbe2be1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140570
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
To use implementation of tdf#139991, shellnew/soffice.* are now 0-bytes
files
Change-Id: Ifa5c02c6903d1d505a882cbe0951e4d5c10720f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140538
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
When drawing bullets for spaces, we were passing a substring to
DrawTextArray() and even taking care of adding an extra character to
both sides to help with Arabic layout. This, however, does not work when
part of the text is in different color because the portion will cover
only that substring and we wouldn’t be passing enough context.
Copying the substring is unnecessary, though, and we can pass the full
string like we do in the non-bullet case. The bullet array (where we
replace spaces with bullets), can continue to be a substring as we are
only drawing the bullets in this case.
This probably also means we can re-use the glyph cache when switching
between bullet and non-bullet mode.
Change-Id: I256ae7b6d592b8c6670d66619e428f943714be57
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140568
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@aliftype.com>
The platform a11y integration code expects a
`FontSlant` in the "CharPosture" `Any`
(s. e.g. `get_style_value`/`FontSlant2Style`
in `vcl/unx/gtk3/a11y/atktextattributes.cxx`
or `QtAccessibleWidget::attributes`)
and that's also what e.g. Writer sets for that attribute
for text in the document, so do the same in
`CharacterAttributesHelper::CharacterAttributesHelper`.
After handling for "CharPosture" was added for
the Qt-based VCL plugins in
commit 99841da686
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Tue Jul 20 13:23:21 2021 +0200
qt a11y: Report font style text attribute (e.g. italic)
, clicking through the a11y hierarchy of e.g. Writer's
"Page Style" dialog in Accerciser's treeview of the LO a11y
hierarchy would otherwise crash LO when used with the qt6 VCL
plugin.
With this in place, the style is reported correctly
there. (Tested by temporarily setting "oblique"
style using glade for the "Next style" label in the "Organizer"
tab in that dialog's UI file.)
Change-Id: Ibea42db067e0cdb3b85c80dbcca5939b3dfe5570
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140527
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
- also add some constnesss and move some things to private
Change-Id: I67a45e1326361b5a8f7e320b3525e74e93b1ef12
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140556
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
This uses the same caret positioning array introduced in:
commit 8cb4db941f
Author: Khaled Hosny <khaled@aliftype.com>
Date: Fri Aug 26 22:20:55 2022 +0200
tdf#30731: Improve caret travelling in Writer
But unlike the Writer change, this is used unconditionally not only when
calculating caret (cursor) position. This might break something, so lets
find out.
Change-Id: Ia285197b7ee41f01ccd37101436be86b476c0272
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140557
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@aliftype.com>
TempFile already handles the stream. And not touching the URL
means we stay on the fast path for temp files.
Change-Id: I1c239c90901af4450ba10e0d1505bb982cdce41c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140116
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
by not asking for the name or URL, we stay on the happy path,
which is faster on Windows
Change-Id: Ia333ab251fc0fc4129ad0610412c5c509914a58e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140453
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
We never subset such fonts after:
commit 77cce80bb5
Author: Khaled Hosny <khaled@aliftype.com>
Date: Thu Sep 22 23:35:12 2022 +0200
vcl: tdf#121327 PDF export for bitmap color fonts
But PrintFontManager::analyzeSfntFile() calls this function for
non-subsetting uses, it probably shouldn’t since all info it should
possibly need can come from FontConfig, but re-instate this for now.
This check is very blunt and it would lead to empty fonts in PDF if we
ever try to subset such a font, but lets clean this up later.
Change-Id: I804d0244ee24a4b4e92b36efd26b376cbe40784d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140542
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@aliftype.com>
use vector rather than handrolling it
Change-Id: Ie160d5d60470e01434c61d80a2c7965e9126d508
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140540
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Update helpcontent2 from branch 'master'
to df6900524c02966c0d115312c458c5bc3e8f6f29
- Silence strings for translation in SF Region service
The example for calling "help" with the Number2Text method cannot be translated because the number and order of options is different for each supported language.
For example, in "en-US" we have the following options:
one, two, three
ordinal: first, second, third
ordinal-number: 1st, 2nd, 3rd
year: nineteen ninety-nine, two thousand, two thousand one
currency (for example, USD): two U.S. dollars and fifty cents
money USD: two and 50/100 U.S. dollars
Whereas in "pt-BR" the options are very different (and more importantly, a different number, which totally prevents translation).
um, dois, três
feminine: uma, duas, três
masculine: um, dois, três
ordinal-feminine: primeira, segunda, terceira
ordinal-masculine: primeiro, segundo, terceiro
ordinal-number-feminine: 1.ª, 2.ª, 3.ª
ordinal-number-masculine: 1.º, 2.º, 3.º
Change-Id: I688de573b82ca83d714562f1acc705c23333081f
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/137528
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Respond to https://bugs.documentfoundation.org/show_bug.cgi?id=117764#c1
a) the function should be *available* on "clean" cells (removed after comment in gerrit)
b) answering "No", one would not edit the existing format, *but will edit a new format instead*
c) answering "Yes", one would edit the existing format
Change-Id: I8c578a59084c557939a853d4746efffbaf4e56e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140266
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
part of the process of hiding the internals of SwPosition
Change-Id: I6eeac9861f3d170d89b78f71a45bf48dd8478c13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140437
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
The problem is that SwXText::compareRegionStarts() calls
SwXText::CreateCursor() which creates a cursor on the last node in the
body text, but it's actually a redline.
Override SwXRedlineText::CreateCursor() to create a cursor in the
redline text.
Complete mystery why SwXText has 2 virtual functions to create
cursors in the first place.
(regression from commit 463178fef5)
Change-Id: I0f3bcf4eda25f1ac7e1c1b0cf47a920f8302d2b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140523
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Clean up the redundant checks too, these are all called after first
checking hasCurrentFieldCtx().
(regression from 463178fef5)
Change-Id: Ieec848944ef576caf319d5da7dc11139a4d26c58
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140514
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* Fix regressions introduced with 5edefc801f "use
more string_view in unotools". (Notably, misuses of two-argument std
string_view rfind are something to watch out for, see the commit message of
93e234c45c "Fix a misuse of two-argument std
string_view rfind" for details.)
* Bring the implementation some more in accordance with the documentation, by
being stricter about handling invalid paths, and making sure to really assign
all of the input _sInPath to the output _rsLocalName in case of an invalid
path.
* Only &...;-decode the names of set elements in ['...'] and ["..."], not
anything else.
Change-Id: If01f4b34af42b0a594994b732d54f26695329286
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140493
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...documenting how the implementation is in discordance with the documentation
for some corner cases and how things got recently broken with
5edefc801f "use more string_view in unotools", in
preparation for an upcoming improvement of that function's implementation
Change-Id: Ia47243c64b724009c5ed5eecb9d890820287e9ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140492
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Regression after commit 92e835dbf0
Author Kunal Pawar <hellokunalpawar@gmail.com>
Date Fri Feb 18 19:15:04 2022 +0530
tdf#98705 Replace GetCaseCorrectPathName with GetLongPathNameW
The fix tries to keep the performance improvement, and when the path
exists, it will only call GetLongPathNameW once. Anyway, for unclear
reason, this normalization only happens on long paths.
Change-Id: I1cf9a47dfc35046ec1b5eebbbcaca09edb1c471a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140516
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
...similar to 93e234c45c "Fix a misuse of two-
argument std string_view rfind". This one got introduce in
15d8762dd0 "use more string_view in cui". (And if
it wasn't for other bugs elsewhere, this code could be reached e.g. in Writer
with "Tools - Macros - Organize Macros - Basic...", in "Macro From" select "My
Macros - Standard - Module1" and in "Existing Macros in: Module 1" select
"Main", then "Assign...", and this code would have miscomputed aModule as "Main"
rather than as "Module1".)
Change-Id: Id3fd66e0bd252d79af629abbbf1e38b37679de70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140490
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This is how Excel handles these.
At first I was afraid that this would upset LibreOffice users,
but then I realized that equals already is case insensitive,
so this change ought to be more consistent, and thus there should
be fewer outcrys.
Change-Id: Ia3de78d5888672ba8b774866d41ecd65293397c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140484
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
otherwise it won't end up hidden if the "keyboard" tab page is the initial
page, this handler only happens when the user switches tabs.
use the newly added virtual methods to manage this instead
Change-Id: I3eef6b4d7d453a5ec16ec62b2ebb558bd4757caa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140489
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
The problem here was that under IsNewModel tables were
selecting the entire column (including merged cells)
and then using THAT selection to ExpandColumnSelection.
Well, that ends in disaster. Since NewModel already
expands to catch the cells that are contained inside
the selected cells, there is no need to expand
the selection of GetTableCell.
Change-Id: I43089d912cdd17b2599619a43e40fecc2f5dd3b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140455
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
