Commit graph

359094 commits

Author SHA1 Message Date
Stephan Bergmann
1b0baa5799 loplugin:literaltoboolconversion
Change-Id: I6fe25eb5619e5e0273e6e2010c948daa547fe46c
2014-08-20 14:16:07 +02:00
Stephan Bergmann
f340f04546 Pick a more suitable type for nLength
Change-Id: I6e38b82f08884c4e187e5b3ca2c95a0d4ca8d541
2014-08-20 14:04:58 +02:00
Eike Rathke
fdb7429bf5 update input bar with new value
If setting the number format isn't called we need to explicitly update
the input bar.

Change-Id: I60c4808ce86eb659d3faf92d368c5118ee9673b2
2014-08-20 13:43:33 +02:00
Eike Rathke
32e8c47df8 refine current date/time hotkey handling
Nearing the "do what I mean" principle..

* key date on time cell  =>  current date + time of cell  =>  date+time formatted cell
  * unless time cell was empty or 00:00 time  =>  current date  =>  date formatted cell
* key date on date+time cell  =>  current date + 00:00 time  =>  date+time formatted cell
  * unless date was current date  =>  current date  =>  date formatted cell
* key date on other cell  =>  current date  =>  date formatted cell
* key time on date cell  =>  date of cell + current time  =>  date+time formatted cell
  * unless date cell was empty  =>  current time  =>  time formatted cell
* key time on date+time cell  =>  current time  =>  time formatted cell
  * unless cell was empty  =>  current date+time  =>  date+time formatted cell
* key time on other cell  =>  current time  =>  time formatted cell

Change-Id: I5025e0d0ea9ac83d1b9e0b130262df6db4693a56
2014-08-20 13:43:31 +02:00
weigao
b7c7877257 add screen text to auto fly
Change-Id: I6a4549bf47f5126510c3ddb93733b2d56a4159e2
2014-08-20 13:01:53 +02:00
weigao
8434a2b6aa add auto fly code
Change-Id: Id137892b855b4a70625335ede8015dfe6dce1e7e
2014-08-20 13:01:53 +02:00
Noel Grandin
0ce1267ae2 remove more unnecessary constructor declarations
Change-Id: Ie5a243006b112c2e6daf12992f3dba8baf12748d
2014-08-20 12:12:43 +02:00
Noel Grandin
609f7b8503 remove do-nothing code
Change-Id: I101cc3be44f029f7353e8d40823c0d6b2bd761b3
2014-08-20 12:12:27 +02:00
Noel Grandin
c0415d5f1e java: remove unnecessary constructor declarations
in the absence of any other constructors, the compiler will automatically
generate a public no-arg constructor

Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-20 12:12:15 +02:00
Noel Grandin
6884ef6317 java: don't catch and then just rethrow an exception
without doing anything else useful

Change-Id: I5803d84d46e0a70e1759f2202e2c2273087f8723
2014-08-20 11:47:47 +02:00
Noel Grandin
8c9fdc4a96 java: remove modifiers implied by the context
found by PMD

Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
2014-08-20 11:45:28 +02:00
Noel Grandin
34352e7f1b fix exception not caught
Change-Id: Idf1942d76f3c13e207f2e54494557ee01013c833
2014-08-20 11:45:28 +02:00
Markus Mohrhard
4fe377ad6d disable the test until I understand the problem
Change-Id: I9a24ff49823a9521d412e1e761c4c1b6ece6b601
2014-08-20 11:27:48 +02:00
Caolán McNamara
9cad46b364 move comment into assert
Change-Id: I230fdf40dc2df552b8cfbdee33e8d3bd25fb81de
2014-08-20 10:20:30 +01:00
Caolán McNamara
7543a4165b fix indent to get this working again
Change-Id: If48dcf4d04d3888975687aa85557e2cee317f2dd
2014-08-20 10:18:42 +01:00
Caolán McNamara
17ccc09ec2 fix crash on loading ooo83574-1.doc
Change-Id: Ia959dde8bac2d663cf1a5bec0358ee89dcaf42ed
2014-08-20 10:04:32 +01:00
Caolán McNamara
30541352a1 fix string out-of-bounds assert on rhbz496762-1.pdf
Change-Id: I224e3c9befd1a9ab3ba0cc2676cd6b4ba51214c8
2014-08-20 09:49:46 +01:00
Caolán McNamara
d01ee7e2cc fix string out-of-bounds assert on gnome627759-1.ods
i.e. on soffice --headless --convert-to pdf gnome627759-1.ods

Change-Id: I01289d5afcc79b7180cc12f8ee345ac760b6a637
2014-08-20 09:39:40 +01:00
Noel Grandin
3f210b0e75 java: remove unnecessary return statements
found by PMD

Change-Id: I3d150421948d17eaed34fac2b1a212da34288d1a
2014-08-20 10:35:54 +02:00
Noel Grandin
a753a458e5 java: avoid if..else when returning boolean values
Change-Id: Iab52762a9abfe8735223372b09638ce9d8d44318
2014-08-20 10:35:53 +02:00
Noel Grandin
60f152caee java: avoid unnecessary comparisons in boolean expressions
i.e. stuff like "x == true"

Change-Id: Ib82a4a30e736df392405332fa197b588482cffcf
2014-08-20 10:35:53 +02:00
Noel Grandin
2922a967a1 java: Avoid naming non-fields with the prefix m_
found by PMD

Change-Id: I5955cfc9c4d777496a2e8e4b2c422a51764a8bc1
2014-08-20 10:35:53 +02:00
Noel Grandin
188af1e56e no need to instantiate an object to get it's class
Change-Id: I7b1f8d4621a3db9094bb61753218db3646c33e34
2014-08-20 10:35:52 +02:00
Noel Grandin
ccbb51ad96 use correct loop index variable
Change-Id: I92531f8fc96c0cb0ca944a7dd50c4fe4ea740b37
2014-08-20 10:35:52 +02:00
Noel Grandin
619dc5d4c8 remove some dead Java code
Change-Id: I03dc362f7302ac8539a4da3dcef9466a7c6d7159
2014-08-20 10:35:52 +02:00
Noel Grandin
252ed1708a double-checked locking is not thread-safe in Java
found by PMD

Change-Id: Ibd4a9139c626932bec56c0b1dd32b4d59c8440b1
2014-08-20 10:35:51 +02:00
Szymon Kłos
a240a78cc7 Fixed size of 'formula' dialog in Calc
Fixed:
1. Open Calc
2. Open formula dialog
3. Choose AMORDEGRC function or other with >= 4 params
Edit field is covered by other controls

Change-Id: Ie14ff91a17373e11bc8ef6477f4f22c0ea4570c3
Reviewed-on: https://gerrit.libreoffice.org/11035
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-08-20 03:12:31 -05:00
David Tardon
34d6e7790f avoid potential null dereference
Change-Id: I2236a18608ffa9481c30088044f34e1a3372dd11
2014-08-20 10:08:49 +02:00
David Tardon
8c536baf20 do not use obsolete OSL_VERIFY macro
Change-Id: I8efdd4933d3e47c5e086dc4a4685110390d6b6e8
2014-08-20 10:08:49 +02:00
David Tardon
238d6ac878 this assert does not make sense
... as the code apparently can work even if xFormatTypes is empty.

Change-Id: I6b733b9b31329d4fafc745bc23d0f555286950e6
2014-08-20 10:08:49 +02:00
Caolán McNamara
0a42632a74 empty Reference
valgrind + bff

Change-Id: Id3c039a46dec5d2d4a4642dfb53d23a76972dde2
2014-08-20 08:57:06 +01:00
Caolán McNamara
e324771991 empty m_aStates
valgrind + bff

Change-Id: I3bd526b7ebf0f4fce5d0c7054809e0dc2908e73f
2014-08-20 08:43:09 +01:00
rbuj
37c49c3058 jurt: Throwable.getCause() instead of Throwable.getTargetException()
As of the JDK 1.4, Throwable.getCause() is the preferred method for getting thrown target exception.

Change-Id: I14f3f9ae52869d1149f92b32562e7fb3293109b5
Reviewed-on: https://gerrit.libreoffice.org/11027
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-20 01:50:57 -05:00
rbuj
b9813addf2 xmerge: Convert a primitive type into a string
Avoid unnecessary temporaries when converting primitive data types into a String.

Change-Id: If361383be52d8258be7c8c9bddf3ba05d5ca92c1
Reviewed-on: https://gerrit.libreoffice.org/11026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-20 01:48:33 -05:00
Markus Mohrhard
1558b50e4f remove whitespace
Change-Id: I5634bf40e8ccc4ce076409907c13f9c6f52d11a3
2014-08-20 08:17:40 +02:00
Tor Lillqvist
a1a480f91e Wa: C4701: potentially uninitialized local variable 'fVal' used
Change-Id: I579205c4cdc3149ef0c1b01daef32155a13d666b
2014-08-20 09:01:41 +03:00
Miklos Vajna
8b6ce55b90 writerfilter: remove now unused namespace-alias elements
Change-Id: If58b3a9f5b1d79d164bb1c2a7c18aa4f99f00ca8
2014-08-19 23:26:09 +02:00
Miklos Vajna
a5396d64a4 writerfilter: stop reading namespace-alias elements
The same info is already available from oox.

Change-Id: I0725799e1f3ffebf6140ad38a0ce376e5417265d
2014-08-19 23:26:09 +02:00
Valentin Kettner
15295ab6db Refactored SwDoc::GetEditShell .
Removed its output paramater as GetCurrentViewShell should be
used instead and added a const version.

Change-Id: Iad8b57553b6e93e3472ce8c6905d08e8d49af770
2014-08-19 21:57:06 +02:00
Eike Rathke
5a05115ee2 more flexible handling of current date/time hotkeys
Let Ctrl+; current date and Shift+Ctrl+; (Ctrl+:) current time behave more
flexible, depending on the formatting (and as such the type) of the existing
cell content.

key date on time  cell => current date + time of cell => date+time formatted cell
key date on other cell => current date => date formatted cell
key time on date  cell => date of cell + current time => date+time formatted cell
key time on other cell => current time => time formatted cell

Change-Id: I2ccbfbab3c50c36a72c4db4696520e32f94caefa
2014-08-19 21:54:46 +02:00
Eike Rathke
11f145d90f a date is a date, without time
And use DateTime instead of manually concatenating Date and Time.

Change-Id: I6f9fb988beea2a9a17c976d3b98860c4f9ed063b
2014-08-19 21:54:44 +02:00
Caolán McNamara
f47baab6d3 Resolves: fdo#82355 crash on loading ppt
regression probably triggered by...

commit 2e3c45afc6
Date:   Fri Mar 4 07:38:16 2011 -0800
Remove usage of deprecated List container.

but that just stopped at the first NULL by chance

Change-Id: I767e3bc3130d99cedceb4172857d1741c677b19b
2014-08-19 20:49:17 +01:00
Tor Lillqvist
a0de5cc93d fdo#529470: I can't remove a path in AutoText dialog
This is, not surprisingly, somewhat weird code, but I think this patch does
what is necessary, it does fix the bug.

Change-Id: Ie1947b311f1455ba48a904f5ef42ad92899fac31
2014-08-19 21:03:05 +03:00
Luboš Luňák
bbc2f9e990 fix last commit
Change-Id: I32d3f99a2f090637d6891123f91093c0bcceddf4
2014-08-19 18:35:35 +02:00
Luboš Luňák
6fc89b66df try to fix windows build
Change-Id: I7620d71fe34b5f7bbd9bf9bf63b634d85cdb4d6c
2014-08-19 18:30:11 +02:00
Caolán McNamara
749f7548b4 only subtract height of hscroll if visible
otherwise infinite loop in extensions update check

Change-Id: I0dbf4f34208f1bf0854e365006a79470b26571f3
2014-08-19 17:20:34 +01:00
Miklos Vajna
788632dcb0 DOCX export: handle SDT end right before a section break introducing headers
Change-Id: I0fab5ae4335ed6016d31aa243b131899c3154388
2014-08-19 18:19:04 +02:00
Miklos Vajna
1c06dc14a1 writerfilter: stop reading namespace-alias elements in factoryimpl
Change-Id: I52c2298c9583617481069040e118520cf8935c6d
2014-08-19 18:19:03 +02:00
Caolán McNamara
69d673b1ae dangling unused .ui file
Change-Id: Ifc1968e5474c7f252960d4b790d6f01db29cab8a
2014-08-19 16:39:53 +01:00
Luboš Luňák
869a3e1b7f split CppunitTest_sw_ooxmlexport into several tests
In order to allow running them in parallel. There are already enough
tests to make it run for a couple of minutes and it's annoying to
see only once core busy with it.
I intentionally left the original file at the same name, without 1
appended, in order to avoid merge problems.

Change-Id: I097c45c34797cc68f5d1790cf31eefc96fbaf44e
2014-08-19 17:25:00 +02:00