Commit graph

430712 commits

Author SHA1 Message Date
Stephan Bergmann
53a78e9fc3 loplugin:staticmethods
Change-Id: I8d26503d68ed3dcc37574e247de3eae02b4e0f53
2018-11-16 15:24:37 +01:00
Noel Grandin
c8907b19dc loplugin:buriedassign in sw
Change-Id: If2adf22a0ac3e030fca1b4ecd0173cac58f0f21e
Reviewed-on: https://gerrit.libreoffice.org/63470
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-16 15:05:58 +01:00
Caolán McNamara
11300c48d4 Resolves: tdf#121246 crash in chart dialogs
Change-Id: I3bc720e44f5ea15749e6bc0f0fada3a17a783e23
Reviewed-on: https://gerrit.libreoffice.org/63463
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-16 14:51:52 +01:00
Caolán McNamara
41d588835c Related: tdf#83128 translate word/char counts as separate n_gettext args
Change-Id: I2033f4ef51a861c7634dccdae885a842bb079913
Reviewed-on: https://gerrit.libreoffice.org/63465
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-16 14:51:22 +01:00
Noel Grandin
890afecb45 loplugin:buriedassign in dbaccess..oox
Change-Id: Ic0ca695a1d9d05418213475a68e233953136cc8e
Reviewed-on: https://gerrit.libreoffice.org/63468
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-16 14:31:38 +01:00
Noel Grandin
faa63cd14c new loplugin buriedassign
Change-Id: If6dd8033daf2103a81c3a7c3a44cf1e38d0a3744
Reviewed-on: https://gerrit.libreoffice.org/63466
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-16 14:20:04 +01:00
Caolán McNamara
f5f5a17be7 entirity of writer rebuilding when vcl widget headers change
which seems a bit excessive

Change-Id: If0ab5a33bfbbd399e270f3e140c9d44d843985aa
Reviewed-on: https://gerrit.libreoffice.org/63422
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-16 14:09:38 +01:00
Noel Grandin
12e460d999 loplugin:buriedassign in avmedia..cui
Change-Id: Id44f1e98a3aac2c417f8030de603175bf68f0dfe
Reviewed-on: https://gerrit.libreoffice.org/63467
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-16 14:03:25 +01:00
Olivier Hallot
caf9cd9389 Update git submodules
* Update helpcontent2 from branch 'master'
  - Honor asc/desc in XHP sorting
    
    Change-Id: I11cc206e3f8771fc19387cd2a9c02697982251dc
    Reviewed-on: https://gerrit.libreoffice.org/63445
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-16 14:02:55 +01:00
Mike Kaganski
071eabe3e8 Do not truncate fractions of seconds in timestamps to integral milliseconds
I.e., importing a CSV field like "1970-01-01T00:00:45.890622" as "Date (YMD)"
should not truncate .890622 to .891.

Change-Id: I8d17ce54f63c3c4e68b8f90c63b6d1bb28bee67b
Reviewed-on: https://gerrit.libreoffice.org/63459
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
2018-11-16 13:54:39 +01:00
Michael Stahl
68880a3004 tdf#121031 sw_redlinehide: fix SwUndoDelete of table: create table frames
(regression from 723728cd35)

Change-Id: I7a52b8499f05e9e8cbf81330ea264fbbfe3bac87
Reviewed-on: https://gerrit.libreoffice.org/63462
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-11-16 12:23:00 +01:00
Aleksei Nikiforov
5edc23dbc5 tdf#120777 KDE5: Update initialization of QImages
Make sure that created empty QImages are filled with transparent pixels.

Copying data from previous QImage on widget resize removes blanking
on window resize when qt5 vcl plugin is used.

Change-Id: If072a4b8b334bc87dbe4aaea9aa8774bb5e202ee
Reviewed-on: https://gerrit.libreoffice.org/63029
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-11-16 10:43:27 +01:00
Miklos Vajna
84a0496de8 starmath: create XMLOasisMetaImporter instances with an uno constructor
Change-Id: Ie48a779958a393b68dea613c3bcc17113165f065
Reviewed-on: https://gerrit.libreoffice.org/63443
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-16 09:05:53 +01:00
Samuel Mehrbrodt
bbf5c85c2a tdf#99122 Send as email: prefer ooxml formats
and remove the draw branch - there is no menu entry in draw for this.

Change-Id: I1e435023a6b39c6990c8a9d3df52b668b5de0571
Reviewed-on: https://gerrit.libreoffice.org/63433
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-16 08:45:00 +01:00
Zdeněk Crhonek
f830d83b3c uitest Calc Show sheet dialog
Change-Id: I27e97e6b0664f20d93cbf6588403d7db85ef7ecf
Reviewed-on: https://gerrit.libreoffice.org/63384
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-11-16 08:22:16 +01:00
andreas kainz
b113553e2e tdf#121017 context menu web text: editstyle is always paragraph style
Change-Id: I985c3f9be81cbeadb393fe8a03bde6a11e3e391d
Reviewed-on: https://gerrit.libreoffice.org/63450
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-11-16 08:13:06 +01:00
andreas kainz
7fbd5e1321 tdf#121017 context menu global text: editstyle is always paragraph style edit
Change-Id: I8c6204e389105e2572cd2edd4fb5f23c87896c66
Reviewed-on: https://gerrit.libreoffice.org/63449
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-11-16 08:12:04 +01:00
andreas kainz
8e3223078b tdf#121017 context menu writer text: editstyle is always paragraph style edit
Change-Id: I56a8385669a8cd74e2794d12a7cd4c722da1313d
Reviewed-on: https://gerrit.libreoffice.org/63448
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-11-16 08:11:10 +01:00
andreas kainz
ee0fa2b83b tdf#121017 context menu swxform text: editstyle is always paragraph style
Change-Id: I3e53e06ce55c377076234f08ce090c4904db8cb6
Reviewed-on: https://gerrit.libreoffice.org/63451
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-11-16 08:10:49 +01:00
Jim Raykowski
b4aa41f305 tdf#121216 Fix custom pattern not displayed in area tab page
pattern editor on reopening

Change-Id: I1c77dff4bfebc9f4a2661210f5bbbaa8573a90db
Reviewed-on: https://gerrit.libreoffice.org/63456
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-11-16 07:44:45 +01:00
Jens Carl
fdb5208253 tdf#45904 Move XEnumeration Java tests to C++
Move XEnumeration Java tests for
ScIndexEnumeration_TableRowsEnumeration to C++. Also improved the
overall run time of the test by limiting the range to enumerate over for
reasons mentioned in fdo#45337.

Change-Id: Id8eb998242cacf61bb472a0c130f38482c95db1c
Reviewed-on: https://gerrit.libreoffice.org/63444
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-16 07:43:44 +01:00
Noel Grandin
a2751c0795 loplugin:staticmethods improvement
Change-Id: I8889ce8a7d2309b54454cfe4c6421282e1c6e755
Reviewed-on: https://gerrit.libreoffice.org/63434
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-16 07:26:27 +01:00
Andrea Gelmini
a04340a08c Fix typos
Change-Id: I033731251c4fffd759144f5bd9d6b9737de48c80
Reviewed-on: https://gerrit.libreoffice.org/63455
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-16 07:19:18 +01:00
Andrea Gelmini
25c61d782d Removed duplicated include
Change-Id: I147e10a4ce503a91e51eed15586db3381447cc7c
Reviewed-on: https://gerrit.libreoffice.org/63454
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-16 07:07:44 +01:00
Brian Fraser
759ee18f4c tdf#37483 Add drag'n'drop to reorder custom Impress animations
- Support drag'n'drop of single items. If the animation is collapsed,
  it will move its collapsed sub-animations as well.
- Sub-lists remain expanded when its parent animation is moved, or
  a sub animation becomes the new parent of the text group (due to moving).
- Maintain the cursor between custom animation list redraws.
- Don't change selection on collapse after custom animation list
  rebuild.

Change-Id: I92d96e9a01c6884ef739612e456cc541218b6ebb
Reviewed-on: https://gerrit.libreoffice.org/62342
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-16 01:37:31 +01:00
Xisco Fauli
525ed5d1fc tdf#107240 tdf#120432 Disable time/date entries in read-only/protected mode
Change-Id: Ia3c757fa094f17be3b4aadaee65c4699bf0c1cb1
Reviewed-on: https://gerrit.libreoffice.org/61953
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
2018-11-15 22:33:14 +01:00
Takeshi Abe
e22ab5e6f6 Resolves: i#32345 Make LARGE()/SMALL() return an array
... if the second parameter is an array.

This change follows their specification in ODF 1.2.

Change-Id: I45c8923f462e9477e1234b47e39dcdd8d2198784
Reviewed-on: https://gerrit.libreoffice.org/62541
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
2018-11-15 22:12:01 +01:00
Caolán McNamara
973a3dd962 force rerender on unit change
Change-Id: I7a64b2e200bf0c50ea636be8aac1249713044103
Reviewed-on: https://gerrit.libreoffice.org/63438
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-15 21:55:51 +01:00
Caolán McNamara
1d98877809 Resolves: tdf#121432 don't insert an extra page when parent is tabcontrol
but the new child is a toplevel widget

Change-Id: Ib794e076e2626485b9d9231daf914db6dd9b5e2f
Reviewed-on: https://gerrit.libreoffice.org/63431
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-15 21:55:08 +01:00
Olivier Hallot
a78bac697f Update git submodules
* Update helpcontent2 from branch 'master'
  - typo
    
    Change-Id: I0ffcaf4a1582d3ee31c40d9ecfc4f922651a1b18
    Reviewed-on: https://gerrit.libreoffice.org/63441
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-15 20:25:37 +01:00
Olivier Hallot
0d3f1ed35a Update git submodules
* Update helpcontent2 from branch 'master'
  - tdf#118473 Help page for VBA FormatNumber
    
    + some fixes in table formatting
    
    * Added Mike's advise.
    * fix dumb copypasta
    
    Change-Id: I997c3200e521e7fac9f20f17a9bb9e2574bccfdd
    Reviewed-on: https://gerrit.libreoffice.org/63373
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-15 20:07:08 +01:00
Tor Lillqvist
65372d470c WaE: -Wimplicit-fallthrough
Change-Id: I4d80a64a228c7225df13ca17d933b8f940ddc3e3
2018-11-15 20:58:14 +02:00
Miklos Vajna
e807d6158e sw reqif-xhtml export: write graphic of OLE object at an RTF level as well
An embedded object have have its replacement graphic at 3 levels in
reqif-xhtml: PNG at HTML level, WMF at RTF level and as a stream in the
OLE2 storage. Some reqif readers depend on having the replacement
graphic at an RTF level, so write that variant, too.

Change-Id: I3391303248d2792a4c370e8fc84db0f22185312e
Reviewed-on: https://gerrit.libreoffice.org/63419
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-15 19:29:46 +01:00
Caolán McNamara
39aa91cfb4 Resolves: tdf#121341 weld TrendlineTabPage
Change-Id: I8ecc1901388986bd6a3822e8d0055e48d873586c
Reviewed-on: https://gerrit.libreoffice.org/63387
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-15 18:45:22 +01:00
Caolán McNamara
21c4165996 Resolves: tdf#121415 font tab page has no name
Change-Id: I3ca6a8b58163fe5c84a306dd80dd7171f8540299
Reviewed-on: https://gerrit.libreoffice.org/63425
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-15 18:45:01 +01:00
Michael Stahl
2e9ad89ee9 sw: -Wimplicit-fallthrough from MacOS clang (or perhaps NDEBUG clang?)
Change-Id: I0219a0f6438c58b3f3307efe0b62d2a40ef281e4
2018-11-15 18:23:53 +01:00
Caolán McNamara
4ce5d39689 bind SalInstanceSpinButton to FormattedField
Change-Id: I71190343739fae51b1c17d74ea1c4a548bca0b01
Reviewed-on: https://gerrit.libreoffice.org/63371
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-15 18:17:35 +01:00
Caolán McNamara
9e0a099fb6 reformat when the unit changes
Change-Id: I2252a5bc4c3b495c35b9d5672a272362646ebbe8
Reviewed-on: https://gerrit.libreoffice.org/63426
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-15 18:14:34 +01:00
Jens Carl
32a8c55c97 tdf#45904 Move XEnumeration Java test to C++
Move XEnumeration Java tests for
ScIndexEnumeration_ScenariosEnumeration to C++;

Change-Id: Ia778f644cbb2836e6c6bfc12ae389cda3420e5b2
Reviewed-on: https://gerrit.libreoffice.org/63399
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-15 17:50:49 +01:00
Stephan Bergmann
ac37f40464 Adapt recent CppunitTest_xmlsecurity_signing fix to ASan
f0305ec0a7 "Fix creation/removal of GPG socketdir"
spawns additional gpgconf processes which need the same LD_LIBRARY_PATH fix as
d15f042abd "CppunitTest_xmlsecurity_signing failed
in sanitizer builds"

Change-Id: I1da9e9e459c5a584f092966923f8818f115322dc
Reviewed-on: https://gerrit.libreoffice.org/63420
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-15 17:47:04 +01:00
Samuel Mehrbrodt
38d9c708b3 Fix wrong path name
Change-Id: I79ed336058ffa9e182d3332acfeda8d6526c6b43
Reviewed-on: https://gerrit.libreoffice.org/63432
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-15 17:39:34 +01:00
Noel Grandin
5c7dd81ca3 loplugin:staticmethods in sc
Change-Id: I3cdce43e0ba9b17f9bf993ebcad5f64f0834ceaf
Reviewed-on: https://gerrit.libreoffice.org/63421
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-15 17:34:13 +01:00
Noel Grandin
d197d524c5 loplugin:staticmethods in sfx2
Change-Id: Ide10d0186431e745c3bb17d321cf46724e801c8f
Reviewed-on: https://gerrit.libreoffice.org/63404
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-15 17:33:55 +01:00
Stephan Bergmann
80751cd90d Update the reference rdbs to libreoffice-6-1-0
LD_LIBRARY_PATH=.../master/instdir/program \
 .../master/workdir/LinkTarget/Executable/unoidl-read --published \
 .../libreoffice-6-1-0/instdir/program/types.rdb \
 >.../master/udkapi/type_reference/udkapi.idl

* no changes

LD_LIBRARY_PATH=.../master/instdir/program \
 .../master/workdir/LinkTarget/Executable/unoidl-read --published \
 .../libreoffice-6-1-0/instdir/program/types.rdb \
 .../libreoffice-6-1-0/instdir/program/types/offapi.rdb \
 >.../master/offapi/type_reference/offapi.idl

* all the interim modifications to offapi/type_reference/offapi.idl were done in
  error and had already been reverted again (i.e., `git diff
  76f30450577bcecf0423833884e3e5215decdd07..5b0ceb86c342754d8f4e83408c7ae0da0e3931d3^
  -- offapi/type_reference/offapi.idl` is empty)

Change-Id: Ibac6d00f9b6fa3fa4d4ac491af66ea4938b36b87
Reviewed-on: https://gerrit.libreoffice.org/63424
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-15 16:55:55 +01:00
Stephan Bergmann
755d79e05c Use C locale in UITest
b96180cb9b "uitest: set en_US.UTF8 for the
LibreOffice instance" had made UITest use the en_US.UTF-8 locale (passed from
LIBO_LANG to LC_ALL when starting soffice in uitest/libreoffice/connection.py),
for unstated reasons.

The mail sub-thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2018-October/081318.html>
"Re: master build problems with en_US.utf8 locale" now argues that support for
an en_US.UTF-8 locale in the OS should not be necessary when building LO.  While
absence of OS-support for en_US.UTF-8 apparently doesn't break the UITests (see
<https://lists.freedesktop.org/archives/libreoffice/2018-November/081375.html>
"Re: master build problems with en_US.utf8 locale"), it feels better to make
these tests not use the en_US.UTF-8 locale at all.  At least for me, the tests
ran fine when using the C locale instead.

Change-Id: I23eb2ce540bb40a7b7d13c2a396e313966f03f6e
Reviewed-on: https://gerrit.libreoffice.org/63360
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-15 16:50:30 +01:00
Caolán McNamara
f90fda2eee reformat on set_digits change
Change-Id: If69cee340e48d42b1be56ea6012e6686aa203f53
Reviewed-on: https://gerrit.libreoffice.org/63423
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-15 16:43:41 +01:00
Eike Rathke
7997c12d01 Resolves: tdf#121260 do not force AddressConvention::OOO on parseFormula()
Change-Id: I48b8295fc75e40f5d58f99fc2809c28de48771d5
Reviewed-on: https://gerrit.libreoffice.org/63417
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
2018-11-15 16:05:39 +01:00
Michael Stahl
fc7f3f44a7 Revert "revert 25622f29b4 in list.cxx"
This reverts commit fa2167fe50 ...
and fixes the merge conflicts.

Change-Id: I57fa6b9e7d35e0fc28d941f2968854a52b17b995
2018-11-15 15:33:49 +01:00
Michael Stahl
418206ee07 sw: GSE_INP is dead since CVS import, remove it
Change-Id: Ib0713df614e63c20965979e7e34f7481fe8ed838
2018-11-15 15:10:08 +01:00
Michael Stahl
176b91fc73 sw: fix a search-and-replace gone bad in DocumentFieldsManager.cxx
Change-Id: I6b2df2aee96ab32123d3fa23fd9a2480b3ed3c72
2018-11-15 15:10:08 +01:00