[MS-OLEDS] 2.2.5 EmbeddedObject actually has a last Presentation field,
and we didn't write it so far.
Luckily all the info can be extracted from the OLE2 container, so we can
roundtrip the OLE1 wrapper around OLE2 nicely.
Change-Id: I8d4922428dd5beeaae8b6cd4da0575db7014e4a2
Reviewed-on: https://gerrit.libreoffice.org/63667
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
in words, for example “az Ipsum”, not “a Ipsum”.
This bug was reported by Gellért Gyuris.
Complete commit 1037e3759b
(tdf#115319 references with Hungarian articles)
Change-Id: If930feb11a0308246d2512f0093bcacdc8675d0b
Reviewed-on: https://gerrit.libreoffice.org/63637
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
For whatever reason this now fails on Windows for multiple
users (including myself). Doesn't look like an easy fix is
possible, so this is reverted until I find some more time
to look into it (or give up on it).
This reverts commit baf0d6d65d.
Change-Id: I432637131ba8ac8be614496bd6da0e157372ae94
Reviewed-on: https://gerrit.libreoffice.org/63664
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
...and not for every target's recipe, once solenv/gbuild/CppunitTest.mk is
included
Change-Id: I710160def23fae5f93c5a67ab25e03fdaa008e00
Reviewed-on: https://gerrit.libreoffice.org/63655
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
to make it easier to read.
And fix the last two fall back cases, where it was assigning a different
value to aLocaleStr than it was returning, which means that it would
return a different value on the second invocation.
Change-Id: I6cac1ddd23b0a6a9e4ae8a0b9e7d94c0d877de39
Reviewed-on: https://gerrit.libreoffice.org/63642
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Fixes the preview on Customize tab page
Change-Id: If918522bda573c0f312b04592b4b7de957c9416b
Reviewed-on: https://gerrit.libreoffice.org/63649
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
add some unit tests, and improve the heuristics
Change-Id: I95aa97a87e178ce8d506bd245710d0ae66ad08a4
Reviewed-on: https://gerrit.libreoffice.org/63647
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
very weird code, no need for hiding this bool inside a method
Change-Id: I75ee67af32ab012fe5ab5ae766abc56212bb08e6
Reviewed-on: https://gerrit.libreoffice.org/63643
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
which arrived with
commit bee746960f
Date: Tue Feb 1 13:42:47 2011 +0100
dba34d: limit invalidate calls
and looks extremely dodgy, because it means only the very first report
design window will be correctly configured.
Change-Id: I127c733faaddcacd8507fa74aebe3b6da761327f
Reviewed-on: https://gerrit.libreoffice.org/63641
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
In DOCX, w:pos specifies the position of the current custom tab stop
with respect to the current page margins.
But in ODT, zero position could be page margins or paragraph indent
according to used settings DocumentSettingId::TABS_RELATIVE_TO_INDENT
Added new unit test.
Change-Id: Ic56a8527380b6562f4239df1edce0c9b4649af24
Reviewed-on: https://gerrit.libreoffice.org/63460
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
...(ExprWithCleanups around the CXXConstructExpr in initializers for members of
O[U]String type, with older Clang, as used in
compilerplugins/clang/test/staticconstfield.cxx), and thus revert
e3e8d52625 "Temporarily disable
compilerplugins/clang/test/staticconstfield" again.
Change-Id: Ic5fcdd1a26e4a6810369e4f9d909200d25feb12e
Reviewed-on: https://gerrit.libreoffice.org/63628
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I031faa67192f21d20938c8cc8056db138326a1ca
Reviewed-on: https://gerrit.libreoffice.org/63143
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Move XEnumeration Java test to C++
for ScIndexEnumeration_SubTotalFieldsEnumeration.
Change-Id: Ibe2b283e99230c5e517eb80858ff31459f2c9844
Reviewed-on: https://gerrit.libreoffice.org/63627
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
This fixes OSX "make debugrun" by dropping VCL_HIDE_WINDOWS
handling and removing the internal GetPseudoHeadless() API.
While at it moves the DialogCancelMode enum out of Application.
Change-Id: I4876e752ddbfc39dd44faa673fb0e97810089a75
Reviewed-on: https://gerrit.libreoffice.org/61598
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Regression from commit af313fc149
(tdf#105143 DOCX import: enable DoNotCaptureDrawObjsOnPage layout compat
option, 2017-01-06), the group shape which covers most of the single
page in the document had a negative left position, while it should have
a small positive one (checking the drawingML markup).
This was a pre-existing problem, but now it's visible since we no longer
force objects to be on the page in Word compat mode.
Seeing the ODT import never positions group shapes (it's just a
container for child shapes), probably the DOCX import shouldn't do that
either. Start moving into this direction, first only for
absolute-positioned toplevel group shapes only, which already fixes the
bug.
Change-Id: I152ba06a81a2bd09195a4c724da4b8878b0457bb
Reviewed-on: https://gerrit.libreoffice.org/63606
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Move XEnumeration Java tests to C++
for ScIndexEnumeration_SpreadsheetViewPanesEnumeration.
Change-Id: I03c05cd894bf84816618ac28deb01ecb2fd8779e
Reviewed-on: https://gerrit.libreoffice.org/63622
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
This is just a minimal solution and obviously not fully parallel.
We still have to walk the tree twice:
1. copy all needed headers to dist (export export_private)
2. the parallel build (libs)
The fixes are:
* Add a few rm and @$(MAKE_OBJDIR) calls to various targets
* Serialize minimal steps in nss_build_all
=> Build libs of nss/lib and nss/cmd/lib before all other
=> drop the minimal all target
* Make $(SHARED_LIBRARY) depend on $(LIBRARY), otherwise dll lib
creation on Windows builds a static lib, instead of the dll one
* Drop all "export:: private_export" rules. We run this before
the build and duplicate targets break the header install
Change-Id: I1c35985c90d2d63990e04a0d2bb9d8ae921a2182
Reviewed-on: https://gerrit.libreoffice.org/62011
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Move XEnumeration Java tests to C++
for ScIndexEnumeration_SpreadsheetsEnumeration.
Change-Id: Id6fbc4dab54e2b50be42df7ade912a5aaf1cb97c
Reviewed-on: https://gerrit.libreoffice.org/63621
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Move XEnumeration Java tests to C++
for ScIndexEnumeration_TableAutoFormatEnumeration.
Change-Id: Ibe9f4cffaecc4f3fada04f82425031e6773b32d7
Reviewed-on: https://gerrit.libreoffice.org/63619
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Move XEnumeration Java tests to C++
for ScIndexEnumeration_SheetCellRangesEnumeration.
Change-Id: Ic3bc6f38244c4f476d29826accc397b4b6902f31
Reviewed-on: https://gerrit.libreoffice.org/63605
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Move XEnumeration Java tests to C++
for ScIndexEnumeration_FunctionDescriptionEnumeration.
Change-Id: I6c15abff293996a6bac8e4a6c0004853fae13990
Reviewed-on: https://gerrit.libreoffice.org/63604
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
• No need for a horizontal line to be randomly there.
• Get rid of GtkFrames that enclose only one element.
Seriously, they are cancer. Use them properly!
• … and while I’m here, use a stock label for the Search button.
I noticed the associated help page not using the “Go” name.
Change-Id: Id196d8d970a219285c5cc606ab9b4327cdce2e91
Reviewed-on: https://gerrit.libreoffice.org/62238
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
its removed when the object was removed from the page to be reinserted
as as a group member
Change-Id: I8edeb89ae07b73572b65413817212a79ef8957b3
Reviewed-on: https://gerrit.libreoffice.org/63578
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Move XEnumeration Java tests to C++
for ScIndexEnumeration_DatabaseRangesEnumeration.
Change-Id: I33fac410b4b05f88dad45f859ae466fabb8303fc
Reviewed-on: https://gerrit.libreoffice.org/63592
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Of the "Gerrit Linux clang/dbgutil" build nodes, one (tb79-pollux) has done the
lode update to use Clang 3.9.1, while the other two nodes (tb75-lilith and
tb76-maggie) are still at the old Clang 3.8.0. When building Gerrit changes for
master, tb79-pollux started to fail in
compilerplugins/clang/test/staticconstfield now
(<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/20247/> and
<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/20252/>) while such
builds on the other two nodes still succeed. So it looks like Clang 3.9.1 has
some issue with that loplugin, which will need further inspection. For now, to
not break Gerrit/Jenkins builds, disable that test.
Change-Id: I1bd380fb98d3b9a411dd04578a5620cdb27cd35b
