an event listener. This crashes when loading a document with print preview
set as active view.
Regression after commit 128ecffe53.
Change-Id: I5dc421f7c08dd70d51772fac5432f33cd9a1491a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99442
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
See tdf#74608 for motivation.
I have changed this from single-instance to multi-instance to avoid loplugin:staticvar
and because I can't see a good reason for a dialog to be single-instance
Change-Id: Ic7c917fd4923dce11466069e9531bf44989a1ae9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99421
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
... because trying to activate this view on load will throw and crash
Unlike in Writer (SwPagePreview), Calc's ScPreviewShell overrides
WriteUserDataSequence to export the view data. This was implemented
in commit 1f51730f3c. That does not
give any clue why is this necessary, so I don't want to revert it.
So to pass the flag to XViewDataSupplier::getViewData, this patch
sets the flag in current context using comphelper::NewFlagContext.
This allows to only skip providing the data conditionally.
Change-Id: I95d70b30b0b8762d2b5c703c3e572064d0b2ef75
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99441
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tables can be empty/not populated during import, bail out in such cases.
Change-Id: Idfefdc153215ff5150aa2040858349ed9f0198a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99415
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit 46068e8b1e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99393
Tested-by: Jenkins
OColumnControlWindow can be seen used in "use wizard to create table" from base
Change-Id: Ib59b487c6711321550c1b516986ef20df402b171
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99414
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
which is exactly the same thing, but doesn't need vcl::Window
Change-Id: I3d41315b5a656563ba8c861aa86bb27f1b00a15e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99384
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
making it similar to GtkEntry
Change-Id: Ic3621dc308222b2464f0daf919a10b81bc887f6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99381
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
where active means the frame has focus
Change-Id: I9f2e7f7bdd8824894e5c99c6b145ec84c1491485
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99379
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
That was the actual intention.
Change-Id: I2967cea8ae3099e8523438a68c076a786042e15a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99297
Tested-by: Jenkins
Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Don't replace the right string by application name
It seems to come from:
commit b5483af985
Author: Thomas Arnhold <thomas@arnhold.org>
Date: Fri Aug 15 21:28:56 2014 +0200
ErrorBoxes from datanavi to String
Change-Id: Ifd5a49537d0574bc2fb6530e70d19c31a35da914
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99371
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
I have a linear algorithm where some elements should be scaled down, but
not all of them. These requirements are described using rules. This
commit just adds the parsing for them, so that later
AlgAtom::layoutShape() can create an improved layout, taking rules into
account.
Change-Id: I5f0f9ffcaff75a804796851e48a9ce10583ec362
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99377
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
This 6.1.4/6.2 hack for tdf#118393 wasn't interested
in isCellOpen, and should have questioned why isTextNodeEmpty
was preventing the necessary page style change.
So purge it, since the removal of isTextNodeEmpty
obsoletes it.
Change-Id: I615ae84ac46f129b09b18555794ed89c42ba93b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99179
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
...for gdb to autoload it
Change-Id: I9a65a03fe18623181d5791b4596b4416228c6c8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99372
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
to allow an integer parameter as the row/column index of the freeze and
use them to set/get freeze indices (row/column) from the lok clients.
The behaviour of the exisiting freeze/split-panes controls in desktop
Calc is not affected, but new menu/notebookbar options can be added for
freezing on a specific row/column in a follow-up commit.
For now, the freeze-panes are shared between all views for each tab of
the spreadsheet. "Private" freeze-panes support can also be added
without much difficulty (for this we need another uno command for the
private/shared flag, but that can be in a separate commit).
Notes regarding compatibility:
Since Online-Calc has support only for the freeze-panes functionality
presently, any pre-exisiting 'real splits' in the spreadsheet (created
using the native-desktop Calc or alternatives) are converted to
equivalent 'freezes' on import, but on export, such 'freezes' are
re-converted and written as 'real splits'. In case the spreadsheet has
'freezes' on import, they are used/exported as such. In short, the type
of sheet-window splits in the document are preserved.
Change-Id: Ia990616f5cedfb2b5db820770c17ec7e209f0e48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99347
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
Tested-by: Jenkins
