<https://ci.libreoffice.org/job/lo_ubsan/1709/> still failed with
> FAIL: test_insert_hyperlink (hyperlinkdialog.HyperlinkDialog)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/tdf/lode/jenkins/workspace/lo_ubsan/sw/qa/uitest/writer_tests3/hyperlinkdialog.py", line 71, in test_insert_hyperlink
> self.assertEqual(get_state_as_dict(xindication)["Text"], "link")
> AssertionError: '' != 'link'
> + link
>
so try a fix similar to 27798238ec "uitest : Avoid
any timing issue in test_insert_hyperlink"
Change-Id: I04b1616f3c5028065aafadbd73e0e52ef220ce5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99669
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...if the specified tabstop would be ignored - for the benefit
of MS Word.
After the numbering character, the tab in Writer stops at
A.) IndentAt, or B.) a non-default tabstop.
In other words, Writer ignores default tabstops.
(Caveat, LO ignores IndentAt when numbering sets a larger tabstop.)
However, MS Word does NOT necessarily stop at IndentAt,
but it stops at default tabstops, or a specified tabstop.
It only seems to stop at IndentAt if there are only
default tabstops that are farther than IndentAt.
In other words, Word usually ignores IndentAt.
(This is true for .doc and .rtf formats. It is also true for .docx
format with MS Word 2003, but not with MS Word 2016.)
In this patch, I only try to fix Word ignoring the IndentAt.
[A basically-unsolvable edge case is when the tabstop is larger than
the first line indent, but still not behind the numbering character.]
This patch could regress if paragraph-level tabstops define the position.
In that case, we have introduced another tabstop at the indentAt
position, and so a SECOND tabstop on the FIRST line might end up
at the wrong position. This is an EXTREMELY unlikely situation,
and in fact, both LO and Word seem to tabstop there anyway,
so I no longer think it would cause a regression. Go figure.
I heavily modified an existing unit test because
although that fix "works" and was an "easy fix"
it probably ought to have calculated the IndentAt and used that
instead of zero to replace the LO default values.
It works, however, so I won't bother doing anything about it.
(Also, the paragraph used doesn't matter - it is the same list.)
Change-Id: Ia13ac880ab63c610b26c99ab77903e08ebdebe35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99529
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
It turns out this doesn't really matter in practice, since if
converting between pixel formats is where time is spent, something
higher must be already wrong. But since I've already written this...
Change-Id: I25451664d529a9226d2d81b2c424a4f4e5422ad5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99577
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
This CSS key is allowed, but only the underline and line-through values
are allowed in reqif mode, according to the top of page 66 of
"01_OMG_Requirements Interchange Format (ReqIF)_Version
1.2_formal-16-07-01.pdf".
Change-Id: Ide64344f58bde4569fe499d8514dab36a055bda9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99662
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
... at start of document, part 2:
In SwUndoDelete::UndoImpl(), the m_aEndStr wasn't inserted, because the
pTextNd was a section node.
This caused asserts when trying to add the history hints that used to be
in the end text node.
thints.cxx:1295: bool SwTextNode::InsertHint(SwTextAttr*, SetAttrMode): Assertion `!pAttr->GetEnd() || (*pAttr->GetEnd() <= Len())' failed.
(regression from 57d4886605)
Change-Id: I48caa7487d2d1e6250b5aceab18f270555d3ee8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99644
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
The problem in CopyImplImpl() is that pCopyPam's end position was
updated to index 0 but text was copied into the node, which is thus not
covered by pCopyPam and thus also not by SwUndoInserts.
Then SwUndoInserts::UndoImpl() doesn't delete the bookmarks in the end
node and the bookmark positions cause ~SwIndexReg asserts.
Change-Id: I4cc03e846eae4cabd9eb4346a98c1e5c2866050d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99643
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
* Update helpcontent2 from branch 'master'
to dfa74e26624aa6ac3d3e58773d56aca4647c0aab
- Improve image attributes in Format Menu -related listings
Change-Id: I75798c8c0ecc6ce7b94b523d122c15dc37fcccd3
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99658
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Copy all version infos in English
Change-Id: I6719e27f721b0ff9f06efb4ea63e286e6d58ebf4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98498
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
instead of checking for changes to them when the fontbox get focus, its now too
late at that point to update ComboBox WYSIWYG mode
Change-Id: Ieea6a4c00be2eb46909d46af29ddd615fff002d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99646
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
so that for the transparent color case we remain showing the original
background and not that part of the icon
Change-Id: I20452c7eccf141fdbede9ed2476270315963022e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99589
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
if the widget triggering the change is the width widget and this callback sets
a different value to the width widget, then rerun the callback using the width
widget to end up in a state consistent with the width widget value.
gtk already resends value-changed if the value of the widget changed during the
callback so this ends up aligning the vcl behaviour to the gtk one which appears
desirable in this case
Change-Id: I32d0e1bb17190279efc552781851e5a18b417154
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99635
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Old search function was demo to test something. This function uses the JSON response to search, not the API call to search.
Change-Id: I0f4163a55331667a73f15dd220302f58a27831c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99388
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Update shadow tab in area dialog with spin button to control blur radius of the shadow.
Change-Id: I41f072ef10d280df4b118afae7a7c058eb975417
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99557
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
if the user presses enter to activate the Entry try to go to the page, and on
success we move focus to the document.
if the SpinButton changed value a Timer was launched, when it times-out, move
to the desired page, but leave focus where it currently is, i.e. typically
remaining in the spinbutton, or whatever other widget the user moved to in the
meantime
This replaces always grabbing focus to the document on a page-change and
re-grabbing focus back to the spinbutton.
Change-Id: I597597aedb1753aee755671a2a55779ca6196c09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99611
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* Update helpcontent2 from branch 'master'
to 29d0bdaaa732169e6ed60a66c1153b16765d6e82
- Refactor elements in Format Menu -related listings
Used xsltproc helpers/refactor.xsl
Change-Id: I0b896dc1906cb5a9c2a34a494ec13eabe2c7ed54
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99627
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
* Update helpcontent2 from branch 'master'
to 008ccd9f3a7a5938ceca575ceb6981cacbee3fcd
- Add comments about Format Menu -related listing
Change-Id: I1a9ec42ccf95ebdbc01666a776747307589942cc
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/99588
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
as well as the split-buttons. We don't draw into the icon for
widebuttons, but we do need to draw the icon into the replacement
wider image so we want to update for widebuttons too
Change-Id: Ia37f7de7faa08e63a498ff474a46a98566930acd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99575
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
so use ImageType just to detect the user has selected a new size,
and use the size of the returned image for the icon pixel size
Change-Id: If101c586bd2f0d83f668637b48ce3d25a0873358
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99561
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
