Commit graph

388908 commits

Author SHA1 Message Date
Caolán McNamara
1ffa92cfe3 coverity#1326333 Unguarded write
Change-Id: I94026a7b66a0cac01a1e42d8eee0ec7b4d5fc513
2016-03-04 11:24:27 +00:00
Stephan Bergmann
d35eac83ab This is test code, OK to unconditionally print to stdout
...and where appropriate use CPPUNIT_ASSERT_EQUAL to have no need to always
print out certain values

Change-Id: Iad2ccb235b09852fffd3f010cf069c45b36e2d4b
2016-03-04 12:21:03 +01:00
Noel Grandin
46c67c4323 loplugin:unuseddefaultparam in tools
Change-Id: I027f4d53e3aa793bd61bf110899e464a9b6430ec
Reviewed-on: https://gerrit.libreoffice.org/22891
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-04 11:20:09 +00:00
Katarina Behrens
ff45bc3346 tdf#98083: Always save cell format
it was pretty bad idea not to save it for rich-formatted cells
(tdf#92296) as there is more to cell format than just a font

Change-Id: I0e5e7d7187c69519bb8f4de2b627e385fccd3d46
Reviewed-on: https://gerrit.libreoffice.org/22762
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-04 11:16:46 +00:00
Stephan Bergmann
066a81ee8d This is test code, OK to unconditionally print to stdout
Change-Id: I419aba8728b3a65fca69c82a4f950daaf4815187
2016-03-04 12:14:51 +01:00
Stephan Bergmann
443208dce7 Remove write-only g_nSocket* debug vars
Change-Id: Ie8a1d015242450094928863013030b4cb0bb1f4e
2016-03-04 12:07:15 +01:00
Stephan Bergmann
4b47853acc Clean up a SAL_WARN_IF
Change-Id: I8a945f3e83559f421aa1a0b4fbfcec1b25932ef7
2016-03-04 12:05:42 +01:00
Miklos Vajna
78a209b951 CppunitTest_xmlsecurity_signing: add signature append testcase
Fails with e.g. commit 963264a417
(xmlsecurity OOXML export: don't loose old signatures when adding a new
one, 2016-03-03) reverted.

Change-Id: Ia2b0f3d8914bca14075481f5ac8cd4c0033d26c1
2016-03-04 11:48:48 +01:00
Miklos Vajna
e89610dad6 xmlsecurity OOXML export: only cache existing signatures, not our temp. one
When adding a signature, first we export it to a temp. storage, then
read it back, show the verification to the user, and then later we do or
do not write the temp. storage back to the original one.

This means the signature gets exported two times, and MSO only considers
the final result valid. So when caching signatures (to avoid a real
export based on our data model), don't cache the one we just added to
the temp. storage, but do a real export second time as well.

With this, MSO considers our appended signature (next to an existing
one) valid, too.

Change-Id: I4d615298463e037ea4e654ff5c3addcef8b0a094
2016-03-04 11:48:48 +01:00
Miklos Vajna
38c39dc49c xmlsecurity OOXML export: fix appending new signatures next to existing ones
We append a new signature to a document by re-exporting the existing
ones, then writing the new signature. Given that existing signatures
aren't canonicalized before hashing, write them back as-is.

With this, our own signature verification is happy about the export
result, containing an existing and a newly created signature.

Change-Id: I0ff57a2266c6070a945f0c45ca5793406678be60
2016-03-04 11:48:48 +01:00
Miklos Vajna
b9fb9062a9 sw, sd: indentation fixes
Change-Id: I4813488d94e6ae2877cdaf39a3849bccb83c389d
2016-03-04 11:48:48 +01:00
Andras Timar
6e9a41dbc2 create empty .lproj directories for languages supported by OS X
The previous solution had problems. InfoPlist.strings were empty,
because localization has not been working since the CFBundleTypeIconFile
entries were removed from Info.plist. Icon file basename was the key
in documents.ulf. So we packaged 0 bytes long files. The second problem
was that we used LibreOffice language codes, and OS X language codes are
different in some cases. This caused problems such as French strings on
English UI (e.g. Open/Save dialogs), because the system did not
recognize en-US.lproj and en-GB.lproj, and fell back to the next one: fr.

Conflicts:
	Makefile.in

(cherry picked from commit 91902ef1411943f65da296fefd15fff9170d9c0c)

Change-Id: I9c502cdf737b497ca2ceef8f3c535ccfea2f6134
2016-03-04 11:29:50 +01:00
Tor Lillqvist
ca3e8b0299 Remove potential old leftover before moving the app bundle
Change-Id: I7f0a8ae184a2f3d8a4476415b56df4ad8e4e342f
(cherry picked from commit 53c396c7008b807cffcc501171520b28c3f2ad24)
2016-03-04 11:28:46 +01:00
Tor Lillqvist
8c25e92bb9 We don't build the Apple Remote code when sandboxed
So no need for the related entitlements.

Change-Id: I54ba7c0586ee77f30096b50755a9a85bbb7965a5
(cherry picked from commit a1379c6d25)
(cherry picked from commit d78c567c78e9d0f4e122caab527da23f69dec6d3)
2016-03-04 11:27:44 +01:00
Tor Lillqvist
fd34a19b4d Seems that we don't need the com.apple.application-identifier after all
Conflicts:
	lo.xcent.in

Change-Id: I3bc499b15c31724dca2d49123dcdbec8dfd934f6
(cherry picked from commit fc01d27ea172809ae7bdbd85df161d5a033d4533)
2016-03-04 11:24:04 +01:00
Tor Lillqvist
2bcef51421 tdf#92191: Don't use any IPC pipe in a sandboxed OS X app
Creating the pipe fails when sandboxed. This caused us to not start
the OfficeIPCThread, and that then meant that the file open requests
coming in through VCL_NSApplication's application:openFile: method in
vclnsapp.mm were not processed properly.

The OS takes care of not starting multiple LO apps simultaneously
anyway, so we don't really need any pipe, I hope.

Conflicts:
	desktop/source/app/officeipcthread.cxx

Change-Id: Ia920520ce2928787313f83199028f9c9942f61f3
(cherry picked from commit e2f4c9eae3f53aaba968d7567f912df6fa911326)
2016-03-04 11:17:55 +01:00
Tor Lillqvist
8ba6e0d6b1 Skip some executables in the OS X sandboxed (Mac App Store) case
I doubt end-users will miss gengal.bin, regview, or regmerge.
We need the gengal program at build time. But don't bother shipping
it on OS X, at least not in the sandboxed (App Store) case.

Change-Id: Id73bef1ba71d126c2d2962fe846e9c31963d6c24
2016-03-04 11:17:55 +01:00
Tor Lillqvist
02c0669017 Mention that there are two disjunct sets of callbacks
Change-Id: Ia8f18666c766cafa63cc702bfdfa69e971cf0e71
2016-03-04 12:07:47 +02:00
Noel Grandin
03614918c0 loplugin:unuseddefaultparam in sc
Change-Id: Id461fc600bec5fe372875c2dcf405997fcf9f0b4
2016-03-04 11:48:05 +02:00
Noel Grandin
fb6c99f21e loplugin:unuseddefaultparam in svtools
Change-Id: I3ef15fa33791bc5e59c36c1e80f669c7e1e7044b
2016-03-04 11:48:04 +02:00
Noel Grandin
1fbc20dad2 loplugin:unuseddefaultparam in svx
Change-Id: Iacd4ed12c6c5dfdc2f31f85c8c1ce2cee8a8641f
2016-03-04 11:48:04 +02:00
Noel Grandin
9cc8a26fcd loplugin:unuseddefaultparam in sw
Change-Id: I1a8a25c09ae0c8ba39fcedb032562df93fdd6ba4
2016-03-04 11:48:04 +02:00
Noel Grandin
9a1e6d916e loplugin:unuseddefaultparam in sfx2
and fix an issue with calls to templated methods in the plugin

Change-Id: I9c9537a0690ff671286c007846d5f4cfb7d2982b
2016-03-04 11:48:04 +02:00
Jaskaran
6610ad9aee tdf#93889 Remove a busy loop
Add SyncFocusState(). Before we needed
pRefInputEdit or bRefInputMode.

Change-Id: Ib1d8c4d26f45824fd6652ef29d56ddf8d276319d
Reviewed-on: https://gerrit.libreoffice.org/22823
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-04 09:43:01 +00:00
Stephan Bergmann
3aafe0568b -Werror,-Wnon-virtual-dtor
Why was CDTransObjFactory a class with virtual functions in the first place?

Change-Id: I315243a2268be67e03feb923ca7f64fd37818337
2016-03-04 10:11:18 +01:00
Stephan Bergmann
0e53c653fb -Werror,-Wnon-virtual-dtor
Why was CCustomControlFactory a class with virtual functions in the first place?

Change-Id: I4449a6f69f45a5b294b1906d0ce8a1a8a52c1d7f
2016-03-04 10:11:17 +01:00
Stephan Bergmann
10aec5f91f Silence -Werror,-Wnon-virtual-dtor
Change-Id: I643c7e8ad12f255822c51a8f295e95f8799ef36a
2016-03-04 10:11:17 +01:00
Stephan Bergmann
e6a3818509 -Werror,-Wunused-macros
Change-Id: Ia8ea71174361b1f685a1a9c038c7ee809e54e0ef
2016-03-04 10:11:16 +01:00
Stephan Bergmann
3889b2894f external/redland: -Werror,-Wundef (__GNUC__ vs. clang-cl)
Change-Id: I1998dc90f20958ea8631e4db49e7f5206c907978
2016-03-04 10:11:16 +01:00
Stephan Bergmann
7d697c7e22 external/python33: adapt to -Werror,-Wundef being enabled for clang-cl
Change-Id: I82bedca98ed5ec22b434c7b25c87bf5d77e7ed21
2016-03-04 10:11:16 +01:00
Stephan Bergmann
69ae921004 external/nss: -Werror,-Wundef (__GNUC__ vs. clang-cl)
Change-Id: I4641767451ac1ec9f580d24bafa57a11e2f99ac3
2016-03-04 10:11:15 +01:00
Stephan Bergmann
61b541e9ef external/liblangtag: -Werror,-Wundef (__GNUC__ vs. clang-cl)
Change-Id: I4213eb841d7eb3627ae64cc242b81b8e7f09cc79
2016-03-04 10:11:15 +01:00
Stephan Bergmann
6b68df5763 Adapt to more warnings being enabled for clang-cl
Change-Id: I62b1e2f5b4918514a7a04bb6a44e55fc21a475af
2016-03-04 10:11:15 +01:00
Stephan Bergmann
c6086ca653 Silence -Werror,-Wnon-virtual-dtor in generated UAccCOM.h (clang-cl)
Change-Id: I9466931485ed5421be589def16185d5c036bdcb8
2016-03-04 10:11:14 +01:00
Stephan Bergmann
ba57e60a6e Silence -Werror,-Wnon-virtual-dtor
Change-Id: I3fdf72b014d2ca0b0bd96fc5eba5606b13b32258
2016-03-04 10:11:14 +01:00
Stephan Bergmann
7f0e9654e5 -Werror,-Wshadow
Change-Id: Ic87e8aacb2e8215751422969e78cc58e18fc5a42
2016-03-04 10:11:14 +01:00
Stephan Bergmann
183dbfe3a7 -Werror,-Wshadow
Change-Id: Idf72ab1a311fcbbc81b16d9a3c1e78aaa10332c0
2016-03-04 10:11:13 +01:00
Stephan Bergmann
5a7289dc14 Silence -Werror,-Wnon-virtual-dtor in external includes
Change-Id: I2ef42eca934588b219de52dfc7c373395118cc32
2016-03-04 10:11:13 +01:00
Stephan Bergmann
f43e0fe4d6 Silence -Werror,-Wundef in external/poppler includes (clang-cl)
Change-Id: I42ae8b5d1769eba3e5af68b3b183c77f40c35ca8
2016-03-04 10:11:13 +01:00
Stephan Bergmann
35133f6035 -Werror,-Wunused-macros
Appears to no (longer?) be relevant here, as reported by clang-cl.

Change-Id: I339f8b04eb733a9c6a97fcd4b9b4758e6a84d5c3
2016-03-04 10:11:12 +01:00
Stephan Bergmann
b542088240 -Werror,-Wshadow
Change-Id: I944d7bd40a297dac97b954196a0e8e286f0ba712
2016-03-04 10:11:12 +01:00
Stephan Bergmann
00af78ed90 -Werror,-Wunused-macros
<https://msdn.microsoft.com/en-us/library/windows/desktop/ms647466%28v=vs.85%29.aspx>
"About Strsafe.h":

  When you include Strsafe.h in your file, the older functions replaced by the
  Strsafe.h functions will be deprecated. Attempts to use these older functions
  will result in a compiler error telling you to use the newer functions. If you
  want to override this behavior, include the following statement before
  including Strsafe.h.

  #define STRSAFE_NO_DEPRECATE

Appears to no (longer?) be relevant here, as reported by clang-cl.

Change-Id: I94a576b71a2a34edd6009059fc5047ba59ec0f12
2016-03-04 10:11:12 +01:00
Stephan Bergmann
a1a24137b3 Silence -Werror,-Wnon-virtual-dtor
Change-Id: Ie346bca98a2da91e20ddb533ab19720f193291d4
2016-03-04 10:11:11 +01:00
Stephan Bergmann
a0997faf07 -Werror,-Wunused-macros
Change-Id: Ib333ad2880e0a1cbfed2f6a919ca2b92f42dde45
2016-03-04 10:11:11 +01:00
Stephan Bergmann
392d32856d -Werror,-Wunused-macros
Change-Id: I0ac1ba124ba452deeeeaa473ccbbf865e490c447
2016-03-04 10:11:11 +01:00
Stephan Bergmann
ae95f93527 -Werror,-Wshadow
Change-Id: I1e26a805ac96f1c57d2f7c795b598c4eaa8d2a3e
2016-03-04 10:11:10 +01:00
Stephan Bergmann
cb859ddcb1 -Werror,-Wshadow
Change-Id: I4893f538911449953fadf4cf10f6adb819bc023f
2016-03-04 10:11:10 +01:00
Stephan Bergmann
9bc10687fc -Werror,-Wshadow
Where wglChoosePixelFormatARB is defined as a macro expanding to
__wglewChoosePixelFormatARB (as WGLEW_GET_FUN is just expanding to its
argument), and __wglewChoosePixelFormatARB is declared in global scope in
workdir/UnpackedTarball/glew/include/GL/wglew.h.
itself) in workdir/UnpackedTarball/glew/include\GL/wglew.h

Change-Id: I0c4d09e9112c2233d25a262ea1f2b35bdf49645c
2016-03-04 10:11:10 +01:00
Stephan Bergmann
a93374a7b4 Silence -Werror,-Wnon-virtual-dtor
Change-Id: Ibe968bdb968a0a86723fcc2c9fa958261724c7da
2016-03-04 10:11:09 +01:00
Stephan Bergmann
b1d9fe788e -Werror,-Wshadow
Change-Id: Ie6a35ce1fece5de31f455d88ab3e12010b8047f5
2016-03-04 10:11:09 +01:00