Project: help 743ed49ef0759b6cbd65d707ae9b8bba90e81a4d
“Mail & News” is just “Mail” now
Support for the news:// protocol was removed in core commit 6d089a4c7
Change-Id: I858331b9fc73502915cbd5fc2a8618e0837ba2a6
Project: help 32a855a02c55f864af7b2d1a7ebddd55043e297b
tdf#92825 Update Impress’ Master menus
For now I removed the tip paragraph on “Format > Slide Layout”, which is
a very old window (from ~2004-era OOo) that nowadays is replaced with the
Sidebar (and before the Sidebar, it was replaced with the Tasks pane).
This tip linked to more obsolete content… It’s a growing snowball. We
really need to get ourselves busy and rewrite all that.
Change-Id: I70e48f7613a0b17649e88f12c986a5ff1969deba
... ending with comma and followed by non-space.
Change-Id: Ia00c662e31940270690c64e1840417436565a6c7
Reviewed-on: https://gerrit.libreoffice.org/24260
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
... instead of continuing the detection loop and being
"detected" as plain text. The detection API will from now
return a type based on the file extension only, which is
far more useful than "plain text" anyway. Plus the media
descriptor has a flag to indicate that the detection wasn't
completed, which can be also used by the loading code to
abort the loading process.
Change-Id: Ida37e2687bd5cd86b5780620724e9bce82e11946
Reviewed-on: https://gerrit.libreoffice.org/24428
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Originally in 2004 commit 0339e43208 added a
"DBG_ASSERT( GetOutDevType() != OUTDEV_PRINTER, "DrawImage(): Images can't
be drawn on any mprinter" );"
Recently commit f749ffbdf4 made the mistake
of trusting this assertion to be correct and added Printer::DrawImage()
overrides that do a hard "assert()" now and don't do any drawing.
Armin claims that the implementation of OutputDevice::DrawImage() should
actually work for Printer as well due to fall-backs and thus the
original DBG_ASSERT was misleading.
This matters when printing documents that contain form controls
such as ImageControl.
Additionally, Image::Draw() should not return early when
IsDeviceOutputNecessary() is false, because that is the case when
printing, where instead a meta-file is recorded.
The called OutputDevice::DrawBitmapEx() will check
IsDeviceOutputNecessary() internally anyway.
This check was actually always there, so i do not understand how this
should have worked in LO 4.2, as the bug reporters claim.
Change-Id: I92ba19e7036197d1dde88c361f8e1cb59fae3a60
Don't do it for the MSVC libraries though, e.g. on my system loading
msvcr70 fails, but the SDK example works without problems.
Change-Id: I81bc0b64967e7abb74ca1fff7a2e4b4dbd75d5a5
Reviewed-on: https://gerrit.libreoffice.org/24432
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
When exporting to doc, ensure that the FKP entry for direct character
formatting is closed at the end of a paragraph, so that any direct
character formatting in the next paragraph does not apply to the
end-of-paragraph marker (CR).
Also revert the changes for i#119650 and tdf#87437 which targetted
more specific examples of this problem, as those issues should now be
covered by this fix.
Add a test case for the example from tdf#99474
Change-Id: I2cb482adb39a84f152707dafcb18f289ca0bd550
Reviewed-on: https://gerrit.libreoffice.org/24402
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
- Fix the check for --enable-compiler-plugins not being included in
the resulting StaticLibrary_iwyudummy.mk file.
- Disable warnings about unused const variables to reduce noise.
Change-Id: If54dfd55f46631bbc526326bed5c272358fb9cf3
Reviewed-on: https://gerrit.libreoffice.org/24419
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
It's more robust to restart soffice after every file, even if it takes
more time, overall it's better than having to prune all the files that
are invalid or cause loops before running convwatch.
Change-Id: I7f7155f71bb2522ae48182aa1b5ca61fc47ae4d5
Recently some new developers accidentally used "resubmit", intending to
upload a new revision of their change, but it actually always creates a
new gerrit change.
4e15809a78 claims that "resubmit creates a
new Change-Id for the current change and thus allow to submit changes for
review on release branches that were already reviewed on master", but
that is not actually required with gerrit versions that were in use in
the recent years, gerrit is capable of tracking Change-Id per branch.
Change-Id: I66eda4dbc6f4ff1e235105b3f55041cda88a6b60
First the table is formatted properly and then the following paragraph
is formatted, along with its anchored objects.
The Fly frame is aligned to the bottom of the page by
SwAnchoredObjectPosition::_AdjustVerRelPos() without checking for any
overlap, and thus overlaps the table.
Then SwFlyNotify and Notify_Background() invalidate the table's PrtArea,
and the table responds by splitting numerous times, until finally there
is a page where the table does not overlap with the fly any more.
Instead of the table splitting, the paragraph with the Fly anchored to
it should move to the next page; suppressing the table invalidation in
Notify_Background() appears to achieve that.
Change-Id: If65879f1756856bda344e0ef8fbffbc33e80f3ec
Reviewed-on: https://gerrit.libreoffice.org/24307
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Revert (parts of) various commits that tried to use LIBO_INTERNAL_ONLY features
in external odk/examples/ code.
Change-Id: I275c3e8979c995430329bca61e51b2841503234f
mostly missing explicit before ctors and
uninitialized member vars
one odd use of std::find
> compilerplugins/clang/implicitboolconversion.cxx
> 800 stlIfFind warning Suspicious condition.
> The result of find() is an iterator, but it is not properly checked.
Change-Id: Iade53494cd7fe8ddb0e110e431449ae5a517fe3b
Reviewed-on: https://gerrit.libreoffice.org/24398
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
"passing an object that undergoes default argument promotion to 'va_start' has
undefined behavior [-Werror,-Wvarargs]"
just drop the variadic overload and use the one taking a WizardPath (i.e., a vector)
Change-Id: I6e389f60f8b7cb0633bf173bde69af1c5af86048
"passing an object that undergoes default argument promotion to 'va_start' has
undefined behavior [-Werror,-Wvarargs]"
just replace the variadic function with one taking an initializer list
Change-Id: Ied3dfe835dcebef48cf35374ec4d8835f98e6779
XCUBasedAcceleratorConfiguration::getPreferredKeyEventsForCommandList() throws
if the command string of a menu entry is empty. Parent entries of sub menus of
extensions are empty. As the method doesn't know about the source of the command
a dummy entry is supplied.
Change-Id: I1d12bbf41c22b66e9ee29f1f05ea216134168795
Reviewed-on: https://gerrit.libreoffice.org/24423
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Rewrite call of rtl::OUString::operator= with empty string constant
argument as call of rtl::OUString::clear.
Change-Id: Ib53fcfcca95e8c46f8ae24d648d7b9bf421df3f5
replace the old declare and don't implement pattern
with C++11 delete keyword
Change-Id: I96c71d512d8dab4ad7c806c2e871604163fc49c1
Reviewed-on: https://gerrit.libreoffice.org/24399
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
