Was previously changed the other way around in
commit 28c89e58d9
Date: Wed Aug 30 15:16:01 2023 +0200
use concrete type for OAccessibleMenuBaseComponent::m_aAccessibleChildren
for no apparent reason.
Change-Id: I0d0c6627134bcef8ac9732cc8a5213ab266afbf7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168005
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
... which is only used in the next line anyway.
Change-Id: I3bb038cfba3b3b31df45ca316242d54442db7220
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168004
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
As discussed in the ESC call of 2024-05-23,
CppunitTest_vcl_gtk3_a11y fails relatively often recently:
> 38 CppunitTest_vcl_gtk3_a11y gerrit_linux_clang_dbgutil
> + this week: have a new problem with CppunitTest_vcl_gtk3_a11y (Cloph)
> + failure is not new, but the frequency increased recently
> + assume: timing issue
Jenkins logs show that failures are due to running into
timeouts, example from [1]:
[...]
found run attribute: CharTopBorder=<Any: (com.sun.star.table.BorderLine2) 0x6831c50>
found run attribute: CharTopBorderComplexColor=<Any: (void)>
found run attribute: MMToPixelRatio=<Any: (float) 1.25>
matching atspi attribute is: mm-to-pixel-ratio=1.25
unknown:0:Test1::TestBody
An uncaught exception of type com.sun.star.uno.RuntimeException
- timeout from dbind at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/vcl/qa/cppunit/a11y/atspi2/atspiwrapper.hxx:302
Increase the timeout for method calls from 2.5 to 10 seconds
in the hope that will help.
(Issue is not reproducible locally for me.)
[1] https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/162811/consoleFull
Change-Id: Ib0eef753cf9f574ee5b2a013a46a0a600c91eb34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168002
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
The gtk3 VCL plugin uses a custom implementation that
has a listbox in a popup (s. vcl/uiconfig/ui/combobox.ui).
The popup window gets shown when expanding the combobox, e.g.
using Alt+Up/Alt+Down while the edit has focus.
Once the popup is closed again, focus is given to the edit
again.
That one correctly reports focus when checked via
`gtk_widget_has_focus`, but for some unknown
reason, the listbox in the popup assumes/claims
it still has global keyboard focus as well, despite it no
longer being visible and the `gtk_widget_has_focus` doc [1]
explicitly mentioning:
> Determines if the widget has the global input focus.
> See gtk_widget_is_focus() for the difference between
having the global input focus, and only having the focus
> within a toplevel.
The tree view listbox still assuming focus leads to it
emitting invalid active-descendant-changed a11y events
when the selected entry changes, which e.g. breaks focus
tracking by the Orca screen reader.
As a consequence, current Orca git main
(as of commit d70919051ef01384c473e08321a88cec52549cd2)
doesn't doesn't announce the new value of e.g. the "Font Name"
combobox in the Writer toolbar when changing it via the
Up/Down arrow keys any more once the popup has been shown.
(It works fine before showing the popup for the first time.)
To avoid that problem, manually unset the focus
using `gtk_widget_send_focus_change`.
Its doc [2] mentions
> This function is not meant to be used by applications.
, but since the focus is apparently not unset
automatically, still use it as a workaround for now.
[1] https://docs.gtk.org/gtk3/method.Widget.has_focus.html
[2] https://docs.gtk.org/gtk3/method.Widget.send_focus_change.html
Change-Id: Ifd32c2a66b4a7b9e827f5c8dc2927c7e359a42aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167994
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
* Update helpcontent2 from branch 'master'
to c9ef3ec7d50ab940d9f9d2a4c255c2cd16a47048
- tdf#130838 tdf#154996 Add warning about copying/moving in record mode
In text/scalc/01/02180000.xhp
- Add statement that sheets can't be moved or copied in Record Changes mode.
In text/shared/00/edit_menu.xhp
- Updated howtoget instructions for "Track Changes" and "Record Changes", including adding Tabbed UI instructions for "Record Changes" and hiding instructions for the Track Changes toolbar behind an application switch, because Calc does not have a Track Changes toolbar.
In text/shared/01/02230000.xhp
- Added variable tags to H1 so that the page can be more easily linked from other pages
In text/shared/01/02230100.xhp
- Moved howtoget function to text/shared/00/edit_menu.xhp
- Updated embed link for howtoget section
Change-Id: I4776c0d45cd5d58a822cf00ede81ae3769ef8218
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167943
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update helpcontent2 from branch 'master'
to 35c331d42654a28c9852187474b102db1c987e53
- tdf#105988 tdf#130024 Update Edit Points Bar help page
Created new file text/shared/02/eliminate_points.xhp so that more detailed information on "Eliminate Points" mode is on its own page.
- Updated the description of the "Eliminate Points" feature to more accurately describe how the feature works.
In AllLangHelp_shared.mk
- Added new page text/shared/02/eliminate_points.xhp
In source/text/shared/01/05270000.xhp
- Added section and variable tags to allow content to be easily embedded in other pages.
In source/text/shared/main0227.xhp
- Added section and variable tags to allow content to be easily embedded in other pages.
- Moved the link to "Converting 2D Objects to Curves, Polygons, and 3D Objects" to a new Related Topics section
- Replaced "Edit Points" section with an embedded link to the description in text/shared/01/05270000 (Edit Points mode) to avoid repetition
- Replaced "Edit Points" section with an embedded link to the description in text/shared/02/eliminate_points.xhp to avoid repetition.
- Created a Related Topics section
In text/simpress/02/10080000.xhp
- Added variable tags to allow the page to be easily linked from other pages
- Changed the Title and Heading 1 from "Curve" to "Curves and Polygons" to reflect current menu options.
Change-Id: Ib9038f35b97b4177e11171bfdedd10c0a4149dd2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167939
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
See <https://bugs.documentfoundation.org/attachment.cgi?id=194306>, the
total height of the endnote separator is now correct, but the
distribution of upper space, line width, lower space is still bad, when
compared to Word.
Our model is 2 spacings and a line width, while Word seems to simply
split the amount of available space: 60% goes above the separator and
the rest goes below.
Fix the problem by breaking up the monster expression for the separator
rectangle in SwFootnoteContFrame::PaintLine(), and then the compat +
horizontal case can do the 60% spacing in the Word compat mode.
The width of the separator is still not correct.
Change-Id: Ic065c138041892225b3c1b7d4bd64d4f1c625611
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167990
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
avoid calling GetTextWidth unless we really need to
Change-Id: Ibb0f378e632fa3fce68b4819028630759baf4eb5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167988
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
For Android Viewer, set the "compact_fonts" LibreOfficeKit
option via environment variable `SAL_LOK_OPTIONS` introduced in
Change-Id: I3dc9f5de876def6e4afc09a43105b1740f7c621f
Author: Michael Meeks <michael.meeks@collabora.com>
Date: Fri May 17 21:25:29 2024 +0100
lok: stop amazing waste of repeated font sizes in each font element.
and adjust the handling in `FontController` to process
the flat lists for font names and sizes that is reported
with that options set, rather than processing
font sizes for each individual font.
(See also discussion in original Gerrit change
for the distro/collabora/co-24.04 branch: [1].).
[1] https://gerrit.libreoffice.org/c/core/+/167799
Change-Id: I85734c1876d152f4f95f9182629affd6b250fdbc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167963
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
* Update translations from branch 'master'
to b46612b5cf30742f137cc685ff3bb75b42a75619
- update translations for master
and force-fix errors using pocheck
Change-Id: I062d883de199aa7dd9015d72f519e190614c6d86
Change-Id: I48f841d1c42f9541e03632a88e1a4f65975a5335
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167971
Tested-by: Jenkins
Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
No need to go via Writer-specific macros here.
Change-Id: I10256d2cd8d214489b52600ccbb45b0ba1526950
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167979
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Change-Id: I4058a4698582256a31ebb21379c0a66b22e2a1cc
android-viewer translated using Weblate
Japanese currently translated at 65.5% (76 of 116 strings)
Change-Id: I74e48d5d605e25ebf39e2a8bd73495274ee94855
Added translation for android-viewer using Weblate (Hebrew)
Change-Id: I491b69291975d22c0552cc20e93f2042cc70e4b0
Update translation files for android-viewer
Updated by "Cleanup translation files" hook in Weblate.
Change-Id: Iea28e4d8bf859accdb1c16bb4c6836237a4d2b26
android-viewer translated using Weblate
Japanese currently translated at 61.0% (72 of 118 strings)
Change-Id: I741c23b1048d4857605d73aad34668c29234dd6f
android-viewer translated using Weblate
Catalan currently translated at 100.0% (118 of 118 strings)
Change-Id: I9cbcf579a5c634adf0686e43aa4dca069c2dd577
Added translation for android-viewer using Weblate (Esperanto)
Change-Id: Ibcf6e82a860c5e789d6ee89dace30d1457a60c22
android-viewer translated using Weblate
Japanese currently translated at 39.8% (47 of 118 strings)
Change-Id: I9efdbae451a5313cb5b8ef4a1abca6969696969b
Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org>
Co-authored-by: Ekaterine Papava <papava.e@gtu.ge>
Co-authored-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
Co-authored-by: Weblate <noreply@documentfoundation.org>
Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ca/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ja/
Translation: android-viewer/android-strings
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167895
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
m_bIsInline is either forced true,
or is set by GetAnchorId() == RndStdIds::FLY_AS_CHAR.
Nothing sets it to false, but it can become true with
ForceTreatAsInline.
So, no need to check for FLY_AS_CHAR if we also allow IsInline.
Change-Id: I5f7a158962dcde1fd2d642ffd54e0995a69ad841
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167966
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Otherwise, the translation gets MAX_DBL value, and scaling becomes 0.
After commit 690526f95e (Generalize basegfx::fround
for templated return type, 2024-04-15) this made some documents (e.g., bugdoc
in tdf#85132) fail an assertion in debug builds, which allowed to find and fix
this problem.
Change-Id: I14cb0afd0c8d884f505efb921907cc8e86418da2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167965
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Previously, Writer performed shaping for each span of text separately.
In certain situations, this caused incorrect glyph use, or incorrect
glyph positioning. This change updates Writer so it will also consider
neighboring text while performing shaping.
This change resolves the outstanding duplicates filed against tdf#61444.
As a side effect, this change also fixes tdf#134226.
In addition to the shaping fix, this change implements rendering for
individually-styled glyphs, which is required to fix tdf#71956. However,
this change does not implement diacritic selection, which is also
required for that issue.
Change-Id: Iab4774ffaab5ad6113778c54d02cb260a70c1010
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167699
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
Tested-by: Jenkins
Comparing the Word vs Writer output for the bugdoc, the vertical
position of the endnote text is not correct: the y pos should be larger
than it is, see the red reference at e.g.
<https://bug-attachments.documentfoundation.org/attachment.cgi?id=194265>.
Seems this is caused by the different height of the rectangle around the
endnote separator: the top margin is 124 twips in Writer, which is a
hardcoded default from the SwPageFootnoteInfo ctor, while Word has this
separator as a special character, inside a paragraph, which inherits the
height of the default paragraph style.
Fix the problem by extending sw::FootnoteSeparatorHeight() to also work
from RES_POOLCOLL_STANDARD in the Word compat case. Note that it's not
enough to take the font size (11pt in this case) from the paragraph
style, we want to work with the real font, which knows the spacing
between lines (15% in this case). SwFont::GetHeight() has this logic,
it's also what e.g. SwTextFrame::FormatEmpty() uses.
Note that footnotes have the same problem, but given that they grow from
the bottom of the page, the text position was correct, even if the
separator height is incorrect. Also, the separator line itself is not
changed in this commit, we just make sure that the height is OK, so text
below the line has the correct position.
Change-Id: If1f4757908355abc81ee711de5ab9db4c751354c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167959
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Update helpcontent2 from branch 'master'
to 74121a4068a305b871e5aa5d0aada26012bced22
- tdf#148587 Update How to get section for Summary slide and Expand slide
In text/simpress/00/00000404.xhp:
- Remove sections on Summary Slide and Expand slide because those options no longer appear in the "Insert" menu
In text/simpress/00/slide_menu.xhp
- Add updated howtoget information for Summary Slide and Expand Slide, including information for TabUI
In text/simpress/01/03090000.xhp
- Add variable tags to h1 so that the page can easily be linked from other help pages
In text/simpress/01/04130000.xhp
- Add variable tags to h1 so that the page can easily be linked from other help pages
- Update embed link in howtoget section to link to updated instructions in source/text/simpress/main_slide.xhp
- Add a related topics section
In text/simpress/01/04140000.xhp:
- Add variable tags to h1 so that the page can easily be linked from other help pages
- Update embed link in howtoget section to link to updated instructions in source/text/simpress/main_slide.xhp
- Add a Related Topics section
In text/simpress/main_slide.xhp
- Add variable tags to h1 so that the page can easily be linked from other help pages
Change-Id: Icc67e3b4745aa1f70fab898436c4b28e64fec578
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167932
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
