Commit graph

495322 commits

Author SHA1 Message Date
Noel Grandin
24ac1b2eea use more concrete UNO classes in writerfilter (SwXTextFrame)
Change-Id: Ic00730c49c0feb7ab7e649c7d6e5d3ff1cb79b27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166801
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-28 22:26:24 +02:00
Noel Grandin
94122cb751 use more concrete UNO classes in writerfilter (field annotation)
Change-Id: I39e2c1d7d3c49017795d1365895ef8bd8d1e0e87
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166800
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-28 22:26:14 +02:00
Julien Nabet
45d2d90d23 tdf#160827: fix crash when retrieving _MarkAsFinal value (docx) (take 2)
Change-Id: I3f2ad56a205877be54b0dbfe361b76db3436f5ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166798
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2024-04-28 20:10:30 +02:00
Noel Grandin
14ed222426 use more concrete UNO classes in writerfilter (SwXTextSection)
Change-Id: I407d165ccdfcb23e2b922701dc9753c72c439cc4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166788
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-28 18:57:59 +02:00
Noel Grandin
192f76cbb2 use more concrete UNO classes in writerfilter (SwXFieldmark)
Change-Id: Ifa90331eadc08e0949c28d09be92d5aed4c8a70f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166787
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-28 18:57:52 +02:00
Gabor Kelemen
a83b7cd01c Use less ConfigurationAccess in favor of officecfg
Change-Id: I9bb0165aabb0d5ff2caac33ec948a04d96eb3316
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166756
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-28 17:10:31 +02:00
Gabor Kelemen
924d7b64f0 Drop CacheConfiguration in favor of officecfg
Also the key path was wrong in SlsCacheConfiguration.cxx:
MultiPaneGUI/SlideSorter/PreviewCache
but in Impress.xcs we have
MultiPaneGUI/SlideSorterBar/PreviewCache
hierarchy so this may actually now start to work :)

Change-Id: I4b552be713e6e157edb45692ba78101429aa1c85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166755
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-28 17:08:29 +02:00
Noel Grandin
6a11bf9f7b use more concrete UNO classes in writerfilter (SwXBookmark)
Change-Id: I8a0e9a83ef2bad7920067d108443b7b682f0660e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166786
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-28 15:59:26 +02:00
Julien Nabet
83236587bf tdf#159625: fix "allow to split paragraph"
2 pbs here:
1) bug described in the bugtracker, the uncheck isn't kept
=> just remove all the buggy GetOldItem stuff
2) after unchecked the option then saving the file and reloading the file, the option is still checked
=> change the buggy
rOutSet->Put( SvxFormatSplitItem( eState == TRISTATE_FALSE, _nWhich ) );
to
rOutSet->Put( SvxFormatSplitItem( eState == TRISTATE_TRUE, _nWhich ) );

In fact, I just mimicked the code used for "keep paragraphs" which works well.

Also change the QA test since "allow to split paragraph" is checked by default
so if the QA simulates a click on it, we expect the value to be false when dialog is opened again

Change-Id: I947feb02e0c282304621a252ad5e4c168c1d295a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166774
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-04-28 13:38:02 +02:00
Julien Nabet
5158104b92 Revert "tdf#160827: fix crash when retrieving _MarkAsFinal value (docx)"
As Noel advised in https://gerrit.libreoffice.org/c/core/+/166724, it's better to test type this way:
getValueType() == cppu::UnoType<bool>::get()

This reverts commit f49d74edf7.

Change-Id: Ic148b27761141d1020b63eeba8044fd545bab2d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166797
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-04-28 13:11:21 +02:00
Julien Nabet
f49d74edf7 tdf#160827: fix crash when retrieving _MarkAsFinal value (docx)
xPropertySet->getPropertyValue("_MarkAsFinal") can retrieve an Any
containing a boolean or a string

Change-Id: I1c8bafc12cdaf7fb98d3500507ba83b3e90f69cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166763
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-04-28 11:39:38 +02:00
Stephan Bergmann
d98e014cf6 Extended loplugin:ostr manual changes
I had done these a while ago, when I looked into extending loplugin:ostr to do
more automatic rewriting, and these were places where I needed to do something
manually, for one reason or another, because the automatic rewriting would not
pick it up correctly.

However, I got distracted, and a wholesale automatic rewrite would still run
into cases where an _ostr/_ustr instance from a library's .rodata would still be
referenced after the library has already been dlcose'd.  So I never came around
to finishing all that.

But there appears to be renewed interest in (automatic) rewritings here now, so
it probably makes sense if I share this part of my work anyway.

Change-Id: I3da9d38398e4bca373cb0000a9d34b49a36ad58a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166792
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
2024-04-28 11:29:52 +02:00
Stephan Bergmann
817d35eb82 -Werror,-Wunused-variable
...after 87e0feafd3 "use more concrete UNO classes
in writerfilter (SwXDocumentSettings)"

Change-Id: I4f57ef975dbee32b6f9ff6654b66483c8f1083a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166791
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-04-28 11:29:29 +02:00
Noel Grandin
32d7935b3d improve the mergedlib script
by copying the improvements from the normal find-can-be-private
script.

Change-Id: I3cb23022ca33d3008af962fa99b5b0907fe753b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166783
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-28 06:21:43 +02:00
Mike Kaganski
826e7e79f3 Simplify a bit
Change-Id: I1db779648b273d0c732683042c74bd29666f1b10
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166785
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
2024-04-28 05:14:50 +02:00
Gabor Kelemen
2f5ab5b8e7 Drop now unused option-stream identifiers
Change-Id: Id08e41e11b8027339e58ab182739087030e66eef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166754
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Jenkins
2024-04-27 22:47:25 +02:00
Mike Kaganski
faeb8adf4b Simplify a bit
Change-Id: Ic6d0dd0f66a258fffd0be7f458316801516aaefc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166778
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-27 20:50:48 +02:00
Noel Grandin
47bebbdcf1 fix mergelibs build
since
    commit 828c1999e0
    Author: Noel Grandin <noelgrandin@gmail.com>
    Date:   Wed Apr 10 16:50:51 2024 +0100
    move writerfilter inside sw

Change-Id: I1c8b37510ccdd640937669f36c8086f5f65183f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166782
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2024-04-27 20:45:28 +02:00
Noel Grandin
6c9f7050f6 reduce symbol visibility in vbahelper
Change-Id: I68995b10956afe4b2a2cf69fe1393d4deaaff02a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166780
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-27 20:34:31 +02:00
Noel Grandin
0eeb12b424 reduce symbol visibility in sc
Change-Id: I7a1c7dbe61e302584b977fdf202d041d987d0833
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166777
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2024-04-27 20:12:31 +02:00
Miklos Vajna
adaea5d10d solenv, gdb fix error while loading the sw_writerfilter pretty printer
Fixes:

Traceback (most recent call last):
  File "/home/vmiklos/git/libreoffice/core-clang/instdir/program/libsw_writerfilterlo.so-gdb.py", line 23, in <module>
    module = importlib.import_module('libreoffice.' + mod)
  File "/usr/lib64/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 953, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'libreoffice.sw_writerfilter'

When loading a DOCX file while gdb is attached to the soffice process.

Change-Id: I383cadfe6afcd3673adecf46388376a6341dbc93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166742
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-27 19:06:19 +02:00
Patrick Luby
05d3a99aa6 tdf#153306 prevent subpixel shifting of X coordinate
HACK: for some unknown reason, if the X coordinate of the
path's bounds is more than 1024, SkBlendMode::kExclusion will
shift by about a half a pixel to the right with Skia/Metal on
a Retina display. Weirdly, if the same polygon is repeatedly
drawn, the total shift is cumulative so if the drawn polygon
is more than a few pixels wide, the blinking cursor in Writer
will exhibit this bug but only for one thin vertical slice at
a time. Apparently, shifting drawing a very tiny amount to
the left seems to be enough to quell this runaway cumulative
X coordinate shift.

Change-Id: Ic1ac8a390df51c4aa1cc3183590dce72059af6b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166766
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Tested-by: Jenkins
2024-04-27 16:35:56 +02:00
Noel Grandin
6f61cb4b63 reduce symbol visibility in sd
Change-Id: I3d4de2b8854278b8713992660268e764815fe738
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166761
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2024-04-27 16:08:42 +02:00
Noel Grandin
a77caf28ba use more concrete UNO classes in writerfilter (SwXTextDefaults)
Change-Id: I44eb8d4561798980ff7008d843bf076fc29582c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166769
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-27 15:56:28 +02:00
Noel Grandin
1528564ffd update can-be-private results file
Change-Id: I2ed375d0c47391b5afaa88935294313175f7b142
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166776
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-27 15:42:07 +02:00
Noel Grandin
60728712f0 loplugin:ostr in cppu,cppuhelper
Change-Id: I15c00d7a87396d07be2d10a0311f308a93e8eec3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166751
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2024-04-27 15:11:25 +02:00
Noel Grandin
87e0feafd3 use more concrete UNO classes in writerfilter (SwXDocumentSettings)
Change-Id: Id668946233d55d641199634d7ceda2607107e76b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166694
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-27 12:47:57 +02:00
Christian Lohmaier
9d7548dafb fix some hardcoded use of wsl.exe and fix some typos
Change-Id: I6152ee61913638f828eeb201ecb26312de5f8572
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166737
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins
2024-04-27 10:16:39 +02:00
Samuel Mehrbrodt
535391b31a Save with newer Glade version
Change-Id: If36d812ba976bc3331086b5beb5493f20c0556ce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166701
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
Tested-by: Jenkins
2024-04-27 09:29:14 +02:00
Moritz Duge
906e5d44f2 Lazy load additional GPG key data.
Change-Id: I7f52b318b083535422202dacbee928333cb3ac78
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166639
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-04-27 08:29:15 +02:00
Moritz Duge
7c0a776f3a Locally simplify getCertificatesImpl.
Change-Id: I13117b36bb063b0afc498ef237b9255c0a900131
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166638
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
Tested-by: Jenkins
2024-04-27 08:26:52 +02:00
Mike Kaganski
60f65e63b4 Fix dc:date export for midnight time
Change-Id: I2fc40055e8949348925159a7e10f231a2573950c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166757
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-27 06:21:58 +02:00
Christian Lohmaier
f5c3ec505b add --with-keep-awake switch to prevent going into sleep/suspend
if used defaults to Awake for Windows and caffeinate for macOS

Change-Id: I35f41bf1fb63af05ce2ec1a7f4d7b50b310536a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166743
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins
2024-04-26 23:10:22 +02:00
Stephan Bergmann
9add004456 Make odfvalidator and officeotron work in WSL_ONLY_AS_HELPER mode
...where e.g. CppunitTest_oox_testscene3d
CPPUNIT_TEST_NAME=test_material_wireframe::TestBody had failed with

> forced failure
> - Error: Unable to access jarfile /mnt/d/lo/tar/odfvalidator-0.9.0-RC2-SNAPSHOT-jar-with-dependencies-2726ab578664434a545f8379a01a9faffac0ae73.jar

and e.g. CppunitTest_oox_mcgr
CPPUNIT_TEST_NAME=testAxialColorLinearTrans::TestBody had failed with

> equality assertion failed
> - Expected: 0
> - Actual  : 1
> - failed to execute: sh D:/lo-wsl/core/bin/officeotron.sh C:\Users\steph\AppData\Local\Temp\test_oox_mcgr.dll2epgul.tmp > C:\Users\steph\AppData\Local\Temp\test_oox_mcgr.dll2epgup.tmp 2>&1
> Error: Unable to access jarfile /mnt/d/lo/tar/8249374c274932a21846fa7629c2aa9b-officeotron-0.7.4-master.jar

Change-Id: I094b76daff6eef2cb6a9874a4776bab9c4424f49
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166703
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
2024-04-26 22:29:52 +02:00
Christian Lohmaier
a1e5496e4d gbuild trace: disable flock for wsl-as-helper case
Change-Id: Ie5db3fcc6fccedb214aec472852d8d82813fb984
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166744
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-26 21:44:23 +02:00
Noel Grandin
752ea376b0 loplugin:ostr in sal
Change-Id: I7732a77fc5ac8d1f5c53052e0f4b6c7e7d70f054
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166739
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2024-04-26 21:41:38 +02:00
Mike Kaganski
105ce47a69 Make sure that collecting redline autostyles succeeds
This step was called separately in SwXMLExport::ExportAutoStyles_,
after collectAutoStyles. collectTextAutoStylesAndNodeExportOrder
(which is called from collectAutoStyles) sets mbCollected to true,
and then all the code checking mbCollected/isAutoStylesCollected
stops collecting autostyles.

This moves exportTrackedChanges call to the place where all auto-
styles are collected.

Change-Id: I3f4bd0e0ff906a35b69c052e34adb6d66ef80d48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166735
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
2024-04-26 21:19:57 +02:00
Michael Weghorn
f6ca163d3f gtk4 a11y: Don't create second AT context for OOoFixed
Similar to how the previous

    Change-Id: I35196ca686e9d56f97bbf884da8b6492358e41fc
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Fri Apr 26 09:45:39 2024 +0200

        gtk4 a11y: Don't create multiple AT contexts for same accessible

avoids creating multiple AT contexts for the same
accessible when the role changes, this commit addresses
another case in which 2 GtkATContexts could be created
for the OOoFixed which could result in segfault crashes:

The OOoFixed is a GtkWidget, and GTK's `gtk_widget_init`
already creates an AT context for widgets.
Then, a second AT context would be created because
`ooo_fixed_accessible_init` set an own implementation
for GtkAccessibleInterface::get_at_context that would
create a second AT context when it got called, resulting
in breaking the apparent assumption that there's a 1:1 mapping
between GtkAccessible and GtkATConetxt.

No longer override `GtkAccessibleInterface::get_at_context`
but live with the GtkATContext created for the GtkWidget,
even if that means an a11y role cannot explicitly be set
for these for now.
From a first quick look at the tree in Accerciser,
I only see one item changed its a11y role from panel to filler.

The main class used. e.g. for the document content is
LOAccessible, not OOoFixed, and setting the proper role
for instances of that class is unaffected, see
`lo_accessible_get_at_context`.

If setting the a11y role is relevant, this could be
done when initializing the OOoFixed instead by setting
the "accessible-role" property [1], tested with this demo
local change to set a dummy table-cell a11y role and
verifying in Accerciser that it was actually set:

    --- a/vcl/unx/gtk3/gtkframe.cxx
    +++ b/vcl/unx/gtk3/gtkframe.cxx
    @@ -993,7 +993,10 @@ void GtkSalFrame::InitCommon()
     #else
         m_pOverlay = GTK_OVERLAY(gtk_overlay_new());
     #if GTK_CHECK_VERSION(4,9,0)
    -    m_pFixedContainer = GTK_FIXED(g_object_new( ooo_fixed_get_type(), nullptr ));
    +    GValue aValue = G_VALUE_INIT;
    +    g_value_init (&aValue, GTK_TYPE_ACCESSIBLE_ROLE);
    +    g_value_set_enum(&aValue, GTK_ACCESSIBLE_ROLE_CELL);
    +    m_pFixedContainer = GTK_FIXED(g_object_new( ooo_fixed_get_type(), "accessible-role", aValue,  nullptr ));
     #else
         m_pFixedContainer = GTK_FIXED(gtk_fixed_new());
     #endif

Similar to how the dropped code did, this could use the
a11y role from the corresponding `vcl::Window`, which is
currently not passed, but that could be adjusted, e.g.
by either passing the window or its accessible info
to `SalInstance::CreateFrame`/`SalInstance::CreateChildFrame`.
See `Window::ImplInit`, where the `vcl::Window` is currently
only set via `SalFrame::SetCallback` after the call to
`SalInstance::CreateFrame`/`SalInstance::CreateChildFrame`.

Without this commit, for me, this crash happened about 10-30 %
of the time when starting LO Writer with the gtk4 VCL plugin in rr,
when Accerciser was running already.

Backtrace for first AT context creation (from `gtk_widget_init`):

    1 gtk_at_context_create gtkatcontext.c 671 0x7f677daf129e
    2 create_at_context gtkwidget.c 8574 0x7f677dd6bcd9
    3 gtk_widget_init gtkwidget.c 2392 0x7f677dd5edbc
    4 g_type_create_instance 0x7f678ed8f2a3
    5 ?? 0x7f678ed72500
    6 g_object_new_with_properties 0x7f678ed73b96
    7 g_object_new 0x7f678ed74a41
    8 GtkSalFrame::InitCommon gtkframe.cxx 996 0x7f677edb9243
    9 GtkSalFrame::Init gtkframe.cxx 1785 0x7f677edb7bca
    10 GtkSalFrame::GtkSalFrame gtkframe.cxx 510 0x7f677edb726d
    11 GtkInstance::CreateFrame gtkinst.cxx 273 0x7f677ec7cebc
    12 vcl::Window::ImplInit window.cxx 1057 0x7f6788cf7f49
    13 ImplBorderWindow::ImplInit brdwin.cxx 1555 0x7f6788a6d45b
    14 ImplBorderWindow::ImplBorderWindow brdwin.cxx 1584 0x7f6788a6da21
    15 VclPtrInstance<ImplBorderWindow>::VclPtrInstance<vcl::Window *&, SystemParentData *&, long&, BorderWindowStyle&> vclptr.hxx 280 0x7f6788d31049
    16 WorkWindow::ImplInit wrkwin.cxx 51 0x7f6788d2f809
    17 IntroWindow::IntroWindow introwin.cxx 35 0x7f6788bb7ee0
    18 (anonymous namespace)::SplashScreenWindow::SplashScreenWindow splash.cxx 122 0x7f677c1cee61
    19 VclPtr<(anonymous namespace)::SplashScreenWindow>::Create<(anonymous namespace)::SplashScreen *> vclptr.hxx 129 0x7f677c1cc86b
    20 (anonymous namespace)::SplashScreen::SplashScreen splash.cxx 145 0x7f677c1cc5f8
    21 desktop_SplashScreen_get_implementation splash.cxx 616 0x7f677c1cc4f9
    22 std::__invoke_impl<com::sun::uno::XInterface *, com::sun::uno::XInterface * ( *&)(com::sun::uno::XComponentContext *, com::sun::uno::Sequence<com::sun::uno::Any> const&), com::sun::uno::XComponentContext *, com::sun::uno::Sequence<com::sun::uno::Any> const&> invoke.h 61 0x7f67907ef7a8
    23 std::__invoke_r<com::sun::uno::XInterface *, com::sun::uno::XInterface * ( *&)(com::sun::uno::XComponentContext *, com::sun::uno::Sequence<com::sun::uno::Any> const&), com::sun::uno::XComponentContext *, com::sun::uno::Sequence<com::sun::uno::Any> const&> invoke.h 114 0x7f67907ef745
    24 std::_Function_handler<com::sun::uno::XInterface * (com::sun::uno::XComponentContext *, com::sun::uno::Sequence<com::sun::uno::Any> const&), com::sun::uno::XInterface * ( *)(com::sun::uno::XComponentContext *, com::sun::uno::Sequence<com::sun::uno::Any> const&)>::_M_invoke(std::_Any_data const&, com::sun::uno::XComponentContext *&&, com::sun::uno::Sequence<com::sun::uno::Any> const&) std_function.h 290 0x7f67907ef63d
    25 std::function<com::sun::uno::XInterface * (com::sun::uno::XComponentContext *, com::sun::uno::Sequence<com::sun::uno::Any> const&)>::operator()(com::sun::uno::XComponentContext *, com::sun::uno::Sequence<com::sun::uno::Any> const&) const std_function.h 591 0x7f67907b6848
    26 cppuhelper::ServiceManager::Data::Implementation::doCreateInstanceWithArguments servicemanager.cxx 725 0x7f679079f26f
    27 cppuhelper::ServiceManager::Data::Implementation::createInstanceWithArguments servicemanager.cxx 696 0x7f679079f143
    28 cppuhelper::ServiceManager::createInstanceWithArgumentsAndContext servicemanager.cxx 1021 0x7f67907a56c5
    29 non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithArgumentsAndContext(rtl::OUString const&, com::sun::uno::Sequence<com::sun::uno::Any> const&, com::sun::uno::Reference<com::sun::uno::XComponentContext> const&) servicemanager.cxx 1022 0x7f67907a577c
    30 desktop::Desktop::OpenSplashScreen app.cxx 2449 0x7f6792723b2c
    31 desktop::Desktop::Main app.cxx 1299 0x7f6792721362
    32 ImplSVMain svmain.cxx 229 0x7f67895bcfbe
    33 SVMain svmain.cxx 261 0x7f67895bf009
    34 soffice_main sofficemain.cxx 93 0x7f67927a5a73
    35 sal_main main.c 51 0x55fa1fbf7a5d
    36 main main.c 49 0x55fa1fbf7a37

Backtrace for second AT context creation:

    1 gtk_at_context_create gtkatcontext.c 671 0x7f677daf129e
    2 get_at_context a11y.cxx 806 0x7f677ec389b6
    3 gtk_accessible_get_at_context gtkaccessible.c 105 0x7f677dae2d4b
    4 gtk_accessible_platform_changed gtkaccessible.c 1081 0x7f677dae427d
    5 gtk_widget_set_focusable gtkwidget.c 5255 0x7f677dd65086
    6 GtkSalFrame::InitCommon gtkframe.cxx 1157 0x7f677edb9d15
    7 GtkSalFrame::Init gtkframe.cxx 1785 0x7f677edb7bca
    8 GtkSalFrame::GtkSalFrame gtkframe.cxx 510 0x7f677edb726d
    9 GtkInstance::CreateFrame gtkinst.cxx 273 0x7f677ec7cebc
    10 vcl::Window::ImplInit window.cxx 1057 0x7f6788cf7f49
    11 ImplBorderWindow::ImplInit brdwin.cxx 1555 0x7f6788a6d45b
    12 ImplBorderWindow::ImplBorderWindow brdwin.cxx 1584 0x7f6788a6da21
    13 VclPtrInstance<ImplBorderWindow>::VclPtrInstance<vcl::Window *&, SystemParentData *&, long&, BorderWindowStyle&> vclptr.hxx 280 0x7f6788d31049
    14 WorkWindow::ImplInit wrkwin.cxx 51 0x7f6788d2f809
    15 IntroWindow::IntroWindow introwin.cxx 35 0x7f6788bb7ee0
    16 (anonymous namespace)::SplashScreenWindow::SplashScreenWindow splash.cxx 122 0x7f677c1cee61
    17 VclPtr<(anonymous namespace)::SplashScreenWindow>::Create<(anonymous namespace)::SplashScreen *> vclptr.hxx 129 0x7f677c1cc86b
    18 (anonymous namespace)::SplashScreen::SplashScreen splash.cxx 145 0x7f677c1cc5f8
    19 desktop_SplashScreen_get_implementation splash.cxx 616 0x7f677c1cc4f9
    20 std::__invoke_impl<com::sun::uno::XInterface *, com::sun::uno::XInterface * ( *&)(com::sun::uno::XComponentContext *, com::sun::uno::Sequence<com::sun::uno::Any> const&), com::sun::uno::XComponentContext *, com::sun::uno::Sequence<com::sun::uno::Any> const&> invoke.h 61 0x7f67907ef7a8
    21 std::__invoke_r<com::sun::uno::XInterface *, com::sun::uno::XInterface * ( *&)(com::sun::uno::XComponentContext *, com::sun::uno::Sequence<com::sun::uno::Any> const&), com::sun::uno::XComponentContext *, com::sun::uno::Sequence<com::sun::uno::Any> const&> invoke.h 114 0x7f67907ef745
    22 std::_Function_handler<com::sun::uno::XInterface * (com::sun::uno::XComponentContext *, com::sun::uno::Sequence<com::sun::uno::Any> const&), com::sun::uno::XInterface * ( *)(com::sun::uno::XComponentContext *, com::sun::uno::Sequence<com::sun::uno::Any> const&)>::_M_invoke(std::_Any_data const&, com::sun::uno::XComponentContext *&&, com::sun::uno::Sequence<com::sun::uno::Any> const&) std_function.h 290 0x7f67907ef63d
    23 std::function<com::sun::uno::XInterface * (com::sun::uno::XComponentContext *, com::sun::uno::Sequence<com::sun::uno::Any> const&)>::operator()(com::sun::uno::XComponentContext *, com::sun::uno::Sequence<com::sun::uno::Any> const&) const std_function.h 591 0x7f67907b6848
    24 cppuhelper::ServiceManager::Data::Implementation::doCreateInstanceWithArguments servicemanager.cxx 725 0x7f679079f26f
    25 cppuhelper::ServiceManager::Data::Implementation::createInstanceWithArguments servicemanager.cxx 696 0x7f679079f143
    26 cppuhelper::ServiceManager::createInstanceWithArgumentsAndContext servicemanager.cxx 1021 0x7f67907a56c5
    27 non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithArgumentsAndContext(rtl::OUString const&, com::sun::uno::Sequence<com::sun::uno::Any> const&, com::sun::uno::Reference<com::sun::uno::XComponentContext> const&) servicemanager.cxx 1022 0x7f67907a577c
    28 desktop::Desktop::OpenSplashScreen app.cxx 2449 0x7f6792723b2c
    29 desktop::Desktop::Main app.cxx 1299 0x7f6792721362
    30 ImplSVMain svmain.cxx 229 0x7f67895bcfbe
    31 SVMain svmain.cxx 261 0x7f67895bf009
    32 soffice_main sofficemain.cxx 93 0x7f67927a5a73
    33 sal_main main.c 51 0x55fa1fbf7a5d
    34 main main.c 49 0x55fa1fbf7a37

Backtrace of the segfault:

    Thread 1 received signal SIGSEGV, Segmentation fault.
    0x00007f677deaec8e in GTK_IS_ACCESSIBLE_TEXT (ptr=0x55fa21196bb0) at ../gtk/gtkaccessibletext.h:35
    35      G_DECLARE_INTERFACE (GtkAccessibleText, gtk_accessible_text, GTK, ACCESSIBLE_TEXT, GtkAccessible)
    (rr) bt
    #0  0x00007f677deaec8e in GTK_IS_ACCESSIBLE_TEXT (ptr=0x55fa21196bb0) at ../gtk/gtkaccessibletext.h:35
    #1  0x00007f677deb1d88 in gtk_atspi_connect_text_signals (accessible=0x55fa21196bb0, text_changed=0x7f677dea1365 <emit_text_changed>, selection_changed=0x7f677dea140b <emit_text_selection_changed>, data=0x55fa2119d860)
        at ../gtk/a11y/gtkatspitext.c:1037
    #2  0x00007f677dea2fea in register_object (root=0x55fa2119e210, context=0x55fa2119d860) at ../gtk/a11y/gtkatspicontext.c:1442
    #3  0x00007f677dea8138 in on_registration_reply (gobject=0x55fa21179030, result=0x55fa39240d80, user_data=0x55fa2117a4a0) at ../gtk/a11y/gtkatspiroot.c:531
    #4  0x00007f6783cc8ee3 in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
    #5  0x00007f6783cc9b83 in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
    #6  0x00007f6783d269da in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
    #7  0x00007f6783cc8ee3 in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
    #8  0x00007f6783cc8f1d in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
    #9  0x00007f6785b110d9 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
    #10 0x00007f6785b14317 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
    #11 0x00007f6785b14930 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
    #12 0x00007f677ec77d0f in GtkSalData::Yield(bool, bool) (this=0x55fa1fe8e000, bWait=true, bHandleAllCurrentEvents=false) at vcl/unx/gtk4/../gtk3/gtkdata.cxx:405
    #13 0x00007f677ec7dbd3 in GtkInstance::DoYield(bool, bool) (this=0x55fa1fe8deb0, bWait=true, bHandleAllCurrentEvents=false) at vcl/unx/gtk4/../gtk3/gtkinst.cxx:435
    #14 0x00007f678959a64c in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:394
    #15 0x00007f6789599f5b in Application::Yield() () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:482
    #16 0x00007f6789599cf2 in Application::Execute() () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:369
    #17 0x00007f679272304c in desktop::Desktop::Main() (this=0x7ffdf3dcc768) at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1615
    #18 0x00007f67895bcfbe in ImplSVMain() () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:229
    #19 0x00007f67895bf009 in SVMain() () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:261
    #20 0x00007f67927a5a73 in soffice_main() () at /home/michi/development/git/libreoffice/desktop/source/app/sofficemain.cxx:93
    #21 0x000055fa1fbf7a5d in sal_main () at /home/michi/development/git/libreoffice/desktop/source/app/main.c:51
    #22 0x000055fa1fbf7a37 in main (argc=2, argv=0x7ffdf3dcc978) at /home/michi/development/git/libreoffice/desktop/source/app/main.c:49

[1] https://docs.gtk.org/gtk4/property.Accessible.accessible-role.html

Change-Id: If4fdcd249aaada846934c3e967d654e3266ad73d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166709
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-04-26 20:18:30 +02:00
Michael Weghorn
707e4f12f1 gtk4 a11y: Don't create multiple AT contexts for same accessible
In the `GtkAccessibleInterface::get_at_context` implementations,
do not create a new `GtkATContext` if the accessible role has
changed.

This broke the apparent assumption that there's a 1:1 mapping
between `GtkAccessible` and `GtkATContext` and resulted in
segfaults seen quite often when starting LO Writer
with the gtk4 VCL plugin while Accerciser was also running.

For me, this was even more reproducible when running in rr
(crashed reliably on start).

LO has the `AccessibleEventId::ROLE_CHANGED` event type
to indicate role changes, but GTK 4 doesn't support
changing the initial role any more.

Quoting the
GtkAccessible doc [1]:

> The role cannot be changed after instantiating a
> GtkAccessible implementation.

And the accessibility section in the GTK 4 doc [2] says:

> Each role is part of the widget’s instance, and cannot be changed over
> time or as the result of a user action. Roles allows assistive
> technology applications to identify a UI control and decide how to
> present it to a user; if a part of the application’s UI changes role,
> the control needs to be removed and replaced with another one
> with the appropriate role.

Sample backtrace:

    Thread 1 received signal SIGSEGV, Segmentation fault.
    0x00007f0399aa0636 in get_parent_context_ref (accessible=0x55a141b5a9b0) at ../gtk/a11y/gtkatspicontext.c:462
    462           res = gtk_at_spi_root_to_ref (self->root);
    (rr) bt
    #0  0x00007f0399aa0636 in get_parent_context_ref (accessible=0x55a141b5a9b0) at ../gtk/a11y/gtkatspicontext.c:462
    #1  0x00007f0399aa43ba in gtk_at_spi_context_get_parent_ref (self=0x55a141b615c0) at ../gtk/a11y/gtkatspicontext.c:1956
    #2  0x00007f0399a9dc75 in collect_object (self=0x55a1469113a0, builder=0x7fff90e1a220, context=0x55a141b615c0) at ../gtk/a11y/gtkatspicache.c:131
    #3  0x00007f0399a9e2f2 in emit_add_accessible (self=0x55a1469113a0, context=0x55a141b615c0) at ../gtk/a11y/gtkatspicache.c:235
    #4  0x00007f0399a9eac1 in gtk_at_spi_cache_add_context (self=0x55a1469113a0, context=0x55a141b615c0) at ../gtk/a11y/gtkatspicache.c:436
    #5  0x00007f0399aa8152 in on_registration_reply (gobject=0x55a141b62060, result=0x55a14e28a890, user_data=0x55a141b64770) at ../gtk/a11y/gtkatspiroot.c:533
    #6  0x00007f039fac8ee3 in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
    #7  0x00007f039fac9b83 in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
    #8  0x00007f039fb269da in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
    #9  0x00007f039fac8ee3 in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
    #10 0x00007f039fac8f1d in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
    #11 0x00007f03a0b110d9 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
    #12 0x00007f03a0b14317 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
    #13 0x00007f03a0b14930 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
    #14 0x00007f039a877d9f in GtkSalData::Yield(bool, bool) (this=0x55a140869000, bWait=true, bHandleAllCurrentEvents=false) at vcl/unx/gtk4/../gtk3/gtkdata.cxx:405
    #15 0x00007f039a87dc63 in GtkInstance::DoYield(bool, bool) (this=0x55a140868eb0, bWait=true, bHandleAllCurrentEvents=false) at vcl/unx/gtk4/../gtk3/gtkinst.cxx:435
    #16 0x00007f03a539a64c in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:394
    #17 0x00007f03a5399f5b in Application::Yield() () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:482
    #18 0x00007f03a5399cf2 in Application::Execute() () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:369
    #19 0x00007f03ae52304c in desktop::Desktop::Main() (this=0x7fff90e1c288) at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1615
    #20 0x00007f03a53bcfbe in ImplSVMain() () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:229
    #21 0x00007f03a53bf009 in SVMain() () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:261
    #22 0x00007f03ae5a5a73 in soffice_main() () at /home/michi/development/git/libreoffice/desktop/source/app/sofficemain.cxx:93
    #23 0x000055a13fefca5d in sal_main () at /home/michi/development/git/libreoffice/desktop/source/app/main.c:51
    #24 0x000055a13fefca37 in main (argc=2, argv=0x7fff90e1c498) at /home/michi/development/git/libreoffice/desktop/source/app/main.c:49

From valgrind output:

    (soffice:972353): Gtk-CRITICAL **: 09:28:48.066: gtk_accessible_get_accessible_parent: assertion 'GTK_IS_ACCESSIBLE (self)' failed

    (soffice:972353): Gtk-CRITICAL **: 09:28:48.067: gtk_accessible_get_at_context: assertion 'GTK_IS_ACCESSIBLE (self)' failed
    ==972353== Thread 1:
    ==972353== Invalid read of size 8
    ==972353==    at 0x19077636: get_parent_context_ref (gtkatspicontext.c:462)
    ==972353==    by 0x1907B3B9: gtk_at_spi_context_get_parent_ref (gtkatspicontext.c:1956)
    ==972353==    by 0x19074C74: collect_object (gtkatspicache.c:131)
    ==972353==    by 0x190752F1: emit_add_accessible (gtkatspicache.c:235)
    ==972353==    by 0x19075AC0: gtk_at_spi_cache_add_context (gtkatspicache.c:436)
    ==972353==    by 0x1907F151: on_registration_reply (gtkatspiroot.c:533)
    ==972353==    by 0x12E72EE2: ??? (in /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.7800.4)
    ==972353==    by 0x12E73B82: ??? (in /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.7800.4)
    ==972353==    by 0x12ED09D9: ??? (in /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.7800.4)
    ==972353==    by 0x12E72EE2: ??? (in /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.7800.4)
    ==972353==    by 0x12E72F1C: ??? (in /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.7800.4)
    ==972353==    by 0x130620D8: ??? (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7800.4)
    ==972353==  Address 0x70 is not stack'd, malloc'd or (recently) free'd
    ==972353==

[1] https://docs.gtk.org/gtk4/iface.Accessible.html
[2] https://docs.gtk.org/gtk4/section-accessibility.html

Change-Id: I35196ca686e9d56f97bbf884da8b6492358e41fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166708
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-04-26 20:18:15 +02:00
Noel Grandin
59ad8d6d15 loplugin:ostr in codemaker,unoidl
Change-Id: I75f5531023f31da029491ce4a078005eebbfe59e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166738
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2024-04-26 19:44:07 +02:00
Gabor Kelemen
fe0d855515 Use less SdOptionsLayout->IsDragStripes/SetDragStripes in favor of officecfg
Change-Id: I0c0e2dd57d1f1408f85bca4b6ee3bfcebae1cf22
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166596
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Jenkins
2024-04-26 17:01:25 +02:00
Gabor Kelemen
c724b81b03 Use less SdOptionsLayout->IsMoveOutline in favor of officecfg
Change-Id: I848e11a64a42b670254c88b791d0b2a2534d112f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166595
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Jenkins
2024-04-26 16:59:49 +02:00
Gabor Kelemen
48e07052be Drop now unused GetOptionStream class
Change-Id: Iddb1fbb437f0f66c551e9231d79511caf1edafb6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166635
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-26 15:16:05 +02:00
Christian Lohmaier
aabf18d561 Configuration_filter.mk: create RESPONSEFILEs using gb_var2file
using echo ... | sed won't help with command-line limits and doing the
simple substitution by make saves spawning a few sed processes

Change-Id: I4ee81d26b3df18ebf82140f00c823cb7543cac1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166411
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins
2024-04-26 15:02:37 +02:00
Stephan Bergmann
b68d717360 Support --with-junit/hamcrest in WSL_ONLY_AS_HELPER mode
...where it failed with

> checking for JUnit 4... ./configure: line 47354: cygpath: command not found

Change-Id: I56c930b6c8b738b39f26766f90476c32efb383e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166508
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins
2024-04-26 14:03:03 +02:00
Stephan Bergmann
9bd93466e4 Honor TMPDIR configure option in WSL_ONLY_AS_HELPER mode
(It needs to be passed-in as a TMPDIR=/mnt/c/... style path, because configure
uses it early on and otherwise fails with some

> checking build system type... config.guess: cannot create a temporary directory in C:/...

error.)

Change-Id: I798ed7dd363eb5fd7614c5984861f77cf9d38266
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166506
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-26 14:02:52 +02:00
Stephan Bergmann
6493143994 Don't hardcode build as x86_64 for WSL_ONLY_AS_HELPER
...to also make it work builds on aarch64

Change-Id: Ibc502b11eedceddb84481c2ad5d351bf8404c8cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166501
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-26 14:02:45 +02:00
Christian Lohmaier
683d9496bd use strawberry perl for installation packaging in wsl-as-helper case
changing it to git-bash perl can probably be done, but would require
more changes to the path handling in the packaging code

Change-Id: I9a31ee6e9f122a2c167e11f5b4f73b18c5c0fa81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166343
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-26 14:02:37 +02:00
Christian Lohmaier
84c80da975 use strawberry perl in wsl-as-helper case for openssl
it needs modules that are not available in git-bash perl, and strawberry
perl is already used as a way to get windres and similar utilities
Might want to revisit that to streamline the dependencies

Change-Id: Ieb1c83831292677e9930d376d9d71283c6a1140e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166342
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-26 14:02:29 +02:00
Christian Lohmaier
b77bcf2838 run autoconf/autoreconf via wsl in wsl-as-helper case
Change-Id: I9bcdfe352fd378e1bf09e15b8d8f7dcea82c0b5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166341
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-04-26 14:02:20 +02:00