* Update helpcontent2 from branch 'master'
to 21d0197b3705212a22b9e221ac1f624049516d9a
- tdf#114930 Clarify associativity and precedence of operators to the help
Change-Id: Ib55f0901235c082e88b49d1526b1123cd036f875
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117347
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
With the recent implemenation of
<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p2266r1.html> "P2266R1:
Simpler implicit move" in Clang 13 trunk as
<bf20631782>
"[clang] Implement P2266 Simpler implicit move", a --with-latest-c++ build
started to fail with
> In file included from sal/rtl/random.cxx:25:
> include/o3tl/temporary.hxx:21:62: error: non-const lvalue reference to type 'double' cannot bind to a temporary of type 'double'
> template <typename T> constexpr T& temporary(T&& x) { return x; }
> ^
> sal/rtl/random.cxx:97:37: note: in instantiation of function template specialization 'o3tl::temporary<double>' requested here
> return std::modf(random, &o3tl::temporary(double()));
> ^
etc. (And fixing that by adding the recommended static_cast then triggered a
false loplugin:redundantcast warning.)
Change-Id: I222429e9872afdedf77a07014c0a2e9e06c60b50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117335
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
add a 'NotifyingLayout' to find out when the size of a widget
changes now that size-allocate has been removed
Change-Id: Iae55b7fafd2fd26c62afaedd777ae40e84fbb964
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117348
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
It was not used anywhere and had not been cherry-picked to the
relevant vendor production branches so apparently it was just some
temporary experimentation? It is good to reduce complexity and
increase code similarity between branches.
Change-Id: Ib6717063f96d901d65ec36d65f3683af31065f2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117364
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
If Options → LibreOffice → Security → Security Options
and Warnings → Options... → Security Options → Remove personal
information on saving" is enabled.
Use the same time (1970-01-01T00:00:00) for mandatory
time stamps, and replace authors and creator-initials with
"1", "2", "3" etc., also to avoid of joining adjacent
redline ranges.
Note: to see the work of the unit test in Linux command line:
(cd sw && make UITest_writer_tests7 UITEST_TEST_NAME="tdf90401.tdf90401.test_tdf90401_remove_personal_info" SAL_USE_VCLPLUGIN=gen)
Change-Id: I3b4d710dbeeee12177aff378597cd2b683ca6c25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117319
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
In View->Show Formula, shortcut text was only "Ctrl" instead
of the complete "Ctrl+`".
Follow-up to commit 3f9fcf0e7f
"tdf#103388 Show the backtick used in shortcut in Calc View menu".
Change-Id: Icef8904bac0b663d9702e62fcdc0ab1f0f4bd1ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117332
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
I didn't notice the need for making the same
exclusion that TabOverMargin made for centering
when 7.2 got the new TabOverSpacing compat flag.
But now I see it is still needed.
Change-Id: Ia8069b5566eaf6dcdac6ff10ee0c60b849c5fa2e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117339
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
B2DTuple2D, B2ITuple2D and B2I64Tuple share a lot in common so
we can generalise it as a template class. The same goes for the
3D variants - B3DTuple and B3ITuple.
This is the initial attempt, but doesn't yet generalise all that
is possible.
Add some tests for the tuple variants that test the behaviour of
overloaded operators and other common methods.
Change-Id: Iee5ed15d58ea88e65ee7854bd05a87ceab22023d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117104
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
With the recent implementation of
<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p2266r1.html> "P2266R1:
Simpler implicit move" in Clang 13 trunk as
<bf20631782>
"[clang] Implement P2266 Simpler implicit move", a --with-latest-c++ build
started to fail with
> comphelper/source/xml/xmltools.cxx:103:20: error: no viable conversion from returned value of type 'char [39]' to function return type 'rtl::OString'
> return str;
> ^~~
[...]
> include/rtl/string.hxx:277:5: note: candidate constructor [with T = char [39]] not viable: expects an lvalue for 1st argument
> OString( T& value, typename libreoffice_internal::NonConstCharArrayDetector< T, libreoffice_internal::Dummy >::Type = libreoffice_internal::Dummy() )
> ^
[...]
etc.
Change-Id: If34f143a1855fdd7cd22ea3d7594f9381d50a7ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117336
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
don't quite see why this doesn't work out of the box in gtk4, but
putting it into the application-level style provider and using it via a
style class works and probably makes more sense anyway.
Change-Id: I4de196e462d7440174a0d67be25923bddab68197
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117337
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
there isn't an obvious candidate as to when to do the split though
Change-Id: Iee6d74015263b180470fc0c90924617bcde14421
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117334
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
...and drop the no-longer necessary loplugin:implicitboolconversion exclusion
(which had been necessary to avoid
> [CXX] vcl/source/window/dockingarea.cxx
> In file included from vcl/source/window/dockingarea.cxx:26:
> In file included from vcl/inc/svdata.hxx:26:
> include/o3tl/hash_combine.hxx:14:78: error: implicit conversion (Dependent) from 'bool' to 'std::enable_if_t<(sizeof(N) == 4), bool>' (aka 'typename enable_if<(sizeof(N) == 4), bool>::type') [loplugin:implicitboolconversion]
> template <typename T, typename N, std::enable_if_t<(sizeof(N) == 4), bool> = false>
> ^~~~~
etc.)
Change-Id: If764365213cf29f7dec6fdd6a773dc9894dd15bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117330
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
for the record
coverity[foo] defect is marked as intentioanl
coverity[foo : FALSE] defect is marked as false positive
coverity[foo : SUPPRESS] detect is not saved at all
Change-Id: I1277c4426b5fa9efde8a9227c2813d53deb56555
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117325
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
MS Word 2016 does something very weird. It attaches a
TabOverMargin to the previous word, and pulls it down to a new line.
Well, I don't think we want to attempt anything silly like that,
but at least we can have the tab itself start on the new line
(and thus take up the whole line).
This seems to be true only for a left-tab.
The other tabs have a different kind of strangeness
that I haven't identified yet.
In order to do that, when we request a tabstop position,
we must query a tabstop beyond the end margin.
So modify the GetTabStop function to allow for
not checking against an nRight position (when passed a zero).
This is complicated by the function's ability to ALWAYS
return the first tabstop - even if it is past the given
right-most edge. So I made nRight modifiable,
so that in this case, it isn't considered to be past
the right edge. That is fine for both cases where
this function is used.
It is a bit ugly, but I don't see how to make it cleaner,
when these inherent complications are already built-in.
This also has an impact on older DOCX, but the impact
is still valid. (In those, the entire paragraph
extends past the end in Word. With this patch, at
least the first line becomes more than just an
auto-tabstop.)
Change-Id: I42791a959aea2932b5776789ba45307fbca41a5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116878
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
so no need to make it explicit
Change-Id: I933fd914a3a7c408b836a85fee7acb39e731990f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117320
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Roundtrip test that checks the slide footers, and their placeholder indexes.
Change-Id: I9c4b819092ac6699617d71538c35b066d6e6f974
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117013
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Adds support for exporting slide footers to PPTX.
Slide footers are exported as shapes that use placeholder indexes to refer to
the shapes on master.
To make the references work they are exported to layout slides too.
Change-Id: I8bfde520b0aec66405523c719844e69c6fc15b79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117012
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
instead of one at 0 and the other at 1
Change-Id: I1943d2e68f39fb463d76237d6eb0bffe800a6b6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117313
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Adds initial support for writing lstStyles that are specific to a shape.
Current implementation only writes first paragraph and first textruns properties
in it.
Made WriteParagraphProperties return a bool that determines whether or not it
wrote a pPr tag. Needed this since lvl1pPr tag should be started even if there
was no paragraph properties since run properties also written inside it.
Change-Id: Ie0cfc9b9f221093db3a1111ca29140a6dfb5e8ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117011
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
OOXML uses placeholder index to determine from which layout placeholder it
should be inheriting styles, position etc.
Added maPlaceholderShapeToIndexMap that stores corresponding Placeholder index
for a Placeholder XShape on the master slide.
Right now only used for placeholder types Footer, DateAndTime and SlideNumber.
Change-Id: If788f235d00b6d1cde7194d9e4a0789e019432c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117010
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Adds a Active-App field in Crash
Report to assist in investigating
the crashes
Change-Id: I30e5f307045b8e5def9986447551f39e70b94edc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116786
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
as Ctrl+` instead of "Ctrl+grave" (see at View->Show Formula).
This affected only gen backend on Linux (SAL_USE_VCLPLUGIN=gen),
gtk3 and qt5 are handling this correctly.
Change-Id: I2bebcf68118642e6c12cf2c5d4392f2ca423665b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116742
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
Creates helper functions to convert from LO time and date formats to datetime
fields on OOXML
Change-Id: Ibbfefa18d0422eddb6c37539294ed23e77fe5f22
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117009
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Makes footer, slidenum and datetime placeholders that are inserted to
the slides themselves on pptx files imported as slide properties if it
is possible to do so without losing information (style, position etc.)
If that is not the case and the footers have some special style applied
to them that isn't inherited from master slides, fallbacks to the current
implementation importing them as shapes.
Also since the default way of displaying slide footers in LO use the
respective text fields on master slides, information in master/layout
slide datetime and footer placeholders respectively get replaced with
<date/time> text fields and <footer> text fields.
Change-Id: Ib2f7d18103b62c0c9a8453e01cfd2fd1aa1d39af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117008
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
VCL default would be 500k pixels, i.e. a 2" x 1" shape at 600 dpi would
be already truncated from 1200 pixels width to 1000 pixels. That's a bit
too extreme, use a larger limit in the sw HTML export.
Change-Id: I52b85d77cd27410d53c700a89190c99348de5e19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117287
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Don't use empty class with static methods for ftools, but just
use namespace instead. Also make sure it works with any floating
point numbers (float and double) and don't allow input if it is
anything else than a floating point number
Change-Id: I94b964291b3999d38ae13afe6ddfdbe6d891d410
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117154
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
