Commit graph

427101 commits

Author SHA1 Message Date
Noel Grandin
2b5812e019 rename ENABLE_HEADLESS option to DISABLE_GUI
since it has nothing to do with the headless command line option, so
use the name it has in the configure.ac file

Change-Id: Ibf0615ed02695d6e48a797f5632e4f417c010c70
Reviewed-on: https://gerrit.libreoffice.org/59611
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-27 08:47:49 +02:00
Noel Grandin
e6f4779de8 directly use malloc/free in sal, instead of rtl_allocateMemory/etc
now that those functions are entirely malloc/free based, we can skip a
function call layer.

Change-Id: Ib091de0bdf4cdd58cee45185df17d96d3e8af402
Reviewed-on: https://gerrit.libreoffice.org/59576
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-27 08:47:38 +02:00
Jan-Marek Glogowski
afd49c1987 tdf#90376 revert the dock windows' Idles to Timers
The dock windows' Timers were converted to Idles in commit
eef25e0e7c ("changed timers to idles"). Since the Idles poll
the mouse buttons, they starve all lower priority events.

From the comment in ImplDockFloatWin2::Move, this is a hack to
get the mouse release event from the window decorations in X11.

Change-Id: Ibba3c58dd8b3d95dbd9296cc111ab32968bee230
Reviewed-on: https://gerrit.libreoffice.org/59590
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-27 08:13:35 +02:00
Jan-Marek Glogowski
b4f16f9189 Add task count to Scheduler debug info
Change-Id: I60c00a40f119260ea34fb48efab72f1da8ae4e53
Reviewed-on: https://gerrit.libreoffice.org/59587
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-27 08:11:00 +02:00
Stanislav Horacek
17226094bc Update git submodules
* Update helpcontent2 from branch 'master'
  - style previews can be now disabled by checkbox
    
    and expert config in not needed for that anymore
    
    Change-Id: I82ba2dc1f867ec50924326c8fed0e25f3e19b4c2
    Reviewed-on: https://gerrit.libreoffice.org/59599
    Tested-by: Jenkins
    Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-08-27 01:13:56 +02:00
Adolfo Jayme Barrientos
1a271ebc59 Checkboxes don’t use title case, only section headings and menus
Change-Id: If54fdd732d05a99fb06ea5dd8d31345dc0f6192a
2018-08-26 18:10:57 -05:00
Stanislav Horacek
1124a4253b Update git submodules
* Update helpcontent2 from branch 'master'
  - fix menu path to image properties
    
    Change-Id: Ic4ea128ba4d995c6adec288a6b47a19dfd118799
    Reviewed-on: https://gerrit.libreoffice.org/59593
    Tested-by: Jenkins
    Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-08-27 01:04:58 +02:00
Kohei Yoshida
4d1f735fcf mdds 1.4.1 is now a minimum requirement.
Change-Id: I647bcfbdd8e0417990ed93b25c1bca00f60df709
Reviewed-on: https://gerrit.libreoffice.org/59614
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-08-26 21:18:06 +02:00
Caolán McNamara
8b5ee6a03d rely on forward declare of boost::optional
Change-Id: Ic3718290944b813b5ac2712fd4006dc97f5b68a0
Reviewed-on: https://gerrit.libreoffice.org/59613
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-26 20:52:58 +02:00
Caolán McNamara
e9fa088735 boostrap->bootstrap
Change-Id: I3082130a39a55609fa38fbf9a667fb95fe6d60ea
Reviewed-on: https://gerrit.libreoffice.org/59612
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-26 20:52:43 +02:00
Kohei Yoshida
51f73f35ea Update mdds to 1.4.1.
The largest change in 1.4.x relevant to the calc code is that the
multi_type_matrix::walk() methods now take a copy of the function
object rather than a reference, to allow for it to take an inline
lambda function.  Instead, it does return a instance of the input
function object, similar to how std::for_each() behaves.

In case the function object contains a large data member, try to
make it a moveable so that it will get moved rather than copied
when going through one of the walk() methods.

Change-Id: Ifd08fc4a2ed75039e5292a35ff08726e0126c77f
Reviewed-on: https://gerrit.libreoffice.org/59584
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-08-26 20:13:54 +02:00
Caolán McNamara
5061663ce0 drop unnecessary SYSTEM_MYSQL_CONNECTOR_CPP
Change-Id: I41cfbf41247270d29e08e5125adc05aac198b175
Reviewed-on: https://gerrit.libreoffice.org/59608
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-26 17:51:51 +02:00
Caolán McNamara
74ef0185b1 don't need dangling Library_mysqlcppconn.mk
Change-Id: I18fbe9feead3d48d9437cc7372eb1373ffb67c3e
Reviewed-on: https://gerrit.libreoffice.org/59607
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-26 17:51:25 +02:00
Caolán McNamara
a42f498f45 presumably should be mysqlc here
Change-Id: I328cb639cf1e190e745aa20e0f83b0e3e4fd2f60
Reviewed-on: https://gerrit.libreoffice.org/59606
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-26 17:51:15 +02:00
Caolán McNamara
44f8789246 MYSQL_CONNECTOR_CPP not built anymore
since...

commit 26b40fcfc6
Author: Tamas Bunth <tamas.bunth@collabora.co.uk>
Date:   Thu Aug 16 16:35:17 2018 +0200

    Moving mysqlc into connectivity as a library

    Additionally I erased the remains of the old mysql C++ connector.

    Also update the code where the clang plugins were unhappy after moving
    the mysqlc module.

    Remove mysql-cpp-connector external.

so we don't need the source to it

Change-Id: I0436e9f5a9cce87d0294cf3163a97a19566df1f4
Reviewed-on: https://gerrit.libreoffice.org/59605
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-26 17:50:33 +02:00
Caolán McNamara
71cbeeee37 CPPCONN_LIB now unused
since

commit 26b40fcfc6
Author: Tamas Bunth <tamas.bunth@collabora.co.uk>
Date:   Thu Aug 16 16:35:17 2018 +0200

    Moving mysqlc into connectivity as a library

Change-Id: Iafc4fb685d8f7b97f8be83dbf26945f9af976f1a
Reviewed-on: https://gerrit.libreoffice.org/59604
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-26 17:49:24 +02:00
Caolán McNamara
ae5d6e44ce get rid of aEndItr entirely
Change-Id: Ib95ca628457d7330ac1e1001ab13a00a764c9bad
Reviewed-on: https://gerrit.libreoffice.org/59598
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-26 15:26:24 +02:00
Paul Trojahn
7b52990a23 tdf#106260 Fix invisible pasted urls
UpdateFields() was never called after pasting a field.

Change-Id: I91f3eb183a0545d8735c0844f1e864a287101d22
Reviewed-on: https://gerrit.libreoffice.org/59339
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-26 10:08:06 +02:00
Caolán McNamara
7a115715c7 crashtesting: cached deque::end invalidated
e.g. import of ooo101471-3.odf

Change-Id: Ie1d83077cf91f2291c74390c24b7f36808e32562
Reviewed-on: https://gerrit.libreoffice.org/59597
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-25 22:22:50 +02:00
Caolán McNamara
a48b5c8e85 ofz#10056 Null deref
Change-Id: I9ea0f272d0a8b13fb51fec55ac57adca47cafc77
Reviewed-on: https://gerrit.libreoffice.org/59596
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-25 22:21:57 +02:00
Andrea Gelmini
621611f648 Fix typo
Change-Id: I7cef050ea84607118bacfe25acc83bc164668379
Reviewed-on: https://gerrit.libreoffice.org/59594
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-08-25 18:33:08 +02:00
Jean-Pierre Ledure
8ff357981f Access2Base - Add Location to Database object
File location is known by URL property for non-registered databases
Effective Location now available for all databases

Change-Id: If1551f2644c82dbb4a4128c647810aa6a755f1ab
2018-08-25 18:00:23 +02:00
Eike Rathke
8ecf5e1815 Build fix, make install: mysql-connector-ooo extension is gone
Since

    commit 26b40fcfc6
    CommitDate: Fri Aug 24 17:19:51 2018 +0200

	Moving mysqlc into connectivity as a library

Was used in #ifdef WITH_EXTENSION_MARIADBC

Change-Id: Ib95d81fbd79f253c4490dd3afdfd67962b5f1563
2018-08-25 16:31:14 +02:00
Jean-Pierre Ledure
fc45d4ae3a Access2Base - Fix typo
Typo error in commit f903dd5e21

Change-Id: I3c770296d1d4063c6bd3190eb90df0389ecf8f26
2018-08-25 15:19:50 +02:00
Jean-Pierre Ledure
f903dd5e21 Access2Base - Fix flush method when closing database
The "flush" method is not always present in
   com.sun.star.sdbc.drivers.OConnectionWrapper or
   com.sun.star.sdbc.XConnection
objects.
=> Test presence before executing Connection.flush

Change-Id: I5ab4968ba6fdd0e23352e0cfe18907260c46b7b0
2018-08-25 15:03:04 +02:00
Noel Grandin
6ae4c85fe6 loplugin:useuniqueptr in ScMoveUndo
Change-Id: I622a0f37866c5ea1f4ec5f4475d784682a0179c2
Reviewed-on: https://gerrit.libreoffice.org/59560
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-25 10:59:37 +02:00
Justin Luth
7413216e02 tdf#70195 docx export: default header/footer at 720
This only impacts MSWord, which otherwise suggests
a new header start at 0. LO ignores that 0 and uses
a sane default.

Change-Id: Id9790038086de1e20918d4ab498a0ce93ca53b5c
Reviewed-on: https://gerrit.libreoffice.org/59523
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-08-25 07:49:51 +02:00
Caolán McNamara
af579ed7d1 ofz#10045 Null deref
Change-Id: If9c8edd94b02240510325d6c9c0fc7584ba89b5f
Reviewed-on: https://gerrit.libreoffice.org/59571
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-24 21:30:51 +02:00
Caolán McNamara
389db2b45c Resolves: tdf#118572 ensure basic error dialog blocks any other dialog
if a dialog is already running, disable input to it until this
error dialog is acknowledged. The other dialog might be running
from the script which has the error.

Change-Id: I10c437a25bd7c91d37eeb8241bef10709767e499
Reviewed-on: https://gerrit.libreoffice.org/59567
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-24 21:30:17 +02:00
Caolán McNamara
e5f6be4902 Related: tdf#118572 set parent of basic error dialog to basic ide
Change-Id: I2e9dfd354dce114af9a2933255a991c29619b8a5
Reviewed-on: https://gerrit.libreoffice.org/59566
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-24 21:29:46 +02:00
Arkadiy Illarionov
d153882ca6 Remove redundant loop, tdf#96099 follow-up
Change-Id: I6318a526c8ea73ef32c18038c9bb5feeffc07b52
Reviewed-on: https://gerrit.libreoffice.org/59583
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-24 21:25:30 +02:00
Olivier Hallot
b324722ace Update git submodules
* Update helpcontent2 from branch 'master'
  - Honor colspan and rowspan in tablecells
    
    Previously not implemented
    
    Change-Id: I8867d82bc12a6c4312fcc6aa49c6b31e360a524e
    Reviewed-on: https://gerrit.libreoffice.org/59580
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-08-24 21:01:05 +02:00
Andrea Gelmini
c112c984af Fix typos
Change-Id: Ie6e3f3edabcd1ef9b44aefeb81ea84ca28654606
Reviewed-on: https://gerrit.libreoffice.org/59578
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-24 19:50:05 +02:00
Tamas Bunth
26b40fcfc6 Moving mysqlc into connectivity as a library
Additionally I erased the remains of the old mysql C++ connector.

Also update the code where the clang plugins were unhappy after moving
the mysqlc module.

Remove mysql-cpp-connector external.

Change-Id: I771cc7afacf5012fc349afb6b36828fb0fee5a66
Reviewed-on: https://gerrit.libreoffice.org/59200
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-08-24 17:19:51 +02:00
Jean-Pierre Ledure
84c02b6d9f Access2Base - Fix OutputTo of null string
Basic builtin function IsDate
returns True for a null-length string.
Intercepted to avoid conversion to date giving "00:00:00"

Change-Id: Ie917574043ea743e43cd79c5d95d023c8ccab38a
2018-08-24 16:30:10 +02:00
Caolán McNamara
e71ece6a6f document that nEndPos of -1 is all text
Change-Id: I4646e1ef09db3a637248cff53cbbafb214219cf8
Reviewed-on: https://gerrit.libreoffice.org/59542
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-24 16:04:37 +02:00
Noel Grandin
1cf7fcda33 loplugin:useuniqueptr pass ScDocument by unique_ptr in the undo code
Change-Id: I85188a4b3da4bc7f1a8a83870c8888be18bc1053
Reviewed-on: https://gerrit.libreoffice.org/59559
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-24 15:57:30 +02:00
Noel Grandin
588333c943 loplugin:useuniqueptr for ScOutlineTable in the undo code
fixing what looks like a couple of leaks on some paths

Change-Id: Idc851b8ffca8e5ed1bd54c9195442709ed310d40
Reviewed-on: https://gerrit.libreoffice.org/59558
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-24 15:57:08 +02:00
Noel Grandin
b5ee452d40 loplugin:useuniqueptr in ScEditFieldObj
consequently fixing potential leak in InitDoc

Change-Id: I50885f32d2465b41ede5dcf6653d7d8d30a3aeba
Reviewed-on: https://gerrit.libreoffice.org/59557
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-24 15:56:56 +02:00
Stephan Bergmann
16357f1c65 Blind fix for -Werror,-Wunused-function
...on Android tb24

Change-Id: I3119a660d6d38d3bff15b3a32a98b188ea06fdbd
2018-08-24 15:23:43 +02:00
Jan-Marek Glogowski
bf0a63dc93 tdf#118786 WIN just assert in Yield
This reminds me - again - that Jenkins doesn't run make check.

It turns out InSendMessage() also returns true, if you process a
nested SendMessage in the same thread. Therefore we have to
remove the SalComWndProc assert and just keep the one in the
Yield call.

Why? Because there seem to be no way to get the information
ReplyMessage has access to, so we could detect the caller /
origin of the send message and implement proper nested call
checks. The alternative would be to change all call sites of
SendMessage to:

if ( !pSalData->mpInstance->IsMainThread() )
    SendMessage(...)
else
    SalComWndProc(...)

which is the same SendMessage already does.

Change-Id: I991d68a64952dc5d47ba51edd8635c9e8c46614c
Reviewed-on: https://gerrit.libreoffice.org/59538
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-24 15:14:53 +02:00
Mark Hung
34dff8df7b tdf#73547 fix ooxml export / import custom dashes.
Fix import logic as well as arithmatic precion of both import
and export.

Change-Id: I97e9bde847e0a2425421af2f2175d4d0b7af0cab
Reviewed-on: https://gerrit.libreoffice.org/59306
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-24 15:07:14 +02:00
Jim Raykowski
80d6cba424 tdf#119416 Open Special Characters dialog on Enter key press
...when focus is on toolbar character map control

Change-Id: Ie7b53b18acfe1967a635c64120591a5ff7f2dc33
Reviewed-on: https://gerrit.libreoffice.org/59528
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-24 15:02:21 +02:00
Olivier R
62dbf07277 Update git submodules
* Update dictionaries from branch 'master'
  - French dictionary update (v6.3)
    
    Change-Id: I98c98d1484810b7403c3de4ed9a02e8689542552
    Reviewed-on: https://gerrit.libreoffice.org/59561
    Reviewed-by: Andras Timar <andras.timar@collabora.com>
    Tested-by: Andras Timar <andras.timar@collabora.com>
2018-08-24 15:00:59 +02:00
Eike Rathke
72db8ca7d9 SCCOLROW instead of long, tdf#117016 follow-up
Change-Id: I94c527031184fd040380de5d532d30e502646dfb
Reviewed-on: https://gerrit.libreoffice.org/59552
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
2018-08-24 14:53:45 +02:00
Eike Rathke
3aa5665669 Consolidate duplicated code, use VectorMatrixAccessor, tdf#117016 follow-up
Change-Id: I52650913034b1d490ad567867ad4405531095d92
Reviewed-on: https://gerrit.libreoffice.org/59551
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
2018-08-24 14:53:20 +02:00
Eike Rathke
ce91b05fd7 Avoid unnecessary copy of vector if nothing omitted, tdf#117016 follow-up
Change-Id: Ifed272642c0594377d66d6cb0c36a1b775e6bb20
Reviewed-on: https://gerrit.libreoffice.org/59550
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
2018-08-24 14:52:59 +02:00
Eike Rathke
1d0d5734ff Eliminate unnecessary per element copy of matrix' first col/row
Change-Id: I12e282bc9e999db674e02218160b6ac199aedc48
Reviewed-on: https://gerrit.libreoffice.org/59548
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
2018-08-24 14:52:47 +02:00
Caolán McNamara
8114f976b8 coverity#1438527 Nesting level does not match indentation
Change-Id: I0b36a0fdb1c284ab8510740d10d9fc0202c71e44
Reviewed-on: https://gerrit.libreoffice.org/59554
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-24 14:30:38 +02:00
Jan-Marek Glogowski
7a14326fea Just set highlight color for focus rect list box
Hopefully fixes the regression from commit 9897fd1c47 ("Fix
list box focused text color"), so it won't re-introduce
tdf#109353.

Change-Id: I7107deb33b959a250da9051b527099d723914223
Reviewed-on: https://gerrit.libreoffice.org/59549
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-24 13:38:05 +02:00