My code comment about "drawable area" and Michaels bug comment
12 about the "frameGeometry()" usage were both half right. LO
expects the window's frame position and the drawable client area
size almost everywhere when "geometry" is involved. The frame's
border is stored in the decorations members of SalFrameGeometry.
Change-Id: Ic00ad1f1d74d7afadcaca0c01e1a41ea7f2833de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135434
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
SvxFont has code to handle these extra features, we just need
to call that
Change-Id: I45691efeeead3ea60ab838eeb081fa5f19a76b90
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135428
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
when we are passing the result to a string_view, it is pointless.
Change-Id: If2532f998343b49a2966e0c704f6f789af936e1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135371
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
The existing labels refer to paragraph border, which is ambiguous
about where the border is located. Meanwhile these labels refer to
an area that is to the left and right of the paragraph text area,
which is well-defined (and explained in help). The change is to
indicate that these options position in relation to the regions
that are to the left and right of the paragraph text area.
Change-Id: Ica033f8f48d47fb3f65a26f93ebede26b9cf80fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135161
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
This patch is part of a general effort to use
"Text Alternative" consistently in the UI.
The control names in the Description dialog for
Imagemap and the Imagemap dialog were both changed
to "Text Alternative". Tooltips were also added
for "Text Alternative" and "Description."
No change was made to the extended tooltip for
"Description", because this field is not exported
to HTML at present (tdf#149013)
Change-Id: I2c5931efec93cff6b1ff1bf905de770d939b9b93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135155
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Tooltips are added in the Options tab in the Properties dialog for
images, frames, and OLE object. The extended tooltip for
“Text Alternative” is corrected, and an extended tooltip for
“Description” is added.
Change-Id: I8a14f3aa57aa7414ab2cf4251189d845269788d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135073
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
The "UnitTest" service is implemented as a new
Basic library called 'SFUnitTests'.
ScriptForge unit tests (SF_UnitTest class module)
======================
Class providing a framework to execute and check sets of unit tests.
The UnitTest unit testing framework was originally
inspired by unittest.py in Python
and has a similar flavor as major unit testing
frameworks in other languages.
It supports
- test automation
- sharing of setupand shutdown code
- aggregation of tests into collections.
Both the
- code describing the unit tests
- code to be tested
must be written exclusively in Basic
(the code might call functions written in other languages).
The code to be tested may be released as an extension.
It does not need to make use of ScriptForge services.
The test reporting device is the Console.
Definitions:
- Test Case: each test case is a Basic Sub.
- Test Suite: a collection of test cases stored in 1 Basic module.
- Unit test: a set of test suites stored in 1 library.
Two modes:
- the normal mode ("full mode"), using test suites and test cases
The UnitTest service is passed as argument to each test case.
- the "simple mode" limited to the use of the Assert...() methods.
Service invocation examples:
- In full mode, the service creation is external to test cases
Dim myUnitTest As Variant
myUnitTest = CreateScriptService("UnitTest", ThisComponent, "Tests")
' Test code is in the library "Tests"
' located in the current document
- In simple mode, the service creation is internal to every test case
Dim myUnitTest As Variant
myUnitTest = CreateScriptService("UnitTest")
With myUnitTest
If Not .AssertTrue(...) Then ...
' ...
.Dispose()
End With
Error handling
To support the debugging of the tested code, the UnitTest service, in cases of
- assertion failure
- Basic run-time error in the tested code
- Basic run-time error in the testing code (the unit tests)
will comment the error location and description in a message box and in the console log,
providing every test case (in either mode) implements an error handler
containing at least a call to the ReportError() method.
Change-Id: I9d9b889b148f172cd868af455493c8c696d1e953
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135365
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
* Update helpcontent2 from branch 'master'
to 02043ac2c6e34f4ae96abe2bdc5737e35bc01e9e
- Fix typo in AutoCorrect help page
Currently the help page uses "Clear" for a checkbox option. However, "Uncheck" is more suitable here.
Change-Id: If4a54e61ba96e5d9b4d76d175b165cb9a0cdbcbf
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135374
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
So if the dialog is widened the Structure tab can display more
details.
Change-Id: I857ca525fea8badc229328ab4c822b7de0b2cc0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135369
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
... instead of hard coded ',' and ';'. And truncate / append "..."
after separator, not at.
Change-Id: I62f8c00f108165102d3b6a8b73b82774b8973a67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135370
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
This commit also tests
- 6079bf6879
"Add binary operators to ForceArrayReturn handling, tdf#149378
follow-up"
- a15ce15709
"Propagate ForceArrayReturn only for Value parameters, tdf#149378
follow-up"
- bac202275b
"Propagate inline array only for Value parameters, tdf#149378 follow-up"
based on their commit description
Change-Id: Ie69868460ae87a67b31e0bd30a66644e89ea60ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135368
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
dropping ubsan.patch which was fixed upstream in this release
Change-Id: Ic2e35b24f7a9c7c3e2a00da8bc5b5b7d500746fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135359
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
So ={1;2} or =-{1;2} or ={1;2}+3 or ={1;2}+{3;4} or ={1;2}+A1 are
propagated. But ={1;2}+A1:A2 is not because the range reference
should be implicit intersection not to be forced to array mode
unless user says so.
This also adds low level ocPush with svMatrix returning always
ParamClass::ForceArrayReturn in FormulaToken::GetInForceArray() so
any derived like ScMatrixToken inherit that.
Change-Id: Ida24414a795d6609bf01e361f96438f9e7f7f66c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135360
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
So in SUM(MUNIT(3)) the SUM does not get ForceArrayReturn.
Same as in
commit bac202275b
CommitDate: Fri Jun 3 13:08:11 2022 +0200
Propagate inline array only for Value parameters, tdf#149378 follow-up
Change-Id: I60b17352c6e2f4fe608070c07f538456ed863156
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135358
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
(In MultiSelection::LastSelected, there is no need to set nCurSubSel (to a
potentially negative value) before setting bCurValid to false, as nCurSubSel is
only ever used after checking that bCurValid is true.)
Change-Id: I3c23c89fbb7b4ef962436476f6576af9fe623fd0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135354
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This reverts commit 652e4ee372. Turns out on
Windows read (aka _read) actually has a parameter of type unsigned, not size_t,
(<https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/posix-read?view=msvc-170>
"read"), so this started to cause
> C:/cygwin/home/tdf/jenkins/workspace/lo_tb_master_win64_dbg/soltools/mkdepend/main.c(504): error C2220: the following warning is treated as an error
> C:/cygwin/home/tdf/jenkins/workspace/lo_tb_master_win64_dbg/soltools/mkdepend/main.c(504): warning C4267: 'function': conversion from 'size_t' to 'unsigned int', possible loss of data
(<https://ci.libreoffice.org/job/lo_tb_master_win64_dbg/34368/>) for MSVC builds
targeting x64.
Change-Id: Ica821c8b32e225b7ebbfcbd33d8b7d55515ab3e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135270
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
The problem is that in the call to pTargetShell->EndAllAction(), the
cursor is on the node before the newly appended one that has the page
break, and only this node is formatted (via GetFormatted()), so no new
page frames are inserted in the layout, which then creates massive
performance problems later, particularly since the bugdoc contains
multiple at-page anchored flys.
(regression from commit 42448f48bb)
Change-Id: I05cd2a515a7f67132ab1c8c6fa0d675252ea3a15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135356
Tested-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
...as both malloc and read, to which this is passed, take arguments of type
size_t, not unsigned
Change-Id: I2b114c4e67bc9317d908d613fda607a12cf22579
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135347
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
So in SUM({1;2}) the SUM does not inherit it, but in ABS({-1;-2})
the ABS still does. This was always off, but so far didn't matter.
Change-Id: I00dfcd4b71b8dea943475bb5a593224312258e31
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135349
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
defaults to the current status of "true"
Change-Id: Id4fa50d359e29fa3a7db845edbcb86a3b1caa790
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135345
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
when we are passing the result to a string_view, it is pointless.
Change-Id: I4c780bd8dd356bd764b9f88400a41cca6d85f84b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135337
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
when we are passing the result to a string_view, it is pointless.
Change-Id: I5af990cbe1a8f2d5b19fea9a031d7d64aeba1c37
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135329
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
when we are passing the result to a string_view, it is pointless.
Change-Id: Id5906bbd7315e80358d09a0d036e605c54ccbf93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135328
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
