* Update helpcontent2 from branch 'master'
to cfdb19246c3675fa8672cd07dfb577949768771e
- Unnecessary
Have you benchmarked all computers in the world?
Change-Id: I8d818b9b7debd519001b6e1ec061b982481a5f5b
- Fix remaining typo
Change-Id: Id5c5100a25ce41c6cf4d5fbceaee23c68b3d8106
- add a dateframe to contentcontroldlg.ui, to be hidden for non-date
content controls
- use a SwNumFormatTreeView to present a list of number formats, with
a special "additional formats..." at the end that triggers a popup
where a custom date format and language can be set
- set the format of that tree view in the SwContentControlDlg ctor
- update the SwContentControl from the tree view in
SwContentControlDlg::OkHdl()
Change-Id: If245eee821fd7fe8b41a40f74b9011c1a6ec140a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135327
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
All call sites already effectively asked for an unsigned return type, including:
* The ThreadPool ctor took an nWorkers argument of type sal_Int32, but
internally stores that as std::size_t mnMaxWorkers.
* ZipOutputStream::reduceScheduledThreadTasksToGivenNumberOrLess apparently
benefits from an unsigned nThreadTasks parameter, getting rid of various casts
in its implementation that were necessary to silence signed vs. unsigned
comparison warnings.
The only drawback is that
comphelper::ThreadPool::getPreferredConcurrency() * 4
in package/source/zippackage/ZipPackageStream.cxx would now silently wrap around
instead of causing UB on overflow (which could be detected with appropriate
tools). Ideally, it would use some o3tl::saturating_mul if we had that, so add
a TODO comment for now.
While std:🧵:hardware_concurrency returns unsigned, it looked more natural
to go with std::size_t here, as some call sites already used that (see above),
so the implementation of ThreadPool::getPreferredConcurrency is a natural place
to hide clamping std:🧵:hardware_concurrency() to std::size_t (in the
unlikely case that std::size_t is of smaller rank than unsigned).
This required addition of o3tl::clamp_to_unsigned in o3tl/safeint.hxx.
Change-Id: I0a04a8b32e63ebfeb39f924c4b38520455a6fb38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135309
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This reverts commit c390c2e3f4.
Causes crashes like
./instdir/program/soffice --headless --convert-to pdf ooo30162-3.xls
because code likes modifying items that are in existing
pools.
Change-Id: I988745a538509f90f357ec6a321b2e37828a4111
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135308
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
assert was introduced in
commit e1972743d6
Author: Noel Grandin <noelgrandin@gmail.com>
Date: Sun Sep 5 15:01:44 2021 +0200
be more disciplined with SetUpdateLayout on editengine
We want to restore UpdateLayout when we're done doing layout, we should
not just leave it FALSE
Change-Id: Ic0431ffc3c66d0d02bfd10c323b18383f52dbc95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132209
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Revert "tdf#132740 bypass work if selection has not changed"
This reverts commit 865641047b.
Change-Id: I69244a1e57ce979bf21946e31df7165f8791423c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135302
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Apparently some selections provide only XTransferable and not
XTransferable2, making this entire call think that there's no
selection at all. Handle that properly, and if XTransferable2
is not provided, then presumably it's not important to check
for isComplex().
Change-Id: I3bbafe46a6b9ac8552c62e524137e1691b54895a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135300
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
when we are passing the result to a string_view, it is pointless.
Change-Id: I1e11d2610d70ed49c0b00d0c908829e8f1252bab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135298
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Allows to send individual images over the wire in lok case,
instead of sending full canvas at every scroll operation.
The control's horizontal and vertical modes (when it's docked to a
vertical or a horizontal parent window side) are now identical.
Some TODOs:
* Re-implement a11y - that needs to be implemented on IconView level;
* Make sure that sub-pixel positioning is not used when creating the
elements icons (makes elements look a bit slim on Windows);
* Maybe restore mouse hover indication; in non-GTK case, a call to
m_xIconView->SetHoverSelection would suffice in SalInstanceIconView.
Change-Id: Idbc35f4e38e2b49fd0848a96da557fa2c1a1f6e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134761
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
...presumably added back in the day to avoid warnings about signed vs. unsigned
comparisons with old compiler versions
Change-Id: Id95e272949e48adf0e75883368cbcd421e289b33
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135292
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
found with the help of a temporary loplugin (which i have put into the
store/ folder)
Change-Id: Ide40d09bef6993ace50039a8fd0439b7e29c09a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135288
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
which is what the old one did, so do that here as well, libtiff will
leave the stream some other pos by default, presumably the directory.
which explains the testTdf138818 mystery
Change-Id: I574700f81a21ee164d9911e05e2023aa48d10370
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135279
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Add hyphenation zone support, i.e. allow the specified
amount of extra space in lines instead of forcing hyphenation.
It's for limiting hyphenation, used especially with
not justified paragraph alignment.
Note: this is an OOXML interoperability feature,
used also in DTP software and CSS.
* Add checkbox to Text Flow in paragraph dialog
* Store property in paragraph model (com::sun:⭐:style::ParagraphProperties::ParaHyphenationZone)
* Add ODF import/export
* Add ODF unit test
* Add layout test
Note: extend SvxHyphenZoneItem::GetPresentation() with
missing No CAPS and No last word hyphenation options.
Note: fix OSL_ENSURE condition in SwTextFormatInfo::GetHyphValues().
Follow-up to commit 29359fc15c
"tdf#149324 sw offapi xmloff: add option to not hyphenate short words".
Change-Id: Ib8eff6ea98a9aa5ca6cb9d17faa0bbb789687ce9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135247
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
- add a new m_xCheckboxFrame to SwContentControlDlg that contains all
the checkbox-related widgets
- hide this frame for non-checkbox content controls
- load the checked & unchecked states into entries to show their current
value
- provide buttons to easily pick special characters using SvxCharacterMap
Change-Id: I8f2ad862d1102bac0198360d40cfe8b653ce4ccd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135286
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
I.e. the layout side of images is not a fly frame, but a no-text frame,
with a fly frame parent.
Change-Id: If76029d02ea2cd583effb31230f5e2d9edc9f237
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135275
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
..so use o3tl::make_unsigned when comparing them against an expression of
unsigned integer type, instead of casting that expression to a signed type
Change-Id: I4fc0bd4447f55d5fd9bf893a4b22d6d2c2cfe3d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135280
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Update helpcontent2 from branch 'master'
to 36303145afbcf57edf4a45129bd5a8b222dfec74
- Base form properties Sort dialog name is case sensitive
Selecting Base form properties data Tab Sort dialog help button caused 'page not found'
Change-Id: If91a478964304893527ac8c03d417dcee445a4ee
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134072
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
So the result will actually display as full matrix, or in the cell
range marked prior to input, instead of just the top left element
in one cell, without having to close the input with
Shift+Ctrl+Enter to force array mode. The previous behaviour can
be forced by pre-selecting/marking one cell, which also worked
previously when closing as array input.
Change-Id: I81c079ce02e0c8d0536617ca6882fb470a352441
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135278
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
