This allows to call collectAutoStyles where required (e.g. when enumerating
used fonts), without side effect of writing table styles XML inside the call,
out of place.
Change-Id: Ida05e373eb8502590c43e2b0e85c3b0c1107c551
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100153
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
...which sets PARALLELISM to 0 and thus caused
cc1: error: unrecognized argument to ‘-flto=’ option: ‘0’
at least with recent GCC 11 trunk
Change-Id: Ifcfb6485c1c2efc8ab798686ca7fc2392d2cfc2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100171
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
so "relative" mode sticks regardless of any rounding issues triggering
the table out of relative mode.
Change-Id: If0abbf2ef75feb6fc4a408966c2a3c350589023f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100161
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
instead of operating on a copy of the original SwTableRep and over
writing the original at commit
Change-Id: I5c42291302f8b4a3394adcdb3425524623f7a051
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100140
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
The problem was that (cd sw && make CppunitTest_sw_ooxmlexport4) fails
with an error that the gpgmepp package doesn't exist, but only on WNT.
Nonobviously, this is due to the override of the rule for the gpgmepp
package in ExternalPackage_gpgmepp.mk, which copies the same file that
the package already depends on for no obvious reason.
Furthermore, RepositoryExternal.mk uses
gb_Helper_register_executables_for_install with gpgme-w32spawn,
when it should just register the package instead, because that is not a
gbuild Executable.
Change-Id: I8cb8b7a68c9681844a39de1390aa736a1ec53449
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100159
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
when footer (header) is shared (even).
Co-authored-by: Tibor Nagy (NISZ)
Change-Id: I6e656f2df1f9b6522af933bd1c71b8d60bbfe19f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99315
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
designating that the special auto-sized toggle column is in use
Change-Id: I23aa927c56e706590f397d15ef7329d20e0b18a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100136
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
<https://ci.libreoffice.org/job/gerrit_windows/71710/console>
> cp: cannot create regular file 'C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/workdir/CustomTarget/extensions/source/activex/SOActionsApproval.cxx': No such file or directory
[...]
> make[1]: *** [C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/extensions/CustomTarget_so_activex_x64.mk:22: C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/workdir/CustomTarget/extensions/source/activex/SOActionsApproval.cxx] Error 1
makes it look like this has been missing all along?
Change-Id: Ifa685808942f05c539950311a4d800be0894c8ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100122
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Call to ImplHandleGetObject may happen in the middle of any UI operation,
including those that make use of references to parts of global settings,
like this:
const LocaleDataWrapper& rLocaleData = Application::GetSettings().GetUILocaleDataWrapper();
setValue(*m_xCurrentWordFT, rCurrent.nWord, rLocaleData); // < here ImplHandleGetObject may be called
setValue(*m_xCurrentCharacterFT, rCurrent.nChar, rLocaleData);
If all settings get replaced, then LocaleDataWrapper gets destroyed, and
the reference becomes invalid, and crashes in the next line.
So first, the change makes the call only modify settings when it's needed;
and second, it makes use of the implementation detail that aMisc modifies
the shared data. The check after the change will catch if implementation
changes so that this is no more true.
Yet, the problem stays that using any references to global settings objects
is unsafe, since any call to Application::SetSettings will invalidate them.
Change-Id: I96d237ee57e80465fe52bc6bb6c149b087c89af9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99947
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
...to help avoid false positives. (Another option to silence such warnings is
to add
(void) this;
to false-positive function bodies, but this new approach may be more natural in
certain cases.)
Change-Id: Ie6ea908730c596dbfb62ff42ae60dbd0a00a8fc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100152
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
So in case the test fails, it's possible to see the same failure
multiple times.
Change-Id: Ic573807967b004bb7650ffb3614f5006db34080e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100137
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
...assuming that such an exception is rare enough that any performance impact
does not matter. (The code was like this ever since its introduction in
9e2bf1d54a "INTEGRATION: CWS canvas02".)
This nicely avoids loplugin:unusedmember about unused mpStr and mnArgPos when
OSL_DEBUG_LEVEL is zero.
Change-Id: I2ad3e36e98a6811ae255525cf8159db89c78ad7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100143
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Jenkins
use a label instead, keep spinbutton (but invisible) to format the label
Change-Id: I36660566df34891e8e813dee24375eacf55e09d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100127
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
> w32-util.c(176,1): error: conflicting types for 'utf8_to_wchar'
> utf8_to_wchar (const char *string)
> ^
> workdir/UnpackedTarball/libgpg-error/src\gpg-error.h(1109,10): note: previous declaration is here
> wchar_t *utf8_to_wchar (const char *string, size_t length, size_t *retlen);
> ^
with clang-cl on Windows, while in a case like this where there is only one
definition, the mismatching declaration merely gets warned about by MSVC with
"warning C4029: declared formal parameter list different from definition". (And
on non-Windows that w32-util.c apparently doesn't get compiled at all.)
Change-Id: I76cfc3ec086325c527c04dbe0e8341cb9b775c50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100091
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
("the source reference is already a subtype of the destination reference")
Change-Id: Ifba02593d77057eaa356ec7c3c76de64ba65cf09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100089
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Update helpcontent2 from branch 'master'
to 92d4f32170e6d3a1b65857bb83e22c4bf7f565bd
- Fix some "D'oh! You found a bug" here and there
Change-Id: I0b3b4eec07378dcc3a110bfb7e2205220f30c579
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/100132
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
...like
> canvas/source/directx/dx_impltools.cxx(137,31): error: rather use make_shared than constructing from 'Gdiplus::Graphics *' [loplugin:makeshared]
> GraphicsSharedPtr pRet(Gdiplus::Graphics::FromImage(rBitmap.get()));
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
on Windows, where those functions like FromImage are provided by Windows (so we
can't help it that they are returning pointers)
Change-Id: Iae5c4b20d64cc6b38ff66409519fbd25f6e509cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100095
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
("the source reference is already a subtype of the destination reference")
Change-Id: I1183eaa2015bd9d6567001bb14f7809dffcae7ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100088
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
and keep the original around for use from ::Reset and overwrite
the original SwTableRep on commit
Change-Id: I18e078e577382c4c13d6f5e576cc1eeec15a7906
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100072
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* Update translations from branch 'master'
to 1c00f748202eb64ffa0be5ce38e57a47f6e5798a
- update translations for master
and force-fix errors using pocheck
Change-Id: I7e90d467017ce8e49d81e914d60d944e2e69e0f1
... and SwDoc::CopyMasterFooter(); this is the same as commit
9f7ee38ace but for 2 other functions that
do the same thing.
Change-Id: Id7ed449a004ee3c9452d4603bf8632e2720651ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100077
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
This changes the order of children, which matters when they have no
explicit ZOrder. With this, the text shapes on the arrow shape are on
top of the arrow, not behind it.
The trick is that nominally chOrder can be "t"(op) or "b"(ottom),
defaulting to bottom, but there is a difference between an explicit "b"
and not setting it. When not setting it, the layout node is expected to
inherit it from its parent layout node, recursively.
This would probably make sense for other algorithms as well, but set it
only for the linear algorithm for now, as that's where we have a bug
document showing the PowerPoint behavior.
Change-Id: I433f92c620149ef5590aebc8cbf43110e1d2fb85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100047
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
