Commit graph

427587 commits

Author SHA1 Message Date
Noel Grandin
38a98c2999 loplugin:simplifyconstruct in helpcompiler..io
Change-Id: Ibdc1933b5d8d6be1fe42a7df93bd7e1c903bb39b
Reviewed-on: https://gerrit.libreoffice.org/60202
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-09 08:18:01 +02:00
Ilhan Yesil
278e664881 tdf#114400 Import drawoo:fontwork-xyz attributes
Either the document has attributes in the old namespace or in the
new, both will be imported. But export is still in the old
namespace.

Change-Id: I9f4d1ca0d8af37c13b513f99cc7d254c68867bb2
Reviewed-on: https://gerrit.libreoffice.org/59405
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-09-09 00:02:13 +02:00
Rizal Muttaqin
260740f0a0 KJ: +more missing Calc NB icons, Calc menu, Writer menu, etc
Change-Id: I81b397608ab8d3d1c0c523a2f620b3417788913f
Reviewed-on: https://gerrit.libreoffice.org/60098
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-09-08 23:08:54 +02:00
Jan-Marek Glogowski
2129753120 tdf#119730 WIN switch to IFileDialog FOS_PICKFOLDERS
Citing SHBrowseForFolderW remarks: "For Windows Vista or later, it
is recommended that you use IFileDialog with the FOS_PICKFOLDERS
option rather than the SHBrowseForFolder function."

Since the minimum required Windows version is already 7 and we
already just provide the Vista file picker, this gets rid of the
Windows XP compatible folder picker code.

Change-Id: I85daae84d4eb36fc827cf20aa277ce6a2f63dd2c
Reviewed-on: https://gerrit.libreoffice.org/60144
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-08 23:07:06 +02:00
Zdeněk Crhonek
025abb0538 uitest Imrepss- Autocorect options dialog
Change-Id: I65c7711e4d655a6c2c759c8e94c196d690512af6
Reviewed-on: https://gerrit.libreoffice.org/60186
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-09-08 21:01:09 +02:00
Aron Budea
1bb732acc6 Revert "tdf#110987: type detection, binary Office formats > templates"
This reverts commit c1817a5b12.

Change-Id: Ia1442dedd07436e5954943c6ff09ed8d9d2b9fc6
Reviewed-on: https://gerrit.libreoffice.org/60197
Tested-by: Jenkins
Reviewed-by: Aron Budea <aron.budea@collabora.com>
2018-09-08 20:11:10 +02:00
Noel Grandin
8dc6c96a80 loplugin:simplifyconstruct in filter..framework
Change-Id: Ida4307a92dfb1dbd14da5a30b6ee1f0fd6a9455e
Reviewed-on: https://gerrit.libreoffice.org/60194
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08 19:28:19 +02:00
Noel Grandin
9212fadc4d loplugin:useuniqueptr in OGenericAdministrationPage
Change-Id: I3028aa7d40b5fea763a93b54bf5f4c5bc4294822
Reviewed-on: https://gerrit.libreoffice.org/60193
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08 19:28:08 +02:00
Noel Grandin
d34098cdb9 loplugin:useuniqueptr in CGMElements
Change-Id: Icff5c5c3790f06af19d463a66a2dcef0a7917f44
Reviewed-on: https://gerrit.libreoffice.org/60190
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08 19:27:59 +02:00
Noel Grandin
9db52c294f clan-tidy bugprone-throw-keyword-missing in SubmissionPropertyHandler
warning: suspicious exception object created but not thrown; did you
mean 'throw IllegalArgumentException'?

looks like a mistake in
    commit cd5b956817
    Date:   Tue Mar 14 10:33:39 2006 +0000
    INTEGRATION: CWS pbrwuno (1.3.88); FILE MERGED

Change-Id: I828501f32b3caff8c4ca05a8a8c4b063dccecd3b
Reviewed-on: https://gerrit.libreoffice.org/60196
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08 17:50:41 +02:00
Noel Grandin
2bbcdc574e clan-tidy bugprone-throw-keyword-missing in SdXShape
warning: suspicious exception object created but not thrown; did you
mean 'throw IllegalArgumentException'?

looks like a mistake in
    commit 1d8d532b36
    Date:   Fri Mar 18 16:03:40 2005 +0000
    INTEGRATION: CWS impress36 (1.45.2); FILE MERGED

Change-Id: I338686e59e4c9b7737f6b304249c1081e4e763aa
Reviewed-on: https://gerrit.libreoffice.org/60195
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08 17:50:31 +02:00
Caolán McNamara
fd9582a56c set default min point line width
Change-Id: I4d75977b930b669c8845059f893d79fbeb2f1afc
Reviewed-on: https://gerrit.libreoffice.org/60199
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-08 17:50:28 +02:00
Noel Grandin
ff2037b76c loplugin:useuniqueptr in TakeThread
Change-Id: I5d3d197d57235f2bd09cbf80a7a35314edda945d
Reviewed-on: https://gerrit.libreoffice.org/60192
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08 17:50:19 +02:00
Caolán McNamara
4907cf58ba ofz#10259 ofz#10263 ofz#10264 ofz#10265 use-after-free
Change-Id: I3e845c21f7a4e853ce9548f2992cab324dec05a8
Reviewed-on: https://gerrit.libreoffice.org/60200
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-08 17:50:17 +02:00
Noel Grandin
cbf8f81156 loplugin:useuniqueptr in xmlhelp
Change-Id: I8a407e0492adf61e1d815cadd5da0a1623c2b23b
Reviewed-on: https://gerrit.libreoffice.org/60191
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08 17:50:13 +02:00
Luboš Luňák
4aecbe9963 blacklist all ocDB* tokens for Calc threading
A sort of follow-up to 92e6be6614, all functions possibly may have
this problem. E.g. sc_opencl_test, if it somehow ends up actually
using threads instead of OpenCL, uses ocDBCount, which indirectly
ends up in ScColumn::GetInputString() calling non-threaded context.

Change-Id: I6e2b1c9aa6dc9a7d8732cdf2e86b8041f19d5bac
Reviewed-on: https://gerrit.libreoffice.org/60030
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-08 15:34:31 +02:00
Caolán McNamara
1da0940a60 drop some unused custom widget descriptions
Change-Id: I21f170235729ee7ea34763d620704213bc9d3b32
Reviewed-on: https://gerrit.libreoffice.org/60171
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-08 15:07:58 +02:00
Caolán McNamara
0e41c75dac fix various focus problems
Change-Id: Ic510420ec486fdf77438891d08521039d180e5d4
Reviewed-on: https://gerrit.libreoffice.org/60170
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-08 15:07:42 +02:00
Caolán McNamara
842c71a1fa weld FontFeaturesDialog
Change-Id: I67ab7388593aceb00b660e4d40904a4eef247620
Reviewed-on: https://gerrit.libreoffice.org/60148
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-08 15:07:22 +02:00
Arkadiy Illarionov
97b6fd8e9e Replace find_if with proper quantifier algorithms
Missed in 085269d25a

Change-Id: I3cfab57232908b48d090658e0fbc948d62b3fc6f
Reviewed-on: https://gerrit.libreoffice.org/60180
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08 14:46:08 +02:00
Jochen Nitschke
b678dee6a8 cppcheck: variableScope in basic
use a range based loop in one case

Change-Id: I3d3acc35739634797e2b6e4d1cc2909b3fe33750
Reviewed-on: https://gerrit.libreoffice.org/60188
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08 14:45:42 +02:00
Noel Grandin
8596681013 clang-tidy bugprone-sizeof-expression
this was not really testing anything before, because it was doing
   sizeof(char*)
which is 4 or 8

Change-Id: I7eccdd3c6ae14a6fabb27202737fdb2fd12663dc
Reviewed-on: https://gerrit.libreoffice.org/60182
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08 14:45:22 +02:00
Noel Grandin
2002bbe83d loplugin:simplifyconstruct in editeng..extensions
Change-Id: I646a24382554312d92a4a8746d5267767353a53f
Reviewed-on: https://gerrit.libreoffice.org/60169
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08 14:45:11 +02:00
Noel Grandin
6d180f09f2 clang-tidy bugprone-use-after-move
Change-Id: I93c33da06f638ec6c8432bd13f992c320cfde93e
Reviewed-on: https://gerrit.libreoffice.org/60158
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08 13:19:26 +02:00
Noel Grandin
867ee21fe4 clang-tidy bugprone-unused-raii in RequestHandler
The message from clang-tidy is:
    warning: object destroyed immediately after creation; did you mean
to name the object?

The guard in
RequestHandler::ExecuteCmdLineRequests
comes from
commit cf333a878c
Date:   Sun Jan 21 22:10:09 2018 +0300
tdf#38915: set cProcessed condition on any process outcome
and I'm sure it's intention was to set the flag on exit from the
function, not immediately.

Change-Id: Ibf874a5774770df00b9db7f673554e7ffda55072
Reviewed-on: https://gerrit.libreoffice.org/60183
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
2018-09-08 13:18:41 +02:00
Stephan Bergmann
ba5670b262 -Werror,-Wformat (clang-cl)
...%d vs. DWORD aka unsigned long, but no need for sprintf anyway

Change-Id: I7e97ada40abf7785a0678c76c76b547d6571f497
Reviewed-on: https://gerrit.libreoffice.org/60160
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-08 09:13:40 +02:00
Andrea Gelmini
bc8131987b Fix typos
Change-Id: I75692373028a64ba71899a4fd8c240fa4f2f1c02
Reviewed-on: https://gerrit.libreoffice.org/60172
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2018-09-08 08:53:12 +02:00
Noel Grandin
09978dd1fc clang-tidy bugprone-unused-return-value
In
   OStorage::openEncryptedStream
the lines were marked with a TODO until the TODO comment was removed in
    commit 8083b46285
    Date:   Tue Jun 16 16:15:54 2009 +0000
    CWS-TOOLING: integrate CWS fwk103
Since no-one has "fixed" this intended functionality by now,
I just removed it.

The lines in unoidl/ were introduced by
    commit 12353c7386
    Date:   Fri Mar 1 23:23:50 2013 +0100
    WIP: Experimental new binary type.rdb format
I assume that not throwing these was just an oversight.

Change-Id: I26fbcce267f2cc1154a30b8259176f59611dfbd8
Reviewed-on: https://gerrit.libreoffice.org/60161
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08 08:45:51 +02:00
Noel Grandin
7764ae70b0 clang bugprone-unused-return-value
most of these changes just make the change of ownership when using
std::unique_ptr clearer, but there is one definite leak fix in
    PlainTextFilterDetect::detect

Change-Id: I8282a68007222a4fee84004f394bde0cca8569e9
Reviewed-on: https://gerrit.libreoffice.org/60159
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08 08:45:41 +02:00
Muhammet Kara
37d5bf82ea [tr][autocorr] Fix erroneous entries
Change-Id: Iaded68785c50833aa998706b6840f86d99ffc17d
Reviewed-on: https://gerrit.libreoffice.org/60155
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-09-08 07:54:50 +02:00
Mark Hung
22f49d10c0 sd / pptx export: use extracted ooxml node type.
Prefer extracted node type over XAnimationNode->getType(),
as the later has been converted to former and unknown
condition filtered.

As the switch-case statements use ooxml node type now,
all kown node types are handled. Hence returning early
for unkown case isn't necessary and is removed.
That also fix unrestored mpConetxt in 9a9b81c721 because
of returning early.

Change-Id: I614dcaa5b0ce32b19c396d0eab4499c1d67fa059
Reviewed-on: https://gerrit.libreoffice.org/60139
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-08 06:04:51 +02:00
Mark Hung
9a9b81c721 sd/ pptx export: resolves unhandled node type causing crashes.
found in
http://dev-builds.libreoffice.org/crashtest/1103bddab3f695b61484960523c4c2c0de4f0f91/

https://bz.apache.org/ooo/attachment.cgi?id=49270
https://bz.apache.org/ooo/attachment.cgi?id=44458
https://bz.apache.org/ooo/attachment.cgi?id=54593

Change-Id: If9e19140f2fcffc0b261c1d91a40597684a51917
Reviewed-on: https://gerrit.libreoffice.org/60060
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-07 23:57:02 +02:00
Muhammet Kara
0fa2a77881 [tr][autocorr] Consistent capitalizations for Turkish
Change-Id: Icfb6d82f094a4ab743d0ec4f51ddfdda606a731a
Reviewed-on: https://gerrit.libreoffice.org/60152
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-09-07 22:48:22 +02:00
Jan-Marek Glogowski
b18747fcee Fix some std::unique_ptr array allocs
Found by reviewing the output of and the code around
git grep -n "unique_ptr.*new.*\[.*\]" | grep -v "\[\]"

The onlineupdater code needs a little bit more attention.

Change-Id: I8b70c7da7db60af52bfac12314a21602ede8bfc0
Reviewed-on: https://gerrit.libreoffice.org/60162
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-07 22:04:50 +02:00
László Németh
694a6389e8 tdf#119019 DOCX track changes: fix invisible delete and insert
during editing in a paragraph with tracked paragraph formatting,
by accepting the old formatting change automatically in the
actual paragraph before text deletion/insertion.

Note: it's not possible to reject paragraph formatting
changes in LO, but showing them is a minimal requirement.
Now they are still visible in change tracking dialog and
by the vertical line before the related paragraphs until
there are no new text deletions and insertions in those
paragraphs.

Change-Id: I526daad8dd96212ac73a10627128553452e4d31c
Reviewed-on: https://gerrit.libreoffice.org/60101
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
2018-09-07 20:55:03 +02:00
Stephan Bergmann
453fde35bb BitmapFilter::execute can be const
...after a little tweak to BitmapMosaicFilter

Change-Id: I76b8ffdbf719a9d7960e7f3dafeb3adeb2300ec5
Reviewed-on: https://gerrit.libreoffice.org/60165
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-07 20:42:59 +02:00
Jan-Marek Glogowski
7cb3e475f2 WIN add SalGraphics* to WinFontInstance
HFONT lookup in ImplDoSetFont depends on the mbVirDev of the
WinSalGraphics. Since we need too look up HFONTs for SalLayout
without changing the corresponding SalGraphics, add a pointer
to the WinFontInstance.

Change-Id: Idb6573ce7267f0019c2183be47621d0eaef8e57b
Reviewed-on: https://gerrit.libreoffice.org/60093
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-07 20:27:01 +02:00
Jan-Marek Glogowski
334df91c6e WIN drop mhFonts[MAX_FALLBACK]
Everything now uses the HFONT from WinFontInstance, so there
is no need for the additional fallback array.

Change-Id: I15a197b262633569cb95c37689561db5323e1115
Reviewed-on: https://gerrit.libreoffice.org/60092
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-07 20:26:18 +02:00
Stephan Bergmann
c5483edae0 Drop workaround for old MSVC that no longer appears necessary with MSVC 2017
The comments talk about unspecific "compilation and/or linking errors" with MSVC
2008 and 2013, but building with latest MSVC 2017 at least works fine now, so
assume the workaround is no longer needed.  (Theoretically, external code being
compiled with older MSVC could run into problems now, but lets take that risk of
becoming slightly build-time incompatible here.)

Change-Id: I9e20be355c765c3a881502773963a61305eb00f3
Reviewed-on: https://gerrit.libreoffice.org/60135
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-07 20:07:45 +02:00
Stephan Bergmann
91f2b2b887 Multiple calls of BitmapColorQuantizationFilter::execute
...should probably be independent of each other

Change-Id: I22fb860a5a197d5f3f0f8706782e25d07511a1d9
Reviewed-on: https://gerrit.libreoffice.org/60153
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-07 20:07:17 +02:00
Caolán McNamara
0593afe560 just edit Entry to readonly, instead of a shadow ro widget
Change-Id: I28d6d3cceec5224a6b38bd44ec380974cd3bae12
Reviewed-on: https://gerrit.libreoffice.org/60104
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-07 18:17:44 +02:00
Olivier Hallot
da8617d69a Update git submodules
* Update helpcontent2 from branch 'master'
  - Prepare to handle native SVG icons
    
    Today icons are PNG images, if later they become SVG natively...
    
    Change-Id: I42d886257b55b5676767c8b8879a6bf35eb4d5e6
    Reviewed-on: https://gerrit.libreoffice.org/60156
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-09-07 17:58:55 +02:00
Olivier Hallot
09b618a03e Update git submodules
* Update helpcontent2 from branch 'master'
  - add image dimension and alt content to icons
    
    some icons miss width and height values.
    
    Change-Id: I4b94a0cf64a29451c96bb8f58729914b2cb576cf
    Reviewed-on: https://gerrit.libreoffice.org/60157
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-09-07 17:58:31 +02:00
Caolán McNamara
a5c1d1c021 Update git submodules
* Update helpcontent2 from branch 'master'
  - adapt to merge of namero and namerw
    
    Change-Id: I46883713361bf8107b601e4cc775ef5bce185e3d
    Reviewed-on: https://gerrit.libreoffice.org/60138
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm@redhat.com>
    Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-07 16:43:39 +02:00
Caolán McNamara
0b8f705380 ofz#10100 skip namespace check in icu
fails under oss-fuzz with linker problem

https://github.com/google/oss-fuzz/issues/1789

Change-Id: I5788fca1914c1b795a91d59f7d9271f854b4d464
Reviewed-on: https://gerrit.libreoffice.org/60134
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-07 16:43:20 +02:00
Caolán McNamara
5744597e4d weld SvxCharEffectsPage
Change-Id: I067b7a8c93e997fd554558f334a2968bf27965c6
Reviewed-on: https://gerrit.libreoffice.org/60147
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-07 16:43:01 +02:00
Miklos Vajna
2a73c9e04b sw: less vcl text layout calls in SwFont::GetTextBreak()
Number of GenericSalLayout::LayoutText() calls during "dt<F3>" in Writer: 105
-> 89.

Change-Id: I0f2bb241536209cfccc1d78bed6f54bf5c31e627
Reviewed-on: https://gerrit.libreoffice.org/60133
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins
2018-09-07 16:02:49 +02:00
Olivier Hallot
2aaf5a73da Update git submodules
* Update helpcontent2 from branch 'master'
  - Height and width are <img> attributes
    
    Change-Id: Ia8084ff7029ddd06e450cbf03a7b1fb5efaa7dc7
    Reviewed-on: https://gerrit.libreoffice.org/60136
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-09-07 15:47:33 +02:00
Christian Lohmaier
01b19afece update credits
Change-Id: I946580363eb272f95694b000d6daa997e761285d
2018-09-07 15:40:18 +02:00
Marco A.G.Pinto
bdbaddc5a3 [pt_PT] Added 21 autocorrect words
Change-Id: I8ca06334d176d5d00f72d448cb92afcc891a7d83
Reviewed-on: https://gerrit.libreoffice.org/60015
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-09-07 15:30:22 +02:00