It should never get used any way. CairoTextRender::GetTextLayout()
returns nullptr for the unlikely even that there is no Freetypefont for
the requested fallback level, so we do the same.
Change-Id: Ib990eb89f9f0fd2bcd87990cbd76406c8d063f57
Reviewed-on: https://gerrit.libreoffice.org/31225
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
If a copied sheet's destination position is before its source position, the
source's ScColumn::nTab members still pointed to the original source position
when the captions were created, which led to the wrong drawing layer page being
used and at the end the drawing shapes not being correctly assigned.
Change-Id: I9c3cc97d8b4486756023b9ab02da28079a1d0627
If an empty sectPr paragraph contains Page/Column break
information, do not discard it.
Change-Id: If817debccb924eb9cf0ffdc374c960d25908370f
Reviewed-on: https://gerrit.libreoffice.org/31227
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>
This reverts commit 6324efd70d.
The old layout engines will soon be gone.
Change-Id: Iedbcffd18b11ac36ad98a66ac12111058aab19b3
Reviewed-on: https://gerrit.libreoffice.org/31142
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
Tested-by: Khaled Hosny <khaledhosny@eglug.org>
...so PaletteManager::SetPalette(LISTBOX_ENTRY_NOTFOUND) would set
PaletteManager::mnCurrentPalette to 65535, and
PaletteManager::GetSelectedPalettePath would do out-of-bounds access into
PaletteManage::m_Palettes.
That the last-used palette (as stored under in the configuration under
/org.openoffice.Office.Common/UserColors/PaletteName) may become more common
with pending changes like <https://gerrit.libreoffice.org/#/c/31199/>
"tdf#104047 Remove dispensable palettes".
Change-Id: I5641bae04f50fea8aa69027a75de08c22394c281
The graphite library is always built static, so the graphite headers must
be included with the GRAPHITE2_STATIC macro, so that the functions are
not marked __declspec(dllimport) on WNT.
Add GRAPHITE2_STATIC to GRAPHITE_CFLAGS so harfbuzz picks it up.
It's a mystery why vcl even links currently without this.
Change-Id: I80d87fe76afa2d05a5697d56dfaf8cbe97d9f977
Fix a missing hunk from e0ad036eed,
which causes assertion, if MM is used via UNO.
Thanks to Alex Kempshall, finding the assertion when testing MM.
Change-Id: Ia0cd6053838adc6f0a4ce93902f06423849bf851
Fixes the regression introduced by
commit e637b6743a
This commit removed the crazy bSubjectIsFilename handling,
where I didn't understood the case of bSubjectIsFilename
and a user supplied prefix.
Mail merge to files never overwrites an existing document,
but there is the special case, when a user selects a target
filename in the MM dialog for single file MM.
Should be fixed by a successive commmit, reverting this and
removing an existing file before starting the MM job.
Change-Id: Idda487023e6984de9c1e701fc088a6b7f92e9847
Keep the beans::NamedValue vector around and convert it to a
uno::Sequence just before executing the mail merge job.
Change-Id: Ib2b4863337af20fb4423cc1b4ea4223d66d63ae5
Because notifications to all views were disabled
(to avoid moving the cursors of everyone when someone
adds a comment) invalidation was also broken. The
issue was observed when a comment crossed tile
boundaries, the other tile was not redrawn.
This forces invalidation so tiles are rendered
correctly, fixing this regression.
One small issue remains in that invalidating a
comment only invalidates the text-area and not the
complete PostIt (specifically, the author and date
are not invalidated). This means that they can
still get trimmed when crossing tile boundaries.
That will be addressed separately, as it was an
existing issue before the regression this patch
fixes.
Change-Id: Ic8173e4873d58836883b897f735fc627bb0572ee
Reviewed-on: https://gerrit.libreoffice.org/31091
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
...as otherwise dynamic_cast<xmlsecurity::pdfio::PDFNameElement*>(...) in
xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx will fail at least on macOS,
causing CppunitTest_xmlsecurity_pdfsigning to fail.
Change-Id: I7c41c994a1e6145b4740a97ffe47d0c42c4e3ca0
